On 11/6/23 6:25 PM, Jim Fehlig wrote:
On 11/3/23 15:19, Jim Fehlig wrote:
Hi Jonathon,
I too on occasion poke at SEV-SNP support in libvirt. I've now pushed
the dusty, hacky branch to my public fork
https://gitlab.com/jfehlig/libvirt/-/tree/sev-snp?ref_type=heads
Looking at the git log, it
On 11/3/23 15:19, Jim Fehlig wrote:
Hi Jonathon,
I too on occasion poke at SEV-SNP support in libvirt. I've now pushed the dusty,
hacky branch to my public fork
https://gitlab.com/jfehlig/libvirt/-/tree/sev-snp?ref_type=heads
Looking at the git log, it seems I fiddle with it every 2 months o
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/index.xml | 3 +
src/cpu_map/meson.build | 3 +
src/cpu_map/x86_Skylake-Client-IBRS.xml | 1 +
src/cpu_map/x86_Skylake-Client-noTSX-IBRS.xml | 1 +
src/cpu_map/x86_Skylake-Client-v4.xml
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/index.xml | 4 +
src/cpu_map/meson.build | 4 +
src/cpu_map/x86_Icelake-Server-noTSX.xml | 1 +
src/cpu_map/x86_Icelake-Server-v3.xml | 103 +
src/cpu_map/x86_Icelake-S
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/x86_Dhyana-v2.xml | 81 +++
src/cpu_map/x86_Dhyana.xml| 1 +
..._64-cpuid-Hygon-C86-7185
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/x86_IvyBridge-IBRS.xml | 1 +
src/cpu_map/x86_IvyBridge.xml | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/cpu_map/x86_IvyBridge-IBRS.xml
b/src/cpu_map/x86_IvyBridge-IBRS.xml
index 430bc3232d..b2b257c11c 100644
--- a/src/cpu_map/x86
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/x86_Haswell-IBRS.xml | 1 +
src/cpu_map/x86_Haswell-noTSX-IBRS.xml | 1 +
src/cpu_map/x86_Haswell-noTSX.xml | 1 +
src/cpu_map/x86_Haswell.xml| 1 +
4 files changed, 4 insertions(+)
diff --git a/src/cpu_map/x86_Haswell-IBRS.x
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/index.xml | 3 +
src/cpu_map/meson.build | 3 +
src/cpu_map/x86_Snowridge-v2.xml | 78 ++
src/cpu_map/x86_Snowridge-v3.xml | 80 +++
src/cpu_ma
---
src/cpu_map/index.xml | 6 +
src/cpu_map/meson.build | 6 +
src/cpu_map/x86_EPYC-IBPB.xml | 1 +
src/cpu_map/x86_EPYC-Milan-v2.xml | 108 ++
src/cpu_map/x86_EPYC-Milan.xml| 1 +
sr
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/index.xml | 3 +
src/cpu_map/meson.build | 3 +
src/cpu_map/x86_Cascadelake-Server-noTSX.xml | 1 +
src/cpu_map/x86_Cascadelake-Server-v2.xml | 93 +++
src/cpu_map/x86_Cascadelake
Since the EPYC CPUs were added to libvirt, some changes have been made
to these models in qemu, mostly adding features. Update these CPUS to
the latest values from qemu.
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/x86_EPYC-IBPB.xml | 2 ++
src/cpu_map/x86_EP
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/x86_SapphireRapids-v2.xml | 125 ++
src/cpu_map/x86_SapphireRapids.xml| 1 +
.../domaincapsdata/qemu_
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/x86_Cooperlake-v2.xml | 98 +++
src/cpu_map/x86_Cooperlake.xml| 1 +
.../x86_64-cpuid-Cooperlake
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/x86_Broadwell-IBRS.xml | 1 +
src/cpu_map/x86_Broadwell-noTSX-IBRS.xml | 1 +
src/cpu_map/x86_Broadwell-noTSX.xml | 1 +
src/cpu_map/x86_Broadwell.xml| 1 +
4 files changed, 4 insertions(+)
diff --git a/src/cpu_map/x86_Broadw
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/x86_SandyBridge-IBRS.xml | 1 +
src/cpu_map/x86_SandyBridge.xml | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/cpu_map/x86_SandyBridge-IBRS.xml
b/src/cpu_map/x86_SandyBridge-IBRS.xml
index fbdb4f2bf6..24cc22f596 100644
--- a/src/cpu
Signed-off-by: Jonathon Jongsma
---
src/cpu_map/x86_Westmere-IBRS.xml | 1 +
src/cpu_map/x86_Westmere.xml | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/cpu_map/x86_Westmere-IBRS.xml
b/src/cpu_map/x86_Westmere-IBRS.xml
index c7898f0c22..46460b5a7d 100644
--- a/src/cpu_map/x86_Wes
After modifying the sync_cpu_model_i386 script to generate an alias for
versioned CPUs, we need to add the ability to handle cpu model aliases.
This involves parsing and storing the alias in the virCPUx86Model
structure and also allowing the CPU to be looked up by its alias or its
official name.
S
---
src/cpu_map/x86_Nehalem-IBRS.xml | 1 +
src/cpu_map/x86_Nehalem.xml | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/cpu_map/x86_Nehalem-IBRS.xml b/src/cpu_map/x86_Nehalem-IBRS.xml
index 00d0d2fe51..1d19cab20f 100644
--- a/src/cpu_map/x86_Nehalem-IBRS.xml
+++ b/src/cpu_map/x86_Ne
This is not necessarily intended as a finished proposal, but as a discussion
starter. I mentioned in an email last week that for SEV-SNP support we will
need to be able to specify versioned CPU models that are not yet supported by
libvirt. Rather than just adding a versioned CPU or two that would s
Previously, the script only generated the parent CPU and any versions
that had a defined alias. Now generate all CPU versions. Any version
that had a defined alias will continue to use that alias, but those
without aliases will use the generated name $BASECPUNAME-vN. This
generated name will be use
DO_TEST_CPUID(arch, host, json) is a multipart test. It consists of the
following tests:
- cpuTestHostCPUID()
- cpuTestGuestCPUID(with JSON_* flag)
- cpuTestCPUIDSignature()
- DO_TEST_JSON():
- if json==JSON_MODELS:
- cpuTestGuestCPUID(without JSON_* flag)
- cpuTestJSONCPUID()
- c
On Mon, Nov 06, 2023 at 07:43:56PM +0100, Andrea Bolognani wrote:
> We recently unified all services and sockets, except a couple
> were missed. Finish the job.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/remote/virt-guest-shutdown.target | 4 ++--
> tools/libvirt-guests.service.in | 6
We recently unified all services and sockets, except a couple
were missed. Finish the job.
Signed-off-by: Andrea Bolognani
---
src/remote/virt-guest-shutdown.target | 4 ++--
tools/libvirt-guests.service.in | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/remo
On Wed, Nov 01, 2023 at 03:22:12PM +0100, Ján Tomko wrote:
> As a guard against programming errors, one part of the condition
> only dereferences srcpool if it exists, other one does not.
>
> Move the check up one level so that it actually has a chance to do
> something useful.
>
> Fixes: 19b1c0d31
On 11/6/23 7:16 AM, Daniel P. Berrangé wrote:
On Mon, Nov 06, 2023 at 12:45:22PM +0100, Michal Prívozník wrote:
On 11/6/23 11:54, Andrea Bolognani wrote:
On Mon, Nov 06, 2023 at 10:26:36AM +, Daniel P. Berrangé wrote:
On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote:
So do
On Mon, Nov 06, 2023 at 07:38:13AM -0800, Andrea Bolognani wrote:
> On Mon, Nov 06, 2023 at 12:42:58PM +, Daniel P. Berrangé wrote:
> > On Mon, Nov 06, 2023 at 12:04:09PM +0100, Andrea Bolognani wrote:
> > > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982
> > >
> > > A
On Mon, Nov 06, 2023 at 12:42:58PM +, Daniel P. Berrangé wrote:
> On Mon, Nov 06, 2023 at 12:04:09PM +0100, Andrea Bolognani wrote:
> > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982
> >
> > Assumes that
> >
> > https://gitlab.com/libvirt/libvirt-ci/-/merge_requests
On Thu, Nov 02, 2023 at 04:40:28PM +0100, Peter Krempa wrote:
> CCW addresses need to be also checked for ABI stability.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/domain_conf.c | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani
--
Andrea
On Mon, Nov 06, 2023 at 12:04:13PM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> ci/cirrus/macos-14.vars | 16
> ci/gitlab/builds.yml| 16
> ci/manifest.yml | 7 +++
> 3 files changed, 39 insertions(+)
> create mode 10
On Mon, Nov 06, 2023 at 12:04:14PM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> ci/cirrus/macos-12.vars | 16
> ci/gitlab/builds.yml| 16
> ci/manifest.yml | 7 ---
> 3 files changed, 39 deletions(-)
> delete mode 100
On Mon, Nov 06, 2023 at 12:04:12PM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> ci/cirrus/macos-13.vars | 16
> ci/gitlab/builds.yml| 16
> ci/manifest.yml | 7 +++
> 3 files changed, 39 insertions(+)
> create mode 10
On Mon, Nov 06, 2023 at 12:04:11PM +0100, Andrea Bolognani wrote:
> We no longer use rpcgen.
>
> Signed-off-by: Andrea Bolognani
> ---
> ci/gitlab/builds.yml | 2 +-
> ci/manifest.yml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards
On Mon, Nov 06, 2023 at 12:04:09PM +0100, Andrea Bolognani wrote:
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982
>
> Assumes that
>
> https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/444
>
> has been merged, which it hasn't yet, but I don't expect it to be
>
On Mon, Nov 06, 2023 at 12:45:22PM +0100, Michal Prívozník wrote:
> On 11/6/23 11:54, Andrea Bolognani wrote:
> > On Mon, Nov 06, 2023 at 10:26:36AM +, Daniel P. Berrangé wrote:
> >> On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote:
> >>> So does that mean that the issue is serv
On 11/6/23 11:54, Andrea Bolognani wrote:
> On Mon, Nov 06, 2023 at 10:26:36AM +, Daniel P. Berrangé wrote:
>> On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote:
>>> So does that mean that the issue is server-side? I'm pretty sure
>>> Laine, Martin and I are all fetching emails u
The virDomainMemoryDefCheckConflict() already does the same set
of checks. There's no need to duplicate them.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 37 -
1 file changed, 37 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qem
Since we're iterating over def->mems array, might as well check
for dimm slot duplicates.
Signed-off-by: Michal Privoznik
---
src/conf/domain_validate.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/src/conf/domain_validate.c b/src/con
So far we check whether virtio-mem and/or virtio-pmem memory
devices do not overlap with each other. But we allow specifying
address where dimm and nvdimm memory devices are mapped too. And
there are left out from this collision check. Not anymore.
This leaves just sgx model out, but that's expect
At the end of virDomainMemoryDefValidate() there's a code that
checks whether two virtio-mem/virtio-pmem devices don't overlap.
Separate this code into its own function
(virDomainMemoryDefCheckConflict()).
Signed-off-by: Michal Privoznik
---
src/conf/domain_validate.c | 147 +
This test case of qemuxml2argvtest is used to check whether we
correctly identify overlapping memory devices. Well, so far we
consider just virtio-mem and virtio-pmem devices, but this is
about to change and be extended for other models too. Extend the
test case now to de-clutter next commit.
Sign
Problem with HW_PHYSMEM sysctl on 64-bit macOS is that it
returns a 32-bit signed value. Thus it overflows. Switching to
HW_MEMSIZE is recommended as it's of an uint_64 type [1].
1:
https://github.com/apple-oss-distributions/xnu/blob/xnu-10002.1.13/bsd/sys/sysctl.h
Reported-by: Jaroslav Suchanek
*** BLURB HERE ***
Michal Prívozník (5):
domain_validate: Move memdevice address conflict check into a separate
function
qemuxml2argvdata: Extend memory-hotplug-virtio-mem-overlap-address.xml
virDomainMemoryDefCheckConflict: Check dimm & nvdimm models too
virDomainMemoryDefCheckConflic
Gain native gettext for MinGW containers, lose rpcgen everywhere.
Signed-off-by: Andrea Bolognani
---
ci/buildenv/almalinux-8.sh| 1 -
ci/buildenv/alpine-317.sh | 1 -
ci/buildenv/alpine-edge.sh| 1 -
ci/buildenv
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982
Assumes that
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/444
has been merged, which it hasn't yet, but I don't expect it to be
controversial.
I've added both macOS 13 and 14, doubling the amount of coverage.
Signed-off-by: Andrea Bolognani
---
ci/cirrus/macos-12.vars | 16
ci/gitlab/builds.yml| 16
ci/manifest.yml | 7 ---
3 files changed, 39 deletions(-)
delete mode 100644 ci/cirrus/macos-12.vars
diff --git a/ci/cirrus/macos-12.vars b/ci/cirrus/ma
Signed-off-by: Andrea Bolognani
---
ci/cirrus/macos-14.vars | 16
ci/gitlab/builds.yml| 16
ci/manifest.yml | 7 +++
3 files changed, 39 insertions(+)
create mode 100644 ci/cirrus/macos-14.vars
diff --git a/ci/cirrus/macos-14.vars b/ci/cirrus/m
Signed-off-by: Andrea Bolognani
---
ci/cirrus/macos-13.vars | 16
ci/gitlab/builds.yml| 16
ci/manifest.yml | 7 +++
3 files changed, 39 insertions(+)
create mode 100644 ci/cirrus/macos-13.vars
diff --git a/ci/cirrus/macos-13.vars b/ci/cirrus/m
We no longer use rpcgen.
Signed-off-by: Andrea Bolognani
---
ci/gitlab/builds.yml | 2 +-
ci/manifest.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml
index 2beca51767..8297adbc5f 100644
--- a/ci/gitlab/builds.yml
+++ b/c
On Mon, Nov 06, 2023 at 10:26:36AM +, Daniel P. Berrangé wrote:
> On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote:
> > So does that mean that the issue is server-side? I'm pretty sure
> > Laine, Martin and I are all fetching emails using different tools, so
> > that would sound
On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote:
> On Mon, Nov 06, 2023 at 09:58:02AM +, Daniel P. Berrangé wrote:
> > On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote:
> > > On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> > > > Ah, since th
On Mon, Nov 06, 2023 at 09:58:02AM +, Daniel P. Berrangé wrote:
> On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote:
> > On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> > > Ah, since the switch to the new ML I cannot apply any patch using git
> > > am:
> > >
On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote:
> On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> > On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote:
> > > On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
> > > > Temporarily
On Mon, Nov 06, 2023 at 10:28:37AM +0100, Michal Privoznik wrote:
> Problem with HW_PHYSMEM sysctl on 64-bit macOS is that it
> returns a 32-bit signed value. Thus it overflows. Switching to
> HW_MEMSIZE is recommended as it's of an uint_64 type [1].
>
> 1:
> https://github.com/apple-oss-distribu
On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote:
> > On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
> > > Temporarily disable '-Wmissing-include-dirs' becuase the
> > > libtirpc pkg-confog fi
On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote:
> > On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
> > > Temporarily disable '-Wmissing-include-dirs' becuase the
> > > libtirpc pkg-confog fi
On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote:
On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
Temporarily disable '-Wmissing-include-dirs' becuase the
libtirpc pkg-confog file has a bogus include dir. The
headers can fortunately still be found since they
Problem with HW_PHYSMEM sysctl on 64-bit macOS is that it
returns a 32-bit signed value. Thus it overflows. Switching to
HW_MEMSIZE is recommended as it's of an uint_64 type [1].
1:
https://github.com/apple-oss-distributions/xnu/blob/xnu-10002.1.13/bsd/sys/sysctl.h
Reported-by: Jaroslav Suchanek
On 11/4/23 01:04, Laine Stump wrote:
> flake8 (run on all python scripts as a part of the syntax checks)
> version 6.1.0 (on macOS 14) issued many complaints like this on the
> new rpcgen python scripts:
>
> [...]libvirt/scripts/rpcgen/rpcgen/lexer.py:57:17: E721 do not compare types,
> for exact
On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
> Temporarily disable '-Wmissing-include-dirs' becuase the
> libtirpc pkg-confog file has a bogus include dir. The
pkg-config
> +++ b/ci/manifest.yml
> @@ -205,6 +205,8 @@ targets:
>- arch: x86_64
> variables:
>
On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
Temporarily disable '-Wmissing-include-dirs' becuase the
libtirpc pkg-confog file has a bogus include dir. The
headers can fortunately still be found since they are
in the system include dir.
Signed-off-by: Daniel P. Berrangé
On Fri, Nov 03, 2023 at 01:56:23PM -0400, Daniel P. Berrangé wrote:
> This port was discontinued and purged from the archives:
>
> https://lists.debian.org/debian-devel-announce/2023/09/msg0.html
>
> Signed-off-by: Daniel P. Berrangé
> ---
> ci/buildenv/debian-sid-cross-mipsel.sh| 115
On Fri, Nov 03, 2023 at 08:04:13PM -0400, Laine Stump wrote:
> flake8 (run on all python scripts as a part of the syntax checks)
> version 6.1.0 (on macOS 14) issued many complaints like this on the
> new rpcgen python scripts:
>
> [...]libvirt/scripts/rpcgen/rpcgen/lexer.py:57:17: E721 do not com
(Sigh, resent because I forgot to update the list address in the reply :-/)
Sorry, I meant to respond to this earlier and forgot. Now I'm sending v2
of the patches, and wanted to make sure you didn't think I was just
ignoring your comments :-) (since this patch is still there in V2)
On 10/23/
Xen only supports a single type of PCI hostdev assignment, so it is
superfluous to have peppered throughout the
config. It *is* necessary to have the driver type explicitly set in
the hosdev object before calling into the hypervisor-agnostic "hostdev
manager" though (otherwise the hostdev manager
The next step in consolidating parsing/formatting of the
element of these objects using a common struct and common code. This
eliminates the virNetworkForwardDriverNameType enum which is nearly
identical to virDeviceHostdevPCIDriverType (the only non-identical bit
was just because they'd gotten ou
The long-deprecated use of in domain xml
for devices was only ever necessary during the period when
libvirt (and the Linux kernel) supported both VFIO and "legacy KVM"
styles of hostdev device assignment for QEMU. This became pointless
many years ago when legacy KVM device assignment was removed
This patch makes it possible to manually specify which VFIO variant
driver to use for PCI hostdev device assignment, so that, e.g. you
could force use of the generic vfio-pci driver with
when libvirt would have normally (after applying a subsequent patch)
found a "better match" for a device in
Currently this enum is defined in domain_conf.h and named
virDomainHostdevSubsysPCIDriverType. I want to use it in parts of the
network and networkport config, so am moving its definition to
device_conf.h which is / can be included by all interested parties,
and renaming it to be less specific to i
Rather than always binding to the vfio-pci driver, use the new
function virPCIDeviceFindBestVFIOVariant() to see if the running
kernel has a VFIO variant driver available that is a better match for
the device, and if one is found, use that instead.
virPCIDeviceFindBestVFIOVariant() function reads
virHostdevIsVFIODevice() and virDomainDefHasVFIOHostdev() are only ever
called from the QEMU driver, and in the case of the QEMU driver, any
PCI hostdev by definition uses VFIO, so really all these callers only
need to know if the device is a PCI hostdev.
(It turned out that the less specific virH
70 matches
Mail list logo
