[389-devel] Please review: Allow modrdn to move subtree and rename non-leaf node

Allow modrdn to move subtree and rename non-leaf node This patch includes - replacing the entrydn index with the entryrdn index - replacing a full DN in each entry in the DB with an RDN - extending Slapi_Entry, entry2str, and str2entry to absorb the changes made on the entry

[389-devel] Please review: [Bug 557224] subtree rename breaks the referential integrity plug-in

https://bugzilla.redhat.com/show_bug.cgi?id=557224 Description of problem: Analysis by andrey.iva...@polytechnique.fr I'm pretty sure the referential integrity plug-in will not work for modrdn operations with a new superior. Looking more thoroughly through the code ( ldap / servers / plugins

[389-devel] Please review: [Bug 194531] db2bak is too noisy

https://bugzilla.redhat.com/show_bug.cgi?id=194531 https://bugzilla.redhat.com/attachment.cgi?id=436980&action=diff https://bugzilla.redhat.com/attachment.cgi?id=436980&action=edit Description: Added -v option to db2bak and bak2db and moved the Backing up/ Restoring logs to the verbose mode ou

[389-devel] Please review: [Bug 621928] Unable to enable replica (rdn problem?) on 1.2.6 rc6

https://bugzilla.redhat.com/show_bug.cgi?id=621928 https://bugzilla.redhat.com/attachment.cgi?id=437670&action=diff https://bugzilla.redhat.com/attachment.cgi?id=437670&action=edit Description: RUV (nsuniqueid=---,) needs to be allowed to add to the DB before is

[389-devel] Please review: [Bug 622628] fix coverity Defect Type: Integer handling issues

https://bugzilla.redhat.com/show_bug.cgi?id=622628 https://bugzilla.redhat.com/attachment.cgi?id=437950&action=diff https://bugzilla.redhat.com/attachment.cgi?id=437950&action=edit https://bugzilla.redhat.com/attachment.cgi?id=437952&action=diff https://bugzilla.redhat.com/attachment.cgi?id=43795

[389-devel] Please review: [Bug 622903] fix coverity Defect Type: Code maintainability issues

https://bugzilla.redhat.com/show_bug.cgi?id=622903 https://bugzilla.redhat.com/attachment.cgi?id=437967&action=diff https://bugzilla.redhat.com/attachment.cgi?id=437967&action=edit https://bugzilla.redhat.com/attachment.cgi?id=437971&action=diff https://bugzilla.redhat.com/attachment.cgi?id=437

[389-devel] Please review: [Bug 629710] escape_string does not check '\'

https://bugzilla.redhat.com/show_bug.cgi?id=629710 https://bugzilla.redhat.com/attachment.cgi?id=442728&action=diff https://bugzilla.redhat.com/attachment.cgi?id=442728&action=edit Description: do_escape_string (core of escape_string) converts '\\ (backslash)' to '\5C' even if the following 2

[389-devel] Please review: [Bug 625014] SubTree Renames: ModRDN operation fails and the server hangs if the entry is moved to "under" the same DN.

https://bugzilla.redhat.com/show_bug.cgi?id=625014 https://bugzilla.redhat.com/attachment.cgi?id=447045&action=diff https://bugzilla.redhat.com/attachment.cgi?id=447045&action=edit Description: adding a check if the newsuperior is the entry itself or its descendent. If it is, modrdn returns L

Re: [389-devel] Please review: Only check modrdn ops for backend/suffix correctness if not the default backend

On 09/13/2010 03:42 PM, Rich Megginson wrote: This fix allows the datainterop tests to pass at 100% ack. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel smime.p7s Description: S/MIME Cryptographic Signature -

Re: [389-devel] 1.2.6-1 crash

On 09/29/2010 12:49 PM, Rich Megginson wrote: Gary Morris wrote: ah.. sorry.. ok.. just retried with 1.2.6.1-1.. / [r...@dalp-ct02 logs]# rpm -qa | grep 389 389-dsgw-1.1.5-1.fc13.x86_64 389-admin-console-1.1.5-1.fc13.noarch 389-admin-1.1.11-1.fc13.x86_64 389-ds-base-1.2.6.1-1.fc13.x86_64 389-d

Re: [389-devel] 1.2.6-1 crash

so.0 (gdb) thread apply all bt On 09/29/2010 01:29 PM, Gary Morris wrote: sure.. i'll do that and rerun them.. On Wed, Sep 29, 2010 at 4:25 PM, Noriko Hosoi <mailto:nho...@redhat.com>> wrote: On 09/29/2010 12:49 PM, Rich Megginson wrote: Gary Morris wrote:

[389-devel] Please review (take 2): [Bug 602456] Allow to add any cn=config attributes; allow to delete some cn=config attributes

https://bugzilla.redhat.com/show_bug.cgi?id=602456 https://bugzilla.redhat.com/attachment.cgi?id=453261&action=diff https://bugzilla.redhat.com/attachment.cgi?id=453261&action=edit Thanks to Nathan for his review on the first proposal. I'm adding this change following Rich's suggestion. Fol

[389-devel] Please review: [Bug 244229] targetattr not verified against schema when setting an aci

https://bugzilla.redhat.com/show_bug.cgi?id=244229 https://bugzilla.redhat.com/attachment.cgi?id=453598&action=diff https://bugzilla.redhat.com/attachment.cgi?id=453598&action=edi Description: 1. When acl contains targetattr keyword: (targetattr [!]= "attribute_1 || attribute_2 ...|| attrib

[389-devel] Please review (take 2): [Bug 244229] targetattr not verified against schema when setting an aci

https://bugzilla.redhat.com/show_bug.cgi?id=244229 https://bugzilla.redhat.com/attachment.cgi?id=453769&action=diff https://bugzilla.redhat.com/attachment.cgi?id=453769&action=edit Following the comments by Rich, revised the proposal so that: 1) the error message is sent to the client, as well.

[389-devel] Please review: [Bug 567282] server can not abandon searchRequest of "simple paged results"

https://bugzilla.redhat.com/show_bug.cgi?id=567282 https://bugzilla.redhat.com/attachment.cgi?id=457550&action=edit https://bugzilla.redhat.com/attachment.cgi?id=457550&action=diff Description: Simple Paged Results search keeps the connection per paging, but not an operation. When an abandon r

Re: [389-devel] Please review: make sure the DBVERSION file ends in a newline

ack. Thanks, Rich!! --noriko Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Introducing an environment variable USE_VALGRIND to clean up the entry cache and dn cache on exit.

From 40ac246939d8e7bf8138c85ea00f30beece094d5 Mon Sep 17 00:00:00 2001 From: Noriko Hosoi Date: Wed, 31 Aug 2011 11:09:42 -0700 Subject: [PATCH] Introducing an environment variable USE_VALGRIND to clean up the entry cache and dn cache on exit. --- ldap/servers/slapd/back-ldbm/dblayer.c | 23

Re: [389-devel] Please review: Make all backend operations transaction aware

Rich Megginson wrote: > http://rmeggins.fedorapeople.org/patches/0001-Make-all-backend-operations-transaction-aware.patch ack. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: convert memberof to use transactions

Rich Megginson wrote: There are 3 patches. 0001 fixes a problem with betxn and modrdn to make the ENTRY_POST_OP available to betxnpostop plugins. 0002 allows us to pass the plugin config entry to plugin_init functions (yay! finally!). 0003 is the actual change to memberof. ack. ack. ack. So

[389-devel] Please review: Fix Coverity Defects

file (master)* <https://bugzilla.redhat.com/attachment.cgi?id=531392> (1.04 KB, patch) 2011-11-02 13:05 EDT <https://bugzilla.redhat.com/show_bug.cgi?id=750625#attach_531392>, Noriko Hosoi <mailto:nho...@redhat.com> nhosoi: review? Details <https://bugzilla.redhat.com/a

[389-devel] Please review: [Bug 750625] Fix Coverity minor defects

w_bug.cgi?id=750625#attach_531631>, Noriko Hosoi <mailto:nho...@redhat.com> nhosoi: review? Details <https://bugzilla.redhat.com/attachment.cgi?id=531631&action=edit> | Diff <https://bugzilla.redhat.com/attachment.cgi?id=531631&action=diff> *Fix Coverity (11062)

[389-devel] Please review: [Bug 689866] ns-newpwpolicy.pl needs to use the new DN format

https://bugzilla.redhat.com/show_bug.cgi?id=689866 https://bugzilla.redhat.com/attachment.cgi?id=486852&action=diff https://bugzilla.redhat.com/attachment.cgi?id=486852&action=edit

Re: [389-devel] Please review: add skin support to admin server

On 06/16/2011 11:28 AM, Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel Looks good to me. ACK. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mai

[389-devel] Please review: [Bug 719069] clean up compiler warnings in 389-ds-base 1.2.9

https://bugzilla.redhat.com/show_bug.cgi?id=719069 https://bugzilla.redhat.com/attachment.cgi?id=511349&action=diff https://bugzilla.redhat.com/attachment.cgi?id=511349&action=edit Thanks, --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailma

[389-devel] Please review (revised): [Bug 560827] Admin Server templates: DistinguishName validation fails

Thanks to Rich and Nathan for their comments and even debugging my code :). I revised the proposal based upon their suggestions. Summary: Admin Server templates: DistinguishName validation fails https://bugzilla.redhat.com/show_bug.cgi?id=560827 Description of problem: Some template file cont

[389-devel] Please review: [Bug 527848] make sure db upgrade to 4.7 and later works correctly

https://bugzilla.redhat.com/show_bug.cgi?id=527848 Subject: make sure db upgrade to 4.7 and later works correctly Proposed Fix: https://bugzilla.redhat.com/attachment.cgi?id=395003&action=diff Change Description: https://bugzilla.redhat.com/attachment.cgi?id=395003&action=edit Thanks, --noriko

Re: [389-devel] Please review: fix various memory leaks

On 03/04/2010 01:03 PM, Rich Megginson wrote: Fixes for various memory leaks found during testing. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. (Thanks, Rich!!) --noriko smime.p7s Description: S/MIME Cryptograph

[389-devel] Please review (take 2): [Bug 570667] MMR: simultaneous total updates on the masters cause deadlock and data loss

Subject: MMR: simultaneous total updates on the masters cause deadlock and data loss https://bugzilla.redhat.com/show_bug.cgi?id=570667 [Revised proposal] --> (https://bugzilla.redhat.com/attachment.cgi?id=398089) git patch file I revised the previous patch to allow sending simultaneous tota

Re: [389-devel] Please review: cleanup build warnings

On 03/05/2010 02:56 PM, Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. --noriko smime.p7s Description: S/MIME Cryptographic Signature -- 389-devel mailing list 389-de...@lists.fedoraproject.org

[389-devel] Please review: [Bug 199923] subtree search fails to find items under a db containing special characters

Subject: subtree search fails to find items under a db containing special characters https://bugzilla.redhat.com/show_bug.cgi?id=199923 This bug had been reopened due to the regression. [Proposed Fix] https://bugzilla.redhat.com/attachment.cgi?id=398612&action=diff https://bugzilla.redhat.com/

Re: [389-devel] Please review: Add support for additional schema/matching rules included with 389

(2010?03?08? 19:54), Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (take 2): [Bug 199923] subtree search fails to find items under a db containing special characters

Subject: subtree search fails to find items under a db containing special characters https://bugzilla.redhat.com/show_bug.cgi?id=199923 Files: ldap/servers/plugins/syntaxes/validate.c ldap/servers/slapd/back-ldbm/ldbm_add.c ldap/servers/slapd/dn.c Fix Description: dn.c: Based upon RFC 4514,

Re: [389-devel] DN normalisation design document

On 03/17/2010 01:13 PM, Andrey Ivanov wrote: In order to support "Old DN format including DN in the double quotes" another cn=config switch may be necessary. It seems there was recently a new switch introduced to make the dn syntax validation a little more "relaxed" - nsslapd-dn

Re: [389-devel] Please Review: Fix parsing of start-slapd scripts

On 04/01/2010 11:18 AM, Nathan Kinder wrote: On 03/31/2010 10:04 PM, Nathan Kinder wrote: On 03/31/2010 09:52 PM, Endi Sukma Dewata wrote: - "Nathan Kinder" wrote: The admin server CGIs parse the start-slapd scripts to determine the DS instance names. A recent format change to start-s

[389-devel] Please review: [389 Project] #18: Data inconsitency during replication

https://fedorahosted.org/389/ticket/18 https://fedorahosted.org/389/attachment/ticket/18/0001-Trac-Ticket-18-Data-inconsitency-during-replication.patch Bug description: If promote a hub server to a new master and assign the same replica ID as the original master server had, some new adds/modifie

Re: [389-devel] Please review: Remove redundant code - make a global into a static

Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #139: RFE: eliminate the use of char *dn in favor of Slapi_DN *dn

https://fedorahosted.org/389/ticket/139 https://fedorahosted.org/389/attachment/ticket/139/0001-Trac-Ticket-139-eliminate-the-use-of-char-dn-in-favo.patch Fix description: The oritinal RFE had been already implemented in the commit f6397113666f06848412bb12f754f04258cfa5fa: Reduce the number

[389-devel] Please review: [389 Project] #52: FQDN set to nsslapd-listenhost makes the server start fail if IPv4-mapped-IPv6 address is given

https://fedorahosted.org/389/ticket/52 https://fedorahosted.org/389/attachment/ticket/52/0001-Trac-Ticket-52-FQDN-set-to-nsslapd-listenhost.patch Fix description: Added a code to check netaddr is duplicated or not. When the address is IPv4-mapped-IPv6, cut the IPv4 part out of the address and u

[389-devel] Please review: [389 Project] #35: Log not clear enough on schema errors

https://fedorahosted.org/389/ticket/35 https://fedorahosted.org/389/attachment/ticket/35/0001-Trac-Ticket-35-Log-not-clear-enough-on-schema-errors.patch Comment: Fix description: Cryptic error message: dse - parsing dse entry [attributeTypes] is now replaced with: dse - Parsing ent

[389-devel] Please review (take 2): [389 Project] #35: Log not clear enough on schema errors

https://fedorahosted.org/389/ticket/35 https://fedorahosted.org/389/attachment/ticket/35/0001-Trac-Ticket-35-Log-not-clear-enough-on-schema-errors.patch Thanks to Rich for his review. The new patch logs the lineno of the corrupted entry in the input ldif file. Comment: Improved the error m

[389-devel] Please review: [389 Project] #27: SASL/PLAIN binds do not work

https://fedorahosted.org/389/ticket/27 https://fedorahosted.org/389/attachment/ticket/27/0001-Trac-Ticket-27-SASL-PLAIN-binds-do-not-work.patch Bug description: ids_sasl_canon_user failed to set "dn: " in front of the dn string in the output argument out_user. The dn string is used in the next

[389-devel] Please review (take 2): [389 Project] #27: SASL/PLAIN binds do not work

https://fedorahosted.org/389/ticket/27 https://fedorahosted.org/389/attachment/ticket/27/0001-Trac-Ticket-27-SASL-PLAIN-binds-do-not-work.patch Thanks to Rich for his comment. Fixed the code based upon his suggestions. --noriko -- 389-devel mailing list 389-de...@lists.fedoraproject.org https:/

[389-devel] Please review: [389 Project] #84: 389 Directory Server Unnecessary Checkpoints

https://fedorahosted.org/389/ticket/84 https://fedorahosted.org/389/attachment/ticket/84/0001-Trac-Ticket-84-389-Directory-Server-Unnecessary-Chec.patch Fix description: txn_checkpoint was always called with DB_FORCE flag. This patch introduces db_force arg to dblayer_txn_checkpoint and DB_F

[389-devel] Please review: [389 Project] #169: allow 389 to use db5

https://fedorahosted.org/389/ticket/169 https://fedorahosted.org/389/attachment/ticket/169/0001-Trac-Ticket-169-allow-389-to-use-db5.patch git patch file (master) -- excluded autogen files Fix description: 1. DB suffix ".db4" is changed to ".db" if the server is linked with db5 (libdb); it

[389-devel] Please review: [389 Project] #260: 389 DS does not support multiple paging controls on a single connection

https://fedorahosted.org/389/ticket/260 https://fedorahosted.org/389/attachment/ticket/260/0001-Trac-Ticket-260-389-DS-does-not-support-multiple.patch Fix description: 1. "Connection" object holds the paged results related values. Now they are packaged in one PagedResults object. And the

Re: [389-devel] Please review: coverity 12563 Read from pointer after free

Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #303: make DNA range requests work with transactions

https://fedorahosted.org/389/ticket/303 https://fedorahosted.org/389/attachment/ticket/303/0001-Trac-Ticket-303-make-DNA-range-requests-work-with-tr.patch Fix Description: 1. pre_op: Adding missing dnatypes (e.g., uidNumber) should be done in the pre op phase (outside of the transaction) t

[389-devel] Please review: coverity 12606 Logically dead code

entry" and free it. >From 4e0c70fd1a52d4bc943613bc496751fab2e390c0 Mon Sep 17 00:00:00 2001 From: Noriko Hosoi Date: Thu, 15 Mar 2012 09:17:33 -0700 Subject: [PATCH] coverity 12606 Logically dead code The previous fix (commit 325abca7135d06225adf5380d726de60dacda5a4) for "Ticket #303 - make DNA range reque

[389-devel] Please review: [Bug 651571] When attrcrypt is on, entrydn is stored in the backend db

https://bugzilla.redhat.com/show_bug.cgi?id=651571 https://bugzilla.redhat.com/attachment.cgi?id=459236&action=diff https://bugzilla.redhat.com/attachment.cgi?id=459236&action=edit Description: If an entry contains a to-be-encrypted attribute, id2entry_add_ext handles a copy of the entry in whi

[389-devel] Please review: [Bug 182507] clear-password mod from replica is discarded before changelogged

https://bugzilla.redhat.com/show_bug.cgi?id=182507 https://bugzilla.redhat.com/attachment.cgi?id=467113&action=diff https://bugzilla.redhat.com/attachment.cgi?id=467113&action=edit Description: Replication drops unhashed passwords which is necessary for the AD password sync. This patch allows

Re: [389-devel] Please review: [Bug 182507] clear-password mod from replica is discarded before changelogged

Hi Andrey, Andrey Ivanov wrote: > Hi Noriko, > > i've read the changelog encryption design document. Indeed, it's a > sound idea to make AD-389 replication more robust. I have two > questions about it: > > * if i understand correctly you say that the server needs a > certificate in order to gene

[389-devel] Please review: [Bug 616850] ldapmodify failed to reject the replace operation if its targeted for an Unknown attribute

https://bugzilla.redhat.com/show_bug.cgi?id=616850 https://bugzilla.redhat.com/attachment.cgi?id=474335&action=diff https://bugzilla.redhat.com/attachment.cgi?id=474335&action=edit Description: Attempting to modify an unknown attribute in the config entry fails with LDAP_UNWILLING_TO_PERFORM, whi

[389-devel] Please review (admin server): [Bug 616260] libds-admin-serv linking fails due to unresolved link-time dependencies

https://bugzilla.redhat.com/show_bug.cgi?id=616260 https://bugzilla.redhat.com/attachment.cgi?id=476923&action=diff https://bugzilla.redhat.com/attachment.cgi?id=476923&action=edit Description: 1) Do not use nodist_property_DATA for ICU resource files, but use BUILT_SOURCES to keep them just

[389-devel] Please review: [Bug 675265] preventryusn gets added to entries on a failed delete

https://bugzilla.redhat.com/show_bug.cgi?id=675265 https://bugzilla.redhat.com/attachment.cgi?id=477486&action=diff https://bugzilla.redhat.com/attachment.cgi?id=477486&action=edit Description: When an entry is deleted with Entry USN plugin enabled, an operational attribute preventryusn is added

[389-devel] Please review (take 3) Admin Server: [Bug 245278] Changing to a password with a single quote does not work

https://bugzilla.redhat.com/show_bug.cgi?id=245278 https://bugzilla.redhat.com/attachment.cgi?id=478422&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478422&action=edit Thanks to Rich for his comments. Instead of doing the in-place escape, changed to duplicate the given password and

[389-devel] Please review: [Bug 668909] Can't modify replication agreement in some cases

https://bugzilla.redhat.com/show_bug.cgi?id=668909 https://bugzilla.redhat.com/attachment.cgi?id=483808&action=diff https://bugzilla.redhat.com/attachment.cgi?id=483808&action=edit Description: Code to modify nsds5ReplicaPort in replication agreement was not implemented. This patch adds it. Whe

[389-devel] Please review: [Bug 684996] Exported tombstone cannot be imported correctly.

https://bugzilla.redhat.com/show_bug.cgi?id=684996 https://bugzilla.redhat.com/attachment.cgi?id=486083&action=diff https://bugzilla.redhat.com/attachment.cgi?id=486083&action=edit Description: When nsslapd-subtree-rename-switch is on, a tombstone entry has a special RDN which looks like this:

[389-devel] Please review: [Bug 597375] Deleting LDBM database causes backup/restore problem

https://bugzilla.redhat.com/attachment.cgi?id=419482&action=diff https://bugzilla.redhat.com/attachment.cgi?id=419482&action=edit Fix Description: 1) When a backend is removed, the db instance directory was removed as well (See also 463774 - index files for database should be deleted when db is

[389-devel] Please review: [Bug 578296] Attribute type entrydn needs to be added when subtree rename switch is on.

https://bugzilla.redhat.com/show_bug.cgi?id=578296 https://bugzilla.redhat.com/attachment.cgi?id=426726&action=diff https://bugzilla.redhat.com/attachment.cgi?id=426726&action=edit Files: ldap/servers/slapd/back-ldbm/back-ldbm.h ldap/servers/slapd/back-ldbm/id2entry.c ldap/servers/slapd/back

[389-devel] Please review: [Bug 610281] fix coverity Defect Type: Control flow issues

https://bugzilla.redhat.com/show_bug.cgi?id=610281 Attachments *git patch file (9.0)* <https://bugzilla.redhat.com/attachment.cgi?id=429110> (1.53 KB, patch) 2010-07-02 12:42 EDT <https://bugzilla.redhat.com/show_bug.cgi?id=610281#attach_429110>, Noriko Hosoi <mailto:nho...@r

[389-devel] Please review: [Bug 619595] Upgrading sub suffix under non-normalized suffix disappears

https://bugzilla.redhat.com/show_bug.cgi?id=619595 https://bugzilla.redhat.com/attachment.cgi?id=435442&action=diff https://bugzilla.redhat.com/attachment.cgi?id=435442&action=edit Fix Description: The cause of this problem is the config attribute nsslapd-parent-suffix was not defined as an att

[389-devel] Please review: [Bug 616608] SIGBUS in RDN index reads on platforms with strict alignments

https://bugzilla.redhat.com/show_bug.cgi?id=616608 https://bugzilla.redhat.com/attachment.cgi?id=434877&action=diff https://bugzilla.redhat.com/attachment.cgi?id=434877&action=edit Fix description: Use the marshall/unmarshall technique for the entryrdn index data. Introduced sizeushort_internal

Re: [389-devel] Please review: schema def must have DESC '' - close paren must be preceded by space

Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #19: Convert entryUSN plugin to transaction aware type

https://fedorahosted.org/389/ticket/19 https://fedorahosted.org/389/attachment/ticket/19/0001-Trac-Ticket-19-Convert-entryUSN-plugin-to-transactio.patch Fix description: * Separated usn_bepreop operations from usn_betxnpreop operations. usn_bepreop_modify and _modrdn add "entryusn: #" to th

[389-devel] Please review (take 2'): [389 Project] #359: Database RUV could mismatch the one in changelog under the stress

https://fedorahosted.org/389/ticket/359 Please review these 2 patches: https://fedorahosted.org/389/attachment/ticket/359/0001-Trac-Ticket-359-Database-RUV-could-mismatch-the-one.2.patch (389-ds-base-1.2.10) https://fedorahosted.org/389/attachment/ticket/359/0001-Trac-Ticket-359-Database

Re: [389-devel] Please review: coverity - mbo dead code - winsync leaks, deadcode, null check, test code

Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (take 2): [389 Project] #351: use betxn plugins by default

https://fedorahosted.org/389/ticket/351 https://fedorahosted.org/389/attachment/ticket/351/0001-Trac-Ticket-351-use-betxn-plugins-by-default.2.patch Fix description: In addition to the fixes following the Rich's suggestions (comment 11), the take 2 patch contains ... . to register cos_post_op

[389-devel] Please review (take 2): [389 Project] #453: db2index with -tattrname:type, type fails

https://fedorahosted.org/389/ticket/453 https://fedorahosted.org/389/attachment/ticket/453/0001-Trac-Ticket-453-db2index-with-tattrname-type-type-fa.patch Fix Description: 1) db2index and db2index.pl did not handle options with no space between the option type and the value. This patch properly

[389-devel] Please review: [389 Project] #47367: ldapdelete returns non-leaf entry error while trying to remove a leaf entry

https://fedorahosted.org/389/ticket/47367 https://fedorahosted.org/389/attachment/ticket/47367/0001-Ticket-47367-phase-1-ldapdelete-returns-non-leaf-ent.2.patch git patch file (master) - phase1: ported from 1.2.11 The difference from 1.2.11: [urp.c] 2) The urp calling timing was moved from SLAP

[389-devel] Please review: [389 Project] #47435: Very large entryusn values after enabling the USN plugin and the lastusn value is negative.

https://fedorahosted.org/389/ticket/47435 https://fedorahosted.org/389/attachment/ticket/47435/0001-Ticket-47435-Very-large-entryusn-values-after-enabli.patch 1. Bug description: The initial value of lastusn is -1, but since the entryusn has the unsigned long long integer type, the server ret

[389-devel] Please review (coverity fix): [389 Project] #48: Active Directory has certain uids which are reserved and will cause a Directory Server replica initialization of an AD server to abort.

mistakenly put the "Ignoring ALREADY EXIST case" code before retrieving the ldap_result_code. This patch fixes the order. commit b00b8acca54267560c6d7ec614bc52cfe541200a Author: Noriko Hosoi Date: Fri Aug 16 14:04:27 2013 -0700 -- 389-devel mailing list 389-de...@lists.fedorap

[389-devel] Please review (additinal fix): [389 Project] #47391: deleting and adding userpassword fails to update the password

https://fedorahosted.org/389/ticket/47391 https://fedorahosted.org/389/attachment/ticket/47391/0001-Ticket-47391-deleting-and-adding-userpassword-fails-.patch Bug description: ldapmodify with changetype "modify" is supposed to skip checking unhashed password in acl_check_mods. "delete" and "

[389-devel] Please review: Ticket #47384 - Plugin library path validation

https://fedorahosted.org/389/ticket/47384 https://fedorahosted.org/389/attachment/ticket/47384/0001-Ticket-47384-Plugin-library-path-validation.3.patch Description: commit a4b81c0ae59a4246d2d44790efea093a62fc972c o

[389-devel] Resending...: Please review: [389 Project] #537: Improvement of range search

(2013/01/07 15:57), Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/537 https://fedorahosted.org/389/attachment/ticket/537/0001-Ticket-537-Improvement-of-range-search.patch Fix description: The index range search function index_range _read_ext was written to call idl_fetch_ext to

[389-devel] Please review: [389 Project] #576: DNA: use event queue for config update only at the start up.

https://fedorahosted.org/389/ticket/576 https://fedorahosted.org/389/attachment/ticket/576/0001-Ticket-576-DNA-use-event-queue-for-config-update-onl.patch Bug description: DNA config updates were always put into the event queue and executed in 30 seconds, which increased a chance to conflict

[389-devel] Please review: [389 Project] #603: A logic error in str2simple

https://fedorahosted.org/389/ticket/603 https://fedorahosted.org/389/attachment/ticket/603/0001-Ticket-603-A-logic-error-in-str2simple.patch Fix description: str2simple sets the strdup'ed type this way: if ( f->f_choice == LDAP_FILTER_PRESENT ) { f->f_type = slapi_ch_strdup( str );

[389-devel] Please review: [389 Project] #605: support TLS 1.1 - adding backward compatibility

https://fedorahosted.org/389/ticket/605 https://fedorahosted.org/389/attachment/ticket/605/0001-Ticket-605-support-TLS-1.1-adding-backward-compatibi.patch Description: commit 88d4beccb9d9f7bb89f5e24c47828d7516ba7ca8 always expected the NSS version supporting TLS 1.2. It broke the build on the