Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-22 Thread Kevin Kofler
Tom Lane wrote: > Hmm ... so what should I do with mysql? Since approximately forever, > upstream has recommended using -fno-exceptions (and also > -felide-constructors -fno-rtti) in CXXFLAGS. I now realize that it's > a bit silly to do that when the plain-C files (of which there are > plenty) ar

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-19 Thread Takanori MATSUURA
For Mozilla, see https://developer.mozilla.org/en/C___Portability_Guide#Don%27t_use_exceptions https://bugzilla.mozilla.org/show_bug.cgi?id=593768 Takanori Matej Cepl wrote: > Dne 19.1.2011 07:53, Haïkel Guémar napsal(a): > > Morale: that's just *PLAIN USELESS* to only remove the -fexceptions f

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-19 Thread Tom Lane
f...@redhat.com (Frank Ch. Eigler) writes: > Tom Lane writes: >> Hmm ... so what should I do with mysql? Since approximately forever, >> upstream has recommended using -fno-exceptions (and also >> -felide-constructors -fno-rtti) in CXXFLAGS. [...] >> ... >> Seems like I should either drop the no

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-19 Thread Frank Ch. Eigler
Tom Lane writes: > Hmm ... so what should I do with mysql? Since approximately forever, > upstream has recommended using -fno-exceptions (and also > -felide-constructors -fno-rtti) in CXXFLAGS. [...] -fexceptions / -frtti are essentially harmless, so I am curious why they were ever thought to

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-19 Thread Tom Lane
Hmm ... so what should I do with mysql? Since approximately forever, upstream has recommended using -fno-exceptions (and also -felide-constructors -fno-rtti) in CXXFLAGS. I now realize that it's a bit silly to do that when the plain-C files (of which there are plenty) are being built with -fexcep

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-19 Thread William Lima
On Wed, Jan 19, 2011 at 4:53 AM, Haïkel Guémar wrote: > hi, > > after a good night of sleep, i just noticed that *just* removing the > -fexceptions flag won't change anything. > -fexceptions is for C code linking to C++ code, but it's already default > when compiling C++, then you have to use the

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-18 Thread Matej Cepl
Dne 19.1.2011 07:53, Haïkel Guémar napsal(a): > Morale: that's just *PLAIN USELESS* to only remove the -fexceptions from > flags, anyway, it's already there. And sleeping might be a good thing. +1 for a good example of disaster which IMHO happens see https://bugzilla.mozilla.org/show_bug.cgi?id=51

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-18 Thread Haïkel Guémar
hi, after a good night of sleep, i just noticed that *just* removing the -fexceptions flag won't change anything. -fexceptions is for C code linking to C++ code, but it's already default when compiling C++, then you have to use the -fno-exceptions flag instead if you really want to disable that fe

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-18 Thread William Lima
so, -fexception is mandatory for building C++ libraries @ Fedora? -- w -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-18 Thread Jakub Jelinek
On Tue, Jan 18, 2011 at 06:08:37PM -0500, Frank Ch. Eigler wrote: > -fexception allows a C library to participate in C++ exception > handling. It does not cost anything except extra data tables in the > ELF file. Its presence matters in cases where a C library is used by > a C++ program, for exam

Re: Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-18 Thread Frank Ch. Eigler
Pierre-Yves writes: > [...] > I have been looking into the review #668863 in which the packager for > this library (who also happens to be upstream) is actually removing the > flag "-fexceptions" from $RPM_OPT_FLAGS in the %build. > [...] > - Upstream does not want to have this flag on, saying t

Removing -fexceptions from $RPM_OPT_FLAGS

2011-01-18 Thread Pierre-Yves
Hi, I have been looking into the review #668863 in which the packager for this library (who also happens to be upstream) is actually removing the flag "-fexceptions" from $RPM_OPT_FLAGS in the %build. Asking this question on irc (on fedora-devel) as lead to a small discussion without clear agreem