Re: systeminfo review

2014-03-02 Thread Pavol Ipoth
Hi, can somebody please review package systeminfo, it is there for several months, i am new to package maintaining. Thanks. https://bugzilla.redhat.com/show_bug.cgi?id=1058038 -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code o

Re: systeminfo - review package

2014-02-24 Thread Pavol Ipoth
Hi, sorry that i am replying so late. I checked your suggestions, replaced /usr/bin with %{_bindir}. I also gave there 0%{?el5} shortcut -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code

Re: systeminfo - review package

2014-02-18 Thread Denis Fateyev
Hello, BuildRoot is only needed for EPEL5: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag If presents, it should be one of those: http://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag Removing BuildRoot and "clean" section are needed only for EPEL5 so I think it would bett

Re: systeminfo - review package

2014-02-18 Thread David Roheim
Hi Pavol, I can not approve your package, but I would suggest some things. * Bump your rev version. Incl. changelog. * Define your BuildRoot * Use %{_bindir} instead of /usr/bin * Source-format your spec-file Why do you have: %if 0%{?rhel} && 0%{?rhel} <= 5 rm -rf %{buildroot} %endif W