Re: Use of sed in spec files

2021-08-11 Thread Dan Čermák
Hi Richard, Richard Shaw writes: > It's quite common to need to do some minor manipulation in a spec file and > you decide to use sed instead of patching so you don't have to update it > every release. > > The problem is that sed returns 0 whether it actually did anything or not. > > Thinking ab

Re: Use of sed in spec files

2021-08-11 Thread Vitaly Zaitsev via devel
On 11/08/2021 19:47, Richard Shaw wrote: I agree, but the real question is, how do you determine when it's no longer necessary? Manual checks on major upstream releases. I always try to send a pull request with fixes. So I'll remove the sed hack when my PR is merged. -- Sincerely, Vitaly

Re: Use of sed in spec files

2021-08-11 Thread Richard Shaw
On Wed, Aug 11, 2021 at 12:46 PM Vitaly Zaitsev via devel < devel@lists.fedoraproject.org> wrote: > On 11/08/2021 19:39, Richard Shaw wrote: > > It's quite common to need to do some minor manipulation in a spec file > > and you decide to use sed instead of patching so you don't have to > > update

Re: Use of sed in spec files

2021-08-11 Thread Vitaly Zaitsev via devel
On 11/08/2021 19:39, Richard Shaw wrote: It's quite common to need to do some minor manipulation in a spec file and you decide to use sed instead of patching so you don't have to update it every release. Patching is always painful. You need to rebase your patches on every upstream release.