On Mon, 12 Dec 2016 16:29:39 +, Zbigniew Jędrzejewski-Szmek wrote:
> On Mon, Dec 12, 2016 at 05:09:58PM +0100, Michael Schwendt wrote:
> > On Mon, 12 Dec 2016 15:56:33 +, Zbigniew Jędrzejewski-Szmek wrote:
> >
> > > > 4) Package complies to the Packaging Guidelines: this seems to me lik
On Mon, Dec 12, 2016 at 05:09:58PM +0100, Michael Schwendt wrote:
> On Mon, 12 Dec 2016 15:56:33 +, Zbigniew Jędrzejewski-Szmek wrote:
>
> > > 4) Package complies to the Packaging Guidelines: this seems to me like
> > > a catch all question, it summarizes all other items, doesn't it?
> >
>
On Mon, Dec 12, 2016 at 03:56:33PM +, Zbigniew Jędrzejewski-Szmek wrote:
> > 2) Package does not generate any conflict: do I have to install all
> > Fedora packeges to check this or is there a better way to check that
> > (maybe a query to the package database)?
>
> fedora-review checks this f
On Mon, 12 Dec 2016 15:56:33 +, Zbigniew Jędrzejewski-Szmek wrote:
> > 4) Package complies to the Packaging Guidelines: this seems to me like
> > a catch all question, it summarizes all other items, doesn't it?
>
> Yeah. The checklist in fedora-review requires contains a few strange
> items
On Mon, Dec 12, 2016 at 03:35:36PM +0100, Guido Aulisi wrote:
> Hi,
> I'm trying to complete an unofficial review
> (https://bugzilla.redhat.com/show_bug.cgi?id=1401450) to check my
> review skills :-), and I have some problems filling some MUST items
> which fedora-review leaves blanks.
> The item
2016-12-12 15:50 GMT+01:00 Stephen Gallagher :
>> 3) Package is not known to require an ExcludeArch tag: I think I need
>> a scratch koji build to check this, but it was not done. Can I do a
>> scratch build myself?
>>
>
>
> This is a MAY, not a MUST, I think. It basically means that the package is
Il 12/12/2016 15:50, Stephen Gallagher ha scritto:
1) Sources contain only permissible code or content: this is very hard
to check if source code is big enough; I'm quite sure that it doesn't
contain content, but checking all source code would be a very long
work. Can we rely on the license (GP
Il 12/12/2016 15:35, Guido Aulisi ha scritto:
Hi,
I'm trying to complete an unofficial review
(https://bugzilla.redhat.com/show_bug.cgi?id=1401450) to check my
review skills :-), and I have some problems filling some MUST items
which fedora-review leaves blanks.
The items are:
1) Sources conta
On 12/12/2016 09:35 AM, Guido Aulisi wrote:
> Hi,
> I'm trying to complete an unofficial review
> (https://bugzilla.redhat.com/show_bug.cgi?id=1401450) to check my
> review skills :-), and I have some problems filling some MUST items
> which fedora-review leaves blanks.
> The items are:
>
> 1) Sou
