Re: Review request: selenium-geckodriver

2019-11-20 Thread Jared K. Smith
On Wed, Nov 20, 2019 at 7:18 AM Kevin Kofler wrote: > Unfortunately, I doubt that Thomas has sufficient packaging experience to > do > a review swap. > One of the things we should always strive for in Fedora is to assume positive intent. In this situation, that would mean assuming it was an acc

Re: Review request: selenium-geckodriver

2019-11-20 Thread Kevin Kofler
Luya Tshimbalanga wrote: > I will take your review in exchange of mine below: Unfortunately, I doubt that Thomas has sufficient packaging experience to do a review swap. Packaging binary blobs as he did is a complete no go in Fedora, everything must be built from source. Kevin Kofler __

Re: Review request: selenium-geckodriver

2019-11-19 Thread Luya Tshimbalanga
Hello Thomas, I will take your review in exchange of mine below: https://bugzilla.redhat.com/show_bug.cgi?id=1771173 Would you update yours following the feedback? -- Luya Tshimbalanga Fedora Design Team Fedora Design Suite maintainer ___ devel mail

Re: Review request: selenium-geckodriver

2019-11-17 Thread Leigh Scott
I wouldn't review this as it isn't correct to use prebuilt code, you will need to build from source. Source0: https://github.com/mozilla/geckodriver/releases/download/v0.26.0/geckodriver-v0.26.0-linux64.tar.gz ___ devel mailing list -- devel@list