Re: Fedora-Review 0.2.0

2012-08-09 Thread Stanislav Ochotnicky
Quoting Paul Howarth (2012-08-02 16:46:39) > On 08/02/2012 03:36 PM, Nathanael D. Noblet wrote: > > On 08/02/2012 08:29 AM, Pierre-Yves Chibon wrote: > >> Maybe it would be better formulated as: > >> [!]: MUST: Buildroot MUST NOT be present (NOTE: this is not true for > >> EPEL5) > >> [!]: MUST: Pa

Re: Fedora-Review 0.2.0

2012-08-02 Thread Alec Leamas
On 08/02/2012 06:15 PM, José Matos wrote: On 07/11/2012 06:23 PM, Pierre-Yves Chibon wrote: Dear all, A new fedora-review is being brought to you. For me it fails like this: $ fedora-review -v -n octave-odepkg Exception down the road... Traceback (most recent call last): File "/usr/lib/pyt

Re: Fedora-Review 0.2.0

2012-08-02 Thread José Matos
On 07/11/2012 06:23 PM, Pierre-Yves Chibon wrote: > Dear all, > > A new fedora-review is being brought to you. For me it fails like this: $ fedora-review -v -n octave-odepkg Exception down the road... Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/review_

Re: Fedora-Review 0.2.0

2012-08-02 Thread Paul Howarth
On 08/02/2012 03:36 PM, Nathanael D. Noblet wrote: On 08/02/2012 08:29 AM, Pierre-Yves Chibon wrote: Maybe it would be better formulated as: [!]: MUST: Buildroot MUST NOT be present (NOTE: this is not true for EPEL5) [!]: MUST: Package MUST NOT run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the

Re: Fedora-Review 0.2.0

2012-08-02 Thread Nathanael D. Noblet
On 08/02/2012 08:29 AM, Pierre-Yves Chibon wrote: Maybe it would be better formulated as: [!]: MUST: Buildroot MUST NOT be present (NOTE: this is not true for EPEL5) [!]: MUST: Package MUST NOT run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install What do you think? That wo

Re: Fedora-Review 0.2.0

2012-08-02 Thread Pierre-Yves Chibon
On Thu, 2012-08-02 at 08:23 -0600, Nathanael D. Noblet wrote: > On 08/02/2012 12:02 AM, Mathieu Bridon wrote: > > On Wed, 2012-08-01 at 23:52 -0600, Nathanael D. Noblet wrote: > >> Where would you like bug reports? > >> > >> I tried it against one of my own review tickets. It found a number of > >>

Re: Fedora-Review 0.2.0

2012-08-02 Thread Nathanael D. Noblet
On 08/02/2012 12:02 AM, Mathieu Bridon wrote: On Wed, 2012-08-01 at 23:52 -0600, Nathanael D. Noblet wrote: Where would you like bug reports? I tried it against one of my own review tickets. It found a number of issues however almost all of them except one was wrong. For example it complained

Re: Fedora-Review 0.2.0

2012-08-01 Thread Mathieu Bridon
On Wed, 2012-08-01 at 23:52 -0600, Nathanael D. Noblet wrote: > Where would you like bug reports? > > I tried it against one of my own review tickets. It found a number of > issues however almost all of them except one was wrong. > > For example it complained of no clean section with a rm -rf %{

Re: Fedora-Review 0.2.0

2012-08-01 Thread Nathanael D. Noblet
Where would you like bug reports? I tried it against one of my own review tickets. It found a number of issues however almost all of them except one was wrong. For example it complained of no clean section with a rm -rf %{buildroot} which the specfile contained, same message except in the ins

Re: Fedora-Review 0.2.0

2012-07-19 Thread Alec Leamas
On 07/19/2012 09:22 PM, Pierre-Yves Chibon wrote: On Thu, 2012-07-19 at 13:20 -0600, Nathanael D. Noblet wrote: Thanks Pierre, Unfortunately there is no such file .config/fedora-review there is however a .config/fedora-create-review. I went a little bit too fast, the file is ~/.config/fedora-r

Re: Fedora-Review 0.2.0

2012-07-19 Thread Pierre-Yves Chibon
On Thu, 2012-07-19 at 13:20 -0600, Nathanael D. Noblet wrote: > Thanks Pierre, > > Unfortunately there is no such file .config/fedora-review there is > however a .config/fedora-create-review. I went a little bit too fast, the file is ~/.config/fedora-review/settings Pierre > On 07/19/2012 01

Re: Fedora-Review 0.2.0

2012-07-19 Thread Nathanael D. Noblet
Thanks Pierre, Unfortunately there is no such file .config/fedora-review there is however a .config/fedora-create-review. On 07/19/2012 01:12 PM, Pierre-Yves Chibon wrote: On Thu, 2012-07-19 at 13:14 -0600, Nathanael D. Noblet wrote: Hello, I tried to use fedora-review and it seems to

Re: Fedora-Review 0.2.0

2012-07-19 Thread Pierre-Yves Chibon
On Thu, 2012-07-19 at 13:14 -0600, Nathanael D. Noblet wrote: > Hello, > >I tried to use fedora-review and it seems to attempt building the > package using Fedora 14? > > from root.log > > rootdir = /var/lib/mock/fedora-14-x86_64/root/ > > Is that intentional? A mis-configuration on my par

Re: Fedora-Review 0.2.0

2012-07-19 Thread Nathanael D. Noblet
Hello, I tried to use fedora-review and it seems to attempt building the package using Fedora 14? from root.log rootdir = /var/lib/mock/fedora-14-x86_64/root/ Is that intentional? A mis-configuration on my part? On 07/11/2012 11:23 AM, Pierre-Yves Chibon wrote: Dear all, A new fedora-re