Re: Packaging question about -Wformat-security on Rawhide

2014-02-04 Thread Ralf Corsepius
On 02/04/2014 05:31 AM, Dan Mashal wrote: On Mon, Feb 3, 2014 at 8:16 PM, Michael Catanzaro wrote: On Mon, 2014-02-03 at 19:42 -0700, Orion Poplawski wrote: I'm not sure why the default -Wall is being dropped from that line (it is on other tests). It's explicitly dropped on configure.ac:1265

Re: Packaging question about -Wformat-security on Rawhide

2014-02-03 Thread Dan Mashal
On Mon, Feb 3, 2014 at 8:16 PM, Michael Catanzaro wrote: > On Mon, 2014-02-03 at 19:42 -0700, Orion Poplawski wrote: >> I'm not sure why the default -Wall is being >> dropped from that line (it is on other tests). > > It's explicitly dropped on configure.ac:1265 > > dnl We enable -Wall lat

Re: Packaging question about -Wformat-security on Rawhide

2014-02-03 Thread Michael Catanzaro
On Mon, 2014-02-03 at 19:42 -0700, Orion Poplawski wrote: > I'm not sure why the default -Wall is being > dropped from that line (it is on other tests). It's explicitly dropped on configure.ac:1265 dnl We enable -Wall later. dnl If it's set after the warning CFLAGS in the compiler

Re: Packaging question about -Wformat-security on Rawhide

2014-02-03 Thread Dan Mashal
On Mon, Feb 3, 2014 at 6:42 PM, Orion Poplawski wrote: > The crux is that you need with -Wall or -Wformat as well on the compile > line test for perl.h. I'm not sure why the default -Wall is being > dropped from that line (it is on other tests). You might work around it > by explicitly adding -W

Re: Packaging question about -Wformat-security on Rawhide

2014-02-03 Thread Orion Poplawski
On 02/03/2014 06:52 PM, Dan Mashal wrote: > Hi, > > So when rebuilding pidgin today I had issues building it for rawhide > and on my local machine (F20). > > Basically this flag is causing the configure script to not be able to > locate perl.h > > Looked at https://fedoraproject.org/wiki/Format-

Packaging question about -Wformat-security on Rawhide

2014-02-03 Thread Dan Mashal
Hi, So when rebuilding pidgin today I had issues building it for rawhide and on my local machine (F20). Basically this flag is causing the configure script to not be able to locate perl.h Looked at https://fedoraproject.org/wiki/Format-Security-FAQ but it is very vague and doesn't provide many e