Re: Packaging pgAdmin4

2021-12-21 Thread Demi Marie Obenour
On 12/9/21 10:12 AM, Vitaly Zaitsev via devel wrote: > On 09/12/2021 14:17, Sandro Mani wrote: >> Is this in any way acceptable? > > All packages must be built completely from sources. > >> Is this compatible with > > You must remove all pre-built artifacts and minified sources before > creatin

Re: Packaging pgAdmin4

2021-12-21 Thread Demi Marie Obenour
On 12/18/21 3:04 AM, Andreas Schneider wrote: > On Thursday, 16 December 2021 23:59:23 CET Demi Marie Obenour wrote: >> On 12/10/21 6:56 AM, Sandro Mani wrote: >>> On 10.12.21 01:54, Demi Marie Obenour wrote: On 12/9/21 1:05 PM, Sandro Mani wrote: > On 09.12.21 17:31, Vitaly Zaitsev via de

Re: Packaging pgAdmin4

2021-12-19 Thread Andreas Schneider
On Thursday, 16 December 2021 23:59:23 CET Demi Marie Obenour wrote: > On 12/10/21 6:56 AM, Sandro Mani wrote: > > On 10.12.21 01:54, Demi Marie Obenour wrote: > >> On 12/9/21 1:05 PM, Sandro Mani wrote: > >>> On 09.12.21 17:31, Vitaly Zaitsev via devel wrote: > On 09/12/2021 16:56, Sandro Man

Re: Packaging pgAdmin4

2021-12-16 Thread Demi Marie Obenour
On 12/10/21 6:56 AM, Sandro Mani wrote: > On 10.12.21 01:54, Demi Marie Obenour wrote: >> On 12/9/21 1:05 PM, Sandro Mani wrote: >>> On 09.12.21 17:31, Vitaly Zaitsev via devel wrote: On 09/12/2021 16:56, Sandro Mani wrote: > This does not appear to be accurate for nodejs packages - take i

Re: Packaging pgAdmin4

2021-12-15 Thread Sandro Mani
Hi, if the packages is using yarn, you can simply use its caching mechanism for bundling the needed node modules. You will have an offline cache where you can install the modules from! Example: https://src.fedoraproject.org/rpms/nodejs-bash-language-server Take a look at prepare_vendor.sh whi

Re: Packaging pgAdmin4

2021-12-12 Thread Andreas Schneider
On Thursday, December 9, 2021 6:59:17 PM CET Ben Beasley wrote: > I haven’t looked at pgAdmin4, but I’m the current maintainer of > nodejs-svgo and several other Fedora packages that use the new NodeJS > packaging guidelines. I’m not the original packager for nodejs-svgo, and > I wasn’t the firs

Re: Packaging pgAdmin4

2021-12-10 Thread Sandro Mani
On 10.12.21 22:05, Fabio Valentini wrote: On Fri, Dec 10, 2021 at 12:57 PM Sandro Mani wrote: On 10.12.21 01:54, Demi Marie Obenour wrote: On 12/9/21 1:05 PM, Sandro Mani wrote: On 09.12.21 17:31, Vitaly Zaitsev via devel wrote: On 09/12/2021 16:56, Sandro Mani wrote: This does not appear

Re: Packaging pgAdmin4

2021-12-10 Thread Fabio Valentini
On Fri, Dec 10, 2021 at 12:57 PM Sandro Mani wrote: > > > On 10.12.21 01:54, Demi Marie Obenour wrote: > > On 12/9/21 1:05 PM, Sandro Mani wrote: > >> On 09.12.21 17:31, Vitaly Zaitsev via devel wrote: > >>> On 09/12/2021 16:56, Sandro Mani wrote: > This does not appear to be accurate for nod

Re: Packaging pgAdmin4

2021-12-10 Thread Sandro Mani
On 10.12.21 01:54, Demi Marie Obenour wrote: On 12/9/21 1:05 PM, Sandro Mani wrote: On 09.12.21 17:31, Vitaly Zaitsev via devel wrote: On 09/12/2021 16:56, Sandro Mani wrote: This does not appear to be accurate for nodejs packages - take i.e. node-svgo, which compliant with the guidelines bun

Re: Packaging pgAdmin4

2021-12-09 Thread Demi Marie Obenour
On 12/9/21 1:05 PM, Sandro Mani wrote: > > On 09.12.21 17:31, Vitaly Zaitsev via devel wrote: >> On 09/12/2021 16:56, Sandro Mani wrote: >>> This does not appear to be accurate for nodejs packages - take i.e. >>> node-svgo, which compliant with the guidelines bundles node_modules >>> dir in svgo

Re: Packaging pgAdmin4

2021-12-09 Thread Sandro Mani
On 09.12.21 17:31, Vitaly Zaitsev via devel wrote: On 09/12/2021 16:56, Sandro Mani wrote: This does not appear to be accurate for nodejs packages - take i.e. node-svgo, which compliant with the guidelines bundles node_modules dir in svgo-2.8.0-nm-dev.tgz resp svgo-2.8.0-nm-prod.tgz. You can

Re: Packaging pgAdmin4

2021-12-09 Thread Ben Beasley
I haven’t looked at pgAdmin4, but I’m the current maintainer of nodejs-svgo and several other Fedora packages that use the new NodeJS packaging guidelines. I’m not the original packager for nodejs-svgo, and I wasn’t the first to convert it to the new NodeJS guidelines. I welcome further communi

Re: Packaging pgAdmin4

2021-12-09 Thread Vitaly Zaitsev via devel
On 09/12/2021 16:56, Sandro Mani wrote: This does not appear to be accurate for nodejs packages - take i.e. node-svgo, which compliant with the guidelines bundles node_modules dir in svgo-2.8.0-nm-dev.tgz resp svgo-2.8.0-nm-prod.tgz. You can vendor only sources. No prebuilt assets are allowed

Re: Packaging pgAdmin4

2021-12-09 Thread Sandro Mani
On 09.12.21 16:12, Vitaly Zaitsev via devel wrote: On 09/12/2021 14:17, Sandro Mani wrote: Is this in any way acceptable? All packages must be built completely from sources. This does not appear to be accurate for nodejs packages - take i.e. node-svgo, which compliant with the guidelines bun

Re: Packaging pgAdmin4

2021-12-09 Thread Sandro Mani
fedoraproject.org%3e>> *Subject*: Packaging pgAdmin4 *Date*: Thu, 9 Dec 2021 14:17:41 +0100 Hi I gave it a go at packaging pgadmin4 [1], to replace the current obsolete and abandoned (and crashy) pgadmin3. pgadmin4 is a mix of Python/Flask for serverside and HTML/JS for client side, for w

Re: Packaging pgAdmin4

2021-12-09 Thread Vitaly Zaitsev via devel
On 09/12/2021 14:17, Sandro Mani wrote: Is this in any way acceptable? All packages must be built completely from sources. Is this compatible with You must remove all pre-built artifacts and minified sources before creating a vendored tarball. NW.js must be built from sources. -- Sincer

Re: Packaging pgAdmin4

2021-12-09 Thread graham_alton
: Sandro Mani Reply-To: Development discussions related to Fedora To: Development discussions related to Fedora Subject: Packaging pgAdmin4 Date: Thu, 9 Dec 2021 14:17:41 +0100 Hi I gave it a go at packaging pgadmin4 [1], to replace the current obsolete and abandoned (and crashy) pgadmin3. pgadmin4 i

Packaging pgAdmin4

2021-12-09 Thread Sandro Mani
Hi I gave it a go at packaging pgadmin4 [1], to replace the current obsolete and abandoned (and crashy) pgadmin3. pgadmin4 is a mix of Python/Flask for serverside and HTML/JS for client side, for which I wrote a minimal Qt5WebEngineView wrapper to make it appear like a desktop application