Re: Package Review Request: python-picloud

2012-03-06 Thread Amit Saha
On 03/06/2012 09:07 PM, Paul Howarth wrote: On 03/06/2012 03:11 AM, Vijay N. Majagaonkar wrote: Please, no! %{__cp} hugely decreases readability and if the situation happens that mkdir and cp are not in the $PATH we will have much bigger problems than running sed on all .spec files. I am sorr

Re: Package Review Request: python-picloud

2012-03-06 Thread Paul Howarth
On 03/06/2012 03:11 AM, Vijay N. Majagaonkar wrote: Please, no! %{__cp} hugely decreases readability and if the situation happens that mkdir and cp are not in the $PATH we will have much bigger problems than running sed on all .spec files. I am sorry but this will hit even if you d

Re: Package Review Request: python-picloud

2012-03-05 Thread Vijay N. Majagaonkar
> Please, no! %{__cp} hugely decreases readability and if the situation > happens that mkdir and cp are not in the $PATH we will have much bigger > problems than running sed on all .spec files. I am sorry but this will hit even if you don't use macro when tools are not in $PATH, unless you use fu

Re: Package Review Request: python-picloud

2012-03-05 Thread Matej Cepl
>> mkdir -p >>cp -p ... It will be good if you make use of macro like %{__cp} Please, no! %{__cp} hugely decreases readability and if the situation happens that mkdir and cp are not in the $PATH we will have much bigger problems than running sed on all .spec files. Use just plain Unix com

Re: Package Review Request: python-picloud

2012-03-05 Thread Vijay N. Majagaonkar
I am not reviewer but I think it make sense following things are good to incorporate >># These packages are not require for python >=2.6 but required for python = 2.5 >>Requires: python >= 2.5 I think your Requires: must be python = 2.5 >>%setup -q -n cloud-%version is that version shoul

Package Review Request: python-picloud

2012-03-04 Thread Amit Saha
Hello: Could someone please review my first package: https://bugzilla.redhat.com/show_bug.cgi?id=799810 ? Since, this is my first, I am in need of a sponsor (FAS: amitksaha) Thanks a lot ! -Amit -- http://echorand.me -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproj