Re: Help with rubygem packaging

2019-12-04 Thread Leigh Scott
> For linked-list, > And you see the temp_dir rubygem dep is used for only > spec/archive_spec.rb context "::load" and "#write!". > > ``` > $ grep -r temp_dir spec/ > ``` > > spec/archive_spec.rb > > ``` Thanks that fixes the %check > context "::load" do > ... > end > > context "#write!"

Re: Help with rubygem packaging

2019-12-04 Thread Jun Aruga
For linked-list, > + ruby -Ilib:. -e 'Dir.glob "test/**/test_*.rb", &method(:require)' ... > 0 runs, 0 assertions, 0 failures, 0 errors, 0 skips > + popd "test/**/test_*.rb" you are using is incorrect in this case, and different from the guideline. The test files were not captured.. "./test/**/*_

Re: Help with rubygem packaging

2019-12-04 Thread Vít Ondruch
Dne 04. 12. 19 v 12:28 Vít Ondruch napsal(a): > Dne 03. 12. 19 v 23:43 Leigh Scott napsal(a): >> Thanks, I didn't know about gem2rpm. >> >> Reviews submitted (needed for sassc tests). > > Out of curiosity, where I can find the tests? Answering to myself: https://github.com/sass/sass-spec Vít

Re: Help with rubygem packaging

2019-12-04 Thread Vít Ondruch
Dne 03. 12. 19 v 23:43 Leigh Scott napsal(a): > Thanks, I didn't know about gem2rpm. > > Reviews submitted (needed for sassc tests). Out of curiosity, where I can find the tests? Vít > > https://bugzilla.redhat.com/show_bug.cgi?id=1779403 > https://bugzilla.redhat.com/show_bug.cgi?id=1779404

Re: Help with rubygem packaging

2019-12-03 Thread Leigh Scott
Thank you for the examples and hints > 2. Adding %check section, as Jaroslav said. > Note that we do not use "bundler" ("bundle" command) and > "rake" > command in RPM *.spec file. > I have removed bundler and rake from linked-list, the test doesn't seem to run anything + pushd ./usr/share/gem

Re: Help with rubygem packaging

2019-12-03 Thread Jun Aruga
> https://bugzilla.redhat.com/show_bug.cgi?id=1779403 > https://bugzilla.redhat.com/show_bug.cgi?id=1779404 I checked your uploaded *.spec files now a little bit. I see that you are using "rake" in your rubygem-linked-list.spec, and there is no %check section in your rubygem-hrx.spec. > Note that

Re: Help with rubygem packaging

2019-12-03 Thread Jun Aruga
Hi Leigh, Thank you for contributing the rubygem-* packages. Let me comment for your *.spec files. I recommend to compare the *.spec file generated by gem2rpm with your *.spec file, and align basically. The gem2rpm guides you. How to do it (For example in case of Fedora 30) ``` $ sudo dnf insta

Re: Help with rubygem packaging

2019-12-03 Thread Leigh Scott
Thanks, I didn't know about gem2rpm. Reviews submitted (needed for sassc tests). https://bugzilla.redhat.com/show_bug.cgi?id=1779403 https://bugzilla.redhat.com/show_bug.cgi?id=1779404 ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscri

Re: Help with rubygem packaging

2019-12-03 Thread Jaroslav Prokop
Hi, great to see someone taking up on some rubygems! to the packages, the rubygem-linked-list as mentioned by Fabio have binaries that will probably have name conflicts with some other packages. Secondly rubygem-hrx should not have `Requires: rubygem(linked-list)`[0] because that dependency

Re: Help with rubygem packaging

2019-12-03 Thread Fabio Valentini
On Tue, Dec 3, 2019 at 7:08 PM Leigh Scott wrote: > > Hi, > > Can someone check these specfiles before I submit review requests please? > I have zero experience with packaging rubygem packaes. > > https://leigh123linux.fedorapeople.org/pub/SPECS/rubygem-hrx.spec > https://leigh123linux.fedorapeop

Help with rubygem packaging

2019-12-03 Thread Leigh Scott
Hi, Can someone check these specfiles before I submit review requests please? I have zero experience with packaging rubygem packaes. https://leigh123linux.fedorapeople.org/pub/SPECS/rubygem-hrx.spec https://leigh123linux.fedorapeople.org/pub/SPECS/rubygem-linked-list.spec Best regards Leigh ___