Re: Debugging fun (wrt C modernization change)

On 5/17/24 22:42, Owen Taylor wrote: On Tue, May 14, 2024 at 6:50 AM Panu Matilainen > wrote: Patch and source numbers start from zero, that goes for automatically numbered patches too. So there's an off by one in the application, and the latter %autop

Re: Debugging fun (wrt C modernization change)

On Tue, May 14, 2024 at 6:50 AM Panu Matilainen wrote: > > Patch and source numbers start from zero, that goes for automatically > numbered patches too. So there's an off by one in the application, and > the latter %autopatch which is supposed to apply patches >= 2 simply has > nothing to do, and

Re: Debugging fun (wrt C modernization change)

On Fri, 2024-05-17 at 10:32 +0200, Michael J Gruber wrote: > Kevin Kofler via devel venit, vidit, dixit 2024-05-16 22:39:00: > > Panu Matilainen wrote: > > > Patch and source numbers start from zero, that goes for automatically > > > numbered patches too. So there's an off by one in the application

Re: Debugging fun (wrt C modernization change)

On 5/17/24 15:53, Kevin Kofler via devel wrote: Michael J Gruber wrote: %patchlist and %auto* should just go away, or at least banned from Fedora by a git hook rejecting such specfiles. We also have unnumbered patch source definition lines, don't we? IIRC, unnumbered Source: or Patch: just d

Re: Debugging fun (wrt C modernization change)

Michael J Gruber wrote: >> %patchlist and %auto* should just go away, or at least banned from Fedora >> by a git hook rejecting such specfiles. > > We also have unnumbered patch source definition lines, don't we? IIRC, unnumbered Source: or Patch: just defaults to Source0: resp. Patch0:. But it

Re: Debugging fun (wrt C modernization change)

On 5/17/24 11:32, Michael J Gruber wrote: Kevin Kofler via devel venit, vidit, dixit 2024-05-16 22:39:00: Panu Matilainen wrote: Patch and source numbers start from zero, that goes for automatically numbered patches too. So there's an off by one in the application, and the latter %autopatch whi

Re: Debugging fun (wrt C modernization change)

Kevin Kofler via devel venit, vidit, dixit 2024-05-16 22:39:00: > Panu Matilainen wrote: > > Patch and source numbers start from zero, that goes for automatically > > numbered patches too. So there's an off by one in the application, and > > the latter %autopatch which is supposed to apply patches

Re: Debugging fun (wrt C modernization change)

Panu Matilainen wrote: > Patch and source numbers start from zero, that goes for automatically > numbered patches too. So there's an off by one in the application, and > the latter %autopatch which is supposed to apply patches >= 2 simply has > nothing to do, and falls through silently. That's a bu

Debugging fun (wrt C modernization change)

Yesterday, we ran into an issue where some of rpm upstream testcases are suddenly failing on one system. The difference to everybody elses working tests turned out to be Fedora 40, and was easily reproduced elsewhere on F40 then. On a closer look, the failing tests were all complaining about