Re: Change to linker flags injection (#1548397)

2018-02-24 Thread Florian Weimer
This should now be complete in Fedora 28 and rawhide. Note that, as an intentional side effect, libtool will no longer drop the -Wl,0z,now flag in many cases. This could issues for a few packages which depended on the (arguably broken) old libtool behavior. I added some notes to https://src

Re: Change to linker flags injection (#1548397)

2018-02-24 Thread Florian Weimer
On 02/24/2018 07:13 PM, Philip Kovacs wrote: A scratch build won't find bind now errors as they are discovered at run time when the dlopen occurs. I have been using:%define _hardened_ldflags "-Wl,-z,lazy"to allow the compile-time hardening, stack protection, etc to remain but filter out the -z

Re: Change to linker flags injection (#1548397)

2018-02-24 Thread Philip Kovacs
A scratch build won't find bind now errors as they are discovered at run time when the dlopen occurs. I have been using:%define _hardened_ldflags "-Wl,-z,lazy"to allow the compile-time hardening, stack protection, etc to remain but filter out the -z now linker flag.I assume this won't work anymo

Re: Change to linker flags injection (#1548397)

2018-02-24 Thread Florian Weimer
On 02/24/2018 06:32 PM, Jerry James wrote: On Sat, Feb 24, 2018 at 10:24 AM, Florian Weimer wrote: We currently inject “-z now” hidden behind a -specs= option for the gcc compiler driver. libtool drops this -specs= option from the linker command line, but it preserves -Wl,-z,relro, so I'm tryi

Re: Change to linker flags injection (#1548397)

2018-02-24 Thread Jerry James
On Sat, Feb 24, 2018 at 10:24 AM, Florian Weimer wrote: > We currently inject “-z now” hidden behind a -specs= option for the gcc > compiler driver. libtool drops this -specs= option from the linker command > line, but it preserves -Wl,-z,relro, so I'm trying whether listing > -Wl,-z,now directly

Change to linker flags injection (#1548397)

2018-02-24 Thread Florian Weimer
We currently inject “-z now” hidden behind a -specs= option for the gcc compiler driver. libtool drops this -specs= option from the linker command line, but it preserves -Wl,-z,relro, so I'm trying whether listing -Wl,-z,now directly improves the linker flag injection here. I'm doing this in