Re: Build flag injection for qmake

2018-01-25 Thread Florian Weimer
On 01/24/2018 11:18 PM, Rex Dieter wrote: It should capture all of CFLAGS, CXXFLAGS, LDFLAGS , see https://src.fedoraproject.org/rpms/qt5/blob/master/f/macros.qt5 where it pulls from %{optflags} and %{?__global_ldflags} as appropriate Ahh—it's conditional whether CFLAGS etc. have been set. If

Re: Build flag injection for qmake

2018-01-25 Thread Rex Dieter
Kevin Kofler wrote: > Rex Dieter wrote: >> It should capture all of CFLAGS, CXXFLAGS, LDFLAGS , see >> https://src.fedoraproject.org/rpms/qt5/blob/master/f/macros.qt5 >> where it pulls from %{optflags} and %{?__global_ldflags} as appropriate > > It will capture CFLAGS, CXXFLAGS, LDFLAGS from the

Re: Build flag injection for qmake

2018-01-25 Thread Kevin Kofler
Rex Dieter wrote: > It should capture all of CFLAGS, CXXFLAGS, LDFLAGS , see > https://src.fedoraproject.org/rpms/qt5/blob/master/f/macros.qt5 > where it pulls from %{optflags} and %{?__global_ldflags} as appropriate It will capture CFLAGS, CXXFLAGS, LDFLAGS from the environment, but it will not

Re: Build flag injection for qmake

2018-01-24 Thread Rex Dieter
Florian Weimer wrote: >> * Adapt packages to use the wrapper. this can take the form of explicitly >> setting QMAKE (or equivalent), adjusting PATH to prefer the qt5 wrapper >> dir, or patching, or some combination of the above. >> >> In the specific case of pcp, it supports QMAKE, so it's a one

Re: Build flag injection for qmake

2018-01-24 Thread Rex Dieter
Florian Weimer wrote: > On 01/24/2018 10:05 PM, Rex Dieter wrote: >> Rex Dieter wrote: >> >>> Florian Weimer wrote: >> >> Oh, *indirectly* calls qmake, that may be trickier. Which package? >> pcp: https://bugzilla.redhat.com/show_bug.cgi?id=1538187 >>> ... I don't want to copy th

Re: Build flag injection for qmake

2018-01-24 Thread Florian Weimer
On 01/24/2018 10:05 PM, Rex Dieter wrote: Rex Dieter wrote: Florian Weimer wrote: Oh, *indirectly* calls qmake, that may be trickier. Which package? pcp: https://bugzilla.redhat.com/show_bug.cgi?id=1538187 ... I don't want to copy this solution in the dozen or so packages which need th

Re: Build flag injection for qmake

2018-01-24 Thread Rex Dieter
Rex Dieter wrote: > Florian Weimer wrote: Oh, *indirectly* calls qmake, that may be trickier. Which package? >> pcp: https://bugzilla.redhat.com/show_bug.cgi?id=1538187 > ... >> I don't want to copy this solution in the dozen or so packages which >> need this (and I probably would have mis

Re: Build flag injection for qmake

2018-01-24 Thread Rex Dieter
Florian Weimer wrote: > On 01/24/2018 07:18 PM, Rex Dieter wrote: >> Rex Dieter wrote: >> >>> Rex Dieter wrote: >>> Florian Weimer wrote: > I have a package which indirectly calls qmake (from Qt5). Is there a > way to inject the standard build flags using environment variables,

Re: Build flag injection for qmake

2018-01-24 Thread Florian Weimer
On 01/24/2018 07:18 PM, Rex Dieter wrote: Rex Dieter wrote: Rex Dieter wrote: Florian Weimer wrote: I have a package which indirectly calls qmake (from Qt5). Is there a way to inject the standard build flags using environment variables, or do I have to patch the invocation of the qmake com

Re: Build flag injection for qmake

2018-01-24 Thread Rex Dieter
Rex Dieter wrote: > Rex Dieter wrote: > >> Florian Weimer wrote: >> >>> I have a package which indirectly calls qmake (from Qt5). Is there a >>> way to inject the standard build flags using environment variables, or >>> do I have to patch the invocation of the qmake command itself to pass >>> t

Re: Build flag injection for qmake

2018-01-24 Thread Rex Dieter
Rex Dieter wrote: > Florian Weimer wrote: > >> I have a package which indirectly calls qmake (from Qt5). Is there a >> way to inject the standard build flags using environment variables, or >> do I have to patch the invocation of the qmake command itself to pass >> the flags, similar to what %{q

Re: Build flag injection for qmake

2018-01-24 Thread Rex Dieter
Florian Weimer wrote: > I have a package which indirectly calls qmake (from Qt5). Is there a > way to inject the standard build flags using environment variables, or > do I have to patch the invocation of the qmake command itself to pass > the flags, similar to what %{qmake_qt5} does? %{qmake_qt

Build flag injection for qmake

2018-01-24 Thread Florian Weimer
I have a package which indirectly calls qmake (from Qt5). Is there a way to inject the standard build flags using environment variables, or do I have to patch the invocation of the qmake command itself to pass the flags, similar to what %{qmake_qt5} does? Would it make to add rpmbuild-qmake o