Re: [389-devel] Please review lib389 ticket 47568: Rename DSAdmin class (2nd)

2013-10-25 Thread thierry bordaz
On 10/25/2013 11:38 AM, Roberto Polli wrote: On Friday 25 October 2013 11:18:53 thierry bordaz wrote: lib389/brooker.py:795: python variable naming convention: I would get stick with the "_" instead of camelCase and change whenever possible. If you prefer to use '_' also for local variable, I

Re: [389-devel] Please review lib389 ticket 47568: Rename DSAdmin class (2nd)

2013-10-25 Thread Roberto Polli
My comments (a github like platform for comment could be really useful) > https://fedorahosted.org/389/attachment/ticket/47568/0002-Ticket-47568-Renam > e-DSAdmin-class.patch line: comment lib389/__init__.py:1: the module is lib389, not dirsrv lib389/brooker.py:795: python variable naming convent

[389-devel] Please review lib389 ticket 47568: Rename DSAdmin class

2013-10-23 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/47568/0001-Ticket-47568-Rename-DSAdmin-class.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel