Re: [389-devel] Please review: Allow modrdn to move subtree and rename non-leaf node

2010-01-19 Thread Nathan Kinder
On 01/19/2010 01:50 PM, Rich Megginson wrote: > Noriko Hosoi wrote: > >> Allow modrdn to move subtree and rename non-leaf node >> >> This patch includes >> - replacing the entrydn index with the entryrdn index >> - replacing a full DN in each entry in the DB with an RDN >>

Re: [389-devel] Please review: Allow modrdn to move subtree and rename non-leaf node

2010-01-19 Thread Rich Megginson
Noriko Hosoi wrote: > Allow modrdn to move subtree and rename non-leaf node > > This patch includes > - replacing the entrydn index with the entryrdn index > - replacing a full DN in each entry in the DB with an RDN > - extending Slapi_Entry, entry2str, and str2entry to absorb the

Re: [389-devel] Please review: Allow modrdn to move subtree and rename non-leaf node

2010-01-18 Thread Andrey Ivanov
>> I ran the test suite that covers these functionalities.  So far, I haven't >> seen any breakage.  But I might be missing something important, so your >> reviews would be greatly appreciated. > > I'm pretty sure the referential integrity plug-in will not work for > modrdn operations with a new su

Re: [389-devel] Please review: Allow modrdn to move subtree and rename non-leaf node

2010-01-15 Thread Howard Chu
389-devel-requ...@lists.fedoraproject.org wrote: > Date: Thu, 14 Jan 2010 16:45:32 +0100 > From: Andrey Ivanov > Here are some questions or remarks that i still do have after this reading: > Citation: > --- > This function entryrdn_index_read finds out the entry_id of the given >

Re: [389-devel] Please review: Allow modrdn to move subtree and rename non-leaf node

2010-01-14 Thread Andrey Ivanov
Hi Noriko, >  Allow modrdn to move subtree and rename non-leaf node > >    This patch includes > ... I've read your design and implementation guide. It is very detailed and discusses a lot of questions in a rather comprehensive way. A lot of uncertainties i had in the beginning of the document we

[389-devel] Please review: Allow modrdn to move subtree and rename non-leaf node

2010-01-12 Thread Noriko Hosoi
Allow modrdn to move subtree and rename non-leaf node This patch includes - replacing the entrydn index with the entryrdn index - replacing a full DN in each entry in the DB with an RDN - extending Slapi_Entry, entry2str, and str2entry to absorb the changes made on the entry