Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Gregory Maxwell
On Fri, Nov 18, 2011 at 11:27 PM, Ralf Corsepius wrote: > [1] -Wstrict-aliasing is one of these cases. > The spots such warnings point to, often are broken, but not always, > because GCC has difficulties in identifying these. This use to be more true, but there are multiple levels of -Wstrict-ali

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Ralf Corsepius
On 11/19/2011 04:57 AM, Xose Vazquez Perez wrote: > Kevin Kofler wrote: > >> Indeed, -Wall is not really all. :-) -Wall -Wextra is closer to all, but >> there are still some things those won't warn about, e.g. -Wwrite-strings >> catches places which use a string literal as a potentially writable ch

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Xose Vazquez Perez
Kevin Kofler wrote: > Indeed, -Wall is not really all. :-) -Wall -Wextra is closer to all, but > there are still some things those won't warn about, e.g. -Wwrite-strings > catches places which use a string literal as a potentially writable char * > instead of a const char *. -O2 is required by

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Kevin Kofler
Paul Howarth wrote: > Hmm, thanks for that. I naively assumed that -Wall was "all warnings"! > I'll look into those. Indeed, -Wall is not really all. :-) -Wall -Wextra is closer to all, but there are still some things those won't warn about, e.g. -Wwrite-strings catches places which use a string

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Tom Lane
Andrew Haley writes: > On 11/18/2011 05:53 PM, Ralf Corsepius wrote: >> pptp.c:459:33: warning: dereferencing type-punned pointer might break >> strict-aliasing rules [-Wstrict-aliasing] > Bingo! Bugs like this must be fixed. Sometimes that's easier said than done. -fno-strict-aliasing might

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Andrew Haley
On 11/18/2011 05:53 PM, Ralf Corsepius wrote: > pptp.c:459:33: warning: dereferencing type-punned pointer might break > strict-aliasing rules [-Wstrict-aliasing] Bingo! Bugs like this must be fixed. Andrew. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/ma

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Paul Howarth
On Fri, 18 Nov 2011 18:53:03 +0100 Ralf Corsepius wrote: > On 11/18/2011 05:32 PM, Paul Howarth wrote: > > On Fri, 18 Nov 2011 15:28:27 + > > Andrew Haley wrote: > > > >> On 11/18/2011 11:31 AM, Paul Howarth wrote: > >>> One of my packages, pptp, suffers occasional segfaults as reported > >>

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Paul Howarth
On Fri, 18 Nov 2011 18:43:30 +0200 Jussi Lehtola wrote: > On Fri, 18 Nov 2011 16:32:23 + > Paul Howarth wrote: > > On Fri, 18 Nov 2011 15:28:27 + > > Andrew Haley wrote: > > > > > On 11/18/2011 11:31 AM, Paul Howarth wrote: > > > > One of my packages, pptp, suffers occasional segfaults

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Ralf Corsepius
On 11/18/2011 05:32 PM, Paul Howarth wrote: > On Fri, 18 Nov 2011 15:28:27 + > Andrew Haley wrote: > >> On 11/18/2011 11:31 AM, Paul Howarth wrote: >>> One of my packages, pptp, suffers occasional segfaults as reported >>> in http://bugzilla.redhat.com/749455. However, whilst investigating >>>

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Jussi Lehtola
On Fri, 18 Nov 2011 16:32:23 + Paul Howarth wrote: > On Fri, 18 Nov 2011 15:28:27 + > Andrew Haley wrote: > > > On 11/18/2011 11:31 AM, Paul Howarth wrote: > > > One of my packages, pptp, suffers occasional segfaults as reported > > > in http://bugzilla.redhat.com/749455. However, whilst

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Paul Howarth
On Fri, 18 Nov 2011 15:28:27 + Andrew Haley wrote: > On 11/18/2011 11:31 AM, Paul Howarth wrote: > > One of my packages, pptp, suffers occasional segfaults as reported > > in http://bugzilla.redhat.com/749455. However, whilst investigating > > this, it seems to be the case that simply rebuild

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Gregory Maxwell
On Fri, Nov 18, 2011 at 6:31 AM, Paul Howarth wrote: > 2. How to determine what the actual problem is, e.g. a problem with the > way the code is written leading to unsafe optimizations, or a gcc bug? [Obviously Andrew's look at warnings advice is good but also…] See if you can reproduce it when

Re: Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Andrew Haley
On 11/18/2011 11:31 AM, Paul Howarth wrote: > One of my packages, pptp, suffers occasional segfaults as reported in > http://bugzilla.redhat.com/749455. However, whilst investigating this, > it seems to be the case that simply rebuilding the package using no > optimization (-O0) as opposed to the d

Twisted 11.1.0 about to hit rawhide

2011-11-18 Thread Julian Sikorski
Hi, I have just kicked off a build of twisted 11.1.0. Please check if everything still works as expected. Should that not be the case, there is plenty of time until Fedora 17 release to iron things out. Regards, Julian -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproj

rawhide report: 20111118 changes

2011-11-18 Thread Rawhide Report
Compose started at Fri Nov 18 08:16:27 UTC 2011 Broken deps for x86_64 -- OpenGTL-0.9.15.1-3.fc17.x86_64 requires libLLVM-2.9.so()(64bit) OpenGTL-devel-0.9.15.1-3.fc17.i686 requires libLLVM-2.9.so OpenGTL-devel-0.9.15.

Package segfaults when built with -O2 but not with -O0

2011-11-18 Thread Paul Howarth
One of my packages, pptp, suffers occasional segfaults as reported in http://bugzilla.redhat.com/749455. However, whilst investigating this, it seems to be the case that simply rebuilding the package using no optimization (-O0) as opposed to the default -O2 is enough to stop this happening. This r