Main Changes :
1.Remove redundant memory init.
Wenyi Xie (1):
CryptoPkg/BaseCryptLib:Remove redundant init
CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 --
1 file changed, 2 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all message
CertCtx is used to be defined as a struct and ZeroMem is called to
init this struct. But now CertCtx is defined as a point, so use
ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenyi Xie
---
CryptoPk
Main Changes :
1.Adding a new function to calculate time stamp.
Wenyi Xie (1):
NetworkPkg/Dhcp6Dxe:Generate real time stamp
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 71 +---
1 file changed, 63 insertions(+), 8 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
The stamp used to be generated is assumed 30day/month. Now adding a
new function which calculates time stamp with the correct days.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Wenyi Xie
---
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 71 +---
1 file changed, 63 inser
Main Changes :
1.Adding null point check before pointer is dereferenced.
Wenyi Xie (1):
MdePkg/UefiDevicePathLib:Add NULL point check
MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 240
1 file changed, 240 insertions(+)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4060
Function CreateDeviceNode may return NULL point when NodeLength is
smaller than a device path header or there is not enough
memory to allocate. But after calling CreateDeviceNode, the
pointer is dereferenced without checking its value.
So is
Main Changes :
1.Adding a new PCD to control ternimal.
Wenyi Xie (1):
MdeModulePkg/TerminalDxe:Adding a switch for Terminal
MdeModulePkg/MdeModulePkg.dec | 4
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
MdeModulePkg/Universal/Console/Term
Adding a new PCD as switch to control Trlminal.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeModulePkg/MdeModulePkg.dec | 4
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
MdeModulePkg/Universal
gt;> From: devel@edk2.groups.io On Behalf Of wenyi,xie via
>> groups.io
>> Sent: Tuesday, October 11, 2022 4:13 AM
>> To: devel@edk2.groups.io; Wang, Jian J ; Gao, Liming
>> ; Gao, Zhichao
>> ; Ni, Ray
>> Cc: songdongku...@huawei.com; xiewen...@huawe
Main Changes:
1.check offset inbetween VirtualAddress and VirtualAddress + Size.
2.Using SafeintLib to do offset addition with result check.
Code can also be found in github:
https://github.com/leadsama/edk2.git
branch: bug-2215-v1
Wenyi Xie (1):
SecurityPkg/DxeImageVerificationLib:Enhanced ver
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2215
There is an integer overflow vulnerability in DxeImageVerificationHandler
function when parsing the PE files attribute certificate table. In cases
where WinCertificate->dwLength is sufficiently large, it's possible to
overflow Offset back to
Main Changes since v1 :
1.add flag IsAuthDataAssigned
2.check IsAuthDataAssigned and result of HashPeImageByType, if either is false,
then skip signature verification and step to next loop
cover letter of the v1 :
https://edk2.groups.io/g/devel/message/64059
Wenyi Xie (1):
SecurityPkg/DxeImag
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2215
There is an integer overflow vulnerability in DxeImageVerificationHandler
function when parsing the PE files attribute certificate table. In cases
where WinCertificate->dwLength is sufficiently large, it's possible to
overflow Offset back to
On 2020/8/12 20:23, Laszlo Ersek wrote:
> On 08/12/20 09:04, wenyi,xie via groups.io wrote:
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2215
>>
>> There is an integer overflow vulnerability in DxeImageVerificationHandler
>> function when parsing the PE
To Laszlo,
Thank you for your detailed description, I agree with what you analyzed and I'm
OK with your patches, it's
correct and much simpler.
To Jiewen,
Sorry, I don't have environment to reproduce the issue.
Thanks
Wenyi
On 2020/8/14 2:50, Laszlo Ersek wrote:
> On 08/13/20 13:55, Wenyi Xie w
en
>
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of wenyi,xie
>> via groups.io
>> Sent: Friday, August 14, 2020 3:54 PM
>> To: Laszlo Ersek ; devel@edk2.groups.io; Yao, Jiewen
>> ; Wang, Jian J
>> Cc: huangm
- the problem statement is unclear,
>>>>
>>>> - it seems like there is indeed an integer overflow problem in the
>>>> SecDataDir parsing loop, but it's uncertain whether the bug reporter
>>>> had exactly that in mind
>>>>
>>&
te a case that bypass all checks in PeCoffLib, then
> run into DxeImageVerificationLib and cause the problem? That would be more
> valuable for us.
>
> Thank you
> Yao Jiewen
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of wenyi,xie
>>
attack.
>
> I am not asking you to exploit the system. Attack here just means: to cause
> system hang or buffer overflow. That is enough.
> But you cannot modify code to remove any existing checker.
>
> Thank you
> Yao Jiewen
>
>> -Original Message-
>&
Main Changes :
1.add support for PEM-encoded certificate.
Wenyi Xie (1):
CryptoPkg/BaseCryptLib: Support PEM certification
CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 33 ++--
1 file changed, 31 insertions(+), 2 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
As PEM-encoded certificate is also necessary, add
support for PEM-encoded certificate in
X509ConstructCertificate.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Jiaxia Xu
Signed-off-by: Wenyi Xie
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 33 +
SmmBootRecordDataSize is initialized in InternalGetSmmPerData,
but this function may fail. so to avoid using SmmBootRecordDataSize
without intialization, set it to 0 at first.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Library/DxeCorePerformanceLib/
Main Changes :
1.Initiallize SmmBootRecordDataSize to 0.
Wenyi Xie (1):
MdeModulePkg/DxeCorePerformanceLib:Variable Initial
MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++
1 file changed, 2 insertions(+)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Link
Add unit test for FrameBufferBltLib.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Test/MdeModulePkgHostTest.dsc
| 5 +
MdeModulePkg/Library/FrameBufferBltLib/UnitTest/FrameBufferBltLibUnitTest.inf
|
Main Changes :
1.Add unit test for function FrameBufferBltConfigure.
Wenyi Xie (1):
MdeModulePkg/FrameBufferBltLib:Add unit test
MdeModulePkg/Test/MdeModulePkgHostTest.dsc
| 5 +
MdeModulePkg/Library/FrameBufferBltLib/UnitTest/FrameBufferBltLibUnitTest.inf
On 2021/12/18 0:39, Sami Mujawar wrote:
> Hi Ard,
>
>
> On 17/12/2021, 16:34, "Ard Biesheuvel" wrote:
>
> On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote:
> >
> > Hi Leif, Ard, Wenyi,
> >
> > Is it possible to review and provde feedback for this change, please?
> >
Reference:https://bugzilla.tianocore.org/show_bug.cgi?id=3804
When calculating SR-IOV reserve bus in function CreatePciIoDevice(),
there are two points may have problem.
LastVF = PFRid + FirstVFOffset + (PciIoDevice->InitialVFs - 1) * VFStride;
PciIoDevice->ReservedBusNum =
(UINT16)(EFI_PCI_BUS_OF
Main Changes :
1.Add check before using InitialVFs.
2.Don't allocate bus for VF.
Wenyi Xie (1):
MdeModulePkg/PciBucDxe:Fix issue when initial SR-IVO
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.20.1.windows.1
-=-=-=-=
Main Changes :
1.Remove redundant if statement.
Wenyi Xie (1):
RedfishPkg/RedfishRestExDxe:Simplify status check
RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +---
1 file changed, 17 insertions(+), 21 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.
Remove redundant determine statements.
No functional change.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Wenyi Xie
---
RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +---
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/RedfishPkg/RedfishRestExDxe/Redfi
On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> May I know what is the problem you encountered and what environment causes
> the issue? Is that under edk2 emulation or the real Redfish service?
>
Hi Abner,
I didn't encounter any issue and there's no functional cha
On 2022/1/20 10:30, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> Could you please create PR for this change? So we can have core CI on this
> patch and I can also merge this patch later when the core CI is finished
> successfully.
> Just send me the link to PR once you create it.
To keep the declaration same with definition, remove the last optional
in declaration of WakeUpAP.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Wenyi Xie
---
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/
Main Changes :
1.Remove suffix optional in declaration of WakeUpAP to keep declaration same
with definition.
Wenyi Xie (1):
UefiCpuPkg/MpInitLib:remove optional in declaration
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
-
Main Changes :
1.free the allocated memory when function collectionEvalOp return.
2.optimeze the code, no functional change.
Wenyi Xie (1):
RedfishPkg: fix memory leak issue
RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c | 16
+++-
1 file changed, 7 insertions(+
The calloc memory is not free when function collectionEvalOp
return in the halfway.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Wenyi Xie
---
RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c | 16
+++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Hi Abner,
Thank you for your reviewing, here is the link to the PR.
https://github.com/tianocore/edk2/pull/2612
Regards
Wenyi
On 2022/3/11 15:03, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> Please add my RB in the commit message and create the PR against edk2, let me
> know the l
Fix header files on #ifdef.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Wenyi Xie
---
ArmPlatformPkg/Drivers/NorFlashDxe/NorFlash.h | 6 +++---
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h | 6 +++---
ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP8
Main Changes :
1.fix the ifdef variable.
Wenyi Xie (1):
ArmPlatformPkg: Fix ECC issues
ArmPlatformPkg/Drivers/NorFlashDxe/NorFlash.h | 6 +++---
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h | 6 +++---
ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchd
y: Sami Mujawar
>
> Regards,
>
> Sami Mujawar
>
> On 14/03/2022, 09:26, "devel@edk2.groups.io on behalf of wenyi,xie via
> groups.io"
> wrote:
>
> Fix header files on #ifdef.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
>
> Signed-
Main Changes :
1.support decimal type version number when running ecc check.
Wenyi Xie (1):
BaseTools:Support decimal version number in ECC check
BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaFileParser.py | 18
+++---
1 file changed, 15 insertions(+), 3 deletions(-)
--
2.20
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3872
When doing ecc inf version check, the decimal type version number
like 1.27 is treated as invalid version.
So the code should be updated to support decimal type version number.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: Wen
Main Changes :
remove redundant sizeof.
Wenyi Xie (1):
SecurityPkg/FvReportPei: remove redundant sizeof
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=
In function InstallPreHashFvPpi, when calculatuing the size
of struct HASH_INFO，sizeof is used twice.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Laszlo Ersek
Signed-off-by: Wenyi Xie
---
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
1 file chan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=
In function InstallPreHashFvPpi, when calculating the size
of struct HASH_INFO，sizeof is used twice. This bug does
not lead to buffer overflow, "sizeof (HASH_INFO)" is 4,
whereas "sizeof (sizeof (HASH_INFO))" is 4 or 8.
Cc: Jiewen Yao
Cc: J
Main Changes since v1 :
Change commit message.
Wenyi Xie (1):
SecurityPkg/FvReportPei: remove redundant sizeof
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
Main Changes :
Remove dead code.
Wenyi Xie (1):
MdeModulePkg/HiiDatabaseDxe: remove dead code
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
1 file changed, 3 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this gr
Outer condition is 'BlockData->Name==NULL' and inner
condition is 'BlockData->Name!=NULL', Opposite 'if'
condition leads to a dead code block.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
From: "wenyi.xie"
Main Changes :
Change default value of PcdSrIovSystemPageSize to 0x10.
wenyi.xie (1):
MdeModulePkg: Modify PCD default value
MdeModulePkg/MdeModulePkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
From: "wenyi.xie"
The default value of PcdSrIovSystemPageSize is 0x1, it means
the memory BAR is 4KB alignment. When page size of OS is set
to 64KB, as the resource partitions are different between OS
and BIOS, it will cause pcie failture. And if 52 bit physical
address need to be supported, page
Main Changes :
Adding unit test for UefiSortLib.
Wenyi Xie (1):
MdeModulePkg/UefiSortLib:Add UefiSortLib unit test
MdeModulePkg/Test/MdeModulePkgHostTest.dsc| 6 +
MdeModulePkg/Library/UefiSortLib/UnitTest/UefiSortLibUnitTest.inf | 32
MdeModulePkg/Library/UefiS
Adding unit test for UefiSortLib.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Test/MdeModulePkgHostTest.dsc| 6 +
MdeModulePkg/Library/UefiSortLib/UnitTest/UefiSortLibUnitTest.inf | 32
MdeModulePkg/Library/UefiSortLib/UnitTest/UefiSor
Main Changes since v1 :
Change commit message.
Wenyi Xie (1):
SecurityPkg/FvReportPei: remove redundant sizeof
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=
In function InstallPreHashFvPpi, when calculating the size
of struct HASH_INFO，sizeof is used twice. This bug does
not lead to buffer overflow, "sizeof (HASH_INFO)" is 4,
whereas "sizeof (sizeof (HASH_INFO))" is 4 or 8.
Cc: Jiewen Yao
Cc: J
Execuse me, I made a mistake and sent the wrong patch. Please ignore it.
Thanks
Wenyi
On 2021/7/29 15:45, Wenyi Xie wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=
>
> In function InstallPreHashFvPpi, when calculating the size
> of struct HASH_INFO，sizeof is used twice. This bug
Main Changes since v1 :
1.add brief summary in commit message
2.change the copyright in UefiSortLibUnitTest.inf
3.refine the indent in UnitTestingEntry
Wenyi Xie (1):
MdeModulePkg/UefiSortLib:Add UefiSortLib unit test
MdeModulePkg/Test/MdeModulePkgHostTest.dsc| 6 +
M
Adding two unit test case for UefiSortLib. One is a test on
sorting an array of UINT32 by using PerformQuickSort, another
is a test on comparing the same buffer by using StringCompare.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Test/MdeModulePkgHostTest.dsc
Hi, Wu Hao
Thank you for your reviewing.
I have create the v2 patch according to your comments.
Thanks
Wenyi
On 2021/7/29 13:42, Wu, Hao A wrote:
> Thanks for the patch.
> Some inline comments below:
>
>
>> -Original Message-
>> From: Wenyi Xie
>> Sent: Wednesday, July 28, 2021 1:58 P
On 2021/8/2 9:56, Wu, Hao A wrote:
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Wu, Hao
>> A
>> Sent: Thursday, July 29, 2021 4:26 PM
>> To: Wenyi Xie ; devel@edk2.groups.io; Wang, Jian
>> J
>> Cc: songdongku...@huawei.com
>> Subject: Re: [edk2-devel] [PATCH EDK2 v2
EDK2 has removed header file ArmLibPrivate.h, so need to
use ArmLib.h instead. A new file OemMiscLib.h is added
to EDK2, its name is same with the header file in
Hisilicon\Include and it will being included first. So
changing the name of header file from OemMiscLib.h to
OemHisiMiscLib.h.
Cc: Leif
Main Changes since v1:
1.change the name of header file.
Wenyi Xie (1):
Hisilicon:Fix header file issues
Silicon/Hisilicon/HisiPkg.dec
| 2 +-
Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.h
Main Changes :
1.remove include uuid.h and link to libuuid. And try to build under linux, the
building is sucessful.
Wenyi Xie (1):
BaseTools: Remove dependence of libuuid
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 -
BaseTools/Source/C/DevicePath/GNUmakefile | 4
BaseTools/So
The uuid.h only included in file GenFvInternalLib.c,
but no interface from libuuid is used in this file.
So remove this include and link to libuuid.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: Wenyi Xie
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 -
BaseTools/Source/
I was on holiday.
>
> On Tue, Jun 22, 2021 at 20:33:25 +0800, wenyi,xie via groups.io wrote:
>> EDK2 has removed header file ArmLibPrivate.h, so need to
>> use ArmLib.h instead. A new file OemMiscLib.h is added
>> to EDK2, its name is same with the header file in
>> Hisil
Hi Wu Hao，
Thank you for your help. I will have a try and send a V3 patch later.
Best Regards,
Wenyi
On 2021/8/11 9:50, Wu, Hao A wrote:
> Seems no help is received so far.
> The approach I can think of is to add this to the ECC exception list defined
> in file MdeModulePkg.ci.yaml.
>
> Hello
Adding two unit test case for UefiSortLib. One is a test on
sorting an array of UINT32 by using PerformQuickSort, another
is a test on comparing the same buffer by using StringCompare.
Add 'main' function name to ECC exception list to avoid ECC
error.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by:
Main Changes since v2:
1.Add define UefiSortLibUnitTestMain for main.
2.Add UefiSortLibUnitTestMain to ecc exception list to avoid ecc error.
Wenyi Xie (1):
MdeModulePkg/UefiSortLib:Add UefiSortLib unit test
MdeModulePkg/Test/MdeModulePkgHostTest.dsc| 6 +
MdeModulePk
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3418
According to xhci spec, at USB packet level, a Control Transfer
consists of multiple transactions partitioned into stages: a
setup stage, an optional data stage, and a terminating status
stage. If Data Stage does not exist, the Transfer Type
Main Changes :
Check data length first, if data length equals to 0, then set TRT to 0.
Wenyi Xie (1):
MdeModulePkg/Xhci: Fix TRT when data length is 0
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 13 +
MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 13 +
2 files changed, 18 i
On 2021/5/31 9:44, Wu, Hao A wrote:
>> -Original Message-
>> From: Wenyi Xie
>> Sent: Thursday, May 27, 2021 8:04 PM
>> To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A
>> ; Ni, Ray
>> Cc: songdongku...@huawei.com; xiewen...@huawei.com
>> Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/Xhc
OK，I will handle this later.
Thanks
Wenyi
On 2021/6/18 23:54, Leif Lindholm wrote:
> Agh. *Actually* cc Wenyi.
>
> On Fri, Jun 18, 2021 at 16:53:38 +0100, Leif Lindholm wrote:
>> +Wenyi
>>
>> On Mon, Jun 14, 2021 at 12:57:49 -0600, Rebecca Cran wrote:
>>> Many of the cache definitions in ArmLibP
Main Changes :
1.Replace ArmLibPrivate.h with ArmLib.h
2.Cahnge order of dec in some inf file since there are same name header files
3.Remove redundant declaration of union PROCESSOR_STATUS_DATA
Wenyi Xie (1):
Hisilicon:Fix header file issues
Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigP
EDK2 has removed header file ArmLibPrivate.h, so need to
use ArmLib.h instead. A new file OemMiscLib.h is added
to EDK2, its name is same with the header file in
Hisilicon\Include and it will being included first. So
some undefined issue occured and need to change the order
of header files.
Cc: Le
The size of array BlockMap is 1 in struct FirmwareVolumeHeader, but in
function InitializeFvAndVariableStoreHeaders, BlockMap[1] is been written.
The memory of BlockMap[1] is already allocated, so the code is OK. But
it is better to use a new point to assign this memory.
Cc: Leif Lindholm
Cc: Ard
Main Changes :
1.Adding new point to assign the value of struct EFI_FV_BLOCK_MAP_ENTRY.
Wenyi Xie (1):
ArmPlatformPkg/Drivers/NorFlashDxe:avoid index out of bound
ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvb.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
--
2.20.1.windo
On 2022/10/30 18:06, Ard Biesheuvel wrote:
> On Sat, 29 Oct 2022 at 11:29, Wenyi Xie wrote:
>>
>> The size of array BlockMap is 1 in struct FirmwareVolumeHeader, but in
>> function InitializeFvAndVariableStoreHeaders, BlockMap[1] is been written.
>
> The size of BlockMap[] is not 1. BlockMap i
Main Changes :
1.Adding two unit test case for TranslateBmpToGopBlt.
Wenyi Xie (1):
MdeModulePkg/BaseBmpSupportLib:Add unit test
MdeModulePkg/Test/MdeModulePkgHostTest.dsc
| 5 +
MdeModulePkg/Library/BaseBmpSupportLib/UnitTest/BaseBmpSupportLibUnitTest.inf
Add unit test for function TranslateBmpToGopBlt in
BaseBmpSupportLib. As the translation will fail when
color map size is zero and this problem is not solved
yet, temporarily mask the fail case check.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeM
From: Zihong Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4167
In CrtLibSupport.h, time_t is defined as INT32, and its maximum value
is 2147483647. That is, the corresponding maximum timestamp is
2038-01-19 11:14:07. Therefore, overflow occurs when the test time
exceeds 2038-01-19 11:1
Main Changes :
1.Change type of time_t to INT64.
2.Using function DivS64x64Remainder to deal with INT64 divide.
Zihong Yi (1):
CryptoPkg/BaseCryptLib:time overflow
CryptoPkg/Library/Include/CrtLibSupport.h | 2 +-
CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c | 51
after merging the patch
importing failed.
>
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of
>> wenyi,xie via groups.io
>> Sent: Friday, November 25, 2022 5:12 PM
>> To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian
>&
Main Changes since v1 :
1.fix code format
Zihong Yi (1):
CryptoPkg/BaseCryptLib:time overflow
CryptoPkg/Library/Include/CrtLibSupport.h | 2 +-
CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c | 51 ++--
2 files changed, 38 insertions(+), 15 deletions(-)
--
From: Zihong Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4167
In CrtLibSupport.h, time_t is defined as INT32, and its maximum value
is 2147483647. That is, the corresponding maximum timestamp is
2038-01-19 11:14:07. Therefore, overflow occurs when the test time
exceeds 2038-01-19 11:1
Main Changes since v1 :
1.fix format issue found by Uncrustify
Wenyi Xie (1):
MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue
MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 6 ++
1 file changed, 6 insertions(+)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
When BitPerPixel is 1,4,8, there should be a color map in bmp file. But if
the format of bmp file is error, it maybe has no color map when BitPerPixel
is 1,4,8. The condition checking now can not catch this issue.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Wenyi X
Main Changes :
1.Change the type of gTimeOut to UINT32.
Wenyi Xie (1):
EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning
EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this
PCD is UINT32. So change the declaratrion of gTimeOut to UINT32
to fix compile warning.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Abner Chang
Cc: Daniel Schaefer
Signed-off-by: Wenyi Xie
---
EmbeddedPkg/Library/GdbSerialDebugPo
As the CommunicationBuffer plus BufferSize may overflow, check the
value first before using.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 22 +---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 5 ++
Main Changes :
1.Add check to avoid overflow.
Wenyi Xie (1):
MdeModulePkg/PiSmmCore:Avoid overflow risk
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 22 +---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 5 +
2 files changed, 19 insertions(+), 8 deletions(-)
--
2.20.1.windows.1
When BitPerPixel is 1,4,8, there should be a color map in bmp file. But if
the format of bmp file is error, it maybe has no color map when BitPerPixel
is 1,4,8. The condition checking now can not catch this issue.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Wenyi X
Main Changes :
1.Add check to catch the issue when format of bmp file is error.
Wenyi Xie (1):
MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue
MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 5 +
1 file changed, 5 insertions(+)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
G
On 2022/8/15 9:12, gaoliming wrote:
> Wenyi:
> I add my comments below.
Thank you for your comments. I agree with you that overflow can be treated as
overlap. I will update the patch and send it later.
Thanks
Wenyi
>
>> -邮件原件-
>> 发件人: devel@edk2.groups
As the CommunicationBuffer plus BufferSize may overflow, check the
value first before using.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 5 -
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4
2 files chang
Main Changes since v1 :
1.treate overflow as overlap
Wenyi Xie (1):
MdeModulePkg/PiSmmCore:Avoid overflow risk
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 5 -
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4
2 files changed, 8 insertions(+), 1 deletion(-)
--
2.20.1.windows.1
-=-=-=-=-
On 2022/8/16 9:49, Ni, Ray wrote:
>> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>> @@ -621,6 +621,9 @@ InternalIsBufferOverlapped (
>>IN UINTN Size2
>>)
>> {
>> + if (((UINTN)Buff1 > MAX_UINTN - Size1) || ((UINTN)Buff2 > MAX_UINTN -
Main Changes since v1 :
1.fix format issue found by Uncrustify
Wenyi Xie (1):
MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue
MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 6 ++
1 file changed, 6 insertions(+)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
When BitPerPixel is 1,4,8, there should be a color map in bmp file. But if
the format of bmp file is error, it maybe has no color map when BitPerPixel
is 1,4,8. The condition checking now can not catch this issue.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Wenyi X
Main Changes since v1 :
1.add comments for overflow check;
2.move condition check to if-clause.
Wenyi Xie (1):
MdeModulePkg/PiSmmCore:Avoid overflow risk
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10 +-
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4
2 files changed, 13 insertions(+
As the CommunicationBuffer plus BufferSize may overflow, check the
value first before using.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10 +-
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4
2 file
> *From:* devel@edk2.groups.io on behalf of wenyi,xie
> via groups.io
> *Sen
1 - 100 of 138 matches
Mail list logo
