Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-10-29 Thread Stefan Berger
: Julien Grall Cc: Peter Grehan Cc: Qi Zhang Cc: Ray Han Lim Ng Cc: Stefan Berger Cc: Wenxing Hou Cc: Xiaoyu Lu Signed-off-by: Michael D Kinney Reviewed-by: Stefan Berger -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110278

Re: [edk2-devel] [PATCH v2 0/3] Ovmf: enable TPM 1.2

2020-02-16 Thread Stefan Berger
On 2/15/20 6:33 AM, Marc-André Lureau wrote: Hi Yao On Thu, Feb 13, 2020 at 2:51 PM Yao, Jiewen wrote: Hi Lureau I don’t think we should expose the TPM Interface type via TpmCommandLib. That is the TPM device implementation. The TPM device might use TIS/FIFO/CRB, but there might be also othe

Re: [edk2-devel] [PATCH v3 2/6] OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei

2020-02-26 Thread Stefan Berger
amp; CRB which are TPM 2.0), try to send a GetTicks TPM 1.2 command to probe the version. In case of failure, fallback on TPM 2.0 path. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger --- OvmfPkg/OvmfPkgIa32.dsc | 2 + OvmfPkg/OvmfPkgIa32X64.dsc

Re: [edk2-devel] [PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

2019-07-18 Thread Stefan Berger
this expectation in "Maintainers.txt" in machine-readable format. Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Leif Lindholm Cc: Marc-André Lureau Cc: Michael D Kinney Cc: Philippe Mathieu-Daudé Cc: Stefan Berger Signed-off-by: Laszlo Ersek Reviewed-by: Marc-André

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-19 Thread Stefan Berger
On 9/19/22 05:17, Igor Mammedov wrote: On Fri, 16 Sep 2022 15:45:38 -0400 "Jason Andryuk" wrote: CCing Stefan as he is probably the best person to talk about qemu impl. of TPM Hi, I've noticed an issue with the TPM2 EventLog. OVMF exposes the TPM Event Log via EFI and ACPI, but they have

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-19 Thread Stefan Berger
On 9/19/22 12:55, Jason Andryuk wrote: Hi, Stefan, On Mon, Sep 19, 2022 at 8:22 AM Stefan Berger wrote: On 9/19/22 05:17, Igor Mammedov wrote: On Fri, 16 Sep 2022 15:45:38 -0400 "Jason Andryuk" wrote: CCing Stefan as he is probably the best person to talk about qemu impl. o

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2PhysicalPresenceLib: Fix incorrect TCG VER comparision

2020-07-10 Thread Stefan Berger
On 7/10/20 1:43 AM, Laszlo Ersek wrote: (+Marc-André, Stefan) On 07/10/20 02:44, Gao, Zhichao wrote: This bug is not obeserved by me. But I view the code. The condition is incorrect and it would affect the TCG operation: if (!mIsTcg2PPVerLowerThan_1_3) { if (OperationRequest < T

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2PhysicalPresenceLib: Fix incorrect TCG VER comparision

2020-07-10 Thread Stefan Berger
On 7/10/20 9:53 AM, Stefan Berger wrote: On 7/10/20 1:43 AM, Laszlo Ersek wrote: (+Marc-André, Stefan) On 07/10/20 02:44, Gao, Zhichao wrote: This bug is not obeserved by me. But I view the code. The condition is incorrect and it would affect the TCG operation: if

Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-21 Thread Stefan Berger
On 10/21/21 8:20 AM, Gerd Hoffmann wrote: Allows to compile OVMF without HashInstanceLibSha1, i.e. no SHA1 hash support in TPM/TCG modules. Does that then mean that the SHA1 bank in a TPM 2 stays untouched, meaning the PCRs there won't get extended even though the bank is there and active?

Re: [edk2-devel] [PATCH 1/4] OvmfPkg: move tcg configuration to dsc and fdf include files

2021-10-21 Thread Stefan Berger
Hoffmann Tested-by: Stefan Berger [Tested with OvmfPkg/OvmfPkgX64.dsc] -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82458): https://edk2.groups.io/g/devel/message/82458 Mute This Topic: https://groups.io/mt/86487980/21656 Group

Re: [edk2-devel] [PATCH 2/4] OvmfPkg: create Tcg2ConfigPeiCompat12.inf

2021-10-21 Thread Stefan Berger
picking the one or the other inf file. FYI: TPM 2 does not provide backwards compatibility to TPM 1.2. TPM 1.2 is its own implementation that is incompatible with TPM 2. So the extension 'Compat12' is a bit odd in this case. Tested-by: Stefan Berger [Tested with OvmfPkg/Ovmf

Re: [edk2-devel] [PATCH 3/4] OvmfPkg: rework TPM configuration

2021-10-21 Thread Stefan Berger
On 10/21/21 8:20 AM, Gerd Hoffmann wrote: Rename TPM_ENABLE to TPM2_ENABLE and TPM_CONFIG_ENABLE to TPM2_CONFIG_ENABLE so they are in line with the ArmVirtPkg config option names. Add separate TPM1_ENABLE option for TPM 1.2 support. I tested this on Fedora and attached a TPM 1.2 to the VM a

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: rework TPM configuration.

2021-10-21 Thread Stefan Berger
A few more comments to this series: - Is there a use case where TPM2_ENABLE_CONFIG is disabled, meaning where there should not be a TPM 2 menu entry? It's worth considering dropping this option because a user does need to have control over certain aspects of the TPM 2 configuration. Most of th

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: rework TPM configuration.

2021-10-22 Thread Stefan Berger
On 10/22/21 3:01 AM, Gerd Hoffmann wrote: On Thu, Oct 21, 2021 at 12:13:51PM -0400, Stefan Berger wrote: A few more comments to this series: - Is there a use case where TPM2_ENABLE_CONFIG is disabled, meaning where there should not be a TPM 2 menu entry? It's worth considering dropping

Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-22 Thread Stefan Berger
On 10/22/21 2:39 AM, Gerd Hoffmann wrote: On Thu, Oct 21, 2021 at 09:24:55AM -0400, Stefan Berger wrote: On 10/21/21 8:20 AM, Gerd Hoffmann wrote: Allows to compile OVMF without HashInstanceLibSha1, i.e. no SHA1 hash support in TPM/TCG modules. Does that then mean that the SHA1 bank in a

Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-22 Thread Stefan Berger
On 10/22/21 7:49 AM, James Bottomley wrote: On Fri, 2021-10-22 at 06:50 -0400, Stefan Berger wrote: [...] I see this also but when I get into Linux and run tpm2_pcrread I see the SHA1 bank active but not having received any PCR extensions from the firmware, which is not supposed to happen

Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-22 Thread Stefan Berger
On 10/22/21 8:40 AM, James Bottomley wrote: On Fri, 2021-10-22 at 07:57 -0400, Stefan Berger wrote: On 10/22/21 7:49 AM, James Bottomley wrote: On Fri, 2021-10-22 at 06:50 -0400, Stefan Berger wrote: [...] I see this also but when I get into Linux and run tpm2_pcrread I see the SHA1 bank

Re: [edk2-devel] [PATCH 2/4] OvmfPkg: create Tcg2ConfigPeiCompat12.inf

2021-10-22 Thread Stefan Berger
On 10/22/21 2:31 AM, Gerd Hoffmann wrote: Hi, FYI: TPM 2 does not provide backwards compatibility to TPM 1.2. TPM 1.2 is its own implementation that is incompatible with TPM 2. So the extension 'Compat12' is a bit odd in this case. Suggestions for a better name? Tcg2ConfigPeiCompat12.

Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-22 Thread Stefan Berger
On 10/22/21 10:17 AM, James Bottomley wrote: On Fri, 2021-10-22 at 09:13 -0400, Stefan Berger wrote: On 10/22/21 8:40 AM, James Bottomley wrote: On Fri, 2021-10-22 at 07:57 -0400, Stefan Berger wrote: On 10/22/21 7:49 AM, James Bottomley wrote: On Fri, 2021-10-22 at 06:50 -0400, Stefan

Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-22 Thread Stefan Berger
On 10/22/21 11:01 AM, James Bottomley wrote: On Fri, 2021-10-22 at 10:52 -0400, Stefan Berger wrote: along with the quote on the sha1 bank. The validator shouldn't accept that quote ... it should require a quote covering all banks. This is the point: you can't fake the quo

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: drop TPM_CONFIG_ENABLE

2021-10-25 Thread Stefan Berger
On 10/25/21 8:15 AM, Gerd Hoffmann wrote: Drop TPM_CONFIG_ENABLE config option. Including TPM support in the build without also including the TPM configuration menu is not useful. Suggested-by: Stefan Berger Signed-off-by: Gerd Hoffmann 2 more files would need this change: ./OvmfPkg

Re: [edk2-devel] [PATCH v2 3/5] OvmfPkg: create Tcg12ConfigPei.inf

2021-10-25 Thread Stefan Berger
1.2 support should be included or not by picking the one or the other inf file. Switch x86 builds to Tcg12ConfigPei.inf, so they continue to have TPM 1.2 support. No functional change. Signed-off-by: Gerd Hoffmann Reviewed-by: Stefan Berger Tested-by: Stefan Berger --- Ovmf

Re: [edk2-devel] [PATCH v2 4/5] OvmfPkg: rework TPM configuration

2021-10-25 Thread Stefan Berger
:  DEFINE TPM_ENABLE  = FALSE Tested-by: Stefan Berger --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 4 +++- OvmfPkg/OvmfTpmComponentsPei.dsc.inc | 6 +- OvmfPkg/OvmfTpmDefines.dsc.inc| 5 - OvmfPkg

Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: add TPM 1.2 config menu

2021-10-25 Thread Stefan Berger
On 10/25/21 8:15 AM, Gerd Hoffmann wrote: When building OVMF with TPM 1.2 support enabled do also include the configuration menu. Suggested-by: Stefan Berger Signed-off-by: Gerd Hoffmann The menu is there but it doesn't react to the selections, which I hadn't tested before.

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg: move tcg configuration to dsc and fdf include files

2021-10-25 Thread Stefan Berger
Hoffmann Reviewed-by: Stefan Berger --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 28 + OvmfPkg/OvmfTpmComponentsPei.dsc.inc | 22 +++ OvmfPkg/OvmfTpmDefines.dsc.inc | 6 ++ OvmfPkg/OvmfTpmLibs.dsc.inc | 14 + OvmfPkg/OvmfTpmLibsDxe.dsc.inc | 8

[edk2-devel] [PATCH 0/4] Add support for TPM 1.2 Physical Presence Interface and Menu

2021-10-26 Thread Stefan Berger
keep them at a minimum. For the PPI Flags I am using a EFI variable just like the original code does. (SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c) Regards, Stefan Gerd Hoffmann (1): OvmfPkg: add TPM 1.2 config menu Stefan Berger (3): OvmfPkg: Check for TPM 2

[edk2-devel] [PATCH 1/4] OvmfPkg: Check for TPM 2 early to leave function early

2021-10-26 Thread Stefan Berger
TPM 1.2 and TPM 2 share QEMU's PPI memory/device and for the TPM 2 code not to initilize over the TPM 1.2 initilization, leave the init function early without touching that memory. Cc: Gerd Hoffmann Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- .../DxeTcg2PhysicalPresence

[edk2-devel] [PATCH 2/4] SecurityPkg: Store physical presence code by submitting to PreOS func

2021-10-26 Thread Stefan Berger
Yao Cc: Jian J Wang Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- .../DxeTcgPhysicalPresenceLib.c | 55 +++ SecurityPkg/Tcg/TcgConfigDxe/TcgConfigImpl.c | 41 +- 2 files changed, 70 insertions(+), 26 deletions(-) diff --git a/SecurityPkg

[edk2-devel] [PATCH 4/4] OvmfPkg: add TPM 1.2 config menu

2021-10-26 Thread Stefan Berger
From: Gerd Hoffmann When building OVMF with TPM 1.2 support enabled do also include the configuration menu. Suggested-by: Stefan Berger Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 + OvmfPkg/OvmfTpmDxe.fdf.inc | 1 + 2 files changed, 2 insertions

[edk2-devel] [PATCH 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

2021-10-26 Thread Stefan Berger
Enable the physical presence interface for TPM 1.2. It is required for the TPM 1.2 menu to work. Cc: Jiewen Yao Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- OvmfPkg/Include/Library/QemuPPI.h

Re: [edk2-devel] [PATCH 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

2021-10-27 Thread Stefan Berger
On 10/26/21 13:38, Stefan Berger wrote: Enable the physical presence interface for TPM 1.2. It is required for the TPM 1.2 menu to work. I am also extending the TPM 2 PPI QEMU code and I am trying to introduce a variable there as well for holding physical presence flags. When trying to

Re: [edk2-devel] [PATCH v3 1/5] OvmfPkg: remove unused TPM options from MicrovmX64.dsc

2021-10-28 Thread Stefan Berger
On 10/28/21 07:09, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann Reviewed-by: Stefan Berger --- OvmfPkg/Microvm/MicrovmX64.dsc | 2 -- 1 file changed, 2 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc index 617f92539518..c58c4c35d4cb 100644

[edk2-devel] [PATCH v2 1/4] SecurityPkg: Store physical presence code by submitting to PreOS func

2021-11-02 Thread Stefan Berger
Yao Cc: Jian J Wang Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- .../DxeTcgPhysicalPresenceLib.c | 55 +++ SecurityPkg/Tcg/TcgConfigDxe/TcgConfigImpl.c | 41 +- 2 files changed, 70 insertions(+), 26 deletions(-) diff --git a/SecurityPkg

[edk2-devel] [PATCH v2 4/4] OvmfPkg: add TPM 1.2 config menu

2021-11-02 Thread Stefan Berger
From: Gerd Hoffmann When building OVMF with TPM 1.2 support enabled do also include the configuration menu. Suggested-by: Stefan Berger Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 + OvmfPkg/OvmfTpmDxe.fdf.inc | 1 + 2 files changed, 2 insertions

[edk2-devel] [PATCH v2 0/4] Add support for TPM 1.2 Physical Presence Interface and Menu

2021-11-02 Thread Stefan Berger
from DxeTcgPhysicalPresenceLib.inf - Other nits Gerd Hoffmann (1): OvmfPkg: add TPM 1.2 config menu Stefan Berger (3): SecurityPkg: Store physical presence code by submitting to PreOS func OvmfPkg: Copy TPM 1.2 DxeTcgPhysicalPresenceLib.c from SecuityPkg OvmfPkg: Enable physical presence

[edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

2021-11-02 Thread Stefan Berger
execute. Cc: Jiewen Yao Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- .../PlatformBootManagerLib/BdsPlatform.c | 2 + .../PlatformBootManagerLib.inf| 1 + .../DxeTcgPhysicalPresenceLib.c

[edk2-devel] [PATCH v2 2/4] OvmfPkg: Copy TPM 1.2 DxeTcgPhysicalPresenceLib.c from SecuityPkg

2021-11-02 Thread Stefan Berger
Copy the TPM 1.2 physical presence interface support from SecurityPkg DxeTcgPhysicalPresenceLib.c along with its .inf and .uni files into OvmfPkg. Fix EFI_F_INFO and EFI_D_ERROR to meet code standards. Signed-off-by: Stefan Berger --- .../DxeTcgPhysicalPresenceLib.c | 1455

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

2021-11-06 Thread Stefan Berger
On 11/5/21 08:17, Gerd Hoffmann wrote: On Tue, Nov 02, 2021 at 11:49:09AM -0400, Stefan Berger wrote: Enable the physical presence interface for TPM 1.2. It is required for the TPM 1.2 menu to work. The changes to DxeTcgPhysicalPresenceLib.c are due to the device we are using in QEMU for

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

2021-11-08 Thread Stefan Berger
bleLockProtocolGuid, NULL, (VOID **)&VariableLockProtocol);    if (!EFI_ERROR (Status)) { Status = VariableLockProtocol->RequestToLock ( Thanks.    Stefan Thank you Yao Jiewen -Original Message----- From: Gerd Hoffmann Sent: Monday, November 8, 2021 7:58 PM To: Stefan Berger

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

2021-11-08 Thread Stefan Berger
On 11/8/21 09:43, Stefan Berger wrote: On 11/8/21 07:13, Yao, Jiewen wrote: The PPFlag variable MUST to be locked to prevent malicious modification. Otherwise, anyone can change the PP configuration without confirmation from end user. That change by an attacker could presumably only  be

[edk2-devel] [PATCH v3 0/8] Add support for TPM 1.2 Physical Presence Interface and Menu

2021-12-01 Thread Stefan Berger
Stefan Berger (7): OvmfPkg: Move processing of physical presence opcode before End-of-Dxe OvmfPkg: Check for TPM 2 early to leave function early SecurityPkg: Store physical presence code by submitting to PreOS func SecurityPkg: Declare PhysicalPresenceFlags variable and its properties

[edk2-devel] [PATCH v3 1/8] OvmfPkg: Move processing of physical presence opcode before End-of-Dxe

2021-12-01 Thread Stefan Berger
For variable creation and locking to work later on we need to move the processing of the TPM physical presence opcode to before End-of-Dxe. Signed-off-by: Stefan Berger --- .../PlatformBootManagerLib/BdsPlatform.c | 20 +-- .../PlatformBootManagerLibBhyve/BdsPlatform.c | 18

[edk2-devel] [PATCH v3 5/8] OvmfPkg: Copy TPM 1.2 DxeTcgPhysicalPresenceLib.c from SecurityPkg

2021-12-01 Thread Stefan Berger
Copy the TPM 1.2 physical presence interface support from SecurityPkg DxeTcgPhysicalPresenceLib.c along with its .inf and .uni files into OvmfPkg. Fix EFI_F_INFO and EFI_D_ERROR to meet code standards. Signed-off-by: Stefan Berger --- .../DxeTcgPhysicalPresenceLib.c | 1455

[edk2-devel] [PATCH v3 6/8] OvmfPkg: Enable physical presence interface for TPM 1.2

2021-12-01 Thread Stefan Berger
execute. Cc: Jiewen Yao Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- OvmfPkg/Bhyve/BhyveX64.dsc| 1 + .../PlatformBootManagerLib/BdsPlatform.c | 1 + .../PlatformBootManagerLib.inf

[edk2-devel] [PATCH v3 8/8] OvmfPkg: add TPM 1.2 config menu

2021-12-01 Thread Stefan Berger
From: Gerd Hoffmann When building OVMF with TPM 1.2 support enabled also include the configuration menu. Suggested-by: Stefan Berger Signed-off-by: Gerd Hoffmann Signed-off-by: Stefan Berger --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 + OvmfPkg/OvmfTpmDxe.fdf.inc | 1 + 2 files

[edk2-devel] [PATCH v3 7/8] OvmfPkg: Enable TPM 1.2 Physical Presence Opcode processing

2021-12-01 Thread Stefan Berger
Enable the processing of the TPM 1.2 physical presence opcodes. This needs to be done before End-of-Dxe since otherwise the creation of the variables doesn't work. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 ++ OvmfPkg/Li

[edk2-devel] [PATCH v3 4/8] SecurityPkg: Declare PhysicalPresenceFlags variable and its properties

2021-12-01 Thread Stefan Berger
: ls PhysicalPresenceFlags-* Signed-off-by: Stefan Berger --- .../Library/AuthVariableLib/AuthServiceInternal.h | 1 + SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c | 11 +++ .../Library/AuthVariableLib/AuthVariableLib.inf | 4 3 files changed, 16 insertions

[edk2-devel] [PATCH v3 2/8] OvmfPkg: Check for TPM 2 early to leave function early

2021-12-01 Thread Stefan Berger
TPM 1.2 and TPM 2 share QEMU's PPI memory/device and for the TPM 2 code not to initilize over the TPM 1.2 initilization, leave the init function early without touching that memory. Cc: Gerd Hoffmann Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- .../DxeTcg2PhysicalPresence

[edk2-devel] [PATCH v3 3/8] SecurityPkg: Store physical presence code by submitting to PreOS func

2021-12-01 Thread Stefan Berger
Yao Cc: Jian J Wang Cc: Marc-André Lureau Signed-off-by: Stefan Berger --- .../DxeTcgPhysicalPresenceLib.c | 55 +++ SecurityPkg/Tcg/TcgConfigDxe/TcgConfigImpl.c | 41 +- 2 files changed, 70 insertions(+), 26 deletions(-) diff --git a/SecurityPkg

[edk2-devel] [PATCH v2] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case

2021-12-16 Thread Stefan Berger
supported before processing TCG physical presence opcodes. Signed-off-by: Stefan Berger Tested-by: Shivanshu Goyal --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 7 +++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 5 + OvmfPkg/Library

[edk2-devel] [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case

2021-12-16 Thread Stefan Berger
supported before processing TCG physical presence opcodes. Fixes: b8675deaa819631db2667df63f89799fe65fc906 Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3771 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Stefan Berger Tested-by: Shivanshu Goyal

Re: [edk2-devel] [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case

2021-12-16 Thread Stefan Berger
v2 had lost the cc: list for some reason. I opened this PR: https://github.com/tianocore/edk2/pull/2319   Stefan On 12/16/21 21:41, Stefan Berger wrote: For GPU passthrough support we have to initialize the console after EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after

[edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

2021-07-26 Thread Stefan Berger
Hello!   The TPM 2 code in EDK2 is missing an important call to Tpm2HierarchyChangeAuth for the platform hierarchy. We have to set the password of that hierarchy and discard the password. See also specs section 11: https://trustedcomputinggroup.org/wp-content/uploads/TCG_PCClient_PFP_r1p05_v2

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

2021-07-27 Thread Stefan Berger
-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth Adding @Jeremiah <mailto:jere...@microsoft.com>… Jeremiah, weren’t you or @Michael <mailto:michael.kuba...@microsoft.com> shopping this change to MinPlatform? - Bret *From: *Stefan Berger via groups.io <mai

Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

2021-07-28 Thread Stefan Berger
to:michael.kuba...@microsoft.com> shopping this change to MinPlatform? - Bret *From: *Stefan Berger via groups.io <mailto:stefanb=linux.ibm@groups.io> *Sent: *Monday, July 26, 2021 7:48 AM *To: *Yao, Jiewen <mailto:jiewen@intel.com>; devel@edk2.groups.io <mailto:devel@

[edk2-devel] [RFC PATCH 2/7] SecruityPkg/TPM: Disable dependency on MinPlatformPkg

2021-08-06 Thread Stefan Berger
/MinPlatformPkg.dec Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf b/SecurityPkg/Library

[edk2-devel] [RFC PATCH 0/7] OVMF: Disable the TPM2 platform hierarchy

2021-08-06 Thread Stefan Berger
'you' wanted to fix things up and repost it, please go ahead... Stefan Stefan Berger (7): SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms SecruityPkg/TPM: Disable dependency on MinPlatformPkg SecurityPkg/TPM: Disable PcdGetBool (PcdRandomizePl

[edk2-devel] [RFC PATCH 4/7] SecurityPkg/TPM: Disable a Pcd

2021-08-06 Thread Stefan Berger
/home/stefanb/dev/edk2/MdeModulePkg/MdeModulePkg.dec /home/stefanb/dev/edk2/SecurityPkg/SecurityPkg.dec /home/stefanb/dev/edk2/CryptoPkg/CryptoPkg.dec Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.inf | 4 ++-- 1 file changed, 2

[edk2-devel] [RFC PATCH 7/7] OVMF: Disable the TPM2 platform hierarchy

2021-08-06 Thread Stefan Berger
Use the newly added functions to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibGrub

[edk2-devel] [RFC PATCH 1/7] SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-08-06 Thread Stefan Berger
Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 ++ .../PeiDxeTpmPlatformHierarchyLib.c | 266 ++ .../PeiDxeTpmPlatformHierarchyLib.inf | 45 +++ 3 files changed, 338 insertions(+) create mode 100644 SecurityPkg/Include

[edk2-devel] [RFC PATCH 3/7] SecurityPkg/TPM: Disable PcdGetBool (PcdRandomizePlatformHierarchy)

2021-08-06 Thread Stefan Berger
~~ Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c b/SecurityPkg/Library/PeiDxeTpmPlatformHi

[edk2-devel] [RFC PATCH 5/7] SecurityPkg/TPM: Add a NULL implementation of PeiDxeTpmPlatformHierarchyLib

2021-08-06 Thread Stefan Berger
Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 23 +++ .../PeiDxeTpmPlatformHierarchyLib.inf | 39 +++ 2 files changed, 62 insertions(+) create mode 100644 SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull

[edk2-devel] [RFC PATCH 6/7] OVMF: Reference new classes in the build system for compilation

2021-08-06 Thread Stefan Berger
Compile the added code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg/OvmfPkgIa32.dsc| 3 +++ OvmfPkg

Re: [edk2-devel] [RFC PATCH 0/7] OVMF: Disable the TPM2 platform hierarchy

2021-08-07 Thread Stefan Berger
t this in this case? Please also merge 2, 3, 4 into 1. I don’t think we want a broken patch in 1, then add fix in 2, 3, 4. Thank you Yao Jiewen -Original Message- From: Stefan Berger Sent: Friday, August 6, 2021 11:33 PM To: devel@edk2.groups.io; Yao, Jiewen Cc: marcandre.lur...@

[edk2-devel] [PATCH v2 1/4] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-08-09 Thread Stefan Berger
Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Modify it so that ConfigureTpmPlatformHierarchy() is the only public function provided by this file. Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++ .../PeiDxeTpmPlatformHierarchyLib.c

[edk2-devel] [PATCH v2 4/4] OvmfPkg: Disable the TPM2 platform hierarchy

2021-08-09 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibGrub

[edk2-devel] [PATCH v2 2/4] OvmfPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

2021-08-09 Thread Stefan Berger
Add a NULL implementation of the library class TpmPlatformHierarchyLib Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 19 .../PeiDxeTpmPlatformHierarchyLib.inf | 31 +++ 2 files changed, 50 insertions(+) create mode 100644

[edk2-devel] [PATCH v2 3/4] OvmfPkg: Reference new TPM classes in the build system for compilation

2021-08-09 Thread Stefan Berger
Compile the added TPM related code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg/OvmfPkgIa32.dsc| 3 +++ OvmfPkg

[edk2-devel] [PATCH v2 0/4] Ovmf: Disable the TPM2 platform hierarchy

2021-08-09 Thread Stefan Berger
://bugzilla.tianocore.org/show_bug.cgi?id=3499 Regards, Stefan Stefan Berger (4): OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms OvmfPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib OvmfPkg: Reference new TPM classes in the build system for compilation

Re: [edk2-devel] [PATCH v2 0/4] Ovmf: Disable the TPM2 platform hierarchy

2021-08-09 Thread Stefan Berger
On 8/9/21 1:54 PM, James Bottomley wrote: On Mon, 2021-08-09 at 12:37 -0400, Stefan Berger wrote: This series imports code from the edk2-platforms project related to changing the password of the TPM2 platform hierarchy and uses it to disable the TPM2 platform hierarchy in Ovmf. It addresses

[edk2-devel] [PATCH v3 3/6] OvmfPkg: Reference new TPM classes in the build system for compilation

2021-08-10 Thread Stefan Berger
Compile the added TPM related code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ OvmfPkg/Bhyve/BhyveX64.dsc | 1 + .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg

[edk2-devel] [PATCH v3 0/6] Ovmf: Disable the TPM2 platform hierarchy

2021-08-10 Thread Stefan Berger
ArmVirtPkg Stefan Berger (6): OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms OvmfPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib OvmfPkg: Reference new TPM classes in the build system for compilation OvmfPkg: Disable the TPM2 platform hierarchy

[edk2-devel] [PATCH v3 5/6] ArmVirtPkg: Reference new TPM classes in the build system for compilation

2021-08-10 Thread Stefan Berger
Signed-off-by: Stefan Berger --- ArmVirtPkg/ArmVirtCloudHv.dsc| 1 + ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + ArmVirtPkg/ArmVirtXen.dsc| 1 + 4 files changed, 6 insertions(+) diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg

[edk2-devel] [PATCH v3 2/6] OvmfPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

2021-08-10 Thread Stefan Berger
Add a NULL implementation of the library class TpmPlatformHierarchyLib Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 19 .../PeiDxeTpmPlatformHierarchyLib.inf | 31 +++ 2 files changed, 50 insertions(+) create mode 100644

[edk2-devel] [PATCH v3 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-08-10 Thread Stefan Berger
Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Modify it so that ConfigureTpmPlatformHierarchy() is the only public function provided by this file. Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++ .../PeiDxeTpmPlatformHierarchyLib.c

[edk2-devel] [PATCH v3 6/6] ArmVirtPkg: Disable the TPM2 platform hierarchy

2021-08-10 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 ++ .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + 2 files changed, 7 insertions(+) diff --git a

[edk2-devel] [PATCH v3 4/6] OvmfPkg: Disable the TPM2 platform hierarchy

2021-08-10 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibGrub

Re: [edk2-devel] [PATCH v3 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-08-12 Thread Stefan Berger
On 8/12/21 9:48 AM, Marc-André Lureau wrote: Hi On Tue, Aug 10, 2021 at 9:22 PM Stefan Berger wrote: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Modify it so that ConfigureTpmPlatformHierarchy() is the only public function provided ‍ ‍ ZjQcmQRYFpfptBannerStart This Message

[edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-08-12 Thread Stefan Berger
Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Fix some bugs from the original code and simplify parts of it. Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++ .../PeiDxeTpmPlatformHierarchyLib.c | 200

[edk2-devel] [PATCH v4 4/6] OvmfPkg: Disable the TPM2 platform hierarchy

2021-08-12 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 7 +++ OvmfPkg/Library/PlatformBootManagerLibGrub

[edk2-devel] [PATCH v4 3/6] OvmfPkg: Reference new TPM classes in the build system for compilation

2021-08-12 Thread Stefan Berger
Compile the added TPM related code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ OvmfPkg/Bhyve/BhyveX64.dsc | 1 + .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg

[edk2-devel] [PATCH v4 6/6] ArmVirtPkg: Disable the TPM2 platform hierarchy

2021-08-12 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 ++ .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + 2 files changed, 7 insertions(+) diff --git a

[edk2-devel] [PATCH v4 2/6] OvmfPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

2021-08-12 Thread Stefan Berger
Add a NULL implementation of the library class TpmPlatformHierarchyLib Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 19 .../PeiDxeTpmPlatformHierarchyLib.inf | 31 +++ 2 files changed, 50 insertions(+) create mode 100644

[edk2-devel] [PATCH v4 0/6] Ovmf: Disable the TPM2 platform hierarchy

2021-08-12 Thread Stefan Berger
: tsshierarchychangeauth -hi p -pwdn newpass With Intel tss2 tools: tpm2_changeauth -c platform newpass Regards, Stefan v4: - Fixed and simplified code imported from edk2-platforms v3: - Referencing Null implementation on Bhyve and Xen platforms - Add support in ArmVirtPkg Stefan Berger (6

[edk2-devel] [PATCH v4 5/6] ArmVirtPkg: Reference new TPM classes in the build system for compilation

2021-08-12 Thread Stefan Berger
Signed-off-by: Stefan Berger --- ArmVirtPkg/ArmVirtCloudHv.dsc| 1 + ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + ArmVirtPkg/ArmVirtXen.dsc| 1 + 4 files changed, 6 insertions(+) diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg

Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-08-12 Thread Stefan Berger
On 8/12/21 4:59 PM, Sean Brogan wrote: This seems like a bad place for a general purpose lib that many other platforms may take a dependency on. In v1 this was SecurityPkg.  OvmfPkg is a platform package and therefore not a good place to define broad interfaces. What caused this to move he

Re: [edk2-devel] [PATCH v4 0/6] Ovmf: Disable the TPM2 platform hierarchy

2021-08-13 Thread Stefan Berger
Yao,   do you have any comments on this series? Would SecurityPkg be a better place for it?     Stefan On 8/12/21 12:59 PM, Stefan Berger wrote: This series imports code from the edk2-platforms project related to changing the password of the TPM2 platform hierarchy and uses it to disable

Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-08-13 Thread Stefan Berger
l references in your INFs for dependency Thanks Sean On 8/12/2021 3:19 PM, Stefan Berger wrote: On 8/12/21 4:59 PM, Sean Brogan wrote: This seems like a bad place for a general purpose lib that many other platforms may take a dependency on. In v1 this was SecurityPkg.  OvmfPkg is a platform

Re: [edk2-devel] [PATCH 05/17] OvmfPkg/Microvm: no tpm

2021-09-01 Thread Stefan Berger
On 8/31/21 5:57 AM, Gerd Hoffmann wrote: Microvm has no TPM support. Signed-off-by: Gerd Hoffmann Reviewed-by: Stefan Berger --- OvmfPkg/Microvm/MicrovmX64.dsc | 76 +- OvmfPkg/Microvm/MicrovmX64.fdf | 18 2 files changed, 1 insertion(+), 93

[edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-01 Thread Stefan Berger
Bhyve and Xen platforms - Add support in ArmVirtPkg Stefan Berger (8): SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms SecurityPkg/TPM: Fix bugs in imported PeiDxeTpmPlatformHierarchyLib SecurityPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

[edk2-devel] [PATCH v5 3/8] SecurityPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

2021-09-01 Thread Stefan Berger
Add a NULL implementation of the library class TpmPlatformHierarchyLib Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 19 .../PeiDxeTpmPlatformHierarchyLib.inf | 31 +++ 2 files changed, 50 insertions(+) create mode 100644

[edk2-devel] [PATCH v5 2/8] SecurityPkg/TPM: Fix bugs in imported PeiDxeTpmPlatformHierarchyLib

2021-09-01 Thread Stefan Berger
Fix some bugs in the original PeiDxeTpmPlatformHierarchyLib.c. Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 23 +-- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib

[edk2-devel] [PATCH v5 5/8] OvmfPkg: Reference new TPM classes in the build system for compilation

2021-09-01 Thread Stefan Berger
Compile the added TPM related code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++ OvmfPkg/Bhyve/BhyveX64.dsc | 1 + .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg

[edk2-devel] [PATCH v5 4/8] SecurityPkg: Introduce new PCD PcdRandomizePlatformHierarchy

2021-09-01 Thread Stefan Berger
Introduce the new PCD gEfiSecurityPkgTokenSpaceGuid.PcdRandomizePlatformHierarchy. Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.inf | 3 +-- SecurityPkg/SecurityPkg.dec | 6 ++ 2 files changed, 7 insertions(+), 2

[edk2-devel] [PATCH v5 1/8] SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-09-01 Thread Stefan Berger
Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 ++ .../PeiDxeTpmPlatformHierarchyLib.c | 266 ++ .../PeiDxeTpmPlatformHierarchyLib.inf | 45 +++ 3 files changed

[edk2-devel] [PATCH v5 7/8] ArmVirtPkg: Reference new TPM classes in the build system for compilation

2021-09-01 Thread Stefan Berger
Signed-off-by: Stefan Berger --- ArmVirtPkg/ArmVirtCloudHv.dsc | 1 + ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + ArmVirtPkg/ArmVirtXen.dsc

[edk2-devel] [PATCH v5 6/8] OvmfPkg: Disable the TPM2 platform hierarchy

2021-09-01 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 7 +++ OvmfPkg/Library/PlatformBootManagerLibGrub

[edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-01 Thread Stefan Berger
Bhyve and Xen platforms - Add support in ArmVirtPkg Stefan Berger (8): SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms SecurityPkg/TPM: Fix bugs in imported PeiDxeTpmPlatformHierarchyLib SecurityPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

[edk2-devel] [PATCH v5 8/8] ArmVirtPkg: Disable the TPM2 platform hierarchy

2021-09-01 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 ++ .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + 2 files changed, 7 insertions(+) diff --git a

[edk2-devel] [PATCH v5 2/8] SecurityPkg/TPM: Fix bugs in imported PeiDxeTpmPlatformHierarchyLib

2021-09-01 Thread Stefan Berger
Fix some bugs in the original PeiDxeTpmPlatformHierarchyLib.c. Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 23 +-- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib

  1   2   3   >