The customer has a server environment where PXE and HTTP service run in same
Linux Server. In this environment a SUT trying to boot to SLES 15 OS via PXE
from the Boot Menu. After PXE Boot file downloaded and grub Loaded without
continuing for installation Exit is pressed and control back to Set
Resolved Coverity Issues reported in SNP Dxe.
1.ComponentName.c (Overflow)
Expression "OffSet--", which is equal to 18446744073709551615, where "OffSet"
is known to be equal to 0, underflows the type that receives it.
2.SnpUndi32GetStatus,SnpUndi32Initialize,SnpUndi32Transmit (Deadcode)
Execution
Resolved INTEGER_OVERFLOW Coverity Issues in MNP Dxe
1.MnpStop,MnpInstanceDeliverPacket
Expression "MnpDeviceData->ConfiguredChildrenNumber--" and
Instance->RcvdPacketQueueSize-- where Both variables are known to be equal to
0, underflows the type that receives it.
Cc: Saloni Kasbekar
Cc: Zac
Resolved Coverity Issues in Http Dxe
1.HttpResponseWorker(DEADCODE)
The result of pointer arithmetic "HttpHeaders + AsciiStrLen("HTTP/1.1") + 1" is
never null.
2.HttpDns4 (DEAD LOOP)
Coverity reports dead loop error since IsDone is always false ,In Some scenario
it might not update the to true
3.
Resolved Coverity Issues in Http Dxe
1.HttpResponseWorker(DEADCODE)
The result of pointer arithmetic "HttpHeaders + AsciiStrLen("HTTP/1.1") + 1" is
never null.
2.HttpDns4 (DEAD LOOP)
Coverity reports dead loop error since IsDone is always false ,In Some scenario
it might not update the to true
3.
Resolved Coverity Issues in DHCP4 Dxe
1.DhcpChooseOffer(CHECKED_RETURN)
Calling "DhcpValidateOptions" without checking return value as is done
elsewhere 6 out of 7 times.
2.DhcpSendMessage(FORWARD_NULL)
In some case ,SeedHead might be dereferencing the null pointer.
3.Dhcp6GetMappingTimeOut(OVERFL
Resolved Coverity Issues in UefiPxeBcDxe
1.PxeBcHandleDhcp4Offer
Expression "Private->SelectIndex - 1", where "Private->SelectIndex" is known to
be equal to 0, underflows the type that receives it.
2.PxeBcDhcp4Discover
Directly dereferencing pointer "Token.Packet" which might have NULL .As
Token.
Both the cases have ASSERTs checking that the value is greater than 0. Move the
checks to the same location as the ASSERT. I'd also prefer if we return with a
failure instead of forcing continuation of the function with an invalid value.
Thanks,
Saloni
Addressed above comments and made changes
HI All,
We are facing issue of httpboot takes more time during large iso file
downloading.
The issue is reported on the customer side. The HTTP/HTTPs takes long time to
download the RHEL ISO image from HTTP/HTTPs servers.
Tried with different cards – Intel x810/x710/MLOM, Mellanox and Broad
