It is better to output error address information When Address is
invalid before ASSERT.
Signed-off-by: Ming Huang
---
MdePkg/Library/BaseIoLibIntrinsic/IoLib.c | 24
1 file changed, 24 insertions(+)
diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLib.c
b/MdePkg/Library
It is better to output error address information When Address is
invalid before ASSERT.
Signed-off-by: Ming Huang
---
MdePkg/Library/BaseIoLibIntrinsic/IoLib.c | 24
1 file changed, 24 insertions(+)
diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLib.c
b/MdePkg/Library
n IoLib except ASSERT (FALSE).
Thanks,
Ming
>
> Thanks,
>
> Mike
>
>> -Original Message-
>> From: Ming Huang
>> Sent: Tuesday, August 13, 2024 2:42 AM
>> To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Kinney, Michael D
>> ; Liu, Zhigua
It is better to output error address information When Address is
invalid before ASSERT.
PR:
https://github.com/tianocore/edk2/pull/6078
Signed-off-by: Ming Huang
---
MdePkg/Library/BaseIoLibIntrinsic/IoLib.c| 36 +
MdePkg/Library/BaseIoLibIntrinsic/IoLibArmVirt.c | 36
System will hang at debug print if enter RecordVarErrorFlag
in runtime.
This patch fix hang issue when run fwts in OS:
fwts uefirtmisc
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 18
PlatformLang variables. So FindVariable() should be
invoked atfer AutoUpdateLangVariable().
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
.../Universal/Variable/RuntimeDxe/Variable.c | 26 ++--
1 file changed, 13 insertions(+), 13 deletions
There are two infrequent issues in variable.
Ming Huang (2):
MdeModulePkg/Variable: Remove some debug print for runtime
MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable
.../Universal/Variable/RuntimeDxe/Variable.c | 44 ++--
1 file changed, 21
PlatformLang variables. So FindVariable() should be
invoked atfer AutoUpdateLangVariable().
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
.../Universal/Variable/RuntimeDxe/Variable.c | 26 ++--
1 file changed, 13 insertions(+), 13 deletions
There are two infrequent issues in variable.
Ming Huang (2):
MdeModulePkg/Variable: Remove some debug print for runtime
MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable
.../Universal/Variable/RuntimeDxe/Variable.c | 44 ++--
1 file changed, 21
System will hang at debug print if enter RecordVarErrorFlag
in runtime.
This patch fix hang issue when run fwts in OS:
fwts uefirtmisc
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 18
I have tested this patch simply, it can boot to OS sucessfully.
Thanks.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#41419): https://edk2.groups.io/g/devel/message/41419
Mute This Topic: https://groups.io/mt/31614327/21656
Group Owner:
On 5/17/2019 6:59 PM, Leif Lindholm wrote:
> On Wed, May 15, 2019 at 04:09:48PM -0700, Michael D Kinney wrote:
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1373
>>
>> Replace BSD 2-Clause License with BSD+Patent License. This change is
>> based on the following emails:
>>
>> https://list
Main Changes:
Add update sas address feature in AcpiPlatformDxe.
Ming Huang (3):
Silicon/Hisilicon: Change updating dsdt in ready to boot event
Silicon/Hisilicon/Acpi: Add update sas address feature
Silicon/Hisilicon: Rename EthMac files
Silicon/Hisilicon/Drivers/AcpiPlatformDxe
As not only update mac address feature in EthMac files, so rename
them to UpdateDsdt.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 +-
Silicon/Hisilicon/Drivers
The better time for updating dsdt is in ready to boot event,
so change the updating time.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 60
++--
1 file changed, 56 insertions(+), 4 deletions(-)
diff --git a/Silicon/Hisilicon/Drivers
The updating sas address feature is similar with apdating mac address.
Modify updating dsdt flow for add this feature.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c | 200
https://bugzilla.tianocore.org/show_bug.cgi?id=2667
Ming Huang (1):
MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 26 ++--
1 file changed, 13 insertions(+), 13 deletions(-)
--
2.8.1
PlatformLang variables. So FindVariable() should
be invoked atfer AutoUpdateLangVariable().
https://bugzilla.tianocore.org/show_bug.cgi?id=2667
Signed-off-by: Ming Huang
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 26 ++--
1 file changed, 13 insertions(+), 13 deletions
by adding
AutoUpdateLangVariable feature.
I hope this patch can be merged to edk2 master.
Thanks
Ming
>
> Best Regards
> Guomin
>> -Original Message-----
>> From: devel@edk2.groups.io On Behalf Of Ming
>> Huang
>> Sent: Monday, May 25, 2020 7:34 PM
>
Add HISI_SAS_CONFIG_PROTOCOL, provide get sas address interface,
this is prepare for adding update sas address feature.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/HisiPkg.dec | 1 +
Silicon/Hisilicon/Include/Protocol/HisiSasConfig.h | 43
2 files
在 2020/5/27 2:50, Leif Lindholm 写道:
> On Thu, May 21, 2020 at 22:43:04 +0800, Ming Huang wrote:
>> As not only update mac address feature in EthMac files, so rename
>> them to UpdateDsdt.
>>
>> Signed-off-by: Ming Huang
>> ---
>> Silicon/Hisilicon
The dsdt need be updated before boot to OS, so change the updating
to ready to boot event and can remove the needless dependence.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 56
+++-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe
在 2020/5/27 1:40, Leif Lindholm 写道:
> Please call your patches PATCH. RFC is when a potential solution
> is put up for discussion, not for changing platform code.
Modify it in v2.
>
> On Thu, May 21, 2020 at 22:43:02 +0800, Ming Huang wrote:
>> The better time for updatin
在 2020/5/27 2:49, Leif Lindholm 写道:
> On Thu, May 21, 2020 at 22:43:03 +0800, Ming Huang wrote:
>> The updating sas address feature is similar with apdating mac address.
>> Modify updating dsdt flow for add this feature.
>>
>> Signed-off-by: Ming Huang
>>
FlashFvbDxe depends on gEfiEventVirtualAddressChangeGuid, but got
away with not declaring it in its INF because of a transitive
dependency. However, this dependency got dropped in core EDK2,
resulting in build failures of the D0x platform.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers
Main changes since v1:
1 Add HISI_SAS_CONFIG_PROTOCOL;
2 Declare missing GUID dependency;
3 Other modifications as comments.
Ming Huang (5):
Silicon/Hisilicon: Change updating dsdt in ready to boot event
Silicon/Hisilicon: Add HISI_SAS_CONFIG_PROTOCOL
Silicon/Hisilicon/Acpi: Add update sas
The updating sas address feature is similar with apdating mac address.
Modify updating dsdt flow for add this feature.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1
I suggest that you can use your patch temporarily.
>
> Any other thing, I check your patch in the mail, it seem that not any change
> in code, can you double confirm it?
>
> Best Regards
>> -Original Message-
>> From: Ming Huang
>> Sent: Tuesday, May 26
n v2.
Thanks,
Ming
>
> Best Regards,
>
> Leif
>
> On Thu, May 21, 2020 at 22:43:01 +0800, Ming Huang wrote:
>> Main Changes:
>> Add update sas address feature in AcpiPlatformDxe.
>>
>> Ming Huang (3):
>> Silicon/Hisilicon: Change updating dsd
As not only update mac address feature in EthMac files, so rename
them to UpdateDsdt.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
Silicon/Hisilicon/Drivers
Break down AddSmbiosType9Entry to three funtions for optimizing
Smbios type 9.
Ming Huang (2):
Silicon/Hisilicon/Smbios: correct coding style issue in type 9
Silicon/Hisilicon/Smbios: Optimize type 9
Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 325
This patch is prepare for optimizing Smbios type 9.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 286
++--
1 file changed, 146 insertions(+), 140 deletions(-)
diff --git a/Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9
Break down AddSmbiosType9Entry to three funtions for optimizing
Smbios type 9.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 173
+++-
1 file changed, 95 insertions(+), 78 deletions(-)
diff --git a/Silicon/Hisilicon/Drivers
在 2020/6/9 1:15, Leif Lindholm 写道:
> Hi Ming,
>
> On Wed, May 27, 2020 at 22:33:56 +0800, Ming Huang wrote:
>> The updating sas address feature is similar with apdating mac address.
>> Modify updating dsdt flow for add this feature.
>>
>> Signed-off-by: Ming Hu
Add HISI_SAS_CONFIG_PROTOCOL, provide get sas address interface,
this is prepare for adding update sas address feature.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/HisiPkg.dec | 1 +
Silicon/Hisilicon/Include/Protocol/HisiSasConfig.h | 43
2 files
The dsdt need be updated before boot to OS, so change the updating
to ready to boot event and can remove the needless dependence.
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 56
+++-
Silicon/Hisilicon
The updating sas address feature is similar with apdating mac address.
Modify updating dsdt flow for add this feature.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1
Main changes since v2:
1 Remove needless three lines.
Ming Huang (4):
Silicon/Hisilicon: Change updating dsdt in ready to boot event
Silicon/Hisilicon: Add HISI_SAS_CONFIG_PROTOCOL
Silicon/Hisilicon/Acpi: Add update sas address feature
Silicon/Hisilicon: Rename EthMac files
Silicon
As not only update mac address feature in EthMac files, so rename
them to UpdateDsdt.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +-
Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
Silicon/Hisilicon/Drivers
在 2020/6/8 23:41, Leif Lindholm 写道:
> On Mon, Jun 08, 2020 at 22:09:56 +0800, Ming Huang wrote:
>> This patch is prepare for optimizing Smbios type 9.
>
> How?
> The commit message should describe what the patch does.
>
> (Yes, I can see with "git diff -w"
The main changes are whitespace/indentation fixing and wrapping
of long lines and changing some macros from EFI_D_ERROR to DEBUG_ERROR.
This patch is prepare for optimizing Smbios type 9.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 286
Main change since v1:
1 Add some commit messages.
Ming Huang (2):
Silicon/Hisilicon/Smbios: correct coding style issue in type 9
Silicon/Hisilicon/Smbios: Optimize type 9
Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 325
+++-
1 file changed, 174
Break down AddSmbiosType9Entry to three funtions for optimizing
Smbios type 9.
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 173
+++-
1 file changed, 95 insertions(+), 78 deletions(-)
diff --git a
在 2020/6/16 22:20, Leif Lindholm 写道:
> One remaining question, then this set is ready to go in:
>
> On Tue, Jun 09, 2020 at 21:27:24 +0800, Ming Huang wrote:
>> The updating sas address feature is similar with apdating mac address.
>> Modify updating dsdt flow
在 2020/6/17 19:07, Leif Lindholm 写道:
> On Wed, Jun 17, 2020 at 10:07:39 +0800, Ming Huang wrote:
>>
>>
>> 在 2020/6/16 22:20, Leif Lindholm 写道:
>>> One remaining question, then this set is ready to go in:
>>>
>>> On Tue, Jun 09, 2020 at 21:27:2
As SMBIOS spec, bit-31 of maximum cache size 2 should be 1
for 64K granularity.
Signed-off-by: Ming Huang
---
ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe
Fix issues in StandaloneMmPkg for supporting communicate from
TF-A with secure buffer.
Ming Huang (3):
StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field
StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR
StandaloneMmPkg: Fix check buffer address failed issue from TF-A
DEBUG_ERROR should be used in error branch.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 6 +++---
StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 12 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a
ShareBufBase;
For now, the second scene will failed because check buffer address.
This patch add CheckBufferAddr() to support check address for secure
buffer.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 70
StandaloneM
, SpPcpuSharedBufSize should be rename to SpSharedBufSize and this field
should no multiply by PayloadBootInfo->NumCpus;
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h
| 2 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobLis
Hi,
Any comments about this series?
On 10/15/21 5:06 PM, Ming Huang wrote:
> Fix issues in StandaloneMmPkg for supporting communicate from
> TF-A with secure buffer.
>
> Ming Huang (3):
> StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field
> StandaloneMmPkg: Repla
Just remove "Linaro Limited. All rights reserved".
Ming Huang (1):
Silicon/Hisilicon: Modify some head files
Silicon/Hisilicon/Include/Library/IpmiCmdLib.h | 3 +--
Silicon/Hisilicon/Include/Library/LpcLib.h | 3 +--
Silicon/Hisilicon/Include/Library/OemAddre
As these head files was wrote by Hisilicon, so remove
"Linaro Limited. All rights reserved".
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Include/Library/IpmiCmdLib.h | 3 +--
Silicon/Hisilicon/Include/Librar
Main Changes:
1 Extract RtcHelperLib from M41T83RealTimeClockLib;
2 Add RX8900RealTimeClockLib;
Ming Huang (2):
Hisilicon/Library: Move two functions to RtcHelperLib
Silicon/Hisilicon: Add RX8900RealTimeClockLib
Platform/Hisilicon/D06/D06.dsc
There are some boards base on D06, but use RX8900 RTC,
so upstream the RX8900RealTimeClockLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClock.h |
41 ++
Silicon/Hisilicon/Library
The functions of acquiring ownership of RTC will be used for other
RTC library, so move them to RtcHelperLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/D06.dsc |
1 +
Silicon
在 2020/5/19 2:13, Leif Lindholm 写道:
> On Mon, May 18, 2020 at 21:37:24 +0800, Ming Huang wrote:
>> There are some boards base on D06, but use RX8900 RTC,
>> so upstream the RX8900RealTimeClockLib.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
&
在 2020/5/19 2:03, Leif Lindholm 写道:
> On Mon, May 18, 2020 at 21:37:23 +0800, Ming Huang wrote:
>> The functions of acquiring ownership of RTC will be used for other
>> RTC library, so move them to RtcHelperLib.
>>
>> Contributed-under: TianoCore Contribution Agr
There is a typo issue in M41T83RealTimeClockLib. The MACROSECOND
should be MICROSECOND.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClock.h| 4
++--
Silicon/Hisilicon/Library
The functions of acquiring ownership of RTC will be used for other
RTC library, so move them to RtcHelperLib. Rename them by add leading
Oem for uniform.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/D06.dsc
Changes since v1:
1 Add a patch to fix typo issue;
2 Other modifications as comments.
Ming Huang (3):
Silicon/Hisilicon: Fix a typo issue in M41T83RealTimeClockLib
Hisilicon/Library: Move two functions to RtcHelperLib
Silicon/Hisilicon: Add RX8900RealTimeClockLib
Platform/Hisilicon/D06
There are some boards base on D06, but use RX8900 RTC,
so upstream the RX8900RealTimeClockLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClock.h |
39 ++
Silicon/Hisilicon/Library
在 2020/5/19 20:16, Leif Lindholm 写道:
> On Tue, May 19, 2020 at 19:08:40 +0800, Ming Huang wrote:
>> The functions of acquiring ownership of RTC will be used for other
>> RTC library, so move them to RtcHelperLib. Rename them by add leading
>> Oem for uniform.
>>
>
There is a typo issue in M41T83RealTimeClockLib. The MACROSECOND
should be MICROSECOND.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClock.h| 4
++--
Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.c | 14
Changes since v2:
1 Drop the Contributed-under tags.
2 revert the renaming.
Ming Huang (3):
Silicon/Hisilicon: Fix a typo issue in M41T83RealTimeClockLib
Hisilicon/Library: Move two functions to RtcHelperLib
Silicon/Hisilicon: Add RX8900RealTimeClockLib
Platform/Hisilicon/D06/D06.dsc
The functions of acquiring ownership of RTC will be used for other
RTC library, so move them to RtcHelperLib. Rename them by add leading
Oem for uniform.
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/D06.dsc |
1 +
Silicon/Hisilicon/Include
There are some boards base on D06, but use RX8900 RTC,
so upstream the RX8900RealTimeClockLib.
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClock.h |
39 ++
Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClockLib.c |
468
The address of GICR_IPRIORITYR is in SGI_base frame. ARM_GICR_CTLR_FRAME_SIZE
should add to GicCpuRedistributorBase for GICR_IPRIORITYR. Otherwise RAS
error(Uncorrected software error) will reported in ArmGicDxe.
Signed-off-by: Ming Huang
---
ArmPkg/Drivers/ArmGic/ArmGicLib.c | 3 +++
1 file
On 2/22/21 8:52 PM, Leif Lindholm wrote:
> Hi Ming,
>
> On Sat, Feb 20, 2021 at 15:08:39 +0800, Ming Huang wrote:
>> The address of GICR_IPRIORITYR is in SGI_base frame. ARM_GICR_CTLR_FRAME_SIZE
>> should add to GicCpuRedistributorBase for GICR_IPRIORITYR. Otherwise RAS
The register address of GICR_IPRIORITYR is in SGI_base frame. Add
IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise
GIC RAS error(Uncorrected software error) may report in ArmGicDxe.
---
ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-
On 2/23/21 8:58 PM, Leif Lindholm wrote:
> On Tue, Feb 23, 2021 at 13:42:49 +0100, Ard Biesheuvel wrote:
>> On Tue, 23 Feb 2021 at 12:07, Ming Huang wrote:
>>>
>>> The register address of GICR_IPRIORITYR is in SGI_base frame. Add
>>> IPRIORITY_ADDRESS macro
ter, I miss Heyi's email, sorry for that.
Thanks,
Ming
>
> Best Regards,
>
> Leif
>
> On Wed, Feb 24, 2021 at 16:26:33 +0800, Ming Huang wrote:
>>
>>
>> On 2/23/21 8:58 PM, Leif Lindholm wrote:
>>> On Tue, Feb 23, 2021 at 13:42:49 +0100,
The first patch is prepare for the second one.
Ming Huang (2):
ArmPkg/ArmGicLib: Fix two macros issue for offset parameter
ArmPkg/ArmGicLib: Fix GICR_IPRIORITYR address wrong issue
ArmPkg/Drivers/ArmGic/ArmGicLib.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
2.17.1
Modify two macros to put "offset" in parentheses and remove
parentheses from "4 * offset".
Signed-off-by: Ming Huang
---
ArmPkg/Drivers/ArmGic/ArmGicLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c
b/A
The register address of GICR_IPRIORITYR is in SGI_base frame. Add
IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise
GIC RAS error(Uncorrected software error) may report in ArmGicDxe.
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
ArmPkg/Drivers/ArmGic/ArmGicLib.c
Hi Sami,
Any comments about this series?
Thanks,
Ming
On 11/5/21 6:51 PM, Sami Mujawar wrote:
> Hi Ming,
>
> Apologies for the delay. I will look at this patch series next week.
>
> Regards,
>
> Sami Mujawar
>
> On 01/11/2021, 14:19, "Ming Huang" wrote:
&
On 12/9/21 1:46 AM, Omkar Anand Kulkarni wrote:
> Hi Ming,
>
> Thanks for this patch. This patch helps to resolve Standalone MM issue while
> exercising RAS use case.
> Few comments mentioned inline.
>
> - Omkar
>
>
> On 10/15/21 2:39 PM, Ming Huang via gro
在 12/9/21 1:46 AM, Omkar Anand Kulkarni 写道:
> Hi Ming,
>
> Thanks for this patch. This patch helps to resolve Standalone MM issue while
> exercising RAS use case.
> Few comments mentioned inline.
>
> - Omkar
>
>
> On 10/15/21 2:39 PM, Ming Huang via groups.io
Changes since v1:
Modify CheckBufferAddr() function.
Ming Huang (3):
StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field
StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR
StandaloneMmPkg: Fix check buffer address failed issue from TF-A
.../Drivers/StandaloneMmCpu/EventHandle.c
, SpPcpuSharedBufSize should be rename to SpSharedBufSize and this field
should no multiply by PayloadBootInfo->NumCpus;
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h
| 2 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobLis
ShareBufBase;
For now, the second scene will failed because check buffer address.
This patch add CheckBufferAddr() to support check address for secure
buffer.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 59
+++-
StandaloneM
DEBUG_ERROR should be used in error branch.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 6 +++---
StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 12 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a
lets
> hope my corresponding patch passes review within this decade...).
>
> Best regards,
> Marvin
>
> On 21.12.21 16:06, Ming Huang wrote:
>> There are two scene communicate with StandaloneMm(MM):
>> 1 edk2 -> TF-A ->
在 12/16/21 5:15 PM, Marvin Häuser 写道:
> Hey all,
>
>> On 15. Dec 2021, at 16:02, Ming Huang wrote:
>>
>>
>>
>>> On 12/9/21 1:46 AM, Omkar Anand Kulkarni wrote:
>>> Hi Ming,
>>> Thanks for this patch. This patch helps to resol
在 12/23/21 7:05 PM, Marvin Häuser 写道:
> On 23.12.21 11:46, Ming Huang wrote:
>>
>> 在 12/16/21 5:15 PM, Marvin Häuser 写道:
>>> Hey all,
>>>
>>>> On 15. Dec 2021, at 16:02, Ming Huang wrote:
>>>>
>>>>
>>>>
>
在 12/24/21 9:52 PM, Marvin Häuser 写道:
> On 24.12.21 02:18, Ming Huang wrote:
>>
>> 在 12/23/21 7:05 PM, Marvin Häuser 写道:
>>> On 23.12.21 11:46, Ming Huang wrote:
>>>> 在 12/16/21 5:15 PM, Marvin Häuser 写道:
>>>>> Hey all,
>>>&g
在 12/30/21 8:27 PM, Marvin Häuser 写道:
>
>
> On 25.12.21 03:09, Ming Huang wrote:
>>
>> 在 12/24/21 9:52 PM, Marvin Häuser 写道:
>>> On 24.12.21 02:18, Ming Huang wrote:
>>>> 在 12/23/21 7:05 PM, Marvin Häuser 写道:
>>>>> On 23.12.21 11:46, M
Changes since v2:
Modify CheckBufferAddr() function.
Ming Huang (3):
StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field
StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR
StandaloneMmPkg: Fix check buffer address failed issue from TF-A
.../Drivers/StandaloneMmCpu/EventHandle.c
ShareBufBase;
For now, the second scene will failed because check buffer address.
This patch add CheckBufferAddr() to support check address for secure
buffer.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 54
+++-
StandaloneM
DEBUG_ERROR should be used in error branch.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 6 +++---
StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 12 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a
, SpPcpuSharedBufSize should be rename to SpSharedBufSize and this field
should no multiply by PayloadBootInfo->NumCpus;
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h
| 2 +-
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobLis
Hi,
Any comment about this series ?
在 12/31/21 7:06 PM, Ming Huang 写道:
> Changes since v2:
> Modify CheckBufferAddr() function.
>
> Ming Huang (3):
> StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field
> StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR
>
The heap space will be rewrote if a StandloneMmPkg module create HOB
by BuildGuidHob() interface and write data to HOB space.
Add a PCD PcdMemoryHobSize for pre-allocation a space to create HOB to
fix this issue.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint
These definitions are added according UEFI spec.
Signed-off-by: Ming Huang
---
MdePkg/Include/Guid/Cper.h | 544
1 file changed, 544 insertions(+)
diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h
index deb96d4af9..715d3b6bb0 100644
--- a/MdePkg/Include
在 2/9/22 1:01 AM, Ard Biesheuvel 写道:
> On Tue, 8 Feb 2022 at 07:16, Ming Huang wrote:
>>
>> These definitions are added according UEFI spec.
>>
>> Signed-off-by: Ming Huang
>> ---
>> MdePkg/Include/Guid/Cper.h | 544
>> 1 fil
These definitions are added according UEFI spec.
Signed-off-by: Ming Huang
---
MdePkg/Include/Guid/Cper.h | 522
1 file changed, 522 insertions(+)
diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h
index deb96d4af9..eef584de03 100644
--- a/MdePkg/Include
Abandon this patch, send a new one for fixing this issue.
在 2/8/22 10:43 AM, Ming Huang 写道:
> The heap space will be rewrote if a StandloneMmPkg module create HOB
> by BuildGuidHob() interface and write data to HOB space.
> Add a PCD PcdMemoryHobSize for pre-allocation a space to crea
The rare case (create hob failed) should be considered. Assert for
StandaloneMmCoreHobLib and return NULL for StandaloneMmobLib.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Library/StandaloneMmCoreHobLib/Arm/StandaloneMmCoreHobLib.c |
6 ++
StandaloneMmPkg/Library/StandaloneMmHobLib
Fix two issues in StandaloneMmPkg HOB.
Ming Huang (2):
StandaloneMmPkg/Hob: Assert or return NULL for create hob failed
StandaloneMmPkg: Fix HOB space and heap space conflicted issue
StandaloneMmPkg/Core/StandaloneMmCore.c | 17 -
StandaloneMmPkg/Core
The heap space will be rewrote if a StandloneMmPkg module create HOB
by BuildGuidHob() interface and write data to HOB space.
Add a PCD PcdMemoryHobSize for pre-allocation a space to create HOB to
fix this issue.
Signed-off-by: Ming Huang
---
StandaloneMmPkg/Core/StandaloneMmCore.c | 17
1 - 100 of 120 matches
Mail list logo
