Re: [edk2-devel] [PATCH] Request to merge PR #6410 into EDK2 master branch

2024-11-11 Thread Michael D Kinney via groups.io
I provided some feedback in PR. Once that is addressed, I have no objections to this change being included in edk2-stable202411. Mike From: Li, Fei Sent: Monday, November 11, 2024 12:44 AM To: Chen, Lin Z ; Kinney, Michael D ; Gao, Liming ; devel@edk2.groups.io Cc: Zhang, Di ; Li, Zhuangzhi

Re: [edk2-devel] [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP window scaling

2024-11-25 Thread Michael D Kinney via groups.io
you please provide your suggestions on this behaviour? Thanks, santhosh From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> on behalf of Michael D Kinney via groups.io mailto:michael.d.kinney=intel@groups.io>&g

Re: [edk2-devel] [edk2-non-osi] pushed Qemu/Sbsa update by mistake

2024-11-25 Thread Michael D Kinney via groups.io
If the commit is not correct, then you can revert the change and push the revert commit. Since this is a public repo, forced pushes to remove the commit are now allowed. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marcin > Juszkiewicz via groups.io > Sent: Mon

Re: [edk2-devel] Capsule validation tool?

2024-11-18 Thread Michael D Kinney via groups.io
There is a shell app that can be used to apply a capsule. https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Application/CapsuleApp Mike From: devel@edk2.groups.io On Behalf Of james.last via groups.io Sent: Monday, November 18, 2024 11:15 AM To: devel@edk2.groups.io Subject: [edk2-dev

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

2024-11-24 Thread Michael D Kinney via groups.io
, GCC5) > > > > All of them including GCC 4.8 and 4.9? > > > > > > Rebecca > > > > > > On 11/22/2024 2:08 PM, Michael D Kinney via groups.io wrote: > > > Hi Rebecca, > > > > > > Yes. I have collected feedback. I hav

Re: [edk2-devel] [PATCH edk2-CCodingStandardsSpecification v3 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Michael D Kinney via groups.io
Reviewed-by: Michael D Kinney > -Original Message- > From: Rebecca Cran > Sent: Monday, February 3, 2025 10:46 AM > To: devel@edk2.groups.io; Kinney, Michael D > ; Sean Brogan ; > Oliver Smith-Denny ; Pedro Falcato > > Cc: Rebecca Cran > Subject: [PATCH edk2-CCodingStandardsSpecifica

Re: [edk2-devel] PRs for edk2-stable202502 (allow @verbatim doxygen tag and make ascii art in SignedCapsulePkg readable)

2025-02-03 Thread Michael D Kinney via groups.io
Approved. Mike > -Original Message- > From: Rebecca Cran > Sent: Monday, February 3, 2025 10:41 AM > To: devel@edk2.groups.io; Liming Gao ; > Kinney, Michael D > Subject: PRs for edk2-stable202502 (allow @verbatim doxygen tag and > make ascii art in SignedCapsulePkg readable) > > I'd l

Re: [edk2-devel] [PATCH edk2-CCodingStandardsSpecification v2 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Michael D Kinney via groups.io
Release process is documented here https://github.com/tianocore-docs/edk2-TemplateSpecification/wiki/TianoCore-Documents-Releasing The "version" field in the main branch is ignored, so there is never any reason to change it. That field typically contains the value when the document was impo

Re: [edk2-devel] [PATCH edk2-CCodingStandardsSpecification v2 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Michael D Kinney via groups.io
Hi Rebecca, The content changes look good. 2 comments below. Mike > -Original Message- > From: Rebecca Cran > Sent: Monday, February 3, 2025 3:26 AM > To: devel@edk2.groups.io; Kinney, Michael D > ; Sean Brogan ; > Oliver Smith-Denny ; Pedro Falcato > > Cc: Rebecca Cran > Subject: [P

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202502

2025-02-03 Thread Michael D Kinney via groups.io
Hi Liming, The Milestone "edk2-stable202502" has been added for PRs, so any PR that should be considered for this release should be tagged with that Milestone. That will make it easier to track progress through the soft and hard freeze to know when all PRs targeted for this release are either

Re: [edk2-devel] [edk2][PATCH 0/1] Update Maintainers.txt with my new email

2025-01-30 Thread Michael D Kinney via groups.io
Edk2 is using PRs now for all code reviews. Please submit a PR. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrei > Warkentin via groups.io > Sent: Thursday, January 30, 2025 11:10 AM > To: devel@edk2.groups.io > Cc: suni...@ventanamicro.com > Subject:

Re: [edk2-devel] [edk2-announce] Hard Feature Freeze starts now for edk2-stable202502

2025-02-07 Thread Michael D Kinney via groups.io
Hi Liming, During the soft/hard freeze period, most developers do not have permissions to set the milestone. Email is one way to request a PR for the next stable tag. Another is to add a comment to the PR requesting the PR be considered for the next PR. If the stewards approve the request, th

Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure

2024-12-18 Thread Michael D Kinney via groups.io
I can not reproduce locally either. I installed VS2022 build tools. The error message is related to the ability to allocate a specific range of virtual memory. If that fails on CI agent, but not local envs, it could be related to the CI agent windows image being used. Mike > -Original

Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure

2024-12-18 Thread Michael D Kinney via groups.io
cally but I was > able > > to with at least one build. With that build, simply rerunning the same > > WinHost.exe binary would sometimes work and fail. > > > > Thanks, > > Michael > > > > On 12/18/2024 3:33 PM, Michael D Kinney via groups.io wrote: > >>

[edk2-devel] TianoCore Bugzilla to GitHub Issues Migration

2024-12-17 Thread Michael D Kinney via groups.io
Hello, The preparation for the migration from TianoCore Bugzilla to GitHub Issues is making great progress. The TianoCore Bugzilla server has been temporarily disabled to support the migration. If you have bug updates to make, please be patient and you should be able to do those in GitHub Iss

Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure

2024-12-18 Thread Michael D Kinney via groups.io
Here are some more details. Looks like the upgrade to VS2022 also change the runner image which included an OS version change as well. Passing Azure Pipelines CI Agent details: Image: windows-2019 Version: 20241125.1.0 Included Software: https://github.com/actions/runner-images/blob

Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure

2024-12-18 Thread Michael D Kinney via groups.io
I also just did a rerun on a job that failed, and the rerun passed. https://github.com/tianocore/edk2/pull/6542 Either there was an OS change/patch since the failed run or the failure is non deterministic. Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, Dece

Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure

2024-12-18 Thread Michael D Kinney via groups.io
4 PM, Michael Kubacki wrote: > > > Hi Mike, > > > > > > I've also had trouble reproducing it consistently locally but I was > > able > > > to with at least one build. With that build, simply rerunning the > same > > > WinHost.exe binary w

[edk2-devel] TianoCore Bugzilla to Github Issues Migration is complete

2024-12-20 Thread Michael D Kinney via groups.io
Hello, The migration of all issues from TianoCore Bugzilla to GitHub Issues is complete. All the open and closed issues have been migrated to the appropriate repository in GitHub. GitHub issue templates are now active. Please let us know if there is any information missing or there are any prob

Re: [edk2-devel] TianoCore Bugzilla to Github Issues Migration is complete

2024-12-20 Thread Michael D Kinney via groups.io
a ID number is part of the GitHub Issue Title, so if Anyone needs to search for an issue by Bugzilla ID, they can use the GitHub issue search and search for "Bugzilla Bug " > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Michael D > > Kinne

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

2024-11-22 Thread Michael D Kinney via groups.io
Hi Rebecca, Yes. I have collected feedback. I have found some use of these toolchains. I do not have a date when the move to newer toolchains will be completed. Mike > -Original Message- > From: Rebecca Cran > Sent: Thursday, November 21, 2024 9:05 PM > To: Kinney, Michael D ; > deve

Re: [edk2-devel] UefiCpuPkg: Proposal to enable/disable AP parallel

2024-11-21 Thread Michael D Kinney via groups.io
If an AP has been disabled on purpose due to a failure and is expected to never be enabled, then a broadcast mechanism would not be a good idea. Instead, we should consider enhancing EFI_MP_SERVICES_ENABLEDISABLEAP to support a non-blocking operation so it can be called in a loop for a group of

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

2024-11-22 Thread Michael D Kinney via groups.io
Subject: Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and > deprecated toolchains (GCC48, GCC49, GCC5) > > All of them including GCC 4.8 and 4.9? > > > Rebecca > > > On 11/22/2024 2:08 PM, Michael D Kinney via groups.io wrote: > > Hi Rebecca, > >

[edk2-devel] PRs with issues reported by CodeQL

2025-01-26 Thread Michael D Kinney via groups.io
EDK II Maintainers and Reviewers, If a PR has an issue that is added by a CodeQL scan, and that issue is later resolved by code updates to the PR, the PR will not be merged by Mergify. The reason is that the state of the conversation started by CodeQL is not seen as resolved by Mergify, even thou