[edk2-devel] [PATCH] ShellPkg: Update smbiosview type 4 with SMBIOS 3.6 fields

2024-03-26 Thread Lien, HoraceX
From: HoraceX Lien REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4737 update smbiosview type 4 related fileds. Signed-off-by: HoraceX Lien Cc: Zhichao Gao --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 1 file changed, 4 insertions(+) diff --git a/ShellPkg/L

[edk2-devel] [PATCH v2] ShellPkg: Update smbiosview type 4 with SMBIOS 3.6 fields

2024-03-27 Thread Lien, HoraceX
From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4737 update smbiosview type 4 related fileds. Signed-off-by: HoraceX Lien Cc: Zhichao Gao Reviewed-by: Zhichao Gao --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 1 file changed, 4 insertions(

[edk2-devel] [PATCH] ShellPkg/Pci.c: Update supported link speed to PCIe Gen6

2024-05-26 Thread Lien, HoraceX
From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4779 Refer to PCI express base specification Reversion 6.2, table 7-23 Link Capabilities Register. Supported Link Speeds Vector bit 5: speed 64 GT/s. Add the support to shell command 'pci'. Signed-off-by: HoraceX Lien Cc: Z

[edk2-devel] [PATCH] ShellPkg: Correct smbiosview strings for SMBIOS Type0

2024-07-17 Thread Lien, HoraceX
From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4813 Some strings not match SMBIOS specification definition, include uppercase and lowercase, wrong characters, extra words,...etc Signed-off-by: HoraceX Lien Cc: Zhichao Gao --- ShellPkg/Library/UefiShellDebug1CommandsLi

[edk2-devel] [PATCH] ShellPkg: Correct smbiosview strings for SMBIOS Type0

2024-07-17 Thread Lien, HoraceX
From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4813 Some strings not match SMBIOS specification definition, include uppercase and lowercase, wrong characters, extra words,...etc Signed-off-by: HoraceX Lien Cc: Liming Gao --- ShellPkg/Library/UefiShellDebug1CommandsLib

[edk2-devel] [PATCH] ShellPkg: Correct smbiosview strings and conditions for SMBIOS Type9

2024-08-11 Thread Lien, HoraceX
From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4826 Using smbiosview to dump SMBIOS Type9, some code condition and string are incorrect. Signed-off-by: HoraceX Lien Cc: Liming Gao --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 19 +-

[edk2-devel] [PATCH] Silicon/Intel/FitGen:FIT change for MMC entry.

2024-08-22 Thread Lien, HoraceX
From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4828 Support Type5 for Memory Microcontroller Firmware Image entry. Signed-off-by: HoraceX Lien Cc: Yuwei Chen Cc: Feng Bob C Cc: Liming Gao --- Silicon/Intel/Tools/FitGen/FitGen.c | 56 +++- Silicon/Int

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-01 Thread Lien, HoraceX
the old code only filtered 4 bits, instead of accurately filtering the number range 0-9. Thanks, Horace Lien -Original Message- From: Kinney, Michael D Sent: Thursday, August 31, 2023 11:56 PM To: devel@edk2.groups.io; Lien, HoraceX Cc: Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-07 Thread Lien, HoraceX
Hi Mike, Could you please reply for me? If you want to filter range 0-9, then I will send PR again. Thanks, Horace Lien -Original Message- From: devel@edk2.groups.io On Behalf Of Lien, HoraceX Sent: Friday, September 1, 2023 3:06 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Liu

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-08 Thread Lien, HoraceX
-- From: Kinney, Michael D Sent: Friday, September 8, 2023 6:05 AM To: Lien, HoraceX ; devel@edk2.groups.io; Gao, Liming Cc: Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao, Zhichao ; Kinney, Michael D Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-14 Thread Lien, HoraceX
-Original Message- From: Lien, HoraceX Sent: Friday, September 8, 2023 5:35 PM To: Kinney, Michael D ; devel@edk2.groups.io; Gao, Liming Cc: Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao, Zhichao Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-15 Thread Lien, HoraceX
r 0-9 can more safely use them. Once SMBIOS version > 9, I think that Spec must be give a reasonable explanation for BcdRevision. Thanks, Horace Lien -Original Message- From: Kinney, Michael D Sent: Friday, September 15, 2023 1:48 AM To: Lien, HoraceX ; devel@edk2.groups.io; Gao, Liming

[edk2-devel] [PATCH v2] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-24 Thread Lien, HoraceX
From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4544 These value of Major/Minor version are updated from SMBIOS memory data, but BCD Revision is updated from PCD PcdSmbiosVersion. We should also update BCD Revision from SMBIOS memory data, to ensure that get consistent ver