On 09/12/19 16:46, Laszlo Ersek wrote:
> On 09/11/19 18:23, Ard Biesheuvel wrote:
>> After upgrading the CI system we use for building the ArmVirtPkg
>> targets, we started seeing failures due to the NOOPT build running
>> out of space when using the CLANG38 toolchain defini
NTEXT.ContextData.X64 or
> PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This patch check the
> mode before using the correct one.
>
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Eric Dong
> ---
> UefiCpuPkg/CpuDxe/CpuDxe.inf | 4 ++-
f
> +!if $(FD_SIZE_IN_MB) == 3
> + 0x00, 0x00, 0x30, 0x00, 0x00, 0x00, 0x00, 0x00, # image_size: 3 MB
> +!endif
>0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, # flags
>0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, # res2
>0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
On 09/09/19 20:40, John E Lofgren wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150
>
> V2 changes:
> Add xchg 16 bit instructions to handle sgdt and sidt base
> 63:48 bits and 47:32 bits.
> Add comment to explain why xchg 64bit isnt being used
>
> Fix #AC split lock's caused by s
Hi Sean,
On 09/13/19 23:00, sean.brogan via [] wrote:
> These tests require using the "edk2-pytool" stuff but are easy to integrate
> with the github PR or CI flow. Example of it running the code compliance
> tests is here:
> https://dev.azure.com/tianocore/edk2-ci-play/_build?definitionId=13&
Lib] is not found
in [StandaloneMmPkg/Core/StandaloneMmCore.inf] [IA32]
Now, I'm not sure if *this* build breakage is related to the Synquacer
work you mention in the blurb. If it is, then fixing it would be nice.
If not, then can we perhaps remove IA32 and X64 from
SUPPORTED_ARCHI
Hi Zhichao,
On 09/16/19 07:15, Gao, Zhichao wrote:
> Hi Roy, Ard, Laszlo,
>
> Do you have any comment if I add the new terminal type to TtyTerm.h? As
> PcAnsi.h, the spec mentioned terminal types are put into one header file.
I've seen the original posting. I have no particular comments.
In Ar
try;
> -DEBUG ((EFI_D_WARN, "XenStore: WatchEvents is not empty, cleaning
> up..."));
> +DEBUG ((DEBUG_WARN, "XenStore: WatchEvents is not empty, cleaning
> up...\n"));
> Entry = GetFirstNode (&xs.WatchEvents);
> while (!IsNull (&xs
ENSTORE_WATCH_SIGNATURE);
>
> - AsciiSPrint (Token, sizeof (Token), "%p", (VOID *) Watch);
> - if (XenStoreFindWatch (Token) == NULL) {
> + if (XenStoreFindWatch (Watch) == NULL) {
> return;
>}
>
> @@ -1393,6 +1394,7 @@ Xen
file changed, 35 insertions(+), 90 deletions(-)
This looks a bit more complex than what I can allocate time for now, so
I'll trust you on it -- it only modifies XenStore.c. Feedback from other
reviewers is encouraged.
Acked-by: Laszlo Ersek
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.i
XENSTORE_STATUS_EINVAL;
> + }
>
> - return Status;
> + return XenStoreWrite (Transaction, DirectoryPath, Node, Buf);
> }
>
> XENSTORE_STATUS
>
Reviewed-by: Laszlo Ersek
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#4
atus;
> }
> @@ -1226,7 +1240,7 @@ XenStoreTransactionStart (
>XENSTORE_STATUS Status;
>
>Status = XenStoreSingle (XST_NIL, XS_TRANSACTION_START, "", NULL,
> - (VOID **) &IdStr);
> +NULL, (VOID **) &IdStr);
(5) Indentati
190
> Signed-off-by: Anthony PERARD
> ---
> OvmfPkg/XenBusDxe/XenStore.c | 297 +++
> 1 file changed, 130 insertions(+), 167 deletions(-)
Sorry, too big for a detailed review, and I'd like to go through the
series today. So, based on the diffstat,
Ac
On 09/16/19 17:39, Laszlo Ersek wrote:
> On 09/13/19 16:50, Anthony PERARD wrote:
>> When doing an action with a path and subpath in the xenstore,
>> XenStoreJoin is called to generate "$path/$subpath". But this function
>> do an allocation of memory which i
On 09/13/19 16:50, Anthony PERARD wrote:
> We will use a buffer on the stack instead of allocating memory for
> internal functions that are expecting a reply from xenstore.
>
> The external interface XENBUS_PROTOCOL isn't changed yet, so
> allocation are made for XsRead and XsBackendRead.
>
> Ref:
his value" with
"XENSTORE_PAYLOAD_MAX").
Other than that, I'm going to have to ACK this after a brief skim only.
Acked-by: Laszlo Ersek
Thanks
Laszlo
> typedef enum {
>XENSTORE_STATUS_SUCCESS = 0,
>XENSTORE_STATUS_FAIL,
> @@ -64,19 +70,17 @@ typedef enum {
On 09/13/19 16:50, Anthony PERARD wrote:
> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid
> using the Memory Allocation Services.
>
> This comes with a new interface named RegisterExitCallback so that PV
> drivers can disconnect from the backend before XenBusDxe is teared
> down
On 09/16/19 17:06, Yao, Jiewen wrote:
> That is correct.
>
> Current trunk only supports ARM system.
>
> I have branch to support x86 -
> https://github.com/jyao1/edk2/tree/StandaloneSmmX86Poc
> But that is not merged into trunk yet.
In that case, for this patch:
Build-te
On 09/16/19 20:36, Andrew Fish wrote:
>
>
>> On Sep 16, 2019, at 10:36 AM, Laszlo Ersek wrote:
>>
>> On 09/13/19 16:50, Anthony PERARD wrote:
>>> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid
>>> using the Memory Allocation Service
://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys
>
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Liming Gao
> Signed-off-by: Zhichao Gao
> ---
> MdeModulePkg/Include/Guid/TtyTerm.h | 1
On 09/17/19 13:08, Tiger Liu(BJ-RD) wrote:
> Hi, Expert:
> I have a question about creating page table.
> If a CPU support 48bit physical address line, then creating page tables(Page
> size=2MB) will occupy too much memory region.
>
> Now, developer could only use PcdUse1GPageTable to avoid occup
Gao
Cc: Maurice Ma
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Siyuan Fu
Cc: Supreeth Venkatesh
Cc: Zhichao Gao
Thanks
Laszlo
Laszlo Ersek (35):
DO NOT APPLY: edk2: turn standard handle types into pointers to
non-VOID
EmbeddedPkg: add missing EFIAPI calling convention specifiers
Embedded
This patch is unrelated to the rest of the series; it just makes sure that
"EmbeddedPkg/EmbeddedPkg.dsc" builds for all platforms advertised in
SUPPORTED_ARCHITECTURES (in particular, X64).
No functional changes.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Laszlo Ersek
o
Cc: Jordan Justen
Cc: Julien Grall
Cc: Leif Lindholm
Cc: Liming Gao
Cc: Maurice Ma
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Siyuan Fu
Cc: Supreeth Venkatesh
Cc: Zhichao Gao
Signed-off-by: Laszlo Ersek
---
MdePkg/Include/Pi/PiPeiCis.h | 6 --
Mde
y the current code doesn't crash.
Perhaps the function is never reached in practice? (It could be tied to an
error path.)
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c
"gTimerEvent" has type EFI_EVENT already, drop the superfluous cast.
Cc: Andrew Fish
Cc: Jordan Justen
Cc: Ray Ni
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
change behavior --, it's just semantically wrong to pass an
(EFI_HANDLE*) where an EFI_HANDLE is expected.
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Signed-off-by: Laszlo Ersek
---
Notes:
lightly tested, as DxeCorePerformanceLib is linked
Cc: Liming Gao
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Laszlo Ersek
---
Notes:
lightly tested, as these modules (except LoadFileOnFv2) are part of the
ArmVirt and/or OVMF platforms
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.c | 2 +-
MdeModulePkg/Universa
ng Gao
Signed-off-by: Laszlo Ersek
---
Notes:
lightly tested, as these modules are part of the ArmVirt and/or OVMF
platforms
MdeModulePkg/Core/Dxe/Event/Event.c| 8
MdeModulePkg/Core/RuntimeDxe/Runtime.c | 10 +-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --gi
HiiGetHiiHandles() returns an array of EFI_HII_HANDLEs, not EFI_HANDLEs.
HiiGetString() takes an EFI_HII_HANDLE, not an EFI_HANDLE.
This change is a no-op in practice; it's a semantic improvement.
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Jian J Wang
Signed-off-by: Laszlo
paths. Fix the UninstallMultipleProtocolInterfaces()
calls.
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Ray Ni
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 2 +-
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 2
ay Ni
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
EmulatorPkg/EmuGopDxe/GopInput.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/EmulatorPkg/EmuGopDxe/GopInput.c b/EmulatorPkg/EmuGopDxe/GopInput.c
index fdd0b4911555..2a23564a2173 100644
--- a/Emulat
of HiiAddPackages(), and stands for the published
HII package list.
Therefore this patch addresses an actual bug.
The typo has not been flagged by compilers because the UEFI spec
regrettably defines both EFI_HANDLE and EFI_HII_HANDLE as (VOID*).
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming G
u
Cc: Jian J Wang
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Laszlo Ersek
---
Notes:
lightly tested: ConSplitterDxe is part of the ArmVirt and OVMF platforms
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +-
MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 4 ++
d
cast it explicitly to EFI_PEI_FILE_HANDLE when assigning it to
(*AprioriFile).
This is a semantic cleanup, there is no functional change.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Laszlo Ersek
---
Notes:
lightly tested: OVMF uses APRIORI PEI in the FDF
d explicit
casts for clarity.
There is no change in functionality.
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Signed-off-by: Laszlo Ersek
---
Notes:
lightly tested: multiple drivers in OVMF write S3 boot script fragments
MdeModulePkg/Universal
nd device path nodes. But it doesn't set up proper parent/child
protocol opens, and it doesn't close them.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
EmbeddedPkg/Universal/MmcDxe/Mmc.c | 5 +++--
1 file changed, 3 insertio
t "DispatchHandle".
This is a semantic cleanup; there is no functional change.
Cc: Eric Dong
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Ray Ni
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only, most likely -- I'm unaware of any code paths in OVMF
that would lead to SmiHand
NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
NULL-check. Fix the type of "SnpHandle".
This patch is a no-op.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Laszlo Ersek
---
Notes:
Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD
take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*).
This patch fixes a real bug.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Laszlo Ersek
---
Notes:
possibly only build-tested
Network
dates that
EFI_HII_HANDLE be a typedef to (VOID*).
Cc: Ard Biesheuvel
Cc: Jordan Justen
Signed-off-by: Laszlo Ersek
---
Notes:
tested in UiApp
OvmfPkg/PlatformDxe/Platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/P
path. Fix the UninstallMultipleProtocolInterfaces() call.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
OvmfPkg/XenBusDxe/XenBus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Ov
DLE*) -- (VOID**) -- types.
This typo is masked because (VOID*) converts to and from any
pointer-to-object type silently.
Note that functionally speaking there is no problem, so this patch does
not change beavior, only cleans up the code.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Las
Unload() functions, which are probably exercised
infrequently. Fix the UninstallMultipleProtocolInterfaces() calls.
Cc: Chao Zhang
Cc: Jian Wang
Cc: Jiewen Yao
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c
regrettably, both
EFI_HANDLE and SHELL_FILE_HANDLE are specified to be typedefs of (VOID*)).
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Laszlo Ersek
---
Notes:
tested: rm, touch
ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c| 2 +-
ShellPkg/Library/UefiShellLevel3CommandsLib
mantic fix; there is no change in operation.
Cc: Achin Gupta
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
StandaloneMmPkg/Core/StandaloneMmCore.h | 2 +-
StandaloneMmPkg/Core/Dispatcher.c | 80 +++-
Standalone
of TlsAuthConfigDxe, because the
driver is unloaded likely very infrequently.)
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
NetworkPkg/DnsDxe/DnsDriver.c | 4 ++--
NetworkPkg/IScsiDxe/IScsiConfig.c | 2 +-
NetworkPk
t is rarely waited for by applications -- edk2
itself has zero instances of that, for example.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
OvmfPkg/VirtioNetDxe/Events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPk
)
Cc: Ard Biesheuvel
Cc: David Woodhouse
Cc: Jordan Justen
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
b/OvmfPkg/Csm/
NDLE are typedefs to (VOID*). However, we shouldn't use EFI_HANDLE
where semantically EFI_HII_HANDLE is passed around.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Laszlo Ersek
---
Notes:
tested with:
- level 1: stall, exit
- level 2: ls
- level 3: pause
o do with the
registration.
This change is a no-op in practice; it's a semantic improvement.
Cc: Chao Zhang
Cc: Jian Wang
Cc: Jiewen Yao
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
SecurityPkg/HddPassword/HddPasswordDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
The HandleProtocol() boot service takes an EFI_HANDLE, not an
(EFI_HANDLE*). Remove the bogus cast in the
InternalImageHandleToFvHandle() function.
This is a semantic cleanup; there is no change in behavior.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Laszlo Ersek
---
Notes
Cc: Siyuan Fu
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
NetworkPkg/TcpDxe/SockImpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NetworkPkg/TcpDxe/SockImpl.c b/NetworkPkg/TcpDxe/SockImpl.c
index f5e01771e2a8..fb28e2ed40d3 100644
--- a/NetworkPkg
an error path which has likely never fired in practice.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Laszlo Ersek
---
Notes:
tested: edit (saving a file)
ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
not flagged it because EFI_HANDLE (the type of
"ImageHandle") is unfortunately specified as (VOID*), and
(EFI_SYSTEM_TABLE*) converts to (VOID*) silently.
Hand the entry point function's "ImageHandle" parameter to
ReserveResourceInGcd(). This fixes an actual bug.
Cc: Benjamin You
by introducing a helper variable called "Signature", so that
we have to refer to "Entry32" or "Entry64" only once per loop body.
Cc: Benjamin You
Cc: Guo Dong
Cc: Maurice Ma
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
UefiPayloadPkg/BlSupport
t; (EFI_HANDLE*) conversion, which happens implicitly after
dereferencing ParentHandle, with an explicit cast.
In practice, this patch is a no-op.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Laszlo Ersek
---
Notes:
build-tested only
ShellPkg/Library/UefiShellLib/UefiS
ecking edk2 itself.
Thanks
Laszlo
>
> Thanks,
> Ray
>
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
>> Sent: Tuesday, September 17, 2019 12:49 PM
>> To: edk2-devel-groups-io
>> Cc: Achin Gupta ; Andrew Fis
On 09/17/19 22:22, Andrew Fish wrote:
>
>
>> On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote:
>>
>> Laszlo,
>> Thank you very much for this work.
>> They are quite helpful to detect potential issues.
>>
>> But without this specific patch being checked in, future break will still
>> happen.
>> I don'
://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys
>
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Liming Gao
> Signed-off-by: Zhichao Gao
> ---
> MdeModulePkg/Include/Guid/TtyTerm.h | 1
On 09/18/19 00:49, John E Lofgren wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2150
> V3 changes:
> change to mov instruction (non locking instuction) instead
> of xchg to simplify design.
I think something's wrong -- the v3 update described above isn't
actually implemented in the
On 09/17/19 21:10, Michael D Kinney wrote:
> Series Reviewed-by: Michael D Kinney
>
> I also agree that the macros would be cleaner, easy to review, and
> and fewer lines of code without the comment block. If I objected
> previously, then I have also changed my mind. I agree we can go
> ahead a
On 09/18/19 17:16, Kinney, Michael D wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> However, if we wanted to allow new projects to #define
>> STRICTER_UEFI_TYPES as their normal mode of operation
>> (and not just for a sanity check in CI), then we
On 09/18/19 17:55, Andrew Fish wrote:
>
>
>> On Sep 18, 2019, at 1:41 AM, Laszlo Ersek wrote:
>>
>> On 09/17/19 22:22, Andrew Fish wrote:
>>>
>>>
>>>> On Sep 17, 2019, at 1:06 PM, Ni, Ray wrote:
>>>>
>>>> Laszlo,
ng, as the three XCHG instructions are not atomic as a whole (i.e.
they are not locked all together).
Another reason for XCHG could be that they wanted to use just one
register -- but I totally don't see the point of not using BX too.
So:
Reviewed-by: Laszlo Ersek
Thanks,
Laszlo
-=-=-=
Hi Igor,
(+Brijesh)
long-ish pondering ahead, with a question at the end.
On 09/17/19 15:07, Igor Mammedov wrote:
> Use commit (2f295167e0 q35/mch: implement extended TSEG sizes) for
> inspiration and (ab)use reserved register in config space at 0x9c
> offset [*] to extend q35 pci-host with abil
On 09/19/19 04:34, Jian J Wang wrote:
> Update all occurrences of "Jian Wang" to be "Jian J Wang".
>
> Cc: Laszlo Ersek
> Cc: Liming Gao
> Signed-off-by: Jian J Wang
> ---
> Maintainers.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 dele
On 09/19/19 11:44, Leif Lindholm wrote:
> Hi Liming,
>
> On Thu, Sep 19, 2019 at 06:19:42AM +, Gao, Liming wrote:
>> I add my comments.
>>
>>> -Original Message-
>>> From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org]
>>> Sent: Thursday, September 19, 2019 12:05 AM
>>> To:
On 09/19/19 16:56, Gao, Liming wrote:
> Leif:
>
>> -Original Message-
>> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>> Sent: Thursday, September 19, 2019 10:39 PM
>> To: Gao, Liming
>> Cc: Gao, Zhichao ; devel@edk2.groups.io; Andrew Fish
&g
On 09/19/19 04:40, Wang, Cloud wrote:
> Dear Edk2 Base tool owner,
> Do latest edk2 build tool support C99 standard?
C source code in edk2 targets C95 in general. There are a few extensions
that are allowed (such as the __FUNCTION__ macro, "//"-style comments,
...), and there are some surpris
On 09/19/19 20:06, Leif Lindholm wrote:
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Cc: David Woodhouse
> Signed-off-by: Leif Lindholm
> ---
> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c
Hi Ray,
On 08/26/19 00:45, Ni, Ray wrote:
> NOTE: #5/5 will be pushed in 2nd phase after known close-source code in
> another
> repo is updated to use the new PCD PcdCpuSmmRestrictedMemoryAccess.
you've now pushed patch 5/5 as commit 136dad095660, but you forgot to
update the UNI file, which is
On 09/20/19 10:28, Igor Mammedov wrote:
> On Thu, 19 Sep 2019 19:02:07 +0200
> "Laszlo Ersek" wrote:
>
>> Hi Igor,
>>
>> (+Brijesh)
>>
>> long-ish pondering ahead, with a question at the end.
> [...]
>
>> Finally: can you please re
On 09/20/19 11:28, Laszlo Ersek wrote:
> On 09/20/19 10:28, Igor Mammedov wrote:
>> On Thu, 19 Sep 2019 19:02:07 +0200
>> "Laszlo Ersek" wrote:
>>
>>> Hi Igor,
>>>
>>> (+Brijesh)
>>>
>>> long-ish pondering ahead, with a q
Ard Biesheuvel
Cc: Boris Ostrovsky
Cc: Brijesh Singh
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Joao M Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: L
vector requested in the INIT-SIPI-SIPI.
Cc: Ard Biesheuvel
Cc: Boris Ostrovsky
Cc: Brijesh Singh
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Joao M Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Thanks
Laszlo
Laszlo
.
Cc: Ard Biesheuvel
Cc: Boris Ostrovsky
Cc: Brijesh Singh
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Joao M Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: La
ey
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 1 +
OvmfPkg/SmmAccess/SmmAccessPei.inf | 1 +
OvmfPkg/SmmAccess/SmramInternal.h | 8 +++
OvmfPkg/S
ijesh Singh
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Joao M Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
OvmfPkg/PlatformPei/MemDet
ned-off-by: Laszlo Ersek
---
OvmfPkg/PlatformPei/PlatformPei.inf | 1 +
OvmfPkg/PlatformPei/Platform.h | 7 +++
OvmfPkg/PlatformPei/MemDetect.c | 18 ++
OvmfPkg/PlatformPei/Platform.c | 1 +
4 files changed, 27 insertions(+)
diff --git a/OvmfPkg/P
medov
Cc: Jiewen Yao
Cc: Joao M Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Include/IndustryStandard/Q35MchIch9.h | 6
Ostrovsky
Cc: Brijesh Singh
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Joao M Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
OvmfPkg
Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
OvmfPkg/PlatformPei/MemDetect.c | 13 +--
OvmfPkg/PlatformPei/Platform.c | 23
Cc: Igor Mammedov
Cc: Jiewen Yao
Cc: Joao M Martins
Cc: Jordan Justen
Cc: Jun Nakajima
Cc: Michael Kinney
Cc: Paolo Bonzini
Cc: Phillip Goerl
Cc: Yingwen Chen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
OvmfPkg/PlatformPei/MemDetect.c | 11
://bugzilla.tianocore.org/show_bug.cgi?id=1512
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 4
OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 21 +++--
OvmfPkg/PlatformPei/AmdSev.c| 24
On 09/19/19 21:52, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> Create a function that can be used to determine if the VM is running
> as an SEV-ES guest.
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
>
t; is active, set the SEV-ES active PCD (PcdSevEsActive).
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Signed-off-by: Tom Lendacky
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 3 +++
> OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++
> OvmfPkg
t is active during the SEV check and uses the
> OVMF temporary RAM space for a stack. After the SEV check is complete, the
> exception handling support is removed and the stack pointer cleared.
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Signed-off-by: Tom
On 09/24/19 15:42, Laszlo Ersek wrote:
> On 09/19/19 21:52, Lendacky, Thomas wrote:
>> +mov esp, SEV_TOP_OF_STACK
> (3) Do we have an estimate how much stack we need? This would be a
> constraint on PcdOvmfSecPeiTempRamSize. The limit would be nice to
> document (pe
On 09/20/19 12:24, Leif Lindholm wrote:
>
> On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote:
>> On 09/19/19 20:06, Leif Lindholm wrote:
>>> Cc: Jordan Justen
>>> Cc: Laszlo Ersek
>>> Cc: Ard Biesheuvel
>>> Cc: Anthony Perar
On 09/24/19 12:41, Philippe Mathieu-Daudé wrote:
> Hi Liming,
>
> On 9/24/19 3:19 AM, Liming Gao wrote:
>> ShellBinPkg is generated for each edk2 stable tag release.
>>
>> Cc: Andrew Fish
>> Cc: Laszlo Ersek
>> Cc: Leif Lindholm
>> Cc: M
Hi Liming,
On 09/24/19 03:19, Liming Gao wrote:
> ShellBinPkg is generated for each edk2 stable tag release.
>
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Liming Gao
> ---
> Maintainers.txt | 13 ++-
On 09/23/19 13:45, Philippe Mathieu-Daudé wrote:
> On 9/17/19 9:49 PM, Laszlo Ersek wrote:
>> The HiiConstructConfigHdr() function takes the "DriverHandle" parameter in
>> order to fetch the device path from it, and then turn the device path into
>> PATH
On 09/23/19 17:08, Philippe Mathieu-Daudé wrote:
> On 9/17/19 9:49 PM, Laszlo Ersek wrote:
>> The last parameter of ReserveResourceInGcd() is "ImageHandle", forwarded
>> in turn to gDS->AllocateMemorySpace() or gDS->AllocateIoSpace() as "owner"
>> i
On 09/23/19 18:27, Marvin Häuser wrote:
> Good day,
>
> Thank you, Laszlo, for your ambition to introduce stricter code style
> enforcements. Sorry to "hijack" the actual topic (I did not CC anyone on
> purpose, as this is mostly a separate topic and I'd like a quick comment
> first), but this
On 09/24/19 07:54, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2212
>
> Current S3BootScriptLib can only support build time opt-out
I think this problem statement is wrong.
In the OVMF platform anyway, PiDxeS3BootScriptLib is linked into the following
two modules:
ecedent.
I'd be willing to fix up (2) for you just before pushing, but I can't
touch (1).
With (1) and (2) fixed, for v2:
Reviewed-by: Laszlo Ersek
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47997): htt
GHCB page table entry to remove the encryption mask.
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Signed-off-by: Tom Lendacky
> ---
> OvmfPkg/OvmfPkg.dec | 10 +++
> OvmfPkg/OvmfPkgX64.fdf| 6 ++
> OvmfPkg/R
s in (1a), which is fine because (1b) reserved it.
(3) s/1a/a/; s/1b/b/
(Also, the original refers to (1c) rather than (1b), and that's not a
typo; but this variant looks just as fine.)
>
> (e) how it is accessed on the warm reset path
>
> It is rewritten same as in
On 09/24/19 20:57, Lendacky, Thomas wrote:
> On 9/24/19 8:42 AM, Laszlo Ersek wrote:
>> On 09/19/19 21:52, Lendacky, Thomas wrote:
>>> +mov esp, SEV_TOP_OF_STACK
>>
>> (2) Can we %define SEV_TOP_OF_STACK in this file, or does it have to be
>> in &qu
701 - 800 of 4419 matches
Mail list logo
