[edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard functions

Rename the standard functions in the LibFdtSupport to remove conflicts with other libraries that define them. Signed-off-by: Jeff Brasen --- MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 16 +++ MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 25 ++- 2 files changed, 18

[edk2-devel] [PATCH] MdePkg: Add FdtLib gmock support

Add Google Mock Library for FdtLib Signed-off-by: Jeff Brasen --- .../Include/GoogleTest/Library/MockFdtLib.h | 165 ++ .../GoogleTest/MockFdtLib/MockFdtLib.cpp | 34 .../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++ 3 files changed, 227 insertions(+) create

[edk2-devel] [PATCH] EmbeddedPkg: Add DtPlatformLoaderLib gmock support

Add Google Mock Library for DtPlatformLoaderDtbLib Signed-off-by: Jeff Brasen --- EmbeddedPkg/EmbeddedPkg.dec | 1 + .../Library/MockDtPlatformDtbLoaderLib.h | 31 +++ .../MockDtPlatformDtbLoaderLib.cpp| 13 .../MockDtPlatformDtbLoader

[edk2-devel] [PATCH] EmbeddedPkg/PrePiMemoryAllocationLib: Add ReallocatePool

Add implementation of ReallocatePool which is defined in the MemoryAllocationLib header file to allow components to not need special handling for PrePi module types. Signed-off-by: Jeff Brasen --- .../MemoryAllocationLib.c | 57 +++ 1 file changed, 57 insertio

Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard functions

seFdtLib: Rename standard > functions > > External email: Use caution opening links or attachments > > > On Mon, Dec 11, 2023 at 3:40 PM Jeff Brasen via groups.io > wrote: > > > > Jeff, > > You're missing CC's on this patch. Also, you should p

Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiMemoryAllocationLib: Add ReallocatePool

Looks like I missed an UINTN cast will fix and push a v2. > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, December 21, 2023 7:54 AM > To: Chang, Abner > Cc: Jeff Brasen ; devel@edk2.groups.io; > ardb+tianoc...@kernel.org; quic_llind...@quicinc.com > Subject: Re: [PATCH] Em

[edk2-devel] [PATCH v2 0/3] EmbeddedPkg ReallocatePool and Mock changes

Adding Mock support for DtPlatformLoaderLib and changing ci.yaml to support this Adding ReallocatePool support to PrePi Library. Passing CI in https://github.com/tianocore/edk2/pull/5197 Change log v2 - Fix uncrustify errors Fix ci allowed packages entries Fix cast on 32-bit systems Jeff B

[edk2-devel] [PATCH v2 2/3] EmbeddedPkg: Add host based dependency to ci

Add UnitTestFrameworkPkg to AcceptableDependencies-HOST_APPLICATION list Signed-off-by: Jeff Brasen --- EmbeddedPkg/EmbeddedPkg.ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/EmbeddedPkg.ci.yaml b/EmbeddedPkg/EmbeddedPkg.ci.yaml index 96a60a6f8b4d..6d0

[edk2-devel] [PATCH v2 1/3] EmbeddedPkg/PrePiMemoryAllocationLib: Add ReallocatePool

Add implementation of ReallocatePool which is defined in the MemoryAllocationLib header file to allow components to not need special handling for PrePi module types. Signed-off-by: Jeff Brasen --- .../MemoryAllocationLib.c | 57 +++ 1 file changed, 57 insertio

[edk2-devel] [PATCH v2 3/3] EmbeddedPkg: Add DtPlatformLoaderLib gmock support

Add Google Mock Library for DtPlatformLoaderDtbLib Signed-off-by: Jeff Brasen --- EmbeddedPkg/EmbeddedPkg.dec | 1 + .../MockDtPlatformDtbLoaderLib.inf| 29 + .../Library/MockDtPlatformDtbLoaderLib.h | 31 +++ .../MockDtPlatform

Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard functions

cato > > Sent: Monday, December 11, 2023 9:00 AM > > To: devel@edk2.groups.io; Jeff Brasen > > Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard > > functions > > > > External email: Use caution opening links or attachments > > > > &g

Re: [edk2-devel] [PATCH] MdePkg: Add FdtLib gmock support

Any comments on this patch? Thanks, Jeff > -Original Message- > From: Jeff Brasen > Sent: Monday, December 11, 2023 8:43 AM > To: devel@edk2.groups.io > Cc: gaolim...@byosoft.com.cn; michael.d.kin...@intel.com; > zhiguang@intel.com; Jeff Brasen > Subject: [PATCH] MdePkg: Add FdtLib

[edk2-devel] [PATCH v2 1/1] MdePkg: Add FdtLib gmock support

Add Google Mock Library for FdtLib Signed-off-by: Jeff Brasen --- .../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++ .../Include/GoogleTest/Library/MockFdtLib.h | 164 ++ .../GoogleTest/MockFdtLib/MockFdtLib.cpp | 34 3 files changed, 226 insertions(+) create

[edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename standard functions

Rename the standard functions in the LibFdtSupport to remove conflicts with other libraries that define them. Signed-off-by: Jeff Brasen --- MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 7 +-- MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 25 ++- 2 files changed, 7 insertio

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add FdtLib gmock support

Oops not sure how that happened will fix and push a v3. -Jeff > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, January 23, 2024 4:52 PM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: gaolim...@byosoft.com.cn; Liu, Zhiguang ; > Kinney, Michael D > Subject: RE: [PATCH v2

[edk2-devel] [PATCH v3 1/1] MdePkg: Add FdtLib gmock support

Add Google Mock Library for FdtLib Signed-off-by: Jeff Brasen --- MdePkg/Test/MdePkgHostTest.dsc| 1 + .../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++ .../Include/GoogleTest/Library/MockFdtLib.h | 164 ++ .../GoogleTest/MockFdtLib/MockFdtLib.cpp

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

Anything else needed to get this merged would as the November stable release is coming up. Thanks, Jeff > -Original Message- > From: gaoliming > Sent: Friday, October 6, 2023 11:23 PM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: jian.j.w...@intel.com; dandan...@intel.com; Ashish Singh

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

Anything else needed to get this merged as the November stable release is coming up. Thanks, Jeff > -Original Message- > From: Gao, Zhichao > Sent: Monday, October 16, 2023 8:39 PM > To: Jeff Brasen ; Gao, Liming > ; devel@edk2.groups.io > Cc: Wang, Jian J ; Bi, Dandan > > Subject: RE:

[edk2-devel] HII Keyword utility

I have a UEFI shell application that can set/get UEFI x-UEFI HII Keyword values. edk2-nvidia/Silicon/NVIDIA/Application/HiiKeywordUtil at main · NVIDIA/edk2-nvidia (github.com) ( https://github.com/NVIDIA/edk2-nvidia/tree/main/Silicon/NVIDIA/Application/HiiKeywordUtil ) I have used this to con

Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

I'll post another version to fix the formatting issue in a bit, but before the patch the issue was we applied the alignment offset before we did a space check. -Jeff > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 7, 2022 2:34 AM > To: Jeff Brasen > Cc: devel@

[edk2-devel] [PATCH 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 211 +- 1 file changed, 206 insertions(+), 5 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 146 -- .../C

[edk2-devel] [PATCH 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Jeff Brasen (3): DynamicTablesPkg: Add CM_ARM_CPC_INFO object DynamicTablesPkg: AML Code generation to add _CPC entries Dynam

[edk2-devel] [PATCH v2] EmbeddedPkg/PrePiMemoryAllocationLib: Check for space on offset allocation

Update check for enough space to occur prior to alignment offset modification. This prevents a case where EfiFreeMemoryTop could be less than EfiFreeMemoryBottom Signed-off-by: Jeff Brasen --- .../MemoryAllocationLib.c | 53 +++ 1 file changed, 30 inser

Re: [edk2-devel] [PATCH v2] EmbeddedPkg/PrePiMemoryAllocationLib: Check for space on offset allocation

> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 7, 2022 10:16 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; ardb+tianoc...@kernel.org; > abner.ch...@amd.com; g...@danielschaefer.me; quic_llind...@quicinc.com > Subject: Re: [PATCH v2] EmbeddedPkg/PrePiMemoryAl

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

CH v2] > MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer > > External email: Use caution opening links or attachments > > > On Fri, 5 Aug 2022 at 18:56, Jeff Brasen via groups.io > wrote: > > > > > > > > > -Original Message- >

[edk2-devel] [PATCH v2 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. Jeff Br

[edk2-devel] [PATCH v2 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 223 +- 1 file changed, 217 insertions(+), 6 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH v2 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 148 -- .../C

[edk2-devel] [PATCH v2 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 148 -- .../C

[edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 223 +- 1 file changed, 217 insertions(+), 6 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH v3 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 - Min

[edk2-devel] [PATCH v3 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH v4 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 60 ++--- DynamicTablesP

[edk2-devel] [PATCH v4 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH v4 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 133 +- 1 file changed, 127 insertions(+), 6 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH v4 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 - Min

Re: [edk2-devel] [PATCH v4 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

Thanks will fix those in v5. Will see if Sami has any other comments before pushing these. -Jeff > -Original Message- > From: Pierre Gondois > Sent: Tuesday, September 20, 2022 8:54 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; alexei.fedo...@arm.com; n.

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

> > Subject: Re: [edk2-devel] [PATCH v2] > > > MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer > > > > > > External email: Use caution opening links or attachments > > > > > > > > > On Fri, 5 Aug 2022 at 18:56, Jeff Br

[edk2-devel] [PATCH v5 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 - Min

[edk2-devel] [PATCH v5 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 60 ++--- DynamicTablesP

[edk2-devel] [PATCH v5 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH v5 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 133 +- 1 file changed, 127 insertions(+), 6 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH v3] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

Update check for enough space to occur prior to alignment offset. This prevents cases where EfiFreeMemoryTop < EfiFreeMemoryBottom. Change-Id: I58c5d378523c881a4afc655e7ace4c009130c781 --- .../MemoryAllocationLib.c | 48 --- 1 file changed, 21 insertions(

[edk2-devel] [PATCH v3] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

Update check for enough space to occur prior to alignment offset. This prevents cases where EfiFreeMemoryTop < EfiFreeMemoryBottom. Signed-off-by: Jeff Brasen --- .../MemoryAllocationLib.c | 48 --- 1 file changed, 21 insertions(+), 27 deletions(-) di

Re: [edk2-devel] [PATCH v5 0/3] DynamicTablesPkg: _CPC support

Those changes look good to me. Thanks, Jeff > -Original Message- > From: Sami Mujawar > Sent: Friday, September 23, 2022 10:55 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; alexei.fedo...@arm.com; > pierre.gond...@arm.com; n...@arm.com > Subject: Re: [PATCH

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

rnel.org > Subject: Re: [edk2-devel] [PATCH v2] > MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer > > External email: Use caution opening links or attachments > > > On Wed, 21 Sept 2022 at 18:27, Jeff Brasen via groups.io > wrote: > > > >

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

; > > > External email: Use caution opening links or attachments > > > > > > Jeff: > > I want to confirm why UFS apply the same rule to SCSI. Does UFS > > follows SCSI spec? > > > > Thanks > > Liming > > > -邮件原件- > >

[edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

Add support for getting disk info from UFS devices. Signed-off-by: Jeff Brasen --- MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 4 +++- .../Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/MdeModuleP

Re: [edk2-devel] Question on TPL in PCD/Variable code

I am trying to get variable services hosted on a UFS device and running into TPL related issues. The variable and PCD code have locks that raise the TPL to NOTIFY prior to calling into the FVB instance and the UFS driver has a few raise tpl calls that increase the TPL to TPL_CALLBACK. This is ca

[edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY

Increase TPL to TPL_NOTIFY to allow for use if caller is > TPL_CALLBACK. This allows services like variable services that run at TPL_NOTIFY to be hosted on ScsiDisks (i.e. UFS) Aligns with the eMMC driver that also uses a higher TPL. This change was made in 3b1d8241d0dac25c5e678c364fa2754ac1731060

Re: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY

> -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 14, 2021 8:00 PM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY > > External email: Use caution opening links or attachments > > > > -Origi

[edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial free

Add support for partial free of non cached buffers. If a request for less than the full size is requested new allocations for the remaining head and tail of the buffer are added to the list. The XHCI driver does this if the page size for the controller is >4KB. Signed-off-by: Jeff Brasen --- ...

[edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

Add support for partial free of non cached buffers. If a request for less than the full size is requested new allocations for the remaining head and tail of the buffer are added to the list. Added verification that Buffer is EFI_PAGE_SIZE aligned. The XHCI driver does this if the page size for the

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

CH v2] > MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer > > External email: Use caution opening links or attachments > > > Deepthi, > Can you please help to review the changes and provide comments? > > Thanks, > Ray > > -Original Message- >

Re: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY

Resuming this PATCH to see if there are any additional thoughts on this. In response to the query about DXE/BDS services we have some internal connection logic that runs in DXE to connect the devices that are needed for arch services that have to be connected prior the end of dxe. Thanks, Jeff

[edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, it can be used in a media device path to specify a Linux style initrd that can be loaded by the OS using the LoadFile2 protocol. Move these defines to MdePkg from OvmfPkg as these are relevant to non-OVMF targets as well. Ref:

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

EDK II extensions. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jeff Brasen > via groups.io > Sent: Thursday, July 15, 2021 11:08 AM > To: devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; Kinney, Michael D > ; Justen, Jordan L > ; g

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

In my opinion MdePkg is where this should be as it is meant to be used by multiple software entities (linux kernel, grub, edk2, coreboot w/ uefi binding) and probably should be documented in some spec (Although, I am not sure which one would make sense) I am fine with MdeModulePkg as well thoug

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Does this look good for text to add "Linux distro boot generally relies on an initial ramdisk (initrd) which is provided by the loader, and which contains additional kernel modules (for storage and network, for instance), and the initial user space startup code, i.e., the code which brings up the

[edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, it can be used in a media device path to specify a Linux style initrd that can be loaded by the OS using the LoadFile2 protocol. Move these defines to MdePkg from OvmfPkg as these are relevant to non-OVMF targets as well. Ref:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Mike, do the comments in this patch work for you? Would be nice to get this in prior to the 8/9 freeze if possible. Thanks, Jeff From: Ard Biesheuvel Sent: Tuesday, July 27, 2021 10:48 AM To: Jeff Brasen Cc: edk2-devel-groups-io ; Ard Biesheuvel ; Michael Ki

[edk2-devel] [PATCH v3 0/2] Relocate LINUX_EFI_INITRD_MEDIA_GUID to MdePkg

Relocate LINUX_EFI_INITRD_MEDIA_GUID from OvmfPkg to MdePkg as it has use outside of Ovmf applications Jeff Brasen (2): OvmfPkg: Remove Initrd LINUX_EFI_INITRD_MEDIA_GUID MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID MdePkg/MdePkg.dec | 5 OvmfPkg/OvmfP

[edk2-devel] [PATCH v3 1/2] OvmfPkg: Remove Initrd LINUX_EFI_INITRD_MEDIA_GUID

Moving LINUX_EFI_INITRD_MEDIA_GUID to MdePkg, remove it from OvmfPkg. Signed-off-by: Jeff Brasen Reviewed-by: Michael D Kinney Acked-by: Ard Biesheuvel --- OvmfPkg/OvmfPkg.dec| 1 - OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h | 17 ---

[edk2-devel] [PATCH v3 2/2] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, it can be used in a media device path to specify a Linux style initrd that can be loaded by the OS using the LoadFile2 protocol. Move these defines to MdePkg from OvmfPkg as these are relevant to non-OVMF targets as well. Ref:

[edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

SctAPrint uses boot services functions but is called after ExitBootServices. Replace with call to Printf which is safe for use in runtime. Signed-off-by: Jeff Brasen --- .../SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c | 52 +-- uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c| 52 +++

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

Any thoughts/feedback on this patch? Thanks, Jeff > -Original Message- > From: Jeff Brasen > Sent: Monday, May 15, 2023 5:49 PM > To: devel@edk2.groups.io > Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; dandan...@intel.com; > Jeff Brasen ; Ashish Singhal > > Subject: [PATCH] Md

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

Any additional thoughts/feedback on this patch series? Thanks, Jeff > -Original Message- > From: Jeff Brasen > Sent: Friday, June 30, 2023 11:30 AM > To: devel@edk2.groups.io > Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; dandan...@intel.com; > zhichao@intel.com; Jeff Bras

[edk2-devel] [PATCH v3 0/4] Add support for generating ACPI ThermalZones

Add APIs needed to create thermal zones dynamically. Does not add a generator for this as creating the TMP method generically may be difficult. Change log: v3 - Fixed a couple error handling paths v2 - renamed NameString function and added goto dones in a couple error cases Jeff Brasen (4): Dy

[edk2-devel] [PATCH v3 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API

Add API to generate a Name that contains a Unicode string buffer. Bug 4063340 Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 31 +++ .../Common/AmlLib/CodeGen/AmlCodeGen.c| 86 ++

[edk2-devel] [PATCH v3 3/4] DynamicTablesPkg: Add support to add Strings to package

Add API to add a String to a package created with NamedPackage API. Bug 4063340 Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 17 .../Common/AmlLib/CodeGen/AmlCodeGen.c| 88 +++

[edk2-devel] [PATCH v3 2/4] DynamicTablesPkg: Add support for simple method invocation.

Add support to add Return objects via AML that pass a single integer argument to the named method. Bug 4063340 Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 54 .../Common/AmlLib/Cod

[edk2-devel] [PATCH v3 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function

Add API to generate a ThermalZone object to AmlLib. Bug 4063340 Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 28 + .../Common/AmlLib/CodeGen/AmlCodeGen.c| 116

[edk2-devel] [PATCH 1/2] DynamicTablesPkg: AML Code generation for I/O ranges

From: Vidya Sagar Add helper functions to generate AML Resource Data describing I/O ranges of four words long. API AmlCodeGenRdQWordIo () is exposed. Reviewed-by: Shanker Donthineni Signed-off-by: Vidya Sagar Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 67 +

[edk2-devel] [PATCH 0/2] Add support for PCI IO using Qword resources

Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses can be used to generate I/O packets over the PCIe bus. Vidya Sagar (2): DynamicTablesPkg: AML Code generation for I/O ranges DynamicTablesPkg: AcpiSsdtP

[edk2-devel] [PATCH 2/2] DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord to describe I/O range

From: Vidya Sagar Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses can be used to generate I/O packets over the PCIe bus. Reviewed-by: Shanker Donthineni Signed-off-by: Vidya Sagar Signed-off-by: Jeff

Re: [edk2-devel] [PATCH 1/2] DynamicTablesPkg: AML Code generation for I/O ranges

Regarding the signed-off-by I wasn't sure the right way to handle this. Vidya was the author of this patch and applied the signed off on our internal repo during development. I was upstreaming it on his behalf. I was unsure if I should just replace his as I assumed just leaving his from this wou

[edk2-devel] [PATCH v4 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function

Add API to generate a ThermalZone object to AmlLib. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 28 + .../Common/AmlLib/CodeGen/AmlCodeGen.c| 116 ++ 2 files changed, 144 insertions(+) diff --git a/DynamicTablesPkg/Include/

[edk2-devel] [PATCH v4 0/4] Add support for generating ACPI ThermalZones

Add APIs needed to create thermal zones dynamically. Does not add a generator for this as creating the TMP method generically may be difficult. Change log: v4 - Fixed an additional error handling path v3 - Fixed a couple error handling paths v2 - renamed NameString function and added goto dones i

[edk2-devel] [PATCH v4 2/4] DynamicTablesPkg: Add support for simple method invocation.

Add support to add Return objects via AML that pass a single integer argument to the named method. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 54 .../Common/AmlLib/CodeGen/AmlCodeGen.c| 244 ++ 2 files changed, 298 insertio

[edk2-devel] [PATCH v4 3/4] DynamicTablesPkg: Add support to add Strings to package

Add API to add a String to a package created with NamedPackage API. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 17 .../Common/AmlLib/CodeGen/AmlCodeGen.c| 88 +++ 2 files changed, 105 insertions(+) diff --git a/DynamicTabl

[edk2-devel] [PATCH v4 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API

Add API to generate a Name that contains a Unicode string buffer. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 31 +++ .../Common/AmlLib/CodeGen/AmlCodeGen.c| 86 +++ 2 files changed, 117 insertions(+) diff --git a/DynamicTab

Re: [edk2-devel] [PATCH v4 3/4] DynamicTablesPkg: Add support to add Strings to package

Hi Sami, That sounds good. Thanks, Jeff > -Original Message- > From: Sami Mujawar > Sent: Thursday, September 21, 2023 10:50 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: pierre.gond...@arm.com; Swatisri Kantamsetti ; > Ashish Singhal ; n...@arm.com > Subject: Re: [PATCH v4 3/4] D

Re: [edk2-devel] [PATCH v4 2/4] DynamicTablesPkg: Add support for simple method invocation.

Only thing I see is if AmlCodeGenInteger fails we don’t delete DataNode right? From: Sami Mujawar Sent: Thursday, September 21, 2023 10:49 AM To: Jeff Brasen ; devel@edk2.groups.io Cc: pierre.gond...@arm.com; Swatisri Kantamsetti ; Ashish Singhal ; n...@arm.com Subject: Re: [PATCH v4 2/4] Dynami

[edk2-devel] [PATCH v2 0/2] Add support for PCI IO using Qword resources

Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses can be used to generate I/O packets over the PCIe bus. Changes: v2 - Rebased and set transferEncoding = 8bit Vidya Sagar (2): DynamicTablesPkg: AML Code

[edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: AML Code generation for I/O ranges

From: Vidya Sagar Add helper functions to generate AML Resource Data describing I/O ranges of four words long. API AmlCodeGenRdQWordIo () is exposed. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 67 ++ .../AmlLib/CodeGen/AmlResourceDataCodeGen.c

[edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord todescribe I/O range

From: Vidya Sagar Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses can be used to generate I/O packets over the PCIe bus. Signed-off-by: Jeff Brasen --- .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcie

Re: [edk2-devel] [PATCH v4 2/4] DynamicTablesPkg: Add support for simple method invocation.

I see you swapped the order of the functions, that looks good and avoids special handling for that case. That looks good to me. Thanks, Jeff From: Sami Mujawar Sent: Thursday, September 21, 2023 2:07 PM To: Jeff Brasen ; devel@edk2.groups.io Cc: Pierre Gondois ; Swatisri Kantamsetti ; Ashish S

Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg/AmlLib: Define an enum for IsaRanges

Reviewed-by: Jeff Brasen > -Original Message- > From: pierre.gond...@arm.com > Sent: Friday, September 22, 2023 8:18 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Leif Lindholm > ; Jeff Brasen > Subject: [PATCH 1/1] DynamicTablesPkg/AmlLib: Define an enum for > IsaRanges > > Exter

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

Anything else needed on this to get it merged? Thanks, Jeff > -Original Message- > From: gaoliming > Sent: Tuesday, September 12, 2023 6:59 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: jian.j.w...@intel.com; dandan...@intel.com; zhichao@intel.com > Subject: 回复: [PATCH v2 0/2] dp

Re: [edk2-devel] [PATCH] ArmPkg/ArmPsciMpServices Add EFI_NOT_READY return

.com > Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmPsciMpServices Add > EFI_NOT_READY return > > External email: Use caution opening links or attachments > > > On Thu, 29 Jun 2023 at 22:47, Jeff Brasen via groups.io > wrote: > > > > Add EFI_NOT_READY return if the

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

Anyone have any thoughts on this patch? Thanks, Jeff > -Original Message- > From: Jeff Brasen > Sent: Monday, September 11, 2023 2:14 PM > To: devel@edk2.groups.io > Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; > dandan...@intel.com; Ashish Singhal > Subject: RE: [PATCH] MdeMod

[edk2-devel] [PATCH 2/2] ShellPkg/AcpiView: APMT Parser

Add a new parser for the Arm Performance Monitoring Unit Table. The APMT table describes the properties of PMU support implemented by components in an Arm-based system. Signed-off-by: Jeff Brasen --- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 21 .../Parsers/Apmt/ApmtParser.c

[edk2-devel] [PATCH 1/2] MdePkg/IndustryStandard: add definitions for ACPI APMT

This adds #defines and struct typedefs for the various node types in the ACPI Arm Performance Monitoring Unit (APMT) table. Signed-off-by: Jeff Brasen --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 ++ .../ArmPerformanceMonitoringUnitTable.h | 69 +++ 2 file

[edk2-devel] [PATCH v2 2/2] ShellPkg/AcpiView: APMT Parser

Add a new parser for the Arm Performance Monitoring Unit Table. The APMT table describes the properties of PMU support implemented by components in an Arm-based system. Signed-off-by: Jeff Brasen --- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 21 .../Parsers/Apmt/ApmtParser.c

[edk2-devel] [PATCH v2 1/2] MdePkg/IndustryStandard: add definitions for ACPI APMT

This adds #defines and struct typedefs for the various node types in the ACPI Arm Performance Monitoring Unit (APMT) table. Signed-off-by: Jeff Brasen --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 ++ .../ArmPerformanceMonitoringUnitTable.h | 69 +++ 2 file

[edk2-devel] [PATCH] DynamicTablesPkg: Allow for specified CPU names

Allow object to specify the name of processor and processor container nodes and the UID of processor containers. This allows these to be more accurately referenced from other tables. For example for the _PSL method or the UID in the APMT table. The UID and Name for processor container may b

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Allow for specified CPU names

This was the simplest approach that I had to solve this issue, but not sure if it would be better to do something smarter. A couple other ideas I had where: - Specify the affinity level that CPUs use and use the levels above that for the containers. - Have a new object that has the container leve

  1   2   3   >