[edk2-devel] [PATCH] EmulatorPkg/WinHost: Add EFI_BUFFER_TOO_SMALL for return status.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2605 I think it is necessary that check the buffer size before ReadFile, it will inform the caller that they should provide more buffer. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/Win/Host

Re: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add EFI_BUFFER_TOO_SMALL for return status.

turn status. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2605 > > > > I think it is necessary that check the buffer size before ReadFile, it > > will inform the caller that they should provide more buffer. > > > > Cc: Jordan Justen

[edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- .../IntelPciDeviceSecurityDxe

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Invalid index may be used.

Hi Michael, Sean, Bret, Could help review the patch? Thanks > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Wednesday, March 4, 2020 3:59 PM > To: devel@edk2.groups.io; newexplor...@gmail.com > Subject: Re: [edk2-devel

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Check Suite pointer before use.

Hi Michael, Sean, Bret, Could you review the patch? Thanks > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, March 12, 2020 2:02 PM > To: devel@edk2.groups.io; newexplor...@gmail.com > Cc: Kinney, Michael D ;

Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData

Hi Michael, Liming, Could you help review the patch. Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 1:58 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Kinney, Michael D > ; Gao, Liming > Subj

Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments

Hi Ray, Rangasai, Could you help review the patch. Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Monday, March 9, 2020 9:21 AM > To: devel@edk2.groups.io; newexplor...@gmail.com > Subject: Re: [edk2-devel] [

Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference

Hi Xuwei, QinKun, Have you indeed encounter this issue or just think it is potential issue. I think below code will always initialize the mFmpImageInfoBuf[] and make sure it is valid. Line 585 - mFmpImageInfoBuf[Index] = AllocateZeroPool (ImageInfoSize); If the second GetImageInfo() is runned,

Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference

Hi Kun, It is clear and i have no confusion. Reviewed-by: Guomin Jiang Thanks guomin From: Kun Qin [mailto:kun@microsoft.com] Sent: Monday, March 23, 2020 3:40 PM To: Jiang, Guomin ; devel@edk2.groups.io; Kinney, Michael D ; Xu, Wei6 Cc: Gao, Liming Subject: RE: [edk2-devel] [PATCH

[edk2-devel] [PATCH v4] MdePkg/UnitTestBaseLib: Add check for pointer BinData

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531 AllocatePool may fail and BinData may be invalid, check it before use. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Guomin Jiang --- MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 4 +++- 1 file changed, 3 insertions

[edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2587 SmmAccessLib.h and ConfigBlockLib.h is the primary header file in IntelSiliconPkg. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 8 1 file changed, 8

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SdDxe: Potential NULL pointer on Token

Hi Ray, Hao Could you please help review this changes. Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Wednesday, March 4, 2020 5:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wu, Hao A > ; Ni, Ray > Subject: [edk2

[edk2-devel] [PATCH v3] MdeModulePkg/SdDxe: Check the Token to avoid null pointer

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2286 Token pointer may be NULL, it should be checked before use it. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Guomin Jiang --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 9 - 1 file changed, 8 insertions(+), 1 deletion

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

It is a good idea, I have a question: 1. When can detect the jumper signal or register? 2. If the jumper use GPIO, SerialUartClockLib will depend on GpioLib? 3. If the register is inside SIO, how to dispose the dependence? If it is too complex to implement the SerialUartClockLib, the project owne

Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid

Hi Jian, Hao, Could you please help review the change. Thanks Original message From: "GuoMinJ via Groups.Io" mailto:newexplorerj=gmail@groups.io>> Date: Fri, Feb 21, 2020, 6:10 PM To: devel@edk2.groups.io Cc: GuoMinJ mailto:newexplor...@gmail.co

Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP

Add commets in your original message > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Yau > Sent: Friday, March 20, 2020 11:42 AM > To: devel@edk2.groups.io > Cc: Yau, KaiX > Subject: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR > di

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

Hi Pankaj, I know your consideration. My consideration is that we provide an interface, it should be better for user, it not, the user won't use it and if no nobody use it, why provide it? In other word, the effort for copying the SerialPortLib and the effort for implementing SerialUartClockLib

Re: [edk2-devel] [PATCH] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

Hi Jian, Hao, Could you please help review this change? Thanks From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of GuoMinJ Sent: Thursday, March 26, 2020 2:11 PM To: devel@edk2.groups.io; newexplor...@gmail.com; GuoMinJ via Groups.Io Cc: Wang, Jian J ; Wu, Hao A Subject: Re:

[edk2-devel] [PATCH v2] CryptoPkg/Pkcs7: Extend support for other OID types

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539 Microsoft signtool supports creation of attached P7's with any OID payload via the "/p7co" parameter. It is necessary to check the data before get the string. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-b

[edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

the build. To solve this problem, the FltUsedLib was created that is one spot that the global static can exist. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Guomin Jiang --- CryptoPkg/CryptoPkg.dsc | 2 ++ .../Library/BaseCryptLib/BaseCryptLib.inf | 1 + .../Library

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

gt; > Cc: Wang, Jian J ; Lu, XiaoyuX > ; Yao, Jiewen ; Sean Brogan > ; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > On 03/30/20 11:02, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 10:52, Guo

[edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2608 According to logic and the practice, it is need to allocate ascii length by 2 for unicode string. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- .../UnitTestPersistenceLibSimpleFileSystem.c

[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

ret Barkelew Signed-off-by: Guomin Jiang --- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c index b136992

Re: [edk2-devel] [PATCH v3 2/3] MdeModulePkg VariablePei: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Monday, March 30, 2020 12:19 PM > To: michael.kuba...@outlook.com; devel@edk2.groups.io > Cc: Bret Barkelew ; Gao, Liming >

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

There is a spell error in the comments of VariableServiceGetVariable() in Variable.c. - @return EFI_BUFFER_TO_SMALL DataSize is too small for the result. + @return EFI_BUFFER_TOO_SMALLDataSize is too small for the result. Need create new bugs for it or fix in this comment directly? > -

[edk2-devel] [PATCH] SecurityPkg/MeasureBootLib: Return EFI_ACCESS_DENIED after image check fail

4b026f0d5af36faf3a3629a3ad49c51b5b3be12f. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Guomin Jiang --- .../DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 14 +++--- .../DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c| 14 +++--- 2 files changed, 14 insertions

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

It is ok, I have no others confusion. Reviewed-by: Guomin Jiang > -Original Message- > From: Michael Kubacki [mailto:michael.kuba...@outlook.com] > Sent: Wednesday, April 1, 2020 1:12 AM > To: Jiang, Guomin ; devel@edk2.groups.io; Wang, > Jian J > Cc: Bret Bark

[edk2-devel] [PATCH] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

be off-by one than size of array, so when check array, the max index should less than size of array. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Guomin Jiang --- .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c| 12 ++-- 1 file changed, 6 insertions

[edk2-devel] [PATCH v2] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index

be off-by one than size of array, so when check array, the max index should less than size of array. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Guomin Jiang --- .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c| 12 ++-- 1 file changed, 6 insertions

Re: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for VS2019 tool chains.

; Ni, Ray > Subject: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for > VS2019 tool chains. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2604 > > The link flags for VS2019 is absent and result the build fail. > > Cc: Jordan Justen > Cc: Andrew F

[edk2-devel] [PATCH] EmulatorPkg: Add MagicPageLib header file declaration.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2663 Add the public header file declaration. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/EmulatorPkg.dec | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dec b

Re: [edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, April 7, 2020 2:34 AM > To: devel@edk2.groups.io > Cc: Kun Qin ; Wang, Jian J > ; Yao, Jiewen ; Zhang, > Chao B > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH v1 2/2] SecurityPkg Tcg: Use SW SMI IO port PCD in Tpm.asl

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, April 7, 2020 2:34 AM > To: devel@edk2.groups.io > Cc: Kun Qin ; Wang, Jian J > ; Yao, Jiewen ; Zhang, > Chao B > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

Hi Kinney, Sean, Bret, Could you help review the change? Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 31, 2020 11:06 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Sean Brogan

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Kinney, Sean, Bret, Could you help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 31, 2020 2:50 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Sean Brogan

Re: [edk2-devel] [PATCH] SecurityPkg/MeasureBootLib: Return EFI_ACCESS_DENIED after image check fail

Hi Jiewen, Jiang, Chao, Could you help review the change. Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Wednesday, April 1, 2020 9:11 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Zha

Re: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files

Hi Ray, Chaganty, Could you please help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, March 24, 2020 2:37 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > &

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Sean, I think it meet the original code logic more closely. According to the LoadUnitTestCache(), it need pointer to pointer, the defect is resulted by pointer to local pointer and I think the original logical just want use the local variable as pointer to pointer. I have reviewed the sugge

Re: [edk2-devel] [PATCH v1 1/7] MdePkg/BaseLib: Add linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Kinney, Michael D ;

Re: [edk2-devel] [PATCH v1 2/7] MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Ni, Ray ; Sean Brogan

Re: [edk2-devel] [PATCH v1 3/7] MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Ni, Ray ; Sean Brogan

Re: [edk2-devel] [PATCH v1 4/7] MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, April 10, 2020 4:05 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Gao, Liming ; > Ni, Ray ; Sean Brogan

[edk2-devel] [PATCH v3] CryptoPkg/Pkcs7: Extend support for other OID types

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539 Microsoft signtool supports creation of attached P7's with any OID payload via the "/p7co" parameter. It is necessary to check the data before get the string. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-b

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Qin, Refer https://github.com/guominjia/edk2/commit/eed5154853f6522e6150b9cff16d24e0c88ad3cc Best Regards guomin From: Kun Qin Sent: Friday, April 10, 2020 3:18 PM To: Jiang, Guomin ; Sean Brogan ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Cor

[edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609 SavedState is not sticky, copied pointer update will not change source pointer Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c

[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Remove FrameworkHandle parameter

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2612 Remove the FrameworkHandle parameter from the SaveFrameworkState interface in UnitTestLib Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang --- MdePkg/Include

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

Summarize current status: Problem Statement: Openssl require _fltused to be defined as a constant anywhere floating point is used. It may use float out of edk2 tree and need _fltused, for example, Microsoft’s OnScreenKeyboard and UiToolKit. Current Proposal as below: Proposal 1: Add FltUsed.c

[edk2-devel] [PATCH v2 4/6] MdeModulePkg/SecurityManagementLib: Mark the File parameter as OPTIONAL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the File description, the File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Include/Library/SecurityManagementLib.h| 2

[edk2-devel] [PATCH v2 5/6] MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the description, the File is optional and can be NULL Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c | 2 +- 1 file changed

[edk2-devel] [PATCH v2 2/6] SecurityPkg/DxeImageAuth: Mark the File parameter as option

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the File description, The File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang --- .../DxeImageAuthenticationStatusLib.c | 2 +- 1 file

[edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File parameter as OPTIONAL.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the description, the File is OPTIONAL and can be NULL. Signed-off-by: Guomin Jiang Cc: Michael D Kinney Cc: Liming Gao --- MdePkg/Include/Protocol/Security2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2-devel] [PATCH v2 1/6] SecurityPkg/TPM: measure UEFI images without associated device paths again

). Therefore rejecting (File==NULL) at the top of the function is invalid. Fixes: 4b026f0d5af36faf3a3629a3ad49c51b5b3be12f Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Guomin Jiang --- .../DxeTpm2MeasureBootLib.c | 20

[edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

File paramter should be optional according to the descritpion. Guomin Jiang (6): SecurityPkg/TPM: measure UEFI images without associated device paths again SecurityPkg/DxeImageAuth: Mark the File parameter as option SecurityPkg/DxeImageVerificationLib: Mark the File parameter as

[edk2-devel] [PATCH v2 3/6] SecurityPkg/DxeImageVerificationLib: Mark the File parameter as OPTIONAL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 According to the File description, the File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 2 +- 1 file

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

Hi Laszlo, According to your advice, i post new change. Can you help review the series again? Hi Jian, Chao, Jiewen, Please help review the series. Thanks, guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Thursday, April 16,

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

es. > > Thanks, > guomin > > > -----Original Message- > > From: devel@edk2.groups.io On Behalf Of > Guomin > > Jiang > > Sent: Thursday, April 16, 2020 3:34 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH v2 0/6] Mark

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

Hi Michael, Sean, Bret, Please help review the change. Best Regards guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, April 14, 2020 9:33 AM > To: devel@edk2.groups.io > Cc: kuqin ; Kinney, Michael D > ; Sean Bro

Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL

Message- > From: Laszlo Ersek > Sent: Monday, April 20, 2020 7:39 PM > To: devel@edk2.groups.io; Jiang, Guomin > Subject: Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as > OPTIONAL > > On 04/16/20 09:33, Guomin Jiang wrote: > > File paramter should be op

Re: [edk2-devel] [PATCH v1 2/9] MdeModulePkg: Define the VariablePolicyLib

It is better that pay more attention to code style, for example Replace NewTable = AllocatePool( NewSize ); With space NewTable = AllocatePool (NewSize); Refer https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C for simple principle and https://edk2-docs.gitbooks.io/edk-ii-c-codin

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

To: Jiang, Guomin ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray > Subject: Re: [PATCH v3 1/1] MdeModulePkg/UsbBusDxe: Rebuild the > description table after Reset Device > > Hi, > > On 5/9/20 3:26 AM, Guomin Jiang wrote: > > REF: https://bugzilla.tianocor

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

ild it when it > detects its missing. > > > Thanks, > > > > > > > Best Regards > > Guomin > >> -Original Message- > >> From: Jeremy Linton > >> Sent: Wednesday, July 15, 2020 8:19 AM > >> To: Jiang, Guomin ; devel@

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option

Can you explain the -Wno-error=format? I haven't search the switch from google. Appreciate it. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Thursday, July 16, 2020 10:55 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Wang, Jian J ; Lu, >

[edk2-devel] [PATCH v2 0/1] Upgrade the OpenSSL to 1.1.1g

v2: Change the process_files.pl to convert the EOL automatically so the generated file will be CRLF format. Cc: Jian J Wang Cc: Xiaoyu Lu Guomin Jiang (1): CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g CryptoPkg/CryptoPkg.dec | 1 - CryptoPkg/Library/OpensslLib

[edk2-devel] [PATCH v2 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g

automatically. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Guomin Jiang Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek --- CryptoPkg/CryptoPkg.dec | 1 - CryptoPkg/Library/OpensslLib/OpensslLib.inf | 58 +-- .../Library/OpensslLib/OpensslLibCrypto.inf | 50

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/Library: Remove the redundant build option

Reviewed-by: Guomin Jiang I review the manual from https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html, It is explained in [-Werror=] option. Thank for your explanation as well. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Fri

[edk2-devel] [PATCH v6 03/10] UefiCpuPkg/CpuMpPei: Add GDT migration support (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Moves the GDT to permanent memory in a memory discovered callback. This is done to ensure the GDT authenticated in pre-memory is not fetched from outside a verified location after the permanent memory transition. Cc:

[edk2-devel] [PATCH v6 02/10] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Introduces new changes to PeiCore to move the contents of temporary RAM visible to the PeiCore to permanent memory. This expands on pre-existing shadowing support in the PeiCore to perform the following additional acti

[edk2-devel] [PATCH v6 00/10] Add new feature that evacuate temporary to permanent memory (CVE-2019-11098)

Cc: Chao Zhang Cc: Qi Zhang Guomin Jiang (7): MdeModulePkg: Add new PCD to control the evacuate temporary memory feature (CVE-2019-11098) MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098) SecurityPkg/Tcg2Pei: Use Migrated FV Info Hob for

[edk2-devel] [PATCH v6 09/10] SecurityPkg/TcgPei: Use Migrated FV Info Hob for calculating hash (CVE-2019-11098)

hash and it use the Migrated FV Info. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Guomin Jiang Reviewed-by: Jian J Wang --- SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 + SecurityPkg/Tcg/TcgPei/TcgPei.c | 29 +++-- 2 files

[edk2-devel] [PATCH v6 10/10] MdeModulePkg/Core: Avoid redundant shadow when enable the Migrated PCD (CVE-2019-11098)

valid choice is to enable PcdMigrateTemporaryRamFirmwareVolumes and disable PcdShadowPeimOnBoot. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Debkumar De Cc: Harry Han Cc: Catharine West --- MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 11

[edk2-devel] [PATCH v6 08/10] UefiCpuPkg: Correct some typos.

Correct some typos. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Guomin Jiang Reviewed-by: Laszlo Ersek --- UefiCpuPkg/CpuMpPei/CpuMpPei.h| 2 +- .../Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 4 ++-- UefiCpuPkg

[edk2-devel] [PATCH v6 04/10] UefiCpuPkg/SecMigrationPei: Add initial PEIM (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Adds a PEIM that republishes structures produced in SEC. This is done because SEC modules may not be shadowed in some platforms due to space constraints or special alignment requirements. The SecMigrationPei module loc

[edk2-devel] [PATCH v6 07/10] UefiCpuPkg/CpuMpPei: Enable paging and set NP flag to avoid TOCTOU (CVE-2019-11098)

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 To avoid the TOCTOU, enable paging and set Not Present flag so when access any code in the flash range, it will trigger #PF exception. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Guomin Jiang Acked-by

[edk2-devel] [PATCH v6 05/10] MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098)

never produce when PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control the total feature. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Debkumar De Cc: Harry Han Cc: Catharine West Signed-off-by: Guomin Jiang Acked-by: Laszlo Ersek --- MdeModulePkg

[edk2-devel] [PATCH v6 06/10] SecurityPkg/Tcg2Pei: Use Migrated FV Info Hob for calculating hash (CVE-2019-11098)

hash and it use the Migrated FV Info. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Guomin Jiang Reviewed-by: Jian J Wang --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 + SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 31 ++--- 2 files

[edk2-devel] [PATCH v6 01/10] MdeModulePkg: Add new PCD to control the evacuate temporary memory feature (CVE-2019-11098)

d-off-by: Guomin Jiang Acked-by: Laszlo Ersek Reviewed-by: Jian J Wang --- MdeModulePkg/MdeModulePkg.dec | 8 MdeModulePkg/MdeModulePkg.uni | 6 ++ 2 files changed, 14 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 843e963

Re: [edk2-devel] File in the build question. I'm working on a smart git grep

I would like that add BaseTols/Scripts/ to the PATH. Usually, I use ```set PATH=%PATH%;%WORKSPACE%\BaseTools\Scripts``` to add new directory to the environment variable. But I suggest that we should judge if the last character in PATH variable is ';' character and then add new directory. Let m

Re: [edk2-devel] [PATCH 06/15] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for LicenseCheck

I think the better subject is "Add configuration for avoiding License Conflict". Anyway, it's good to me. Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Monday, July 20, 2020 4:37 PM >

Re: [edk2-devel] [PATCH 04/15] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for LicenseCheck

I think the better subject is "Add configuration for avoiding License Conflict". Anyway, it's good to me. Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Monday, July 20, 2020 4:37 PM >

[edk2-devel] [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule.

When i upgrade openssl to 1.1.1g, error occurred when run PatchCheck.py. The reason is that the submodule will end with LF, but it will check based on file rule, it make no sense and need ignore the check. Signed-off-by: Guomin Jiang Cc: Bob Feng Cc: Liming Gao --- BaseTools/Scripts

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule.

: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > > Subject: [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade > submodule. > > When i upgrade openssl to 1.1.1g, error occurred when run PatchCheck.py. > The reason is that the submodule will end with LF,

Re: [edk2-devel] [PATCH] FmpDevicePkg: Enhance capsule verification with secure boot keys

; > > > > > But if your customer indeed want it, you can add > > it to > > > > your customization code. > > > > > > > > > > Thanks > > > > > Guomin > > > > > > > > > > > -Original Message- > >

Re: [edk2-devel] [PATCH edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

Hi Ming, The new posted change https://edk2.groups.io/g/devel/topic/75412007#62327 may be helpful for this issue. Can you add the change in your code and verify it? Thanks Guomin > -Original Message- > From: Ming Huang > Sent: Friday, July 3, 2020 8:49 PM > To: Jiang, Guomin ; devel@ed

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI.

Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Friday, March 6, 2020 1:36 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Daniel Schaefer ; > Wang, Jian J ; Lu, XiaoyuX ; > Leif Lindholm ;

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule.

> Cc: Feng, Bob C ; Gao, Liming > > > > Subject: [PATCH 1/1] BaseTools/Scripts: Ignore the CRLF check when > > upgrade submodule. > > > > When i upgrade openssl to 1.1.1g, error occurred when run PatchCheck.py. > > The reason is that the submodule will end with L

Re: [edk2-devel] [PATCH edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

Hi Ming, Can you try the newest edk2? Thanks Guomin > -Original Message- > From: Huangming (Mark) > Sent: Wednesday, July 22, 2020 2:44 PM > To: Jiang, Guomin ; devel@edk2.groups.io; Wang, > Jian J ; Wu, Hao A ; Gao, > Liming > Cc: Lidongzhan ; Songdongkuang > ; wanghuiqiang > ; qiulian

[edk2-devel] [PATCH v7 02/10] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Introduces new changes to PeiCore to move the contents of temporary RAM visible to the PeiCore to permanent memory. This expands on pre-existing shadowing support in the PeiCore to perform the following additional acti

[edk2-devel] [PATCH v7 01/10] MdeModulePkg: Add new PCD to control the evacuate temporary memory feature (CVE-2019-11098)

d-off-by: Guomin Jiang Acked-by: Laszlo Ersek Reviewed-by: Jian J Wang --- MdeModulePkg/MdeModulePkg.dec | 8 MdeModulePkg/MdeModulePkg.uni | 6 ++ 2 files changed, 14 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 843e963

[edk2-devel] [PATCH v7 03/10] UefiCpuPkg/CpuMpPei: Add GDT migration support (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Moves the GDT to permanent memory in a memory discovered callback. This is done to ensure the GDT authenticated in pre-memory is not fetched from outside a verified location after the permanent memory transition. Cc:

[edk2-devel] [PATCH v7 00/10] Add new feature that evacuate temporary to permanent memory (CVE-2019-11098)

: Leif Lindholm Cc: Rahul Kumar Cc: Jiewen Yao Cc: Chao Zhang Cc: Qi Zhang Guomin Jiang (7): MdeModulePkg: Add new PCD to control the evacuate temporary memory feature (CVE-2019-11098) MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098) SecurityPkg

[edk2-devel] [PATCH v7 04/10] UefiCpuPkg/SecMigrationPei: Add initial PEIM (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Adds a PEIM that republishes structures produced in SEC. This is done because SEC modules may not be shadowed in some platforms due to space constraints or special alignment requirements. The SecMigrationPei module loc

[edk2-devel] [PATCH v7 09/10] SecurityPkg/TcgPei: Use Migrated FV Info Hob for calculating hash (CVE-2019-11098)

hash and it use the Migrated FV Info. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Guomin Jiang Reviewed-by: Jian J Wang Reviewed-by: Zhang, Qi1 --- SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 + SecurityPkg/Tcg/TcgPei/TcgPei.c | 29

[edk2-devel] [PATCH v7 08/10] UefiCpuPkg: Correct some typos.

Correct some typos. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Guomin Jiang Reviewed-by: Laszlo Ersek --- UefiCpuPkg/CpuMpPei/CpuMpPei.h| 2 +- .../Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 4 ++-- UefiCpuPkg

[edk2-devel] [PATCH v7 06/10] SecurityPkg/Tcg2Pei: Use Migrated FV Info Hob for calculating hash (CVE-2019-11098)

hash and it use the Migrated FV Info. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Guomin Jiang Reviewed-by: Jian J Wang Reviewed-by: Zhang, Qi1 --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 + SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 31

[edk2-devel] [PATCH v7 10/10] MdeModulePkg/Core: Avoid redundant shadow when enable the Migrated PCD (CVE-2019-11098)

unnecessary, so the only valid choice is to enable PcdMigrateTemporaryRamFirmwareVolumes and disable PcdShadowPeimOnBoot and PcdShadowPeimOnS3Boot. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Debkumar De Cc: Harry Han Cc: Catharine West

[edk2-devel] [PATCH v7 07/10] UefiCpuPkg/CpuMpPei: Enable paging and set NP flag to avoid TOCTOU (CVE-2019-11098)

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 To avoid the TOCTOU, enable paging and set Not Present flag so when access any code in the flash range, it will trigger #PF exception. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Guomin Jiang Acked-by

[edk2-devel] [PATCH v7 05/10] MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098)

never produce when PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control the total feature. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Debkumar De Cc: Harry Han Cc: Catharine West Signed-off-by: Guomin Jiang Acked-by: Laszlo Ersek Reviewed-by: Jian J

  1   2   3   4   >