Re: [edk2-devel] [PATCH edk2-CCodingStandardsSpecification v3 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Michael D Kinney via groups.io
Reviewed-by: Michael D Kinney > -Original Message- > From: Rebecca Cran > Sent: Monday, February 3, 2025 10:46 AM > To: devel@edk2.groups.io; Kinney, Michael D > ; Sean Brogan ; > Oliver Smith-Denny ; Pedro Falcato > > Cc: Rebecca Cran > Subject: [PATCH edk2-CCodingStandardsSpecifica

Re: [edk2-devel] PRs for edk2-stable202502 (allow @verbatim doxygen tag and make ascii art in SignedCapsulePkg readable)

2025-02-03 Thread Michael D Kinney via groups.io
Approved. Mike > -Original Message- > From: Rebecca Cran > Sent: Monday, February 3, 2025 10:41 AM > To: devel@edk2.groups.io; Liming Gao ; > Kinney, Michael D > Subject: PRs for edk2-stable202502 (allow @verbatim doxygen tag and > make ascii art in SignedCapsulePkg readable) > > I'd l

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202502

2025-02-03 Thread gaoliming via groups.io
Mike: Thanks. The milestone is helpful for the stable tag release process. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney via groups.io > 发送时间: 2025年2月4日 2:28 > 收件人: gaoliming ; devel@edk2.groups.io; > annou...@edk2.groups.io > 抄送: 'Andrew Fish' ; leif.lindh...@

Re: [edk2-devel] [PATCH edk2-CCodingStandardsSpecification v2 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Michael D Kinney via groups.io
Release process is documented here https://github.com/tianocore-docs/edk2-TemplateSpecification/wiki/TianoCore-Documents-Releasing The "version" field in the main branch is ignored, so there is never any reason to change it. That field typically contains the value when the document was impo

[edk2-devel] Dynamic Stack Cookies PR For edk2-stable202502

2025-02-03 Thread Oliver Smith-Denny via groups.io
Hi Liming, I am planning to merge https://github.com/tianocore/edk2/pull/6381 for stable tag edk2-stable202502. It has been under review for several months now and currently has multiple approvals, just waiting for Mike Kinney to confirm he is done reviewing and hopefully approve :). I will also

[edk2-devel] PRs for edk2-stable202502 (allow @verbatim doxygen tag and make ascii art in SignedCapsulePkg readable)

2025-02-03 Thread Rebecca Cran
I'd like to commit the following PRs for the edk2-stable202502 release: BaseTools: Add @verbatim as allowed Doxygen tag: https://github.com/tianocore/edk2/pull/10714 https://github.com/tianocore/edk2/pull/6476: SignedCapsulePkg: make Doxygen interpret ASCII art as verbatim text -- Rebecca

[edk2-devel] [PATCH edk2-CCodingStandardsSpecification v3 0/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Rebecca Cran
Prefer use of `static` C keyword over EDK2 type `STATIC` A while ago a decision was made on the edk2-devel mailing list that the `STATIC` EDK2 type should be replaced with the C keyword `static`. Following further discussion, it was decided to disallow static local variables to prevent breakage w

[edk2-devel] [PATCH edk2-CCodingStandardsSpecification v3 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Rebecca Cran
A while ago a decision was made on the edk2-devel mailing list that the `STATIC` EDK2 type should be replaced with the C keyword `static`. Following further discussion, it was decided to disallow static local variables to prevent breakage when using GoogleTest. Update the Coding Specification to m

[edk2-devel] [PATCH edk2-CCodingStandardsSpecification v2 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Rebecca Cran
A while ago a decision was made on the edk2-devel mailing list that the `STATIC` EDK2 type should be replaced with the C keyword `static`. Following further discussion, it was decided to disallow static local variables to prevent breakage when using GoogleTest. Update the Coding Specification to m

[edk2-devel] [PATCH edk2-CCodingStandardsSpecification v2 0/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Rebecca Cran
Prefer use of `static` C keyword over EDK2 type `STATIC` A while ago a decision was made on the edk2-devel mailing list that the `STATIC` EDK2 type should be replaced with the C keyword `static`. Following further discussion, it was decided to disallow static local variables to prevent breakage w

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Rebecca Cran
On 10/21/24 3:11 PM, Pedro Falcato wrote: On Mon, Oct 21, 2024 at 10:04 PM Kinney, Michael D wrote: I recall clang having more restrictions on redefining keywords. Clang has restrictions on redefining macros and builtin functions. It appears to not have any issues doing horrible unspeakable th

Re: [edk2-devel] [PATCH edk2-CCodingStandardsSpecification v2 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Michael D Kinney via groups.io
Hi Rebecca, The content changes look good. 2 comments below. Mike > -Original Message- > From: Rebecca Cran > Sent: Monday, February 3, 2025 3:26 AM > To: devel@edk2.groups.io; Kinney, Michael D > ; Sean Brogan ; > Oliver Smith-Denny ; Pedro Falcato > > Cc: Rebecca Cran > Subject: [P

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202502

2025-02-03 Thread Michael D Kinney via groups.io
Hi Liming, The Milestone "edk2-stable202502" has been added for PRs, so any PR that should be considered for this release should be tagged with that Milestone. That will make it easier to track progress through the soft and hard freeze to know when all PRs targeted for this release are either

Re: [edk2-devel] [PATCH edk2-CCodingStandardsSpecification v2 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2025-02-03 Thread Rebecca Cran
On 2/3/25 11:17 AM, Kinney, Michael D wrote: Version is ignored when "draft" is "yes", so this change can be dropped. book.json should only be updated in a release branch to publish a new release. Do we have a process to make sure book.json is updated? It looks like version 2.3 was missed.