Re: [edk2-devel] [PATCH 0/5] SPI Driver Stack

2024-05-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Brit, We have to fix the CI failure. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Tuesday, April 30, 2024 10:06 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subje

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, May 2, 2024 #cal-reminder

2024-05-01 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, May 2, 2024 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.

[edk2-devel] [PATCH v7 2/5] ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c

2024-05-01 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented dumping of the Image Execution Table using Dmem.c Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sam Kaynor Tested-by: Stuart Yoder Reviewed-by: Stuart Yoder Reviewed-by: Zhichao Gao --- Notes: v5: - corrected comment

[edk2-devel] [PATCH v7 0/5] Adding support for veborse UEFI Table dumping to Dmem.c

2024-05-01 Thread Sam Kaynor
This adds an additional option to the dmem UEFI shell command for verbose dumping of a couple of UEFI tables. The tables specified are the RT Properties Table, the Image Execution Table, and the Conformance Profiles table. Supporting objects are added in the .inf and .uni files relating to Dmem

[edk2-devel] [PATCH v7 5/5] ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c

2024-05-01 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c Uses header file for GUIDs added in previous patches Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sam Kaynor Tested-by: Stuart Yoder Reviewed-by: Stuart Yoder --- No

[edk2-devel] [PATCH v7 1/5] ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c

2024-05-01 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented the dumping of the UEFI RT Properties Table using Dmem.c Added new entry to the help command for the -verbose option Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Sam Kaynor Tested-by: Stuart Yoder Reviewed-by: Stuart Yoder Re

[edk2-devel] [PATCH v7 3/5] MdePkg: Adding support for EFI_CONFORMANCE_PROFILE_TABLE

2024-05-01 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Adding support for EFI_CONFORMANCE_PROFILE_TABLE by adding an associated header file and relevant GUIDs to MdePkg.dec as defined in the UEFI 2.10 spec. This table is needed to address changes being made within ShellPkg. Cc: Michael D Kinney

[edk2-devel] [PATCH v7 4/5] MdePkg: Adding EBBR EFI_CONFORMANCE_PROFILE_TABLE GUIDs

2024-05-01 Thread Sam Kaynor
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Adding additional GUIDs for the EFI_CONFORMANCE_PROFILE_TABLE that are defined in the Embedded Base Boot Requirments (EBBR) Specification. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Sam Kaynor --- Notes: v7

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, May 2, 2024 #cal-reminder

2024-05-01 Thread Group Notification
*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, May 2, 2024 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join

[edk2-devel] [PATCH v2 0/3] TCG_Sp800_155_PlatformId_Event3 support

2024-05-01 Thread Dionna Glaze via groups.io
In December 2023, the TCG published the PC Client Platform Firmware Profile version 1.06 revision 52. This revision includes a new event type for NIST SP 800-155 recommended signed BIOS reference measurements. The new type allows for the event log auditor to find local or remote copies of the signe

[edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type info

2024-05-01 Thread Dionna Glaze via groups.io
TCG PC Client Platform Firmware Profile 1.06 revision 52 of December 2023 added a new event signature and extended information about where a reference measurement document for the firmware can be found. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Dionna Glaze --- .../

[edk2-devel] [PATCH v2 2/3] SecurityPkg: recognize sp800155Event3 event too

2024-05-01 Thread Dionna Glaze via groups.io
The signatures for event2 or event3 are now valid TCG SP800155 event types. Cc: Jiewen Yao Cc: Rahul Kumar Reviewed-by: Jiewen Yao Signed-off-by: Dionna Glaze --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/Tcg/Tc

[edk2-devel] [PATCH v2 3/3] OvmfPkg: add sp800155Event3 support

2024-05-01 Thread Dionna Glaze via groups.io
The signatures for event2 or event3 are now valid TCG SP800155 event types. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Reviewed-by: Jiewen Yao Signed-off-by: Dionna Glaze --- OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --gi

[edk2-devel] Call or topics for May TianoCore Community Meeting

2024-05-01 Thread Michael D Kinney
Please let me know if you have any topics for the TianoCore Community Meeting this month. Thanks, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118467): https://edk2.groups.io/g/devel/message/118467 Mute This Topic: https://groups

[edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-01 Thread Michael D Kinney
Hello, I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based code reviews. The proposed date to switch would be immediately after the next stable tag which is currently scheduled for May 24, 2024. Updates to the following Wiki pag

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-01 Thread Leif Lindholm
On 2024-05-01 18:43, Michael D Kinney wrote: Hello, I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based code reviews. The proposed date to switch would be immediately after the next stable tag which is currently scheduled for M

[edk2-devel] [PATCH v4 0/3] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set

2024-05-01 Thread Roth, Michael via groups.io
For the most part, OVMF will clear the encryption bit for MMIO regions, but there is currently one known exception during SEC when the APIC base address is accessed via MMIO with the encryption bit set for SEV-ES/SEV-SNP guests. In the case of SEV-SNP, this requires special handling on the hypervis

[edk2-devel] [PATCH v4 1/3] OvmfPkg/ResetVector: Clear SEV encryption bit for non-leaf PTEs

2024-05-01 Thread Roth, Michael via groups.io
Future changes will make use of CpuPageTableLib to handle splitting page table mappings during SEC phase. While it's not strictly required by hardware, CpuPageTableLib relies on non-leaf PTEs never having the encryption bit set, so go ahead change the page table setup code to satisfy this expectati

[edk2-devel] [PATCH v4 2/3] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set

2024-05-01 Thread Roth, Michael via groups.io
For the most part, OVMF will clear the encryption bit for MMIO regions, but there is currently one known exception during SEC when the APIC base address is accessed via MMIO with the encryption bit set for SEV-ES/SEV-SNP guests. In the case of SEV-SNP, this requires special handling on the hypervis

[edk2-devel] [PATCH v1 1/6] MdePkg/SpiConfiguration: Correct the definition spelling

2024-05-01 Thread Chesley, Brit via groups.io
From: Abner Chang Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley --- MdePkg/Include/Protocol/SpiConfiguration.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Protocol/SpiConfiguration.h b/MdePkg/Include/Protocol/SpiConfiguration.h

[edk2-devel] [PATCH v1 0/6] SPI Driver Stack

2024-05-01 Thread Chesley, Brit via groups.io
From: Brit Chesley This patchset introduces the SPI driver stack as defined in the Platform Initialization specification Volume 5 chapter 18 (DXE) and Volume 4 chapter 12 (SMM). The SPI stack decouples the SPI chip details from the SPI controller and SPI bus configuration details to enable silico

[edk2-devel] [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

2024-05-01 Thread Chesley, Brit via groups.io
From: Brit Chesley Including the SpiBus drivers in MdeModulePkg.dsc Platform Initialization spec 1.7 volume 5 section 18.1.6 Bugzilla #4753 Cc: Liming Gao Cc: Ray Ni Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file change

[edk2-devel] [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

2024-05-01 Thread Chesley, Brit via groups.io
From: Brit Chesley Including the SpiHc drivers in MdeModulePkg.dsc Bugzilla #4753 Cc: Liming Gao Cc: Ray Ni Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.

[edk2-devel] [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

2024-05-01 Thread Chesley, Brit via groups.io
From: Brit Chesley Adding NULL SpiHcPlatformLib instance. This library is responsible for handling the low level details of the SPI host controller. Since this is platform specific this library will be dependent on OEM SPI implementation. The SPI host controller layer will utilize this library fo

[edk2-devel] [PATCH v1 5/6] MdeModulePkg: SpiHc: SpiHc Drivers

2024-05-01 Thread Chesley, Brit via groups.io
From: Brit Chesley Added SpiHc DXE and SMM drivers. This code receives bus transactions from the SpiBus layer and passes them onto the SpiHcPlatformLib Platform Initialization Spec 1.7 volume 5 section 18.1.7 Bugzilla #4753 Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley

[edk2-devel] [PATCH v1 2/6] MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers

2024-05-01 Thread Chesley, Brit via groups.io
From: Brit Chesley Added SpiBus DXE and SMM drivers. This code translates SPI requests from the application layer into SPI Bus transactions on the SPI host controller. The code is responsible for checking if the transaction is valid, then setting up the SPI clock and chip select properly before p

[edk2-devel] [PATCH v4 3/3] OvmfPkg/CcExitLib: Drop special handling for Encrypted MMIO to APIC

2024-05-01 Thread Roth, Michael via groups.io
The current #VC handler guards against MMIO to addresses that are mapped with the encryption bit set, but has an special exception for MMIO accesses to the APIC base address so allow for early access during SEC. Now that the SEC page table has the encryption bit cleared for the APIC base address r

[edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file

2024-05-01 Thread Hsueh, Hong-Chih (Neo) via groups.io
Cc: Jiangang He Signed-off-by: Neo Hsueh --- MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/MdePkg/Include/Register/Amd/Cpuid.h b/MdePkg/Include/Register/Amd

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: Remove HOB creation

2024-05-01 Thread Oliver Smith-Denny
Hi folks, returning to this thread because I noticed that HOB creation still exists in StandaloneMmCore for ARM: https://github.com/tianocore/edk2/blob/5d4c5253e8bbc0baa8837fcd868925212df85201/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobList.c As far as I can tell, there is o

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-01 Thread Dionna Glaze via groups.io
On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io wrote: > > On 2024-05-01 18:43, Michael D Kinney wrote: > > Hello, > > > > I would like to propose that TianoCore move all code review from email > > based code reviews to GitHub Pull Requests based code reviews. > > > > The proposed date

Re: [edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type info

2024-05-01 Thread Yao, Jiewen
Thanks Dionna. Almost good, except you create a typo below: >EFI_GUIDReferenceManifestGuid; > - // > + // >// Below structure is newly added in TCG_Sp800_155_PlatformId_Event2. With typo fix, reviewed-by: Jiewen Yao Thank you Yao, Jiewen > -Original Message- > From: dev

[edk2-devel] [PATCH v3 1/3] MdePkg: Add TcgSp800155Event3 type info

2024-05-01 Thread Dionna Glaze via groups.io
TCG PC Client Platform Firmware Profile 1.06 revision 52 of December 2023 added a new event signature and extended information about where a reference measurement document for the firmware can be found. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-By: Jiewen Yao Signed-off-by

[edk2-devel] [PATCH v3 0/3] TCG_Sp800_155_PlatformId_Event3 support

2024-05-01 Thread Dionna Glaze via groups.io
In December 2023, the TCG published the PC Client Platform Firmware Profile version 1.06 revision 52. This revision includes a new event type for NIST SP 800-155 recommended signed BIOS reference measurements. The new type allows for the event log auditor to find local or remote copies of the signe

[edk2-devel] [PATCH v3 2/3] SecurityPkg: recognize sp800155Event3 event too

2024-05-01 Thread Dionna Glaze via groups.io
The signatures for event2 or event3 are now valid TCG SP800155 event types. Cc: Jiewen Yao Cc: Rahul Kumar Reviewed-by: Jiewen Yao Signed-off-by: Dionna Glaze --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/Tcg/Tc

[edk2-devel] [PATCH v3 3/3] OvmfPkg: add sp800155Event3 support

2024-05-01 Thread Dionna Glaze via groups.io
The signatures for event2 or event3 are now valid TCG SP800155 event types. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Reviewed-by: Jiewen Yao Signed-off-by: Dionna Glaze --- OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --gi

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-01 Thread Rebecca Cran
On Wed, May 1, 2024, at 11:43 AM, Michael D Kinney wrote: > * The Pull Request submitter is required to invite the required > maintainers and reviewers to the pull request. This is the same > set of maintainers and reviewers that are required to be listed in > Cc: tags in today's process. T

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, May 2, 2024 #cal-reminder

2024-05-01 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, May 2, 2024 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-01 Thread Michael Kubacki
Thank you for this proposal. We've been anticipating this change for years and are excited to help support it. Here's some items we'd like to raise for feedback that we could help implement. Many could likely be done in time for the transition. 1. Automate reviewers - We've discussed CODEOWN

Re: [edk2-devel] [PATCH v1 1/6] MdePkg/SpiConfiguration: Correct the definition spelling

2024-05-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Attar, AbdulLateef (Abdul > Lateef) > Subject: [PATCH v1 1/6] MdePkg/SpiConfiguration: Correct the

Re: [edk2-devel] [PATCH v1 2/6] MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers

2024-05-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] We had reviewed this patch internally before sending this to community. Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Attar, AbdulLateef (Abdul >

Re: [edk2-devel] [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

2024-05-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subject: [PATCH v1 3/6] MdeModulePkg: A

Re: [edk2-devel] [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

2024-05-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subject: [PATCH v1 4/6] MdeModulePkg:Ba

Re: [edk2-devel] [PATCH v1 5/6] MdeModulePkg: SpiHc: SpiHc Drivers

2024-05-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] We had reviewed this patch internally before sending this to community. Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Attar, AbdulLateef (Abdul >

Re: [edk2-devel] [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

2024-05-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subject: [PATCH v1 6/6] MdeModulePkg: A

[edk2-devel] [PATCH] PACKAGE_GUID duplication in Intel silicon folders

2024-05-01 Thread dorax . hsueh
From: DoraX Hsueh https://bugzilla.tianocore.org/show_bug.cgi?id=4759 Modify PACKAGE_GUID duplication in Intel silicon folders. Cc: Sai Chaganty Cc: Rosen Chuang Cc: Saloni Kasbekar Cc: Nate DeSimone Cc: Paul Lohr Signed-off-by: DoraX Hsueh --- Silicon/Intel/AlderlakeSiliconPkg/SiPkg.dec

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-01 Thread Marcin Juszkiewicz
W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze: I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based code reviews. The proposed date to switch would be immediately after the next stable tag which is currently sche