Re: [edk2-devel] [PATCH v2 0/3] Adding support for verbose UEFI Table dumping to Dmem.c

You didn't resolve the feedback from: stuart.yo...@arm.com. All the address parameters are not used, just check the null pointer without use them. Thanks, Zhichao > -Original Message- > From: Sam Kaynor > Sent: Wednesday, March 20, 2024 3:11 AM > To: devel@edk2.groups.io > Cc: stuart.yo

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny wrote: > > Hi Mike and Ray, > > I'm here to bug you again :). I have another patchset that > unfortunately Liming has not gotten to review in a month's > time frame with weekly pings. When I bugged you last time, > he reviewed the next day, so somet

Re: [edk2-devel] [PATCH v1] MdePkg: Adds a PCD to define IPMI interface type

[AMD Official Use Only - General] Please update AMD copyright to 2024. Thanks Abner > -Original Message- > From: Abdul Lateef Attar > Sent: Friday, March 29, 2024 11:17 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Michael D Kinney > ; Liming Ga

Re: [edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes

Hi Abner, I'm very sorry, so busy those days with release. I will be able to check it next week only. Best regards, Igor Get Outlook for Android From: Chang, Abner Sent: Wednesday, March 27, 2024 3:43:55 AM To: Nickle Wang ; devel@edk2.grou

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

Hi Ard, I have reviewed the discussion on the V1 and V2 versions of the series. For the V2 Series: Acked-by: Michael D Kinney I will add the Rb/Ab tags and get this merged. Mike > -Original Message- > From: Ard Biesheuvel > Sent: Friday, March 29, 2024 1:03 AM > To: devel@edk2.gr

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

Hi Oliver, I am seeing a merge conflict with the V2 patches from the emails. Can you please rebase, resolve conflicts, and resend? Thanks, Mike > -Original Message- > From: Oliver Smith-Denny > Sent: Friday, March 29, 2024 10:14 AM > To: devel@edk2.groups.io; Kinney, Michael D ; > Ard

[edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

ImagePropertiesRecordLib is currently creating Image Records that are not accurate. It is setting the CodeSegmentSize to be the size of the raw data in the image file, however, when the image is loaded into memory, the raw data size is aligned to the section alignment. This caused the memory attrib

[edk2-devel] [PATCH v3 3/3] MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib

The functionality to create and delete Image Records has been consolidated in a library and ensured that MemoryProtection.c's usage is encapsulated there. This patch moves MemoryProtection.c to reuse the code in the lib and to prevent issues in the future where code is updated in one place but not

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

I sent a v3 with the fixup (it was trivial, from my last patch, apologies for not fixing up before). I added the RBs/AB, hope that was alright since there was no substantial code change, just the merge fix. Thanks, Oliver On 3/29/2024 10:28 AM, Oliver Smith-Denny wrote: Will do! Sorry, it's sat

Re: [edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

Sorry Mike, I realized I missed you on the cover letter email. I have the CI PR up (the commit messages there don't have the RBs/AB) and I made sure it passed all gates. Thanks for getting this merged. Oliver On 3/29/2024 1:21 PM, Oliver Smith-Denny wrote: ImagePropertiesRecordLib is currently

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf is a virtual storage device, so it just emulates an unformatted disk. You would need to partition or initialize the file system given you have a RAM disk. The file system driver lives here: https://github.com/tianocore/edk2/tree/master/FatP

Re: [edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

Merged: https://github.com/tianocore/edk2/pull/5505 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oliver > Smith-Denny > Sent: Friday, March 29, 2024 1:21 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Leif Lindholm > ; Ard Biesheuvel ; > Sami Mujawar ; Taylor Beebe >

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

There are also utilities to partition and format. https://www.intel.com/content/www/us/en/download/714351/uefi-shell-disk-utilities.html Mike From: devel@edk2.groups.io On Behalf Of Andrew Fish via groups.io Sent: Friday, March 29, 2024 3:11 PM To: devel@edk2.groups.io; yuinyee.c...@starfivete

[edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type

Define IPMI interface type as per specification version 2.0, section C1-1.1. Cc: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Abdul Lateef Attar --- MdePkg/MdePkg.dec | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/Mde