Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

2024-03-22 Thread sunceping
On Thursday, March 21, 2024 8:25 PM Gerd Hoffmann wrote: > Well, just try to read them. If present they can just be measured. > If not present we can either skip them, or measure with an empty data > field to indicate it is not present. My understanding : If the fw_cfg is present, it must be mea

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

2024-03-22 Thread Gerd Hoffmann
On Fri, Mar 22, 2024 at 02:39:20AM +, Yao, Jiewen wrote: > Please aware that this option will cause potential security risk. > > In case that any the guest component only knows one of vTPM or RTMR, > and only extends one of vTPM or RTMR, but the other one only verifies > the other, then the ch

[edk2-devel] [edk2-redfish-client][PATCH V2 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Set SettingsObject URI in @Redfish.Settings resource as the config language which is the same as the config language of parent URI that mandates @Redfish.Settings. With this, we can find the config language of the properties in SettingsObject URI. Signed-off-by: Abner Chang Cc

[edk2-devel] [edk2-redfish-client][PATCH V2 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Use SetRedfishSettingsObjectsUri to set the config language for SettingsObject URI. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 + RedfishClientPkg/Features/Bios/v1_1_0/

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

2024-03-22 Thread Gerd Hoffmann
On Fri, Mar 22, 2024 at 08:29:28AM +, Sun, CepingX wrote: > On Thursday, March 21, 2024 8:25 PM Gerd Hoffmann wrote: > > Well, just try to read them. If present they can just be measured. > > If not present we can either skip them, or measure with an empty data > > field to indicate it is not

[edk2-devel] [edk2-redfish-client][PATCH V3 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Set SettingsObject URI in @Redfish.Settings resource as the config language which is the same as the config language of parent URI that mandates @Redfish.Settings. With this, we can find the config language of the properties in SettingsObject URI. Signed-off-by: Abner Chang Cc

[edk2-devel] [edk2-redfish-client][PATCH V3 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Use SetRedfishSettingsObjectsUri to set the config language for SettingsObject URI. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 + RedfishClientPkg/Features/BootOption/v

Re: [edk2-devel] [edk2-redfish-client][PATCH V3 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Mike Maslenkin
Hi Abner, > On 22. 3. 2024., at 12:09, Chang, Abner via groups.io > wrote: > > From: Abner Chang > > Set SettingsObject URI in @Redfish.Settings resource as the config > language which is the same as the config language of parent URI > that mandates @Redfish.Settings. > With this, we can find

[edk2-devel] [PATCH 0/5] [PATCH 0/5] Config language searching algorithm enhancement and the bug fixes

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang PR # 5491 In this patch set, 1 We enhance the config language searching algorithm. As the performance of searching config language using HII GetString is pretty slow. For the example, 1800 HII BIOS options takes over 30 mins to build up the metadata required for Redfish B

[edk2-devel] [PATCH 2/5] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Introduce DEBUG_REDFISH macro for the debug message of edk2 Redfish components. DEBUG_REDFISH can be used in any edk2 Redfish component with Redfish DebugCatagory as the first parameter. Whether the debug message is output or not depends on the platform setting of PcdRedfishDebu

[edk2-devel] [PATCH 4/5] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Add the condition check when delete HII string. Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP" and the statement value type = EFI_IFR_TYPE_STRING. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- .../RedfishPlatformConfigDxe/R

[edk2-devel] [PATCH 1/5] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

2024-03-22 Thread Chang, Abner via groups.io
From: abnchang Build up the x-uefi-redfish string database for the Redfish confg language searching, instead of using HII String protocol. This can improve the time consumption lot on searching strings. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- .../Redfi

[edk2-devel] [PATCH 5/5] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang --- EmulatorPkg/EmulatorPkg.dsc | 21 + 1 file changed, 21 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 85134b07816..5fa1ed345a3 100644 --- a/EmulatorPkg/EmulatorPkg.

[edk2-devel] [PATCH 3/5] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Add RedfishPlatformConfigDxe debug capability that aligns with edk2 Redfish debug mechanism. - PcdRedfishPlatformConfigDebugProperty, add PCD to control RedfishPlatformConfigDxe subordinate of Redfish debug capabilities. - PcdRedfishPlatformConfigFeatureProperty, add PCD to

[edk2-devel] [edk2-redfish-client][PATCH V4 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Set SettingsObject URI in @Redfish.Settings resource as the config language which is the same as the config language of parent URI that mandates @Redfish.Settings. With this, we can find the config language of the properties in SettingsObject URI. Signed-off-by: Abner Chang Cc

[edk2-devel] [edk2-redfish-client][PATCH V4 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Use SetRedfishSettingsObjectsUri to set the config language for SettingsObject URI. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 + RedfishClientPkg/Features/BootOption/v

Re: [edk2-devel] [edk2-redfish-client][PATCH V3 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Mike, Thanks for catching this, V4 sent. Abner > -Original Message- > From: M M > Sent: Friday, March 22, 2024 5:20 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Igor Kulchytskyy ; Nickle Wang > Subject: Re: [edk2-devel] [edk2-redfish-client][P

Re: [edk2-devel] [edk2-redfish-client][PATCH V3 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Mike Maslenkin
Hi Abner, Sorry if I wasn't clear. I meant in this function including the success path. RedfishSetRedfishUri->..->NewConfigLangMapRecord() creates a copy of this string, so it should be freed in this function. Regards, Mike. On Fri, Mar 22, 2024 at 12:58 PM Chang, Abner wrote: > > [AMD Offici

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-22 Thread Gerd Hoffmann
On Wed, Mar 20, 2024 at 04:41:52PM +0800, Chao Li wrote: > This patch set adjusted some order in UefiCpuPig alphabetically, added > LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of > the first patch series v8 submitted at > https://edk2.groups.io/g/devel/message/114526. > >

[edk2-devel] [PATCH 1/4] OvmfPkg: Add VirtHstiDxe driver

2024-03-22 Thread Gerd Hoffmann
From: Konstantin Kostiuk The driver supports qemu machine types 'pc' and 'q35'. This patch adds some helper functions to manage the bitmasks. The implemented features depend on both OVMF build configuration and qemu VM configuration. For q35 a single security feature is supported and checked: I

[edk2-devel] [PATCH 2/4] OvmfPkg: Add VirtHstiDxe to OVMF firmware build

2024-03-22 Thread Gerd Hoffmann
From: Konstantin Kostiuk Cc: Ard Biesheuvel Cc: Jiewen Yao Signed-off-by: Konstantin Kostiuk Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfPkgIa32.dsc| 2 ++ OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ OvmfPkg/OvmfPkgX64.dsc | 2 ++ OvmfPkg/OvmfPkgIa32.fdf| 1 + OvmfPkg/OvmfPkgIa32X64.fdf

[edk2-devel] [PATCH 3/4] OvmfPkg/VirtHstiDxe: add varstore flash check

2024-03-22 Thread Gerd Hoffmann
Detects qemu config issue: vars pflash is not in secure mode (write access restricted to smm). Applies to Q35 with SMM only. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Konstantin Kostiuk Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf | 4 ++ OvmfPkg/VirtHstiDxe/VirtHstiDxe.

[edk2-devel] [PATCH 0/4] OvmfPkg: Add VirtHstiDxe driver

2024-03-22 Thread Gerd Hoffmann
Gerd Hoffmann (2): OvmfPkg/VirtHstiDxe: add varstore flash check OvmfPkg/VirtHstiDxe: add code flash check Konstantin Kostiuk (2): OvmfPkg: Add VirtHstiDxe driver OvmfPkg: Add VirtHstiDxe to OVMF firmware build OvmfPkg/OvmfPkgIa32.dsc | 2 + OvmfPkg/OvmfPkgIa32X64.dsc

[edk2-devel] [PATCH 4/4] OvmfPkg/VirtHstiDxe: add code flash check

2024-03-22 Thread Gerd Hoffmann
Detects qemu config issue: code pflash is writable. Checked for both PC and Q35. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Konstantin Kostiuk Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf | 2 ++ OvmfPkg/VirtHstiDxe/VirtHstiDxe.h | 13 +++ OvmfPkg/VirtHstiDxe/Qem

[edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Set SettingsObject URI in @Redfish.Settings resource as the config language which is the same as the config language of parent URI that mandates @Redfish.Settings. With this, we can find the config language of the properties in SettingsObject URI. Signed-off-by: Abner Chang Cc

[edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

2024-03-22 Thread Chang, Abner via groups.io
From: Abner Chang Use SetRedfishSettingsObjectsUri to set the config language for SettingsObject URI. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 + RedfishClientPkg/Features/BootOption/v

Re: [edk2-devel] [edk2-redfish-client][PATCH V3 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Ah I got your point. I reviewed that function and sent the V5. Thanks Abner > -Original Message- > From: Mike Maslenkin > Sent: Friday, March 22, 2024 6:08 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; Igor Kulchytskyy ; Nickle Wang > > Subject: R

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

2024-03-22 Thread Dionna Glaze via groups.io
On Fri, Mar 22, 2024 at 1:52 AM Gerd Hoffmann wrote: > > On Fri, Mar 22, 2024 at 02:39:20AM +, Yao, Jiewen wrote: > > Please aware that this option will cause potential security risk. > > > > In case that any the guest component only knows one of vTPM or RTMR, > > and only extends one of vTPM

[edk2-devel] [PATCH edk2-platforms v9 0/4] get rid of DeviceTree from SbsaQemu

2024-03-22 Thread Marcin Juszkiewicz
We want to stop parsing DeviceTree to gather hardware information. Instead we ask TF-A for those details using SMC calls. On real hardware platform it could be asking on-board Embedded Controller. Hardware information (CPU, Memory) is now in SbsaQemuHardwareInfoLib together with new code for hand

[edk2-devel] [PATCH edk2-platforms v9 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-03-22 Thread Marcin Juszkiewicz
This library provides functions to check for hardware information. For now it covers CPU ones: - amount of cpu cores - MPIDR value for cpu core - NUMA node id for cpu core Values are read from TF-A using platform specific SMC calls. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/S

[edk2-devel] [PATCH edk2-platforms v9 2/4] Platform/SbsaQemu: use SbsaQemuHardwareInfoLib for cpu information

2024-03-22 Thread Marcin Juszkiewicz
We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to parse DeviceTree anymore. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 6 ++ .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 5 ++--- .../SbsaQemu/Library/SbsaQemu

[edk2-devel] [PATCH edk2-platforms v9 3/4] Platform/SbsaQemu: drop use of DeviceTree

2024-03-22 Thread Marcin Juszkiewicz
There is no need for EDK2 to know that there is DeviceTree around. All hardware information is read using functions from SbsaQemuHardwareInfoLib library. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 1 - Platform/Qemu/SbsaQemu/SbsaQemu.dsc

[edk2-devel] [PATCH edk2-platforms v9 4/4] Platform/SbsaQemu: get the information of memory via SMC calls

2024-03-22 Thread Marcin Juszkiewicz
From: Xiong Yining Provide functions to check for memory information: - amount of memory nodes - memory address - NUMA node id for memory Values are read from TF-A using platform specific SMC calls. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

2024-03-22 Thread Taylor Beebe
v1: - Initial patch series v2: - Simplified the check for if the currently evaluated inf is a module or library. - Added a commit to use stronger matching of NULL includes (check for pattern "NULL") Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Taylor Beebe (2): BaseTo

[edk2-devel] [PATCH v2 1/2] BaseTools: Don't Recurse NULL Includes Not Linked to Module

2024-03-22 Thread Taylor Beebe
When collecting the required library instances for modules and libraries, included libraries will be recursed to ensure the module is built with all the libraries directly linked to it and indirectly linked to it via included libraries. Using the following scenario as an example: [LibraryClasses.

[edk2-devel] [PATCH v2 2/2] BaseTools: Use Stronger Matching for NULL Linked Libraries

2024-03-22 Thread Taylor Beebe
To prevent the possibility that a library with a name like NULLTestLib is interpreted as a NULL linked library, use more explicit pattern matching to ensure that the library name follows the pattern NULL%d. Signed-off-by: Taylor Beebe Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

2024-03-22 Thread Saloni Kasbekar
Hi Siva, Have you looked into getting this fixed in grub as Laszlo suggested? What's the expected timeline for this workaround? Thanks, Saloni -Original Message- From: Sivaraman Nainar Sent: Tuesday, March 19, 2024 4:32 AM To: devel@edk2.groups.io; Laszlo Ersek ; Santhosh Kumar V ; K