This is an expanded version of the original set of 9 patches with
additional patch introducing brackets for IPv6 Redfish resource location
with required changes according to comments for the initial RFC patch.
PR: https://github.com/tianocore/edk2/pull/5149
diff from v2:
added Abner's R-b
ref
PlatformHostInterfaceBmcUsbNicLib is the library instance name not
the class name.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion
RedfishPlatformCredentialIpmiLib is the library instance name not the
class name.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishPlatformCredentialIpmiLib.inf| 2 +-
1 file changed, 1 insertion(+), 1 deletion(
It seems that initial implementation of this header file is based on
CrtLibSupport.h from CryptoPkg. But uid, euid, gid, egid and sa_family_t
sre not used in RedfishPkg. So remove them.
Also take "true" and "false" definition from MdePkg's LibFdtSupport.h
header file, that also seems based on a he
It's unclear why the new string is allocated as copy of the original
string if its pointer is stored in an array and the original string
is released immediately after the copy is created. All data allocated
in the same pool.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Rev
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg/Redfis
Currently there is no description for RedfishConfigHandler driver.
This leads to in the "DRIVER NAME" column of a `drivers`
command for example.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishConfigHandler/ComponentName.c | 218
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be
initialized to avoid error condition on BMC side.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../PlatformHostInterfaceBmcUsbNicLib.c | 8 +---
1 file changed
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
EmulatorPkg/EmulatorPkg.dec | 8
.../RedfishPlatformCredentialLib.c | 12 ++--
.../RedfishPlatformCredentialLib.inf | 8
3 files chan
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishPlatformHostInterfaceLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
b/EmulatorPkg/
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 --
1 file changed, 74 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg/Redfis
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Pedro Falcato
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscov
It is required to free previously allocated strings stored in
DiscoveredInstance->Information structure.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 ++
1 file changed, 2 insertions(+)
diff --gi
This patch adds a handy helper function deallocating resources from the
EFI_REDFISH_DISCOVERED_INFORMATION structure instance.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 68 ---
1 file
URI is generated based on the RedfishLocation containing an ASCII string
representing the IP address. So, in the case of IPv4 the canonical
representation of an IPv4 address was inserted into the resulting Unicode
string i.e: "http{,s}://X.X.X.X/".
In the case of IPv6, to access resources, the IP
Cache size of ASCII string in local variable.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 ---
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/RedfishPkg/Redf
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4625
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 89 ---
1 file changed, 78 insertions(+), 11 deletions(-)
diff --git a/RedfishPkg/Red
Zifeng:
VFR_FLAGS can be set in the module INF for this module only. So, you can
set --catch_default option in the modules those you want to remove the
default opcode for. With this usage, --except_list option is not required.
For example, module INF can add below section to enable this option.
Chao:
I add my comments below.
发件人: devel@edk2.groups.io 代表 Chao Li
发送时间: 2023年12月21日 19:19
收件人: gaoliming ; devel@edk2.groups.io; 'Michael D
Kinney'
抄送: 'Zhiguang Liu' ; 'Laszlo Ersek'
主题: Re: 回复: 回复: [edk2-devel] [PATCH v4 09/37] MdePkg: Add a new library named
PeiServicesTablePointer
REF: UEFI SPEC 2.10 34.8.10 EFI_KEY
Add EfiKeyIntl0-9.
Signed-off-by: Yi Li
v2:
Remove changes in HiiFramework.h because it should follow HII spec.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Yi Li (2):
MdePkg: Upda
REF: UEFI SPEC 2.10 34.8.10 EFI_KEY
Add EfiKeyIntl0-9.
Signed-off-by: Yi Li
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
---
MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Uefi/Uefi
REF: UEFI SPEC 2.10 34.8.10 EFI_KEY
Add EfiKeyIntl0-9.
Signed-off-by: Yi Li
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
---
.../Include/Common/UefiInternalFormRepresentation.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Source
Thanks for your review, patch updated.
Regards,
Yi
-Original Message-
From: gaoliming
Sent: Saturday, December 23, 2023 10:16 AM
To: Li, Yi1 ; devel@edk2.groups.io
Cc: 'Rebecca Cran' ; Feng, Bob C ;
Chen, Christine
Subject: 回复: [PATCH 2/2] BaseTools: Update keybaord map based on UEFI
Hi Liming,
Thank you for adding the account for me.
I have created a Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=4629
for this feature ~
Best Regards,,
Yuting
-Original Message-
From: gaoliming
Sent: Monday, December 25, 2023 9:14 AM
To: Yang, Yuting2
Subject: 回复: [Patch
24 matches
Mail list logo
