Here is my suggestion:
1) Please perform the test to ensure the functional part is correct.
Without that, how can people know you are doing things right?
2) If you do not run any test, before you send out patch, please call out that
clearly.
That is important to reminder the maintainer: Don't m
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4533
There are use cases which not all FVs need be migrated from TempRam to
permanent memory before TempRam tears down. This new guid is introduced
to avoid unnecessary FV migration to improve boot performance. Platform
can publish ToMigrateFvInf
Thanks for the suggestion.
I'll update the test result once I finished the test. Also the abstract message
in this patch has been modified to mention that this patch should not be merged
now.
Thanks,
Dun
-Original Message-
From: Yao, Jiewen
Sent: Friday, October 27, 2023 3:07 PM
To:
Hi all,
Could you please help to review this patch set? In this patch set, the IoLib
instance BaseIoLibIntrinsic is modified to support AMD SEV feature and the
BaseIoLibIntrinsicSev is removed.
Also could you help to do a test on AMD processor to make sure that the SEV
feature still works good
Hi Mike
Thank you for your feedback.
I have updated the patch to v3: https://edk2.groups.io/g/devel/message/110197
Pull Request: https://github.com/tianocore/edk2/pull/4970
Based on V2, this update includes changes:
- Add more descriptions for "gEdkiiToMigrateFvInfoGuid" PPI usages and
backgro
Hi,
> So, for this purpose, only the following could have a chance of working:
>
> - Expose a new config option on the QEMU command line to the user,
> regarding the intended use of the serial port(s). This could be of any
> tolerable form (machine property, front-end (device) property, whateve
Hi,
> + while (RetryCount < MAX_RETRIES_PER_PAGE) {
> +TdStatus = TdVmCallMapGPA (PhysicalAddress, Length, &MapGpaRetryaddr);
> +if (TdStatus != TDVMCALL_STATUS_RETRY) {
> + break;
> +}
> +
> +DEBUG ((DEBUG_VERBOSE, "%a: TdVmcall(MAPGPA) Retry PhysicalAddress is
> %llx, Ma
---
UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c
b/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c
index 3315a6cc44..c4bf6ad4bb 100644
--- a/UefiCpuPkg/Library/MmSaveState
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Wednesday, October 18, 2023 12:51 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac Oram
> ; Nickle Wang
> Subject:
Thanks for your response, Pedro.
I chased this as a toolchain bug originally, but concluded that the ADR indeed
works before GenFw rewrites it. But I see your point regarding the relocation
statement.
As requested, below is the disassembled function along with relocations. This
was generated
I've enabled the DEBUG mode and I've extracted the following logs (my HTTPS
server IP is 10.0.2.254 in this example)
>
>
>
> >>Start HTTP Boot over IPv4
>
>
>
>
>
> InstallProtocolInterface: BA23B311-343D-11E6-9185-5820B1D65299 7DCBA180
> .MnpAddFreeTxBuf: Add TxBufWrap 7E5DC118, TxBuf 7
Hello all,
Apologies for the late response.
On Fri, 27 Oct 2023 at 14:44, Jake Garver via groups.io
wrote:
>
> Thanks for your response, Pedro.
>
> I chased this as a toolchain bug originally, but concluded that the ADR
> indeed works before GenFw rewrites it. But I see your point regarding th
Hi Ard:
> Can you double check the object file? I suspect this is a linker relaxation
> not a compiler issue.
With LTO in play, is there a way to check the object file? It's not in aarch64
assembly.
Thanks,
Jake
From: Ard Biesheuvel
Sent: Friday, October 27,
On Fri, Oct 27, 2023 at 2:47 PM Ard Biesheuvel wrote:
>
> Hello all,
>
> Apologies for the late response.
>
> On Fri, 27 Oct 2023 at 14:44, Jake Garver via groups.io
> wrote:
> >
> > Thanks for your response, Pedro.
> >
> > I chased this as a toolchain bug originally, but concluded that the ADR
On Fri, Oct 27, 2023 at 3:09 PM Jake Garver via groups.io
wrote:
>
> Hi Ard:
>
> > Can you double check the object file? I suspect this is a linker relaxation
> > not a compiler issue.
>
> With LTO in play, is there a way to check the object file? It's not in
> aarch64 assembly.
Unless you pas
On Fri, 27 Oct 2023 at 16:09, Jake Garver via groups.io
wrote:
>
> Hi Ard:
>
> > Can you double check the object file? I suspect this is a linker relaxation
> > not a compiler issue.
>
> With LTO in play, is there a way to check the object file? It's not in
> aarch64 assembly.
>
Perhaps not.
On Fri, Oct 27, 2023 at 3:13 PM Ard Biesheuvel wrote:
>
> On Fri, 27 Oct 2023 at 16:09, Jake Garver via groups.io
> wrote:
> >
> > Hi Ard:
> >
> > > Can you double check the object file? I suspect this is a linker
> > > relaxation not a compiler issue.
> >
> > With LTO in play, is there a way to
On the other side, using curl I get
curl --cacert rootCA.crt https://10.0.2.254:5248/ --tls-max 1.2 --tlsv1.2 -v
* Trying 10.0.2.254:5248...
* Connected to 10.0.2.254 (10.0.2.254) port 5248 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* CAfile: rootCA.crt
* CApath: /etc/ssl/certs
* T
On Fri, 27 Oct 2023 at 16:26, Pedro Falcato wrote:
>
> On Fri, Oct 27, 2023 at 3:13 PM Ard Biesheuvel wrote:
> >
> > On Fri, 27 Oct 2023 at 16:09, Jake Garver via groups.io
> > wrote:
> > >
> > > Hi Ard:
> > >
> > > > Can you double check the object file? I suspect this is a linker
> > > > rela
On 10/27/2023 9:15 AM, Joey Vagedes via groups.io wrote:
Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to v0.25.1
and performs all necessary integrations as noted in the individual package
commits.
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Michael D Kinney
Cc: Liming Gao
Ard, Pedro,
> Could you try adding -Wl,--no-relax to the DLINK_FLAGS for your build and see
> if it makes a difference?
With "-Wl,--no-relax", I still see an ADR instruction. Clean build. Verified
the "-Wl,--no-relax" is part of the gcc all to build this dll.
2fec :
2fec: a
This allows ambiguous "platform" code in the critical path of the MM
core. Is this necessary?
Do you need this for one feature that others might too and can be
abstracted? Or, do you plan to perform an unknown and arbitrary number
of changes behind the hook over time?
Thanks,
Michael
On 10/
This commit provides 2 sample scripts namely
http_echo_client.py and http_echo_server.py to exercise the
socket capabilities on UEFI shell using the http library from Python UEFI
interpreter.
Jayaprakash N (1):
ek2-libc: Sample python scripts for socket client capabilities on UEFI
shell
.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580
This BZ has been created to provide the sample python scripts
to demonstrate the socket client capabilities using http library
on UEFI shell with the help of Python UEFI interpreter.
The http_echo_client.py and http_echo_server.py scripts
ar
Hi,
This should be the [PATCH V1 2/2] I assume?
On Thu, Oct 26, 2023 at 5:58 PM sunceping wrote:
> From: Ceping Sun
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4572
>
> According to section 3.2 of the [GHCI] document, if the result of MapGPA
> is "TDG.VP.VMCALL_RETRY", TDVF must re
Thank you for the reviews. Pending any reviews other maintainers of these
packages would like to do, this patch series is ready to merge. I've updated
the PR with the reviewed-by tags:
https://github.com/tianocore/edk2/pull/4966
Joey
-Original Message-
From: Michael Kubacki
Sent: Fri
I'd like to bring attention to Apache License 2.0 code in the CodeQL
series I sent to the mailing list for steward review.
In particular, the files in the BaseTools/Plugin/CodeQL/analyze
directory of this patch:
https://edk2.groups.io/g/devel/message/109696
Please let me know if any next ste
On 10/27/23 03:05, Tan, Dun wrote:
Hi all,
Could you please help to review this patch set? In this patch set, the IoLib
instance BaseIoLibIntrinsic is modified to support AMD SEV feature and the
BaseIoLibIntrinsicSev is removed.
Also could you help to do a test on AMD processor to make sure th
This patch set adds serveral IPMI features to support server management:
BmcAcpiState: A DXE driver to notify BMC of S0 power state.
BmcAcpiSwChild: An SMM driver to notify BMC of ACPI power state changes and add
SEL records.
BmcElog: PEI, DXE, and SMM drivers to support BMC event log functions.
Add GenericFruDriver and generate data based on SMBIOS data.
Signed-off-by: Zhen Gong
---
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 4 +
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 3 +-
.../IpmiFeaturePkg/Include/PostMemory.fdf | 3 +-
.../IpmiFeaturePkg/GenericFru/GenericFr
Add DXE and SMM drivers that send "Set ACPI Power State" command to BMC.
Signed-off-by: Zhen Gong
---
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 1 +
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 2 +
.../IpmiFeaturePkg/Include/PostMemory.fdf | 2 +
.../BmcAcpiState/BmcAcpiState
Lightweight lib to support Server Management drivers.
Signed-off-by: Zhen Gong
---
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 1 +
.../ServerManagementLib.inf | 35 +
.../ServerManagementLibNull.inf | 38 +
.../Include/Library/ServerMgmtRtLib.h |
Add generic Elog driver and support BMC Elog operations.
Signed-off-by: Zhen Gong
---
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 +
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 7 +-
.../IpmiFeaturePkg/Include/PostMemory.fdf | 5 +-
.../IpmiFeaturePkg/Include/PreMemory.fdf
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Saturday, October 28, 2023 7:13 AM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Dong, Guo ;
Rhodes, Sean ; Lu, James ; Guo, Gua
Subject: [PATCH v2 1/1] UefiPayloadPkg: Fix incorrect code on Fit function.
From: BruceX Wa
From: Michael Kubacki
Introduces two new APIs to EDKII_VARIABLE_POLICY_PROTOCOL:
1. GetVariablePolicyInfo()
2. GetLockOnVariableStateVariablePolicyInfo()
These allow a caller to retrieve policy information associated with
a UEFI variable given the variable name and vendor GUID.
GetVariableP
From: Michael Kubacki
Adds a new module (dynamic shell command) to ShellPkg that lists
variable policy information for all UEFI variables on the system.
Some other UEFI variable related functionality is also included to
give a greater sense of platform UEFI variable state. This command
is intend
36 matches
Mail list logo
