Re: [edk2-devel] [PATCH v2] DynamicTablesPkg/AmlLib: Enumerate memory attributes

2023-10-10 Thread PierreGondois
Hi Jeshua, Thanks for the v2, Reviewed-by: Pierre Gondois Sami: There was also a tag from Leif: https://edk2.groups.io/g/devel/message/109285 Regards, Pierre On 10/5/23 18:38, Jeshua Smith wrote: AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable and MemoryRangeType parameters

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-10 Thread Ard Biesheuvel
On Sun, 8 Oct 2023 at 17:39, Laszlo Ersek wrote: > > This ArmVirtPkg series can be fetched from: > > repo: https://pagure.io/lersek/edk2.git > branch: armvirt-dual-serial @ 65ee08413595 > > The series does the following: > > - It centralizes (and cleans up) two FDT parsing actions, namely lo

Re: [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: CI: Add PrEval entry

2023-10-10 Thread Ard Biesheuvel
On Mon, 9 Oct 2023 at 18:49, Joey Vagedes wrote: > > Hello All, > > Due to a Subject Line mistake, this particular patch was labeled as a > CryptoPkg change. I'm resending this out to the package maintainers with the > correct package (StandaloneMmPkg). > > Please review this change to your pack

[edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg

2023-10-10 Thread Chang, Abner via groups.io
From: Abner Chang Remove duplicate IpmiCommandLib.h and use the one under MdeModulePKg instead. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Isaac Oram Cc: Nickle Wang Cc: Isaac Oram Cc: Nate DeSimone --- .../IpmiFeaturePkg/BmcElog/BmcElog.inf| 1 + .../IpmiFeaturePkg/F

[edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg

2023-10-10 Thread Chang, Abner via groups.io
From: Abner Chang Remove duplicate IpmiCommandLib.h and use the one under MdeModulePKg instead. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Isaac Oram Cc: Nickle Wang --- .../Universal/IpmiBmcElog/BmcElog.inf | 1 + .../Universal/IpmiFrb/FrbPei.inf | 1 +

[edk2-devel] [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

2023-10-10 Thread Chang, Abner via groups.io
From: Abner Chang Define the structure for IPMI Get System Interface Capabilities command (0x57) Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 8 1 file changed, 8 inserti

[edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

2023-10-10 Thread Chang, Abner via groups.io
From: Abner Chang Define the API for IPMI Get System Interface Capabilities command (0x57) Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Jian J Wang Cc: Liming Gao --- MdeModulePkg/Include/Library/IpmiCommandLib.h | 17 + 1 file changed, 17 insertions(+) diff --git

Re: [edk2-devel] [PATCH v2 2/4] MdePkg: DelayedDispatch: Added WaitOnEvent interface

2023-10-10 Thread Laszlo Ersek
On 10/10/23 02:18, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 > > This change adds a new interface for the delayed dispatch PPI. This > new addition allows functional components relying on delayed dispatch > callbacks to be managed/dispatched with definitive order. >

[edk2-devel] [edk2-platforms][PATCH v1 0/2] Add SMBIOS support for RD-V2 platform

2023-10-10 Thread Pranav Madhu
SMBIOS provides basic hardware and firmware configuration information through table-driven data structure. This patch series adds SMBIOS support for Arm's RD-V2 platforms. The first patch in this series defines platform-id values for the RD-V2 platform. The second patch add CPU information and cac

[edk2-devel] [edk2-platforms][PATCH v1 1/2] Platform/Sgi: Define RD-V2 platform id values

2023-10-10 Thread Pranav Madhu
Add the RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 5 + Platform/ARM/SgiPkg/Library/PlatformLib

[edk2-devel] [edk2-platforms][PATCH v1 2/2] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2023-10-10 Thread Pranav Madhu
The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe

[edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/Sgi: update fastchannel address for RD-N2 variants

2023-10-10 Thread Pranav Madhu
For RD-N2 and variant platforms, the shared SRAM memory carveouts have changed due to updates in the platform firmware. Correspondingly, update the fastchannel address to align with the rest of the platform firmware components. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/AcpiTables/RdN2/

Re: [edk2-devel] [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling

2023-10-10 Thread PierreGondois
Hello Jeshua, Just a small remark, but this should be equivalent, so: Reviewed-by: Pierre Gondois On 10/6/23 18:28, Jeshua Smith wrote: This fixes two bugs and adds some enhancements to the handling of characters and strings in objects being printed by the CM ObjectParser. Bug fixes: 1. Print

Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg/TableHelperLib: Enhance error handling

2023-10-10 Thread PierreGondois
Hello Jeshua, On 10/6/23 18:28, Jeshua Smith wrote: This patch enhances error handling and reporting in the CM ObjectParser. Specifically: 1. ObjectIDs used as array indexes are checked for being out of bounds, and if so an error message is printed before the assert. 2. An error message is p

[edk2-devel] [edk2-platforms][PATCH v1 1/4] Platform/Sgi: add remote memory descriptor

2023-10-10 Thread Sayanta Pattanayak
8GB address region starting at 0x3FE is reserved for extended Remote Memory use. One of the use case, for extended remote memory region, is using it as CXL.Mem region. Remote memory region, with Normal memory attributes, is included into the Translation table entries based on the PcdRemote

[edk2-devel] [edk2-platforms][PATCH v1 2/4] Platform/Sgi: prepare SRAT, HMAT table

2023-10-10 Thread Sayanta Pattanayak
The primary objective of this patch is to create SRAT, HMAT table at runtime based on configuration data found by discovering remote CXL Mem device. In SRAT table, the Localmemory, GICC structure information remain Static, but only configuration data about Remote memory node is updated at runtime.

[edk2-devel] [edk2-platforms][PATCH v1 3/4] Platform/ARM: add CXL driver

2023-10-10 Thread Sayanta Pattanayak
This patch introduces CXL Dxe, which primarily discovers a PCIe device with CXL capability and configures the same. This patch creates and registers event notifier based on gEfiPciEnumerationCompleteProtocolGuid. Once PCIe enumeration is completed then CXL Dxe triggers function to discover CXL cap

[edk2-devel] [edk2-platforms][PATCH v1 4/4] Platform/Sgi: add CXL driver support

2023-10-10 Thread Sayanta Pattanayak
CxlDxe discovers CXL capable device with memory expander capability and reads out memory range details. Platform drivers fetch the remote memory details and include as part of system memory through ACPI tables. Signed-off-by: Sayanta Pattanayak --- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 1 +

[edk2-devel] [edk2-platforms][PATCH v1 0/4] add support for enabling cxl-type3 device as memory expander on Arm/RD platform

2023-10-10 Thread Sayanta Pattanayak
This patch series is about enabling CXL-Type3 capability on Arm reference design platform. * Designated 8GB address space is reserved and configured for using as extended CXL memory. * During PCIe enumeration process, a CXL device with DOE capability is looked for. Once discovered, using DOE m

Re: [edk2-devel] [PATCH v5 24/28] ArmVirtPkg: Apply Memory Protections via SetMemoryProtectionsLib

2023-10-10 Thread Gerd Hoffmann
Hi, > > + gArmVirtTokenSpaceGuid.PcdDxeMemoryProtectionProfile > (3) NB: are we sure this isn't needed for OVMF? (In which case the PCD > would be declared there, and ArmVirtPkg would consume it.) Yes, I think both ovmf and armvirt should use this pcd. ovmf would fallback to that in case noth

Re: [edk2-devel] [PATCH v2 3/4] MdeModulePkg: PeiMain: Introduce implementation of delayed dispatch

2023-10-10 Thread Laszlo Ersek
On 10/10/23 02:18, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 > > This change adds the implementation that fits the needs and description > of PI spec defined Delayed Dispatch PPI in Pei Core. > > The PPI would allow minimal delay for registered callbacks. As well as

Re: [edk2-devel] [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling

2023-10-10 Thread Jeshua Smith via groups.io
Thanks for the review. Reply inline. -Original Message- From: Pierre Gondois Sent: Tuesday, October 10, 2023 4:14 AM To: Jeshua Smith ; devel@edk2.groups.io Cc: sami.muja...@arm.com Subject: Re: [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling External email:

[edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

2023-10-10 Thread Aaron Young
Reference: https://github.com/tianocore/edk2/pull/4892 BmExpandPartitionDevicePath is called to expand "short-form" device paths which are commonly used with OS boot options. To expand a device path, it calls EfiBootManagerConnectAll to connect all the possible BlockIo devices in the system to sea

[edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg/Ipmi: IPMI Get System Interface Capabilities Command

2023-10-10 Thread Chang, Abner via groups.io
From: Abner Chang Implment AppFn, 0x57 command. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang --- .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 68 +++ 1 file changed, 68 insertions(+) diff --git a/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiC

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-10 Thread Laszlo Ersek
On 10/10/23 09:43, Ard Biesheuvel wrote: > On Sun, 8 Oct 2023 at 17:39, Laszlo Ersek wrote: >> >> This ArmVirtPkg series can be fetched from: >> >> repo: https://pagure.io/lersek/edk2.git >> branch: armvirt-dual-serial @ 65ee08413595 >> >> The series does the following: >> >> - It centralize

Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg/TableHelperLib: Enhance error handling

2023-10-10 Thread Jeshua Smith via groups.io
#3 is not currently used by any published code. It is a development aid, which the ObjectParser itself seems to be. Here's why I added it. Several people on our team have (not yet upstreamed) changes that resulted in additional ObjectIDs being added to the ObjectID enums, but without correspond

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg/Ipmi: IPMI Get System Interface Capabilities Command

2023-10-10 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Looks good. Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Tuesday, October 10, 2023 8:47 PM To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang Subject: [edk2-platforms][PATCH] ManageabilityPkg/Ip

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath

2023-10-10 Thread Laszlo Ersek
On 10/10/23 17:06, Aaron Young wrote: > Reference: https://github.com/tianocore/edk2/pull/4892 > > BmExpandPartitionDevicePath is called to expand "short-form" device paths > which are commonly used with OS boot options. To expand a device path, it > calls EfiBootManagerConnectAll to connect all th

Re: [edk2-devel] [PATCH v1 0/2] Fix Python minor version

2023-10-10 Thread Marcin Juszkiewicz
W dniu 7.10.2023 o 01:10, Michael Kubacki pisze: Python 3.12 released recently. The Python version is currently specified to allow updates to newer minor versions. Time is needed to adjust scripts for Python 3.12 so this series fixes the Python version to 3.11. Some places that were already fix

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, October 10, 2023 #cal-reminder

2023-10-10 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, October 10, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-

回复: [edk2-devel] [PATCH v2 0/4] Implement Delayed Dispatch per PI v1.8

2023-10-10 Thread gaoliming via groups.io
Kun: Thanks for your update. I have no other comments. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Kun Qin > 发送时间: 2023年10月10日 8:19 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Jian J > Wang ; Dandan Bi ; > Debkum

Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage

2023-10-10 Thread Nickle Wang via groups.io
Sorry for my late response. > Do we need pack(1) for this structure? We can remove pack directive if we > don't > need to have packed structure members. @nick...@nvidia.com, could you > please confirm this? I see the use of "pack(1)" in EDK2 DriverSample.h. I think we can keep it. Reviewed-by

Re: [edk2-devel] [PATCH 5/9] RedfishClientPkg: reduce identation level by adding early return

2023-10-10 Thread Nickle Wang via groups.io
Sorry for the delay review. I go through the changes, and it looks good to me. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Monday, October 2, 2023 11:10 AM > To: Mike Maslenkin ; devel@edk2.groups.io; Nickle > Wang > Cc: ig...@ami.com >

[edk2-devel] 回复: [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

2023-10-10 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: abner.ch...@amd.com > 发送时间: 2023年10月10日 16:36 > 收件人: devel@edk2.groups.io > 抄送: Abdul Lateef Attar ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu > 主题: [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface > Capabilities > > Fr

[edk2-devel] 回复: [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

2023-10-10 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: abner.ch...@amd.com > 发送时间: 2023年10月10日 16:36 > 收件人: devel@edk2.groups.io > 抄送: Abdul Lateef Attar ; Jian J Wang > ; Liming Gao > 主题: [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface > Capabilities > > From: Abner Chang > > De

回复: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg

2023-10-10 Thread gaoliming via groups.io
This change is a good clean. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chang, Abner > via groups.io > 发送时间: 2023年10月10日 16:22 > 收件人: devel@edk2.groups.io > 抄送: Abdul Lateef Attar ; Isaac Oram > ; Nickle Wang > 主题: [edk2-devel] [edk2-platforms][PATCH 1

回复: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg

2023-10-10 Thread gaoliming via groups.io
This is a good clean. Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chang, Abner > via groups.io > 发送时间: 2023年10月10日 16:22 > 收件人: devel@edk2.groups.io > 抄送: Abdul Lateef Attar ; Isaac Oram > ; Nickle Wang ; Nate > DeSimone > 主题: [edk2-devel] [edk2-platforms][PATCH 2/2]

回复: 回复: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

2023-10-10 Thread gaoliming via groups.io
Taylor: Thanks for your detail information. I understand more in the detail. The changes is good to me. Reviewed-by: Liming Gao Thanks Liming 发件人: devel@edk2.groups.io 代表 Taylor Beebe 发送时间: 2023年10月9日 3:21 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; 'Ard Biesheuvel' 抄送: 'Andre

[edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules

2023-10-10 Thread Chang, Abner via groups.io
From: Abner Chang BZ #: 4566 Update Redfish modules to use the small footprint version of base SortLib by the means of module scoped subelement . With this the platform level SortLib (full version) is not impacted if Redfish.dsc.inc is included in platform DSC. Signed-off-by: Abner Chang Cc: N

Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules

2023-10-10 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Wednesday, October 11, 2023 11:41 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; Nhi > Pham > Subject: [PATCH] RedfishPkg: Use base version SortLib for the specific

Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules

2023-10-10 Thread Nhi Pham via groups.io
Thanks for writing this patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham Regards, Nhi On 10/11/2023 10:49 AM, Nickle Wang wrote: Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Wednesday, October 11, 2023 11:41 AM To: devel@edk2.group

Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules

2023-10-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] https://github.com/tianocore/edk2/pull/4906 is merged. Abner > -Original Message- > From: Nhi Pham > Sent: Wednesday, October 11, 2023 12:14 PM > To: Nickle Wang ; Chang, Abner > ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re: [PATCH] Redf

Re: [edk2-devel] [edk2-platforms][PATCH V3 1/1] Platform/ARM/N1sdp: Add support to parse NT_FW_CONFIG

2023-10-10 Thread chandni cherukuri
Hi Sahil, These changes look good to me. Reviewed-by: Chandni Cherukuri Regards, Chandni Cherukuri On Wed, Aug 23, 2023 at 4:33 PM sahil wrote: > > NT_FW_CONFIG DTB contains platform information passed by > Tf-A boot stage. > This information is used for Virtual memory map generation > during

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-10-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Aladyshev, Here is my response, 1. Shouldn't we update the PLDM protocol's 'PldmSubmit' function to receive 'MctpSrcEID'/'MctpDestEID'. Yes, I see the use case of EFI shell application. I would like to have the input parameters similar with MctpSubmitCommand