Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically

On Tue, Sep 12, 2023 at 04:17:14PM +0200, Laszlo Ersek wrote: > "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro > VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already > use it (such as ArmVirtPkg/PlatformBootManagerLib, > OvmfPkg/VirtioSerialDxe). We should us

Re: [edk2-devel] [PATCH] OvmfPkg: raise DXEFV size to 14.5 MB in the traditional platform FDFs

Hi, > In particular I suspect (but have no proof) that the OpenSSL 3.0 update > led to a size explosion. This latest increase both comes sooner and is > larger than the previous ones. Yes, it's openssl 3. > It could likely be mitigated by including the crypto driver in OVMF (as > opposed to li

Re: [edk2-devel] [PATCH] OvmfPkg: raise DXEFV size to 14.5 MB in the traditional platform FDFs

On Tue, Sep 12, 2023 at 04:18:49PM +0200, Laszlo Ersek wrote: > My usual IA32X64 and X64 builds fail for the NOOPT target, using GCC5: > > - IA32X64: > > > the required fv image size 0xdef130 exceeds the set fv image size > > 0xd0 > > - X64: > > > the required fv image size 0xd8f7b8 exceeds

Re: [edk2-devel] [PATCH v4 1/2] MdePkg/BaseFdtLib: Add Fdt function.

Reviewed-by: Benny Lin -Original Message- From: Wang, BruceX Sent: Monday, September 18, 2023 3:02 PM To: devel@edk2.groups.io Cc: Wang, BruceX ; Lin, Benny ; Guo, Gua ; Chiu, Chasel ; Lu, James Subject: [PATCH v4 1/2] MdePkg/BaseFdtLib: Add Fdt function. From: "Brucex.Wang" Add F

[edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes

There are some changes in progress which make BL1 bigger than 0x8000 which EDK2 uses. TF-A defines BL1 size to be 0x12000 one. So let follow it. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Plat

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes

On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote: > There are some changes in progress which make BL1 bigger than 0x8000 > which EDK2 uses. > > TF-A defines BL1 size to be 0x12000 one. So let follow it. > > Signed-off-by: Marcin Juszkiewicz This fixes a TF-A bug that you uncover

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes

On Mon, 18 Sept 2023 at 13:35, Leif Lindholm wrote: > > On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote: > > There are some changes in progress which make BL1 bigger than 0x8000 > > which EDK2 uses. > > > > TF-A defines BL1 size to be 0x12000 one. So let follow it. > > > > Signed-

Re: [edk2-devel] [PATCH v4 1/2] MdePkg/BaseFdtLib: Add Fdt function.

Reviewed-by: Gua Guo -Original Message- From: Wang, BruceX Sent: Monday, September 18, 2023 3:02 PM To: devel@edk2.groups.io Cc: Wang, BruceX ; Lin, Benny ; Guo, Gua ; Chiu, Chasel ; Lu, James Subject: [PATCH v4 1/2] MdePkg/BaseFdtLib: Add Fdt function. From: "Brucex.Wang" Add Fdt

Re: [edk2-devel] [PATCH v4 2/2] UefiPayloadPkg: Add FIT support

Reviewed-by: Gua Guo -Original Message- From: Wang, BruceX Sent: Monday, September 18, 2023 3:02 PM To: devel@edk2.groups.io Cc: Wang, BruceX ; Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH v4 2/2] UefiPayloadPkg: Add FIT support From: "Brucex.Wang" Provide Fit f

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes

W dniu 18.09.2023 o 14:33, Ard Biesheuvel pisze: On Mon, 18 Sept 2023 at 13:35, Leif Lindholm wrote: Note for the interested: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417 TL;DR: the fip base and bl1 size don't line up. The bl1 size was already set to sufficient size, b

[edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

JsonObjectGetValue() cannot find corresponding JSON value when the EDKII_JSON_VALUE object is created by another UEFI driver. This is because "hashtable_seed" is initialized by current time while JsonLib is loaded. So, "hashtable_seed" will be different in each individual UEFI driver. Signed-off-b

[edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Return unsupported HTTP status code to caller so caller can handle HTTP error status code. Current implementation only return EFI error to caller. Without knowing the HTTP status code, caller has trouble to handle HTTP request failure. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchyts

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Hi Mike, Sorry for my late response. Version2 is here: https://edk2.groups.io/g/devel/message/108778 Please help me to review it while you have chance. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, August 3, 2023 6:16 PM > To: Nickle Wang > Cc: devel@ed

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Hi @Abner Chang I update the function header of RedfishRestExSendReceive() in 2nd version and I assume there is no need to update UEFI specification for this. Please feel free to correct me if I am wrong. Thanks, Nickle > -Original Message- > From: d

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Nickle, Does that mean, that json_object_seed function is useless anymore with those changes? And there is no need for other module to call json_object_seed? Thank you, Igor -Original Message- From: Nickle Wang Sent: Monday, September 18, 2023 9:09 AM To: devel@edk2.groups.io Cc: Abne

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Monday, September 18, 2023 9:13 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez ; Mike Maslenkin Subject: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP

[edk2-devel] [PATCH v4 2/4] UefiCpuPkg/ResetVector: Remove AP waking vector from ResetVector

From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Current reset vector uses 0xffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code a

[edk2-devel] [PATCH v4 3/4] MdePkg/BaseFdtLib: Add Fdt function.

From: "Brucex.Wang" Add FdtGetName() and FdtNodeDepth() function. Cc: Benny Lin Cc: Gua Guo Cc: Chasel Chiu Cc: James Lu Signed-off-by: BruceX Wang --- MdePkg/Include/Library/FdtLib.h| 34 + MdePkg/Library/BaseFdtLib/FdtLib.c | 40 ++

[edk2-devel] [PATCH v4 0/4] UefiPayloadPkg: Add FIT support

From: "Brucex.Wang" V4: Fix Benny comment in patch mail. V3: Fix Lean Sheng comment in patch mail V2: Fix Gua and Chasel comment in PR V1: Initialize Version Brucex.Wang (2): MdePkg/BaseFdtLib: Add Fdt function. UefiPayloadPkg: Add FIT support Zhiguang Liu (2): OvmfPkg: Remove applicatio

[edk2-devel] [PATCH v4 1/4] OvmfPkg: Remove applicationProcessorEntryPoint

From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Current reset vector uses 0xffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code a

[edk2-devel] [PATCH v4 1/4] OvmfPkg: Remove applicationProcessorEntryPoint

From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Current reset vector uses 0xffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code a

[edk2-devel] [PATCH v4 3/4] MdePkg/BaseFdtLib: Add Fdt function.

From: "Brucex.Wang" Add FdtGetName() and FdtNodeDepth() function. Cc: Benny Lin Cc: Gua Guo Cc: Chasel Chiu Cc: James Lu Signed-off-by: BruceX Wang --- MdePkg/Include/Library/FdtLib.h| 34 + MdePkg/Library/BaseFdtLib/FdtLib.c | 40 ++

[edk2-devel] [PATCH v4 4/4] UefiPayloadPkg: Add FIT support

From: "Brucex.Wang" Provide Fit format for UniversalPayload, developer can use argument "--Fit" to build UniversalPayload.fit Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: BruceX Wang --- .../Include/Guid/UniversalPayloadBase.h | 19 + UefiPayloadPkg/PayloadL

[edk2-devel] [PATCH v4 0/2] UefiPayloadPkg: Add FIT support

From: "Brucex.Wang" V4: Fix Benny comment in patch mail. V3: Fix Lean Sheng comment in patch mail V2: Fix Gua and Chasel comment in PR V1: Initialize Version Brucex.Wang (2): MdePkg/BaseFdtLib: Add Fdt function. UefiPayloadPkg: Add FIT support MdePkg/Include/Library/FdtLib.h

[edk2-devel] [PATCH v4 4/4] UefiPayloadPkg: Add FIT support

From: "Brucex.Wang" Provide Fit format for UniversalPayload, developer can use argument "--Fit" to build UniversalPayload.fit Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: BruceX Wang --- .../Include/Guid/UniversalPayloadBase.h | 19 + UefiPayloadPkg/PayloadL

[edk2-devel] [PATCH v4 0/4] UefiPayloadPkg: Add FIT support

From: "Brucex.Wang" V4: Fix Benny comment in patch mail. V3: Fix Lean Sheng comment in patch mail V2: Fix Gua and Chasel comment in PR V1: Initialize Version Brucex.Wang (2): MdePkg/BaseFdtLib: Add Fdt function. UefiPayloadPkg: Add FIT support Zhiguang Liu (2): OvmfPkg: Remove applicatio

[edk2-devel] [PATCH v4 2/2] UefiPayloadPkg: Add FIT support

From: "Brucex.Wang" Provide Fit format for UniversalPayload, developer can use argument "--Fit" to build UniversalPayload.fit Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: BruceX Wang --- .../Include/Guid/UniversalPayloadBase.h | 19 + UefiPayloadPkg/PayloadL

[edk2-devel] [PATCH v1] MdeModulePkg: Ignore TAB in string input

From: Oscar Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4550 Ignore TAB when handling input characters for string input to be consistent with the usual behavior. Signed-off-by: Oscar Li Cc: Dakota Chiang Cc: Dandan Bi Cc: Eric Dong --- MdeModulePkg/Universal/DisplayEngineDxe/In

[edk2-devel] [PATCH v4 2/4] UefiCpuPkg/ResetVector: Remove AP waking vector from ResetVector

From: Zhiguang Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Current reset vector uses 0xffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code a

[edk2-devel] [PATCH v4 1/2] MdePkg/BaseFdtLib: Add Fdt function.

From: "Brucex.Wang" Add FdtGetName() and FdtNodeDepth() function. Cc: Benny Lin Cc: Gua Guo Cc: Chasel Chiu Cc: James Lu Signed-off-by: BruceX Wang --- MdePkg/Include/Library/FdtLib.h| 34 + MdePkg/Library/BaseFdtLib/FdtLib.c | 40 ++

[edk2-devel] [PATCH 1/1] MdeModulePkg\XhciDxe: Command Abort when times out

https://bugzilla.tianocore.org/show_bug.cgi?id=4552 CC: Hao A Wu CC: Ray Ni CC: Jian J Wang CC: Liming Gao CC: More Shih Signed-off-by: Xianglei Cai --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 35 1 file changed, 35 insertions(+) diff --git a/Mde

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, September 18, 2023 9:13 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez ; Mike Maslenkin > > Subject: [PATCH v2] RedfishPkg/RedfishRe

[edk2-devel] [PATCH v4 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function

Add API to generate a ThermalZone object to AmlLib. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 28 + .../Common/AmlLib/CodeGen/AmlCodeGen.c| 116 ++ 2 files changed, 144 insertions(+) diff --git a/DynamicTablesPkg/Include/

[edk2-devel] [PATCH v4 0/4] Add support for generating ACPI ThermalZones

Add APIs needed to create thermal zones dynamically. Does not add a generator for this as creating the TMP method generically may be difficult. Change log: v4 - Fixed an additional error handling path v3 - Fixed a couple error handling paths v2 - renamed NameString function and added goto dones i

[edk2-devel] [PATCH v4 2/4] DynamicTablesPkg: Add support for simple method invocation.

Add support to add Return objects via AML that pass a single integer argument to the named method. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 54 .../Common/AmlLib/CodeGen/AmlCodeGen.c| 244 ++ 2 files changed, 298 insertio

[edk2-devel] [PATCH v4 3/4] DynamicTablesPkg: Add support to add Strings to package

Add API to add a String to a package created with NamedPackage API. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 17 .../Common/AmlLib/CodeGen/AmlCodeGen.c| 88 +++ 2 files changed, 105 insertions(+) diff --git a/DynamicTabl

[edk2-devel] [PATCH v4 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API

Add API to generate a Name that contains a Unicode string buffer. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 31 +++ .../Common/AmlLib/CodeGen/AmlCodeGen.c| 86 +++ 2 files changed, 117 insertions(+) diff --git a/DynamicTab

Re: [edk2-devel] [PATCH v4 0/2] UefiPayloadPkg: Add FIT support

Series Reviewed-by: Gua Guo -Original Message- From: devel@edk2.groups.io On Behalf Of brucex.w...@intel.com Sent: Monday, September 18, 2023 3:02 PM To: devel@edk2.groups.io Cc: Wang, BruceX Subject: [edk2-devel] [PATCH v4 0/2] UefiPayloadPkg: Add FIT support From: "Brucex.Wang" V4

[edk2-devel] [PATCH edk2-platforms v2 1/1] Platform/Ampere: Update Readme.md

Improve the Readme.md in Platform/Ampere: Direct people to the top-level Readme.md file for build instructions. Mention the edk2-ampere-tools repo for additional build tools. Delete everything else, since it's redundant. Signed-off-by: Rebecca Cran --- Platform/Ampere/Readme.md | 29 ++-

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Memory Bin Range Update Accounts for Guard Page

Merged - https://github.com/tianocore/edk2/commit/408e4631359d3e67633b36f6adf9a13a7cc573d3 On 8/10/2023 2:06 PM, Taylor Beebe wrote: From: Taylor Beebe When finding a free page range for allocation, if the found range starts below the tracked memory bin address range, the lowest memory bin ad

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, September 18, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, September 18, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, September 18, 2023 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* Monday, September 18, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-

Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Monday, September 18, 2023 3:35 PM > To: devel@edk2.groups.io; Leif Lindholm ; Sami > Mujawar ; Gerd Hoffmann > Cc: Ard Biesheuvel > Subject: Re: [edk2-devel] [PATCH v

Re: [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Monday, September 18, 2023 3:37 PM > To: devel@edk2.groups.io; Pierre Gondois ; Yeo Reum > Yun ; nd > Cc: sami.muja...@arm.com > Subject: Re: [edk2-devel] [PATCH v2 5/7

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, September 19, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, September 19, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e34

[edk2-devel] [PATCH v1 0/1] RISCV: Fix InternalLongJump

I was playing around with building code with -Os and ran into weird crashes, that I ended up chasing down to an obviously incorrect InternalLongJump implementation, which has never been correctly passing its 2nd parameter down as the return value of SetJump. You can find the pull at https://github

[edk2-devel] [PATCH v1 1/1] RISCV: Fix InternalLongJump to return correct value

InternalLongJump was not returning the 2nd parameter passed to LongJmp (Value) as the return value from SetJmp. Seen with code compiled with -Os, where an LongJmp (Buffer, -1) somehow translated to SetJmp returning 0... Cc: Yong Li Cc: Sunil V L Cc: Tuan Phan Cc: Daniel Schaefer Signed-off-by