Hi Ard,
Thanks for your response on this patch. Please see my reply inline...
On 8/30/2023 8:10 PM, Ard Biesheuvel wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
On Wed
Hi Sean,
> I propose we remove openssl from the edk2 CryptoPkg and into the
> OpenSslCryptoPkg in another new tianocore repository dedicated to OpenSsl.
> MbedTls could then be checked into the MbedTlsCryptoPkg and added to another
> new repository.
It may be a better choice to put openssl a
Like Sean, I'm very positive to the work - and I'm excited about the
opportunity to formalise the abstractions.
But Sean is also asking to import the mbedTLS code outright instead of
using submodules, which adds an additional dimension to the matrix below.
I'm not too concerned over the infra
On 8/29/2023 8:05 PM, Richard Ho (何明忠) wrote:
Hi Rebecca,
We have tried the patch. It works on my device.
I think it could be add it into UsbNetwork source. Do you think?
I agree, it looks good.
Reviewed-by: Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages se
Hi,
Apologies for the long delay reviewing this set.
I have rebased your patches onto:
https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci
I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
not break bisect.
If you're happy with the slightly modified version, I think thi
On Thu, 31 Aug 2023 at 15:06, Leif Lindholm wrote:
>
> Hi,
>
> Apologies for the long delay reviewing this set.
>
> I have rebased your patches onto:
> https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci
>
> I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
> not break bis
> (I don see what is the response header for MCTP KCS in spec though, does it
> mention the KCS response?).
The spec doesn't explicitly mention that the format of a send and
response packets differ. So I assume it is the same and it is
described at the "Figure 1 – MCTP over KCS Packet Format"
(ht
[AMD Official Use Only - General]
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Konstantin Aladyshev via groups.io
> Sent: Thursday, August 31, 2023 10:57 PM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discuss
I have not looked at the Mbedtls patches in detail yet, but I
am curious if it is possible to add the mbedtls based library
instances of the edk2 crypto libraries to the existing
CryptoPkg and pull the mbedtls sources into the CryptoPkg using
a submodule just like openssl? This way, platforms can
[AMD Official Use Only - General]
But wait, wee my another comment below,
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, August 31, 2023 11:42 PM
> To: devel@edk2.groups.io; aladyshe...@gmail.com
> Cc: disc...@edk2.groups.io
> Subject: RE: [edk2-devel] [edk2-discuss] PLDM mes
Are mPrivateData.Smbios.MajorVersion and mPrivateData.Smbios.MinorVersion
guaranteed to be in range 0..9?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> horacex.l...@intel.com
> Sent: Wednesday, August 30, 2023 2:13 AM
> To: devel@edk2.groups.io
> Cc: Lien, HoraceX
As I've said there is nothing like "KCS completion code" in the MCTP
over KCS binding specification
(https://www.dmtf.org/sites/default/files/standards/documents/DSP0254_1.0.0.pdf).
The response packet should have the same structure as a request. I.e.
a packet with MANAGEABILITY_MCTP_KCS_HEADER and
On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote:
>
> On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > I have tried the patch below, and I don't see any slowdowns with or
> > > without the patch, running both DEBUG and RELEASE builds under
> > > ordinary KVM/nested-vir
Hi Mike
We are using submodule for mbedtls in this patch. Copying source code is not
preferred.
I think we are discussing multiple ways to layout the *mbedtls crypto wrapper*.
See following 4 options.
Thank you
Yao, Jiewen
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursd
This patch fixes the compilation issue of Python UEFI interpreters socket
module due to duplicate definitions of certain structures as reported
in BZ 4545.
Jayaprakash N (1):
ek2-libc: socket module of python UEFI fails to compile with GCC
.../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4545
The compilation issues reported in the BZ are fixed by
defining below 2 macros in pyconfig.h
HAVE_ADDRINFO
HAVE_SOCKADDR_STORAGE
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Jayaprakash N
---
.../Python/Python
Jiewen,
Thanks. Option #1 makes more sense if it is the Mbedtls
wrapper code.
I prefer Option #1.
Breaking out into multiple repos also makes it hard to align
Releases across multiple repos. We already have this as an
unsolved problem for edk2-platforms repo, and I am not interested
in adding
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Thursday, August 31, 2023 9:13 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI
> fails
Hi Nate,
I do not disagree with the logic of the patch.
Reviewed-by: Michael D Kinney
However, I do not understand how the 1st call to
InternalCoreLocateHandle() can succeed and the 2nd call
can fail if the handle database protocol lock is in
the acquired state.
Is there a real scenario where
replying to the whole chain.
I am not encouraging importing the source directly but still trying to
isolate the "wrapper code" and the external mbedtls submodule management.
I am advocating that the underlying crypto implementation is 100%
"hidden" from public include/dependency and the rest
Subject: [edk2-platfoms][PATCH V1] WhitleyOpenBoardPkg : Updated
PcdFlashFvSecuritySize for JunctionCity and Aowanda platform
Fix to resolve the build error for JunctionCity and Aowanda platform.
Updated PcdFlashFvSecuritySize in JunctionCity\PlatformPkg.fdf and
Aowanda\PlatformPkg.fdf
Cc: Hari
How is the current patch set a breaking change?
Mike
From: Sean Brogan
Sent: Thursday, August 31, 2023 10:52 AM
To: devel@edk2.groups.io; Kinney, Michael D ; Yao,
Jiewen ; Leif Lindholm ; Hou,
Wenxing
Cc: af...@apple.com
Subject: Re: [edk2-devel] [edk2/add_mbedtls PATCH 0/9] *** Add
HMAC/HKD
The breaking change would be in the future to move/make these structural
changes (package /repo) in the future after checking in this patch.
Thanks
Sean
On 8/31/2023 11:45 AM, Michael D Kinney wrote:
How is the current patch set a breaking change?
Mike
*From:* Sean Brogan
*Sent:* Thursd
Hi Mike,
I agree that it should be extremely rare for the 1st call to succeed AND the
2nd call to fail. The only case I can think of where that could happen is if
the call to AllocatePool() in CoreFindProtocolEntry() fails due to an out of
memory scenario. As always thank you for your careful r
A gentle ping :)
https://edk2.groups.io/g/devel/message/92452
As MdeModulePkg/Core was modified, might it be possible to add more?
Should I resend those patches?
MdeModulePkg/Core maintainers didn't reply.
Regards,
MIke.
On Thu, Aug 31, 2023 at 11:02 PM Nate DeSimone
wrote:
>
> Hi Mike,
>
> I
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This module supports Sophgo SG2042 EVB platform. It uses the
PEI less design. Add this module in SG2042Pkg leveraging the
one from OvmfPkg/RiscVVirt.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc: m
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
SG2042 (Xuantie C920) MMU can be enabled in SV39 mode. C920 has five
customizable page properties that control whether the page is Strong
order(SO), Cacheable(C), Bufferable(B), Shareable(SH), Trustable(Sec).
This driver modifies the page table attrib
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This driver installs SMBIOS information for SG2042. Install hardware
information by creating an SMBIOS table which includes BIOS version,
system manufacturer, product name, processor, memory, slots, storage,
and other.
Signed-off-by: caiyuqing379 <20
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This driver implements Sophgo SDHCI controller, which provides
the necessary interfaces for handling communication and data
transfer with SD cards.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc: men
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
Add infrastructure files to build edk2-platforms for Sophgo SG2042
platform. It follows PEI less design.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc: meng-cz
Cc: yli147
Cc: ChaiEvan
Cc: Sunil V
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
Add SG2042Pkg for Sophgo SG2042 platform. Provides PCD tokens.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc: meng-cz
Cc: yli147
Cc: ChaiEvan
Cc: Sunil V L
---
Platform/Sophgo/SG2042Pkg/SG2042P
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn>
Co-authored-by: USER0FISH
Cc: dahogn
Cc: meng-cz
Cc: yli147
Cc: ChaiEvan
Cc: Sunil V L
*** BLURB HERE ***
caiyuqing379 (8):
Sophgo/SG2042Pkg: Add SmbiosPlatformDxe module.
Sophgo/SG20
From: caiyuqing379 <202235...@mail.sdu.edu.cn>
This driver implements the MMC Host protocol, which is used by SD
interface driver that the Sophgo SG2042 EVB supports. Add this driver
in Sophgo/SG2042Pkg leveraging the one form Embedded Package.
Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.
Can you please resend the patch series.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mike
> Maslenkin
> Sent: Thursday, August 31, 2023 2:20 PM
> To: devel@edk2.groups.io; Desimone, Nathaniel L
>
> Cc: Kinney, Michael D ; Gao, Liming
> ; Wang, Jian J ; Bi
Please, find trivial memory leak fixes on error path.
The only question: is it required to use FreePool() or CoreFreePool()
from DXE core code? Patch 2/2 is made in accordance with existing code.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Nate DeSimone
Signed-off-by: Mike Maslenkin
FwVolHeader must be deallocated on error path.
Signed-off-by: Mike Maslenkin
---
MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
index 153bfecafa77..0c1554ba4d63 100644
--- a/MdeMod
FvbDev->LbaCache must be freed on error path before deallocating FvbDev.
Signed-off-by: Mike Maslenkin
---
MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBl
The Hii form is named "MainFormState" while the EFI variable is named
"PlatformConfig".
This discrepancy in names causes the following SCT cases to fail on
RiscVVirtQemu:
ExtractConfigConformance
ExtractConfigFunction
ExtractConfig_Func
Previous Commit 16acacf addressed two of these issues, and t
Hi Jian and Liming,
Could you please help to review this patch?
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan
Sent: Wednesday, August 30, 2023 3:36 PM
To: devel@edk2.groups.io
Cc: Wang, Jian J ; Gao, Liming
; Ni, Ray
Subject: [edk2-devel] [Patch V2] MdeM
-*GopBlt = AllocatePool (*GopBltSize);
+*GopBlt = AllocatePages (*GopBltSize);
It doesn't look right. You cannot pass in the same value origilly passed to
AllocatePool().
Thanks,
Ray
From: Ck, Chitralekha
Sent: Thursday, August 3, 2023 5:29 PM
To
[AMD Official Use Only - General]
See my answer below,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Konstantin Aladyshev via groups.io
> Sent: Friday, September 1, 2023 12:02 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; disc...@edk2.groups.io
> Subject: Re: [edk
41 matches
Mail list logo
