Re: [edk2-devel] OVMF build.sh change is incorrect

2023-08-20 Thread Mike Beaton
This is now in https://bugzilla.tianocore.org/show_bug.cgi?id=4528 as it should have been in the first place! On Sun, 13 Aug 2023 at 11:34, Mike Beaton wrote: > > Perhaps I can briefly clarify: > > "This now no longer works" was too brief - of course the listed command does > build and start QEM

[edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-20 Thread Elyes Haouas
Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas --- EmbeddedPkg/Include/fdt.h | 4 ++-- ...

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, August 21, 2023 #cal-reminder

2023-08-20 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, August 21, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272

[edk2-devel] [Patch V2 0/5] Use MpService2Ppi to wakeup CPU in Smm CpuS3

2023-08-20 Thread duntan
In V2 patch set: 1.Put MpService2Ppi together with other Return*** fields as they are a group of fields initialized in S3 boot path. 2.Use %lx print format for MpService2Ppi 3.Implemente InitializeAp and InitializeBsp as a single function InitializeCpuProcedure because they are doing almost the s

[edk2-devel] [Patch V2 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

2023-08-20 Thread duntan
Add MpService2Ppi field in SMM_S3_RESUME_STATE of AcpiS3Context.h. It will be used to wakeup AP to do the CPU initialization during smm s3 boot flow in following patches. With this field, we can avoid sending InitSipiSipi to wakeup AP. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Jian J Wang Cc: Limin

[edk2-devel] [Patch V2 2/5] UefiCpuPkg/S3Resume2Pei: prepare MpService2Ppi in S3Resume

2023-08-20 Thread duntan
Prepare MpService2Ppi in S3Resume when PEI and SMM env run in the same execution mode. Then smm s3 code can use Mp Service to wakeup AP instead of only sending InitSipiSipi. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Dun Tan --- UefiCpuPkg/Universal/Acpi/S

[edk2-devel] [Patch V2 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode combo

2023-08-20 Thread duntan
Add assert for invalid excution mode combination of 64bit PEI + 32bit DXE. Signed-off-by: Dun Tan Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/UefiCpuPkg/Universal/Acpi/S3Resu

[edk2-devel] [Patch V2 4/5] UefiCpuPkg/PiSmmCpuDxe: code refinement for CpuS3.c

2023-08-20 Thread duntan
This commit is code logic refinement for s3 boot flow in CpuS3.c. It doesn't change any code functionality. This commit implementes InitializeAp and InitializeBsp as a single function since they are doing almost the same thing. Then both BSP and AP will execute the same function InitializeCpuProced

[edk2-devel] [Patch V2 5/5] UefiCpuPkg/PiSmmCpuDxe: use MpService2Ppi to wakeup AP in s3

2023-08-20 Thread duntan
Use MpService2Ppi to wakeup AP in s3 boot flow during initializing CPU. If mSmmS3ResumeState->MpService2Ppi is not 0, then BSP will use MpService2Ppi->StartupAllCPUs to do CPU initialization for both BSP and AP instead of only sending InitSipiSipi for AP. Signed-off-by: Dun Tan Cc: Eric Dong Cc:

[edk2-devel] [PATCH V1 1/1] OvmfPkg/TdxDxe: Change MadtMpWk->MailBoxVersion from 1 to 0

2023-08-20 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4527 According to ACPI 6.5 (https://uefi.org/specs/ACPI/6.5/05_ACPI_Software _Programming_Model.html?highlight=mailboxversion#multiprocessor-wakeup- structure) the MailBoxVersion is 0. This patch changed MadtMpWk->MailBoxVersion

[edk2-devel] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix boot hang with faulty PCI Option ROM

2023-08-20 Thread Nhi Pham via groups.io
A faulty PCI device has the Option ROM image size set to 0. UEFI reads two headers PCI_EXPANSION_ROM_HEADER and PCI_DATA_STRUCTURE to get the Option ROM information. Because the image size is 0, the Option ROM header address never changes. As a result, UEFI keeps reading the same two headers defini

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add Cxl20.h into IndustryStandard

2023-08-20 Thread Nong, Foster
Hi Mike, Yes. In CXL SPEC chapter 8.1.9, the number of register blocks need calculate from DVSEC length value of DVSEC header1 register. -Original Message- From: Kinney, Michael D Sent: Friday, August 18, 2023 11:30 PM To: Chris Li OS ; devel@edk2.groups.io; Nong, Foster ; Gao, Lim

[edk2-devel] [RESEND][PATCH 1/1] MdeModulePkg/PciBusDxe: Fix boot hang with faulty PCI Option ROM

2023-08-20 Thread Nhi Pham via groups.io
A faulty PCI device has the Option ROM image size set to 0. UEFI reads two headers PCI_EXPANSION_ROM_HEADER and PCI_DATA_STRUCTURE to get the Option ROM information. Because the image size is 0, the Option ROM header address never changes. As a result, UEFI keeps reading the same two headers defini

[edk2-devel] [PATCH] BaseTools/Conf/tools_def.template: Fix uninitialized variable error

2023-08-20 Thread 汪流
GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE add -Wno-maybe-uninitialized to fix build error. Signed-off-by: wangliu-iscas --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template