On Thu, Aug 10, 2023 at 8:09 AM Wu, Hao A wrote:
> > -Original Message-
> > From: Ranbir Singh
> > Sent: Monday, July 17, 2023 7:39 PM
> > To: devel@edk2.groups.io; rsi...@ventanamicro.com
> > Cc: Wu, Hao A ; Ni, Ray ; Veeresh
> > Sangolli
> > Subject: [PATCH v1 1/2] MdeModulePkg/Bus/Pc
On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> I'm not sure why test results are not being reported that may be a
> larger issue.
>
> I pulled the branch locally, run uncrustify, and it automatically
> fixed
> the code to pass.
>
> The issue is the following function call:
>
>
My take is that:
For all the possible calling scenario of UhciConvertPollRate() in current
UhciDxe driver implementation, it is guaranteed that the input parameter
'Interval' will not be 0.
I think this is why the "ASSERT (Interval != 0);" statement is put here to
indicate such case will never hap
When code is compiled in RELEASE mode, the ASSERT (Interval != 0);
statement gets NULL'ified. Hence for Coverity it simply doesn't exist.
Further, IMO Coverity seems to look at a function in isolation whether it
is safe or not. It is however not necessary to fix all issues pointed out
by Coverity i
Hi Arun,
When I apply these changes in intel platform, I will hit some "warning treated
as error" issues, so I file a bug in tianocore:
https://bugzilla.tianocore.org/show_bug.cgi?id=4522
Could you please help to check it?
Thanks!
Best Regards,
Yanbo Huang
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
XhciDxe uses the timer functionality provided by the
boot services table to detect timeout conditions. This
breaks the driver's ExitBootServices call back, as
CoreExitBootServices halts the timer before signaling
the ExitBootServices event. I
Patch series seems sane to me.
Reviewed-by: Graeme Gregory
(I seem to be moving further and further from ARM development and even
further from SBSA machine development so Ill probably remove myself
as a reviewer for this machine)
On Wed, Jul 19, 2023 at 02:08:39PM +0200, Marcin Juszkiewicz wrot
From: Michael Kubacki
Adds a new script and build plugin called DebugMacroCheck.
The script verifies that the number of print specifiers match the
number of arguments in DEBUG() calls.
Overview:
- Build plugin: BuildPlugin/DebugMacroCheckBuildPlugin.py
- Runs on any build target that is not
From: Michael Kubacki
Some macros added have a mismatched number of print specifiers to
arguments.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Michael Kubacki
---
RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
| 8
From: Michael Kubacki
regex is a popular PIP module for regular expression support.
https://pypi.org/project/regex/
This change adds regex for the upcoming DebugMacroCheck plugin.
Cc: Sean Brogan
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
pip-requirements.txt |
From: Michael Kubacki
Adds a CI YAML entry to acknowledge a case where a single argument
is matched to a format specifier with a ternary operator.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: Michael Kubacki
---
SecurityPkg/SecurityPkg.ci.yaml | 9 +
1 file changed, 9 insertions(+)
From: Michael Kubacki
Adds a CI YAML entry to acknowledge a case where a macro is expanded
that contains a print specifier.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Michael Kubacki
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 8
1 file changed,
From: Michael Kubacki
Adds a CI YAML entry to acknowledge a case where custom strings
contain print specifiers for a single debug macro.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Cc: Pierre Gondois
Signed-off-by: Michael Kubacki
---
DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8
1 file c
From: Michael Kubacki
Disables the DebugMacroCheck CI plugin to reduce CI checks performed
in the package.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Michael Kubacki
---
OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 +
1 file changed, 1 insertion(+)
From: Michael Kubacki
Adds a plugin that finds debug macro formatting issues. These errors
often creep into debug prints in error conditions not frequently
executed and make debug more difficult when they are encountered.
The code can be as a standalone script which is useful to find
problems in
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, August 14, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272
On Mon, Aug 14, 2023 at 9:49 PM Michael Kubacki
wrote:
>
> From: Michael Kubacki
>
> Adds a new script and build plugin called DebugMacroCheck.
>
> The script verifies that the number of print specifiers match the
> number of arguments in DEBUG() calls.
>
> Overview:
>
> - Build plugin: BuildPlug
*Tools, CI, Code base construction meeting series*
*When:*
Monday, August 14, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f
> On Aug 14, 2023, at 3:51 PM, Pedro Falcato wrote:
>
> On Mon, Aug 14, 2023 at 9:49 PM Michael Kubacki
> mailto:mikub...@linux.microsoft.com>> wrote:
>>
>> From: Michael Kubacki
>>
>> Adds a new script and build plugin called DebugMacroCheck.
>>
>> The script verifies that the number of pr
On Tue, Aug 15, 2023 at 1:23 AM Andrew (EFI) Fish wrote:
>
>
>
> On Aug 14, 2023, at 3:51 PM, Pedro Falcato wrote:
>
> On Mon, Aug 14, 2023 at 9:49 PM Michael Kubacki
> wrote:
>
>
> From: Michael Kubacki
>
> Adds a new script and build plugin called DebugMacroCheck.
>
> The script verifies that
I believe this change
https://github.com/tianocore/edk2/commit/173a7a7daaad560cd69e1000faca1d2b91774c46
may have misunderstood the purpose of the previous code.
I used to frequently use:
`./build.sh -a X64 -b RELEASE` (or whichever arch and build target I
required) to build OVMF
and then:
`./bu
Perhaps I can briefly clarify:
"This now no longer works" was too brief - of course the listed command
does build and start QEMU. But, to clarify, a rebuild is not what is wanted
here, both for the additional time it takes, and for the fact that it
resets (rebuilds) the NVRAM of the VM.
The advan
> On Aug 14, 2023, at 5:26 PM, Michael Kubacki
> wrote:
>
> On 8/14/2023 8:23 PM, Andrew Fish via groups.io wrote:
>>> On Aug 14, 2023, at 3:51 PM, Pedro Falcato wrote:
>>>
>>> On Mon, Aug 14, 2023 at 9:49 PM Michael Kubacki
>>> mailto:mikub...@linux.microsoft.com>> wrote:
From:
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, August 15, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4
I don't see the package maintainers actually in Cc for these patches.
You might want to resend the series with them copied as their email
rules might otherwise not bring the emails to their attention.
Thanks,
Michael
On 8/9/2023 5:32 PM, VivianNK wrote:
Introduce cpp-specific formatting rules
Hi Liming, Bob and Yuwei
There is a need that some code wants to supports Self-Modification,
because some program behavior may not be determined during compilation,
and I think this demand may be very popular.
The permise of Self-Modification is that the section has executable and
writable p
We also support Xcode clang so that means we also support Mach-O executables
that get converted to PE/COFF. The is a tool called mtoc (mach-o to coff) in a
crufty old open source project that does the conversion.
The reason you are having issues is due to security hardening as the self
modifyi
27 matches
Mail list logo
