Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC

2023-08-06 Thread Sami Mujawar
Hi Joshua, No problem. Thank you for all the feedback. I will send out an updates patch series soon. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107603): https://edk2.groups.io/g/devel/message/107603 Mute This

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, August 7, 2023 #cal-reminder

2023-08-06 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, August 7, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f

[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message

2023-08-06 Thread Rebecca Cran
There's an extra format specifier in the DEBUG_ERROR message that gets printed when the PCIe link check fails. This causes a synchronous exception. Remove the string format specifier. Signed-off-by: Rebecca Cran --- Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 2 +- 1 file chan

Re: [edk2-devel] [PATCH v5 1/9] MdeModulePkg: Duplicate BaseRngLibTimerLib to MdeModulePkg

2023-08-06 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107606): https://edk2.groups.io/g/devel/message/107606 Mute This Topic

Re: [edk2-devel] [PATCH v5 2/9] MdePkg: Add deprecated warning to BaseRngLibTimer

2023-08-06 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107607): https://edk2.groups.io/g/devel/message/107607 Mute This Topic:

Re: [edk2-devel] [PATCH v5 6/9] MdeModulePkg/Rng: Add GUID to describe unsafe Rng algorithms

2023-08-06 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107608): https://edk2.groups.io/g/devel/message/107608 Mute This Topic:

Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib

2023-08-06 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote: > > + gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCES ## GUID = > # Unique ID of the algorithm for RNG Can you check if the line above should be part of this patch, please? Otherwise, this patch looks goo

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message

2023-08-06 Thread Ard Biesheuvel
On Mon, 7 Aug 2023 at 03:56, Rebecca Cran wrote: > > There's an extra format specifier in the DEBUG_ERROR message that > gets printed when the PCIe link check fails. This causes a > synchronous exception. Remove the string format specifier. > > Signed-off-by: Rebecca Cran Thanks Pushed as 4507d