Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread wangy
Hi Pedro Falcato, At 2023-07-27 08:26:44, "Pedro Falcato" wrote: >On Wed, Jul 26, 2023 at 4:07 AM wangy wrote: >> >> Hi Pedro Falcato, >> >> At 2023-07-25 16:45:01, "Pedro Falcato" wrote: >> >> >On Tue, Jul 25, 2023 at 2:10 AM wrote: >> >> >> >> From: Yang Wang >> >> >> >> Check EmacGetDmaSta

Re: [edk2-devel] empty USB DVD disk hang Xhci

2023-07-27 Thread Chao Li
Hi Likun, Liming and Hao have reviewd and acked your patch, I think you can submit your patch on edk2 repo and don't forget include Liming and Hao review message. Good job! Thanks, Chao 在 2023/7/27 11:21, 苏丽坤 写道: Hi, Hao,Liming,    this is my reply, function XhcInitializeDeviceSlot64 wil

Re: [edk2-devel] [PATCH V5 2/3] CryptoPkg/Library/BaseCryptLib: add sha384 and sha512 to ImageTimestampVerify

2023-07-27 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Sheng, W > Sent: Thursday, July 27, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Xu, Min M ; Chen, Zeyi ; Wang, > Fiona ; Lu, Xiaoyu1 ; Jiang, > Guomin ; Kinney, Michael D > > Subject: [PATCH V5 2/3] Cr

Re: [edk2-devel] [PATCH V5 0/3] SecureBoot: Support RSA 512 and RSA 384

2023-07-27 Thread Yao, Jiewen
Thanks. May I know what *negative* test you have done? > -Original Message- > From: Sheng, W > Sent: Thursday, July 27, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Xu, Min M ; Chen, Zeyi ; Wang, > Fiona ; Lu, Xiaoyu1 ; Jiang, > Guomin ; Kinney, Michael D

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread Pedro Falcato
On Thu, Jul 27, 2023 at 8:12 AM wangy wrote: > > Hi Pedro Falcato, > > At 2023-07-27 08:26:44, "Pedro Falcato" wrote: > >On Wed, Jul 26, 2023 at 4:07 AM wangy wrote: > >> > >> Hi Pedro Falcato, > >> > >> At 2023-07-25 16:45:01, "Pedro Falcato" wrote: > >> > >> >On Tue, Jul 25, 2023 at 2:10 AM

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Qemu/Sbsa: Update TF-A binaries for Neoverse-V1 support

2023-07-27 Thread Ard Biesheuvel
On Fri, 14 Jul 2023 at 15:03, Marcin Juszkiewicz wrote: > > Update the TF-A binaries to have Neoverse-V1 cpu support. > > This support was merged into TF-A: > > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/21813 > > This allows SBSA Reference Platform to boot Linux on "neoverse-v

[edk2-devel] [PATCH V1 1/1] UefiCpuPkg/ResetVector: Cache Disable should not be set by default in CR0

2023-07-27 Thread xueshengfeng via groups.io
From: "Wu, MingliangX" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4511 With 64 bit build we are seeing the CD in control register CR 0 set. This causes the NEM to disabled for some specific bios profiles. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Debkumar De C

[edk2-devel] [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-07-27 Thread chitralekha ck
https://bugzilla.tianocore.org/show_bug.cgi?id=4507 AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. AllocatePool() is being avoided due to its 64k allocation size limit when the library is incorporated into a PEI component. change the function debug string to __func__ Cc: Ra

Re: [edk2-devel] [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-07-27 Thread Pedro Falcato
On Thu, Jul 27, 2023 at 4:40 PM chitralekha ck wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4507 > AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. > AllocatePool() is being avoided due to its 64k allocation size limit > when the library is incorporated into a PEI

Re: [edk2-devel] [PATCH V5 0/3] SecureBoot: Support RSA 512 and RSA 384

2023-07-27 Thread Sheng Wei
Here are my negative tests. 1) Enroll a RSA2048 Cert, execute an unsigned efi image. 2) Enroll a RSA2048 Cert, execute a RSA4096 signed efi image. 3) Enroll a RSA4096 Cert, execute a RSA3072 signed efi image. 4) Enroll a RSA4096 Cert to both DB and DBX, execute the RSA4096 signed efi image. Test

回复: [edk2-devel] [PATCH] BaseTools: Add FMMT BinPipWrappers

2023-07-27 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yuwei Chen > 发送时间: 2023年7月26日 15:17 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran ; Liming Gao > ; Bob Feng > 主题: [edk2-devel] [PATCH] BaseTools: Add FMMT BinPipWrappers > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob F

Re: [edk2-devel] [PATCH V5 0/3] SecureBoot: Support RSA 512 and RSA 384

2023-07-27 Thread Yao, Jiewen
OK. Thanks! > -Original Message- > From: Sheng, W > Sent: Friday, July 28, 2023 9:50 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Xu, Min M ; > Chen, Zeyi ; Wang, Fiona ; Lu, > Xiaoyu1 ; Jiang, Guomin ; > Kinney, Michael D ; Gao, Liming > > Subject: RE: [PATCH V5 0/3]

Re: [edk2-devel] [PATCH V5 3/3] SecurityPkg/SecureBoot: Support RSA 512 and RSA 384

2023-07-27 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Sheng, W > Sent: Thursday, July 27, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Xu, Min M ; Chen, Zeyi ; Wang, > Fiona > Subject: [PATCH V5 3/3] SecurityPkg/SecureBoot: Support RSA 512 and RSA 384 > >

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread wangy
Hi Pedro Falcato, At 2023-07-27 21:45:46, "Pedro Falcato" wrote: >On Thu, Jul 27, 2023 at 8:12 AM wangy wrote: >> >> Hi Pedro Falcato, >> >> At 2023-07-27 08:26:44, "Pedro Falcato" wrote: >> >On Wed, Jul 26, 2023 at 4:07 AM wangy wrote: >> >> >> >> Hi Pedro Falcato, >> >> >> >> At 2023-07-2

[edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread wangy
From: Yang Wang If IrqStat is NULL, the interrupt status will not be read from the device.When the interrupt status is read, it will also be cleared. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Ran Wang Signed-off-by: Yang Wang --- .../Drivers/DwEmacSnpDxe/EmacDxeUtil.c| 22 ++

Re: [edk2-devel] [Patch V3 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-27 Thread Zeng, Star
Do we really want to mention OVMF specifically in UefiCpuPkg.dec PCD definition ? Those comments may be better to be in OVMF dsc PCD override. -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Friday, July 21, 2023 11:52 AM To: Xie, Yuanhao ; devel@edk2.groups.io C

Re: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for CERT_RSA3072 and CERT_RSA4096

2023-07-27 Thread Sheng Wei
Hi Michael D, Could you help to review and merge this patch to MdePkg? This patch is only to add 2 new GUIDs. These 2 GUIDs will be used for adding RSA3072/RSA4096 cert support for secure boot feature. Thank you. BR Sheng Wei > -Original Message- > From: devel@edk2.groups.io On Behalf Of

[edk2-devel] [Patch V4 0/4] Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

[edk2-devel] [Patch V4 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf

2023-07-27 Thread Yuanhao Xie
From: Yuanhao Xie Add new API SendStartupIpiAllExcludingSelf(), and modify SendInitSipiSipiAllExcludingSelf() by let it call the new API. Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni Signed-off-by: Ray Ni Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Include

[edk2-devel] [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-27 Thread Yuanhao Xie
Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment and necessary to wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + Uefi

[edk2-devel] [Patch V4 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

[edk2-devel] [Patch V4 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-27 Thread Yuanhao Xie
Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- OvmfPkg/OvmfPkgIa32.dsc| 9

Re: [edk2-devel] [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-27 Thread Yuanhao Xie
Hi Star, Could you please review this patch, I have made updates to the comments for: Do we really want to mention OVMF specifically in UefiCpuPkg.dec PCD definition ? Those comments may be better to be in OVMF dsc PCD override. Thanks for the feedback Yuanhao -Original Mes

Re: [edk2-devel] [Patch V4 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-27 Thread Yuanhao Xie
Hi Star, Could you please review this patch, I have made updates to the comments for: Do we really want to mention OVMF specifically in UefiCpuPkg.dec PCD definition ? Those comments may be better to be in OVMF dsc PCD override. Thanks for the feedback Yuanhao -Original Mes

Re: [edk2-devel] [Patch V4 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf

2023-07-27 Thread Yuanhao Xie
Hi Gerd, Could you please review this patch series? Thanks a lot Yuanhao -Original Message- From: Xie, Yuanhao Sent: Friday, July 28, 2023 1:18 PM To: devel@edk2.groups.io Cc: Xie, Yuanhao ; Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann ; Ni, Ray Subject: [Patch V4 1/4] UefiCpuPkg: Ad

Re: [edk2-devel] 回复: [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain support

2023-07-27 Thread Sunil V L
On Tue, Jul 25, 2023 at 05:59:25PM +0200, Ard Biesheuvel wrote: > On Fri, 21 Jul 2023 at 06:52, Sunil V L wrote: > > > > On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > > > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > > > wrote: > > > > > > > > Sunil: > > > > Do you

Re: [edk2-devel] [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-27 Thread Zeng, Star
Would like to highlight it is for first time. " Determining Whether APs Awakened from SIPI or INIT-SIPI-SIPI" to "Determining APs first time wakeup by SIPI or INIT-SIPI-SIPI" or similar. " BSP Broadcast Method" -> " BSP Broadcast Method for first time AP wakeup" or similar. Thanks, Star -Or

Re: [edk2-devel] [Patch V4 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-27 Thread Zeng, Star
Minor comment " to indicate whether to broadcast INIT-SIPI-SIPI or SIPI" -> " to broadcast INIT-SIPI-SIPI for first time AP wakeup" or similar. Thanks, Star -Original Message- From: Xie, Yuanhao Sent: Friday, July 28, 2023 1:24 PM To: Zeng, Star Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul

[edk2-devel] [Patch V5 0/4] Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

[edk2-devel] [Patch V5 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf

2023-07-27 Thread Yuanhao Xie
From: Yuanhao Xie Add new API SendStartupIpiAllExcludingSelf(), and modify SendInitSipiSipiAllExcludingSelf() by let it call the new API. Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni Signed-off-by: Ray Ni Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Include

[edk2-devel] [Patch V5 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-27 Thread Yuanhao Xie
Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment and necessary to wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + Uefi

[edk2-devel] [Patch V5 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-27 Thread Yuanhao Xie
Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- OvmfPkg/OvmfPkgIa32.dsc| 9

[edk2-devel] [Patch V5 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

Re: [edk2-devel] [Patch V4 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-27 Thread Yuanhao Xie
Hi Star, I have just updated it and patch 2 in the V5 version. Thanks, Yuanhao -Original Message- From: Zeng, Star Sent: Friday, July 28, 2023 1:43 PM To: Xie, Yuanhao Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul R ; Gerd Hoffmann ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; devel

[edk2-devel] [Patch V6 0/4]Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

[edk2-devel] [Patch V6 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf

2023-07-27 Thread Yuanhao Xie
From: Yuanhao Xie Add new API SendStartupIpiAllExcludingSelf(), and modify SendInitSipiSipiAllExcludingSelf() by let it call the new API. Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni Signed-off-by: Ray Ni Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Include

[edk2-devel] [Patch V6 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-27 Thread Yuanhao Xie
Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment and necessary to wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + Uefi

[edk2-devel] [Patch V6 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-27 Thread Yuanhao Xie
Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- OvmfPkg/OvmfPkgIa32.dsc| 10 +++

[edk2-devel] [Patch V6 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

2023-07-27 Thread Ni, Ray
SmmS3ResumeState is a structure which contains two kinds of fields: * that are initialized in previous boot. E.g.: Signature, Smm***, Smst * that are initialized in S3 boot: e.g.: Return*** Your patch adds a new field that is initialized in S3 boot path. Can you put the fields together with other

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg/S3Resume2Pei: prepare MpService2Ppi in S3Resume

2023-07-27 Thread Ni, Ray
> + DEBUG ((DEBUG_INFO, "SMM S3 MpService2Ppi Point = %x\n", > SmmS3ResumeState->MpService2Ppi)); Can you please check PrintLib implementation that "%x" is suitable for a 64bit value? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#1

Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode combo

2023-07-27 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, July 27, 2023 10:21 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul > R > Subject: [PATCH 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode > combo > > Add assert for invali

[edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-07-27 Thread Li, Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3466 According to https://www.OpenSSL.org/policies/releasestrat.html, OpenSSL Version 1.1.1 will be supported until 2023-09-11 (LTS). Need to upgrade OpenSsl to 3.0.9 before 1.1.1 support stopping. PR: https://github.com/tianocore/edk2/pull/4692

[edk2-devel] [PATCH 01/29] CryptoPkg/openssl: update submodule to openssl-3.0.9

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/openssl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl index 70c2912f63..d

[edk2-devel] [PATCH 04/29] CryptoPkg/openssl: add openssl3 configure scripts

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Rewrite the script to configure openssl 3.0 from scratch. It's two scripts now: * Tiny helper script, dumping the perl configdata as json. * Actual configure.py script, written in python, which copies over the generated files to openssl-gen and updates the OpensslLib*.i

[edk2-devel] [PATCH 03/29] CryptoPkg/openssl: update Openssl*.inf files for openssl 3.0

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann The configure workflow as changed, see the commit adding the configure script for details. Adapt the *.inf files to the changes. The configuration define handling has changed a bit. The new configure script will build a single per-arch file list, which simplifies the Accel

[edk2-devel] [PATCH 05/29] CryptoPkg/openssl: UefiAsm.conf update for openssl 3.0

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann New naming convention for the configs: UEFI-${efiarch}-${compiler}. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/UefiAsm.conf | 41 +++ 1 file changed, 12 insertions(+), 29 deletions(-)

[edk2-devel] [PATCH 06/29] CryptoPkg/BaseCryptLib: no openssl deprecation warnings please

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Stop using deprecated interfaces is left as exercise for another day. So please don't warn for now so -Werror builds can work. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/InternalCryptLib.h | 2 ++ 1 file

[edk2-devel] [PATCH 07/29] CryptoPkg/BaseCryptLib: adapt CryptSm3.c to openssl 3.0 changes.

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Functions have been renamed. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/Hash/CryptSm3.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Ha

[edk2-devel] [PATCH 08/29] CryptoPkg/BaseCryptLib: drop BIO_* dummy functions

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann openssl 3.0 requires a functional BIO_sprintf() implementation. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 27 --- .../SysCall/UnitTestHostCrtWrapper.c | 25 -

[edk2-devel] [PATCH 09/29] CryptoPkg/TlsLib: ERR_GET_FUNC is gone

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/TlsLib/TlsConfig.c | 2 +- CryptoPkg/Library/TlsLib/TlsProcess.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/TlsConfig.c

[edk2-devel] [PATCH 10/29] CryptoPkg/openssl: adapt rand_pool.c to openssl 3.0 changes

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Some functions have been renamed. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/rand_pool.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/CryptoPkg/Library/Open

[edk2-devel] [PATCH 11/29] CryptoPkg/openssl: move compiler_flags to buildinf.c

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Seems with openssl 3.0 this is used by multiple source files, so we get duplicate symbol errors when linking. Fix that by moving compiler_flags from header file to a source file. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Li

[edk2-devel] [PATCH 12/29] CryptoPkg/openssl: store dummy update for openssl 3.0

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/ossl_store.c | 156 ++ 1 file changed, 156 insertions(+) diff --git a/CryptoPkg/Library/OpensslLib/ossl_store.c b/Crypto

[edk2-devel] [PATCH 13/29] CryptoPkg/openssl: adapt EcSm2Null.c for openssl 3.0

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/EcSm2Null.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/EcSm2Null.c b/CryptoPkg/Library/OpensslLib/EcSm

[edk2-devel] [PATCH 16/29] CryptoPkg: adapt 3.0 change in SslNull.c

2023-07-27 Thread Li, Yi
Type of input params changed in openssl30. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslStub/SslNull.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/OpensslStub/SslNull.c b/

[edk2-devel] [PATCH 14/29] CryptoPkg: Move all UEFI implement of openssl to OpensslStub

2023-07-27 Thread Li, Yi
Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 8 CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 8 CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 8 CryptoP

[edk2-devel] [PATCH 15/29] CryptoPkg: use UEFI provider as default

2023-07-27 Thread Li, Yi
Added UEFI provider which removed unused features to optimize the size of openssl3. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 + .../Library/OpensslLib/OpensslLibAccel.inf| 1 + .../Library/OpensslLib/Opens

[edk2-devel] [PATCH 17/29] CryptoPkg: Add instrinsics to support building openssl3 on IA32 windows

2023-07-27 Thread Li, Yi
This dependency is needed to build openssl lib with openssl3 under IA32 Windows, so added implementation for _alldiv, _aulldiv, _aullrem and _alldvrm instrinsics. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/IntrinsicLib/Ia32/MathLldiv.asm | 203 +++

[edk2-devel] [PATCH 18/29] CryptoPkg: disable C4133 warning in openssl libraries

2023-07-27 Thread Li, Yi
Disable warning as error of C4133: v3_genn.c(101): warning C4133: 'function': incompatible types - from 'ASN1_TYPE *' to 'const ASN1_STRING *'. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 5 +++-- CryptoPkg/Libr

[edk2-devel] [PATCH 19/29] CryptoPkg/TlsLib: use unsigned long for ErrorCode

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/TlsLib/TlsConfig.c | 3 ++- CryptoPkg/Library/TlsLib/TlsProcess.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/TlsConfig.c

[edk2-devel] [PATCH 20/29] CryptoPkg: Align with 4096 when build with OpensslFullAccel

2023-07-27 Thread Li, Yi
Should align to 4096 when build ecp_nistz256 related asm files. ecp_nistz256-x86.S Line3: .globl ecp_nistz256_precomputed .align 4096 Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/CryptoPkg.dsc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

[edk2-devel] [PATCH 22/29] CryptoPkg: add missing gcc instructions

2023-07-27 Thread Li, Yi
Used when build IA32 CryptoPkg by gcc, the definition of the instructions can be found at: https://gcc.gnu.org/onlinedocs/gccint/Integer-library-routines.html Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../IntrinsicLib/Ia32/MathDivModU64x64.c | 23

[edk2-devel] [PATCH 23/29] CryptoPkg: add define of maximum unsigned size_t

2023-07-27 Thread Li, Yi
Used by openssl30 source code. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index 94b0

[edk2-devel] [PATCH 21/29] CryptoPkg: Enable memcpy sys call in RISCV64 build

2023-07-27 Thread Li, Yi
When build Openssl30, compiler optimization may use memcpy() for memory copy. Need enable it in RISCV64 build also. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Cryp

[edk2-devel] [PATCH 24/29] CryptoPkg: add implemention of _ftol2_sse() to avoid build error

2023-07-27 Thread Li, Yi
Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c | 12 1 file changed, 12 insertions(+) diff --git a/CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c b/CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c index 09000c6

[edk2-devel] [PATCH 25/29] CryptoPkg: add more dummy implement of openssl for size optimization

2023-07-27 Thread Li, Yi
Add dummy implement of Encoder, Pkcs12 and sslserver. OpenSSL libraries which don't need these features can include these files to reduce the size of output. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 4 + .../Libra

[edk2-devel] [PATCH 27/29] CryptoPkg: remove strcmp to syscall

2023-07-27 Thread Li, Yi
In rare cases the platform may not provide the full IntrinsicLib. But openssl30 build always require strcmp, provide this function by moving it into CrtWrapper.c. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 9 +++

[edk2-devel] [PATCH 29/29] CryptoPkg: remove BN and EC accel for size optimization

2023-07-27 Thread Li, Yi
BN and EC have not been fully tested, and will greatly increase the size of the Crypto driver(>150KB). Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/OpensslLib/OpensslLibAccel.inf| 26 ++ .../OpensslLib/OpensslLibFullAccel.inf| 34 +

[edk2-devel] [PATCH 28/29] CryptoPkg/openssl: update CI config for openssl 3.0

2023-07-27 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/CryptoPkg.ci.yaml | 54 + 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/Crypt

Re: [edk2-devel] [Patch V6 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Jeff Fan via groups.io
Yuanhao, Have you verirfed whether APs could be waken-up from ApInHltLoop state or not? Thanks! Jeff fanjianf...@byosoft.com.cn From: Yuanhao Xie Date: 2023-07-28 14:25 To: devel CC: Eric Dong; Ray Ni; Rahul Kumar; Gerd Hoffmann; Yuanhao Xie Subject: [edk2-devel] [Patch V6 4/4] UefiCpuPkg:Wak

回复: Re: [edk2-devel] [Patch V6 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-27 Thread Jeff Fan via groups.io
Yuanhao, Sorry. I are missing the following updating. +if ((CpuMpData->InitFlag == ApInitConfig) Please ignore my last comments ! :-) Reviewed-by: Jeff Fan Thanks! Jeff fanjianf...@byosoft.com.cn 发件人: fanjianf...@byosoft.com.cn 发送时间: 2023-07-28 14:49 收件人: devel@edk2.groups.io; y