[edk2-devel] [PATCH 0/5] SPI NOR Flash Driver for SFDP flash device

2023-07-25 Thread Chang, Abner via groups.io
From: Abner Chang This patch fixes the missing SPI defintions per to the PIWG approval against PI spec 1.8 errata for ticket #2394. This patch also provides the implemtation of SPI NOR flash driver that supports JEDEC SFDP specification. This driver support the flash device that has the GUID gEdk

[edk2-devel] [PATCH 1/5] MdePkg/Include: Update definitions of SPI related header files

2023-07-25 Thread Chang, Abner via groups.io
From: abnchang BZ#: 4471 Update definitions according to PI spec v1.8 Errata as it is approved in PIWG (Ticket #2394). Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar --- MdePkg/Include/Protocol/SpiConfiguration.h | 8 MdePkg

[edk2-devel] [PATCH 2/5] MdePkg/Include: Add SPI NOR Flash JEDEC SFDP header file

2023-07-25 Thread Chang, Abner via groups.io
From: abnchang BZ#: 4472 Add definition of JEDEC Serial Flash Discoverable Parameters (SFDP) specification. https://www.jedec.org/standards-documents/docs/jesd216b Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar --- .../IndustryStandar

[edk2-devel] [PATCH 3/5] MdePkg: Add definitions in DEC for SPI NOR Flash SPDF driver

2023-07-25 Thread Chang, Abner via groups.io
From: abnchang BZ#: 4473 Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar --- MdePkg/MdePkg.dec | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index b85614992b9..47d8daba82

[edk2-devel] [PATCH 5/5] MdeModulePkg: Add SPI NOR FLash SFDP drivers to DSC

2023-07-25 Thread Chang, Abner via groups.io
From: abnchang BZ#: 4473 SPI NOR Flash JEDEC Serial Flash Discoverable Driver implementation. Signed-off-by: Abner Chang Cc: Jian J Wang Cc: Liming Gao Cc: Abdul Lateef Attar --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.ds

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-25 Thread Pedro Falcato
On Tue, Jul 25, 2023 at 2:10 AM wrote: > > From: Yang Wang > > Check EmacGetDmaStatus input parameters > IrqStat may be a null pointer. > > Signed-off-by: Yang Wang > --- > .../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c | 7 +-- > .../Drivers/DwEmacSnpDxe/EmacDxeUtil.c | 16 +++

Re: [edk2-devel] Detecting Linux boot failure from UEFI shell (BootServices)

2023-07-25 Thread Ard Biesheuvel
On Mon, 24 Jul 2023 at 19:28, Pedro Falcato wrote: > > On Mon, Jul 24, 2023 at 6:07 PM wrote: > > > > I am developing a UEFI application which functions as a bootloader. It is > > required to handle loading between two Linux kernels dependending on which > > one failed last (A/B system). > > Is

[edk2-devel] [PATCH v1 02/11] MdePkg: MADT: Add TRBE interrupt to GICC

2023-07-25 Thread Sami Mujawar
The ASWG ECR 2303 introduces a new field 'TRBE interrupt' to GICC structure in ACPI 6.5. The Trace Buffer Extension (TRBE) interrupt is a Processor Private interrupt (PPI) and is used to specify a platform-specific interrupt to signal TRBE events. Signed-off-by: Sami Mujawar --- MdePkg/Include/

[edk2-devel] [PATCH v1 09/11] DynamicTablesPkg: Add an ET info object parser

2023-07-25 Thread Sami Mujawar
An Embedded Trace (ET) info object is used to provide information about an Embedded Trace Extension (ETE) or an Embedded Trace Module (ETM) available on a platform. The CM_ARM_ET_INFO object has already been added to the Arm namespace objects list by a previous patch. Therefore, update the CM O

[edk2-devel] [PATCH v1 08/11] DynamicTablesPkg: Add an ET info object to Arm namespace

2023-07-25 Thread Sami Mujawar
Add an Embedded Trace (ET) info object that can be used to provide information about Embedded Trace Extension (ETE) or Embedded Trace Module (ETM) available on a platform. Although ETE and ETM share the same HID, ETE has a system register interfaces, unlike ETM which requires memory mapped registe

[edk2-devel] [PATCH v1 01/11] MdePkg: MADT: Add Online capable flag in GICC

2023-07-25 Thread Sami Mujawar
Bugzilla: 3706 'Code First - MADT GICC new flags' On ARM systems physical CPU hotplug is not supported. All CPUs are considered present and this is true throughout the system uptime. The ECR 2285 introduces a new 'online-capable' flag in the GICC structure flags in ACPI 6.5, to signal firmware po

[edk2-devel] [PATCH v1 04/11] DynamicTablesPkg: Add TRBE interrupt to GICC object parser

2023-07-25 Thread Sami Mujawar
ACPI 6.5 introduces a new filed to the MADT GICC structure to specify the Trace Buffer Extension (TRBE) interrupt. The TRBE interrupt is a Processor Private interrupt (PPI) and is used to specify a platform-specific interrupt to signal TRBE events. This field has already been added to the CM_ARM_G

[edk2-devel] [PATCH v1 07/11] ShellPkg: Acpiview: Update MADT parser for TRBE interrupt

2023-07-25 Thread Sami Mujawar
ACPI 6.5 introduces a new filed to the MADT GICC structure to specify the TRBE interrupt. The TRBE interrupt is a Processor Private interrupt (PPI) and is used to specify a platform-specific interrupt to signal TRBE events. Therefore, update the MADT GICC structure parser to parse the new TRBE int

[edk2-devel] [PATCH v1 10/11] DynamicTablesPkg: Add ETE device to CPU node in AML

2023-07-25 Thread Sami Mujawar
The Coresight Embedded Trace Extension (ETE) feature can be detected by the platform firmware by examining the debug feature register ID_AA64DFR0_EL1.TraceVer field. The platform configuration manager can then describe the ETE by creating CM_ARM_ET_INFO object(s) and referencing these in CM_ARM_GIC

[edk2-devel] [PATCH v1 03/11] DynamicTablesPkg: Add TRBE interrupt to GICC object

2023-07-25 Thread Sami Mujawar
ACPI 6.5 introduces a new filed to the MADT GICC structure to specify the Trace Buffer Extension (TRBE) interrupt. The TRBE interrupt is a Processor Private interrupt (PPI) and is used to specify a platform-specific interrupt to signal TRBE events. Therefore, update the CM_ARM_GICC_INFO to reflect

[edk2-devel] [PATCH v1 06/11] DynamicTablesPkg: Update FADT generator to ACPI 6.5

2023-07-25 Thread Sami Mujawar
The ACPI 6.5 specification updates the minor revision of the FADT table to 5. Therefore, update the FADT generator to setup the minor revision for ACPI 6.5. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 108 ++-- 1 file change

[edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5

2023-07-25 Thread Sami Mujawar
The ACPI 6.5 specification updates the MADT table to add a new field to GICC for specifying the TRBE interrupt and also adds support for Online Capable flag to the GICC flags. The Online Capable flags should be passed transparently through as specified in the CM_ARM_GICC_INFO.Flags field and only

[edk2-devel] [PATCH v1 11/11] DynamicTablesPkg: Fix referencing of CPC token

2023-07-25 Thread Sami Mujawar
The CpcToken has been incorrectly referenced in the CreateTopologyFromGicC() and always points to the CPC token in the first GICC Info object. Therefore, fix this by correctly indexing into the GicCInfo object array. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpu

[edk2-devel] [PATCH v1 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support

2023-07-25 Thread Sami Mujawar
This patch series provides the following updates: - The patches 1 & 2 add the new fields introduced in MADT (APIC table) by ACPI 6.5 and the patch 7/11 updates the Acpiview MADT parser accordingly. - The patches 3, 4 & 5 adds TRBE support to the MADT table generator in DynamicTablesPkg. - Pat

[edk2-devel] [PATCH edk2-platforms v1 1/3] Platform/ARM: Add dynamic CPU node generation for FVP

2023-07-25 Thread Sami Mujawar
Add support to dynamically generate the CPU nodes in SSDT. Signed-off-by: Sami Mujawar --- Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl | 38 +--- Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Configuratio

[edk2-devel] [PATCH edk2-platforms v1 0/3] Platform/ARM: Add dynamic CPU node, TRBE & ETE support to FVP

2023-07-25 Thread Sami Mujawar
This patch series updates the FVP platform firmware to add support for dynamically generating CPU nodes in AML and also reports the TRBE interrupt in the MADT GICC structure. The last patch in the series enables support for adding an ETE device to the CPU device nodes in AML. This patch series dep

[edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC

2023-07-25 Thread Sami Mujawar
When TRBE is enabled the FVP model uses the PPI 15 (i.e. INT ID 31) as the TRBE interrupt. Ref: https://www.kernel.org/doc/Documentation/ devicetree/bindings/arm/arm,trace-buffer-extension.yaml Therefore, check the debug feature register ID_AA64DFR0_EL1.TraceBuffer field to see if TRBE is enabled

[edk2-devel] [PATCH edk2-platforms v1 3/3] Platform/ARM: FVP: Add ETE device if supported by FVP

2023-07-25 Thread Sami Mujawar
When ETE is enabled in the FVP model the firmware can check the debug feature register ID_AA64DFR0_EL1.TraceVer field to identify the presence of FEAT_ETE and add an ETE device to the CPU node in the AML CPU hierarchy. This enables the Operating System driver to probe and enable ETE support. Note

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

2023-07-25 Thread Yao, Jiewen
Hello I agree with you on the problem statement. But I don't think this is a desired solution. We expect Platform BDS to call the PhysicalPresenceLib. As such, why not clear the screen in the platform BDS? Thank you Yao, Jiewen From: Poosapalli, Karunakar Sent: Monday, July 24, 2023 11:26 PM

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-07-25 Thread PierreGondois
Hello Rohit, I should have answered your comments, On 7/24/23 18:07, Rohit Mathew wrote: Hi Pierre, Thank you for the response. Few comments inline - -Original Message- From: Pierre Gondois Sent: Monday, July 24, 2023 3:40 PM To: Rohit Mathew ; devel@edk2.groups.io Cc: Thomas Abraham

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask check issue

2023-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, July 25, 2023 8:15 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH] RedfishPkg/RedfishDiscoverDxe: fix netmask che

[edk2-devel][edk2-platforms][PATCH V5-1] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

2023-07-25 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This A

[edk2-devel][edk2-platforms][PATCH V5-2] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-07-25 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This A

Re: [edk2-devel] 回复: [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain support

2023-07-25 Thread Ard Biesheuvel
On Fri, 21 Jul 2023 at 06:52, Sunil V L wrote: > > On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > > wrote: > > > > > > Sunil: > > > Do you use which CLANG version is used to verify this change? > > > > > > > For the se

[edk2-devel] [edk2-libc Patch 0/1] edk2-libc/StdLib: Fix uninitialized global variable

2023-07-25 Thread Jayaprakash, N
This patch contains the fix for uninitialized global variable in edk2-libc/StdLib/BsdSocketLib/res_init.c file. Jayaprakash N (1): edk2-libc/StdLib: Fix uninitialized global variable StdLib/BsdSocketLib/res_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.40.0.windows.

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Fix uninitialized global variable

2023-07-25 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506 res_init() is called from different places in sockets library. It depends on global _res variable containing a state. The problem is that if __BIND_RES_TEXT macro is not defined, _res is not initialized. Depending on compiler and build opti

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

2023-07-25 Thread Girish Mahadevan via groups.io
Hi Sami My responses inline [GM] Best Regards Girish On 7/24/2023 11:48 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Hi Girish, Thank you for taking this effort forward Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 22/07/2023

[edk2-devel] [PATCH v3 0/5] DynamicTablesPkg: Add SMBIOS Table Generation

2023-07-25 Thread Girish Mahadevan via groups.io
Patch series to add SMBIOS Table generation using DynamicTablesPkg This patch series builds on top of the SMBIOS table dispatcher work that dispatches and installs SMBIOS tables in the correct order. This patches series does the following: - Modify the existing DynamicTableManagerDxe driver to re

[edk2-devel] [PATCH v3 1/5] DynamicTablesPkg: Add SMBIOS table generation

2023-07-25 Thread Girish Mahadevan via groups.io
Add the SMBIOS Table generator code to the DynamicTablesPkg. This change includes adding new logic to the DynamicTableManager to process and add SMBIOS tables and augmenting the existing SMBIOS Factory generator to include installing multiple SMBIOS tables . Also included is running the SMBIOS and

[edk2-devel] [PATCH v3 4/5] DynamicTablesPkg: Smbios Memory Device (Type 17)

2023-07-25 Thread Girish Mahadevan via groups.io
Add the Generator library for SMBIOS Table Type 17 - Memory Device. Signed-off-by: Girish Mahadevan Reviewed-by: Jeff Brasen --- .../Include/SmbiosNameSpaceObjects.h | 70 +++ .../SmbiosType17Lib/SmbiosType17Generator.c | 445 ++ .../SmbiosType17Lib/SmbiosType17Lib.i

[edk2-devel] [PATCH v3 3/5] DynamicTablesPkg: Introduce new namespace for SMBIOS Objects

2023-07-25 Thread Girish Mahadevan via groups.io
Introduce a new namespace for SMBIOS related CM Objects. Signed-off-by: Girish Mahadevan Reviewed-by: Nick Ramirez Reviewed-by: Jeff Brasen --- .../Include/ConfigurationManagerObject.h | 14 ++- .../Include/SmbiosNameSpaceObjects.h | 42 +++ 2 files changed, 5

[edk2-devel] [PATCH v3 2/5] DynamicTablesPkg: Split the ACPI and SMBIOS table generators

2023-07-25 Thread Girish Mahadevan via groups.io
Split the SMBIOS and ACPI table generators into their own files. Signed-off-by: Girish Mahadevan Reviewed-by: Jeff Brasen --- .../DynamicTableManagerDxe/AcpiTableBuilder.c | 798 ++ .../DynamicTableManagerDxe.c | 1356 + .../DynamicTableManagerDxe.inf

[edk2-devel] [PATCH v3 5/5] DynamicTablesPkg: Smbios Physical Memory Array (Type 16)

2023-07-25 Thread Girish Mahadevan via groups.io
Add the Generator library for SMBIOS Table Type 16 - Physical Memory Array. Signed-off-by: Girish Mahadevan Reviewed-by: Jeff Brasen Reviewed-by: Nick Ramirez --- .../SmbiosTableBuilder.c | 3 - .../Include/SmbiosNameSpaceObjects.h | 19 + .../SmbiosType16Lib/S

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-25 Thread wangy
Hi Pedro Falcato, At 2023-07-25 16:45:01, "Pedro Falcato" wrote: >On Tue, Jul 25, 2023 at 2:10 AM wrote: >> >> From: Yang Wang >> >> Check EmacGetDmaStatus input parameters >> IrqStat may be a null pointer. >> >> Signed-off-by: Yang Wang >> --- >> .../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c

[edk2-devel] [PATCH] UefiCpuPkg: Decouple the SEV-ES functionality.

2023-07-25 Thread Yuanhao Xie
The purpose is to fix an issue where an exception occurs at the start of the DXE phase by applying the following patch series on INTEL-based systems. UefiCpuPkg: Refactor the logic for placing APs in HltLoop. UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. UefiCpuPkg: Create MpHan