Re: [edk2-devel] 回复: [PATCH 3/4] BaseTools/tools_def: Add CLANGDWARF support for RISC-V

2023-07-10 Thread Sunil V L
Hi Liming, On Mon, Jul 10, 2023 at 09:52:18AM +0800, gaoliming via groups.io wrote: > Sunil: > I add my comments below. > > > -邮件原件- > > 发件人: Sunil V L > > 发送时间: 2023年7月3日 16:09 > > 收件人: devel@edk2.groups.io > > 抄送: Sunil V L ; Rebecca Cran > > ; Liming Gao ; Bob Feng > > ; Yuwei Chen

[edk2-devel] [PATCH V1] OvmfPkg/PeilessStartupLib: Updated with PcdSecureBootSupported

2023-07-10 Thread sunceping
SECURE_BOOT_FEATURE_ENABLED was dropped by the commit(92da8a154f), but the PeilessStartupLib was not updated with PcdSecureBootSupported, that made SecureBoot no longer work in IntelTdxX64. Fix this by replacing SECURE_BOOT_FEATURE_ENABLED with PcdSecureBootSupported in PeilessStartupLib. Cc: Erd

Re: [edk2-devel] [PATCH V1] OvmfPkg/PeilessStartupLib: Updated with PcdSecureBootSupported

2023-07-10 Thread Gerd Hoffmann
On Mon, Jul 10, 2023 at 06:05:39PM +0800, sunceping wrote: > SECURE_BOOT_FEATURE_ENABLED was dropped by the commit(92da8a154f), but the > PeilessStartupLib was not updated with PcdSecureBootSupported, that made > SecureBoot no longer work in IntelTdxX64. > > Fix this by replacing SECURE_BOOT_FEATU

回复: [edk2-devel] [PATCH 1/4] BaseTools: Remove logic to create AP waking vector in GenFv

2023-07-10 Thread gaoliming via groups.io
Zhiguang: If there is no such usage any more, I agree to remove this logic. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Zhiguang Liu > 发送时间: 2023年7月10日 11:17 > 收件人: devel@edk2.groups.io > 抄送: Zhiguang Liu ; Rebecca Cran > ; Liming Gao ; Bob Feng > ; Yu

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Integrate UiApp and BootManagerMenuApp into MultiFv

2023-07-10 Thread Guo, Gua
Reviewed-by: Gua Guo -Original Message- From: Lin, MarsX Sent: Monday, July 10, 2023 5:02 PM To: devel@edk2.groups.io Cc: Lin, MarsX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Integrate UiApp and BootManagerMenuApp into MultiFv Fro

[edk2-devel] [PATCH] UefiPayloadPkg: Integrate UiApp and BootManagerMenuApp into MultiFv

2023-07-10 Thread marsx . lin
From: MarsX Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4347 To put UiApp.inf and BootManagerMenuApp.inf to proper FV(BDSFV) Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: MarsX Lin --- .../PlatformBootManager.c | 55 -

[edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

2023-07-10 Thread osy
I have an existing install of Ubuntu 22.04 on a QEMU virtual machine which I've decided to update the UEFI firmware. After doing so, GRUB no longer boots ("Synchronous Exception" message seen). After a git bisect session, I found the problematic 2997ae38739756ecba9b0de19e86032ebc689ef9. The comm

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: scan Edk2ToolsBuild.py make output

2023-07-10 Thread Joey Vagedes via groups.io
Thanks Rebecca! Let me know if you need anything else from me before you get it merged. I appreciate your time! Joey On Sun, Jul 9, 2023 at 4:18 PM Rebecca Cran wrote: > Sorry for the delay. > > > Reviewed-by: Rebecca Cran > > > On 6/21/23 9:59 AM, Joey Vagedes wrote: > > Adds edk2_logging.sca

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

2023-07-10 Thread Pedro Falcato
On Mon, Jul 10, 2023 at 2:28 PM wrote: > > I have an existing install of Ubuntu 22.04 on a QEMU virtual machine which > I've decided to update the UEFI firmware. After doing so, GRUB no longer > boots ("Synchronous Exception" message seen). After a git bisect session, I > found the problematic

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

2023-07-10 Thread osy
On Mon, Jul 10, 2023 at 8:58 AM Pedro Falcato wrote: > > On Mon, Jul 10, 2023 at 2:28 PM wrote: > > > > I have an existing install of Ubuntu 22.04 on a QEMU virtual machine which > > I've decided to update the UEFI firmware. After doing so, GRUB no longer > > boots ("Synchronous Exception" mess

[edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set Boot Options

2023-07-10 Thread brit.chesley via groups.io
From: Brit Chesley BZ #: 4455. Support parameter selectors for IPMI Get/Set boot options. The size of the response data is now dependent on the parameter selector, rather than being fixed. Cc: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Signed-off-by: Brit Chesley ---

[edk2-devel] [PATCH v2 0/4] Add support for generating ACPI ThermalZones

2023-07-10 Thread Jeff Brasen via groups.io
Add APIs needed to create thermal zones dynamically. Does not add a generator for this as creating the TMP method generically may be difficult. Change log: v2 - renamed NameString function and added goto dones in a couple error cases Jeff Brasen (4): DynamicTablesPkg: Add ThermalZone CodeGen f

[edk2-devel] [PATCH v2 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function

2023-07-10 Thread Jeff Brasen via groups.io
Add API to generate a ThermalZone object to AmlLib. Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 28 + .../Common/AmlLib/CodeGen/AmlCodeGen.c| 116 ++ 2 files changed, 144 insertions(+) diff --git

[edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add support for simple method invocation.

2023-07-10 Thread Jeff Brasen via groups.io
Add support to add Return objects via AML that pass a single integer argument to the named method. Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 54 + .../Common/AmlLib/CodeGen/AmlCodeGen.c| 224 ++

[edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: Add support to add Strings to package

2023-07-10 Thread Jeff Brasen via groups.io
Add API to add a String to a package created with NamedPackage API. Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 17 .../Common/AmlLib/CodeGen/AmlCodeGen.c| 82 +++ 2 fi

[edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API

2023-07-10 Thread Jeff Brasen via groups.io
Add API to generate a Name that contains a Unicode string buffer. Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 31 +++ .../Common/AmlLib/CodeGen/AmlCodeGen.c| 86 +++ 2 f

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, July 10, 2023 #cal-reminder

2023-07-10 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, July 10, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f9

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, July 10, 2023 #cal-notice

2023-07-10 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, July 10, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, July 11, 2023 #cal-reminder

2023-07-10 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, July 11, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set Boot Options

2023-07-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thank you Brit for the contribution! Let's wait for 1-2 days to see if there is any other comments for this change. Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Tuesday, July 11, 2023 3:23 AM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Integrate UiApp and BootManagerMenuApp into MultiFv

2023-07-10 Thread Lu, James
Reviewed-by: James Lu Thanks, James -Original Message- From: Lin, MarsX Sent: Monday, July 10, 2023 5:02 PM To: devel@edk2.groups.io Cc: Lin, MarsX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Integrate UiApp and BootManagerMenuApp in

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

2023-07-10 Thread Gerd Hoffmann
On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote: > On Mon, Jul 10, 2023 at 2:28 PM wrote: > > > > I have an existing install of Ubuntu 22.04 on a QEMU virtual machine which > > I've decided to update the UEFI firmware. After doing so, GRUB no longer > > boots ("Synchronous Exceptio