Re: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-07-09 Thread Abhimanyu Singh
Hi Liming and Michael, I have added the requested change, here is the PR: https://github.com/tianocore/edk2/pull/4546 Thanks, Abhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106747): https://edk2.groups.io/g/devel/message/106747 Mu

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: scan Edk2ToolsBuild.py make output

2023-07-09 Thread Rebecca Cran
Sorry for the delay. Reviewed-by: Rebecca Cran On 6/21/23 9:59 AM, Joey Vagedes wrote: Adds edk2_logging.scan_compiler_output() to Edk2ToolsBuild.py to catch some compilation errors and log them as an error. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey

Re: [edk2-devel] [PATCH v1 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-07-09 Thread Rebecca Cran
Please fix the documentation block. It should go above the function, and use Doxygen style. Also, the commit message doesn't make sense to me - specifically ", it must," -- Rebecca Cran On 7/6/23 9:26 AM, Joey Vagedes wrote: Hi all, Do you have any concerns over the changes I've made t

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, July 10, 2023 #cal-reminder

2023-07-09 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, July 10, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f9

回复: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-09 Thread gaoliming via groups.io
Pierre: Another option is to define two PCD for Rng algorithm in MdePkg. One PCD value is ArmRndr GUID, another is UnSafe GUID. This way can also resolve the package dependency. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yao, Jiewen > 发送时间: 2023年7月7日 22:34 > 收件人: devel@edk2

回复: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-07-09 Thread gaoliming via groups.io
Abhi: I just approve it. It will be merged soon. Thanks Liming 发件人: devel@edk2.groups.io 代表 Abhimanyu Singh 发送时间: 2023年7月10日 7:14 收件人: gaoliming ; devel@edk2.groups.io 主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

回复: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v2 1/1] MdePkg: Add Cxl20.h into IndustryStandard

2023-07-09 Thread gaoliming via groups.io
Acked-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chris Li OS > via groups.io > 发送时间: 2023年7月3日 17:39 > 收件人: Ni, Ray ; devel@edk2.groups.io; Yao, Jiewen > ; Nong, Foster > 抄送: gaolim...@byosoft.com.cn; michael.d.kin...@intel.com; Open Source > Submission > 主题: [ ** SPAMMAIL

回复: [edk2-devel] [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines

2023-07-09 Thread gaoliming via groups.io
Christine: I just push this patch @ bab1724cdf725b7d22869c79fa2b86ed47e01110 in edk2-staging. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yuwei Chen > 发送时间: 2023年7月4日 15:52 > 收件人: Gao, Liming ; devel@edk2.groups.io > 抄送: 'Rebecca Cran' ; Feng, Bob C > ; Chan, Amy ; Huang, Ya

[edk2-devel] 回复: [PATCH 3/4] BaseTools/tools_def: Add CLANGDWARF support for RISC-V

2023-07-09 Thread gaoliming via groups.io
Sunil: I add my comments below. > -邮件原件- > 发件人: Sunil V L > 发送时间: 2023年7月3日 16:09 > 收件人: devel@edk2.groups.io > 抄送: Sunil V L ; Rebecca Cran > ; Liming Gao ; Bob Feng > ; Yuwei Chen ; Ard > Biesheuvel > 主题: [PATCH 3/4] BaseTools/tools_def: Add CLANGDWARF support for > RISC-V > > REF:

Re: [edk2-devel] [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines

2023-07-09 Thread Yuwei Chen
Thanks Liming for your support~ Thanks, Christine > -Original Message- > From: gaoliming > Sent: Monday, July 10, 2023 9:51 AM > To: devel@edk2.groups.io; Chen, Christine > Cc: 'Rebecca Cran' ; Feng, Bob C > ; Chan, Amy ; Huang, Yanbo > > Subject: 回复: [edk2-devel] [Patch V3] [edk2-stag

[edk2-devel] [PATCH 0/4] Remove AP waking vector in Reset Vector

2023-07-09 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Today for SEC core(not VTF-0), GenFv finds free 4K aligned space in FV for AP waking vector and JMP to 4G-30h in the waking vector. There is no usage of this today. Remove the logic to avoid confusing and save spaces in reset vector. Zhigu

[edk2-devel] [PATCH 1/4] BaseTools: Remove logic to create AP waking vector in GenFv

2023-07-09 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Today for SEC core(not VTF-0), GenFv finds free 4K aligned space in FV for AP waking vector and JMP to 4G-30h in the waking vector. There is no usage of this today. Remove the logic to avoid confusing and save spaces in reset vector. Cc: Re

[edk2-devel] [PATCH 2/4] UefiCpuPkg/SecCore: Remove AP waking Vector logic in SecCore

2023-07-09 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 There are two part of AP waking Vector logic in SecCore. The first one working with GenFv to find a free 4K aligned space, use the 4K aligned address as AP waking Vector and jump to 4G-30h, and finally jump to ApStartup.. The second one hard

[edk2-devel] [PATCH 3/4] OvmfPkg: Remove applicationProcessorEntryPoint

2023-07-09 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Current reset vector uses 0xffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code as the comment expects

[edk2-devel] [PATCH 4/4] UefiCpuPk/ResetVector: Remove AP waking vector from ResetVector

2023-07-09 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 Current reset vector uses 0xffe0 as AP waking vector, and expects GenFv generates code aligned on a 4k boundary which will jump to this location. However, some issues are listed below 1. GenFV doesn't generate code as the comment expects

Re: [edk2-devel] [PATCH 0/4] Remove AP waking vector in Reset Vector

2023-07-09 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhiguang Liu > Sent: Monday, July 10, 2023 11:17 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang > Subject: [edk2-devel] [PATCH 0/4] Remove AP waking vector in Reset Vector > > REF: https://bugzilla.ti