Re: [edk2-devel] [Patch V4 0/5] Eliminate the second INIT-SIPI-SIPI sequence

2023-07-05 Thread Ni, Ray
Gard, any comments? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, July 5, 2023 10:49 AM > To: devel@edk2.groups.io; Xie, Yuanhao > Subject: Re: [edk2-devel] [Patch V4 0/5] Eliminate the second INIT-SIPI-SIPI > sequence > > Reviewed-by: Ray Ni

[edk2-devel] Use gMmst from MmServiceTableLib in MmSaveStateLib

2023-07-05 Thread duntan
Hi Abdul, In the new MmSaveStateLib created in this patch set, gSmst from SmmServiceTableLib is used. This causes that only DXE_SMM_DRIVER type module can consume this lib but MM_STANDALONE type module cannot. In current edk2, there are different MmServicesTableLib and SmmServicesTableLib: Stad

Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe

2023-07-05 Thread Mike Maslenkin
Just one note: All manipulations with this list are going in conjunction with RestExSb->RestExChildrenNum. At first glance it appears this field must be decremented also. But I see no usage for RestExChildrenNum at all, may be it can be eliminated? Regards, MIke. On Wed, Jul 5, 2023 at 9:56 AM Ni

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, July 6, 2023 #cal-reminder

2023-07-05 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, July 6, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm

[edk2-devel] Tianocore edk2-test Bug Triage Meeting

2023-07-05 Thread G Edhaya Chandran
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:India Standard Time BEGIN:STANDARD DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:DAYLIGHT E

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

2023-07-05 Thread Henz, Patrick
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948 XhciDxe uses the timer functionality provided by the boot services table to detect timeout conditions. This breaks the driver's ExitBootServices call back, as CoreExitBootServices halts the timer before signaling the ExitBootServices event. I

[edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib

2023-07-05 Thread Michael Kubacki
From: Michael Kubacki Commit `b71f2bd` introduced a couple build errors in VariableWritelib. This change adds the SMM Services Table (`gSmst`) and MM Services Table (`gMmst`) calls needed to register the protocol notify in the Traditional and Standalone MM services constructors. Cc: Chasel Chiu

[edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add Mem Type Info variable validity checks

2023-07-05 Thread Michael Kubacki
From: Michael Kubacki Adds some sanity checks around the Memory Type Information data restored from the `EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME` UEFI variable. This is particularly useful when the structures that the data was saved against have changed in the latest firmware image. For exampl

[edk2-devel] [PATCH 0/3] Small SMM status code handler fixes

2023-07-05 Thread Isaac Oram
This is some minor housekeeping on SMM status code handling. https://github.com/tianocore/edk2/pull/4610 Cc: Dandan Bi Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Signed-off-by: Isaac Oram Isaac Oram (3): MdeModulePkg/StatusCodeHandlerSmm: Remove unused code MdeModulePkg/StatusC

[edk2-devel] [PATCH 1/3] MdeModulePkg/StatusCodeHandlerSmm: Remove unused code

2023-07-05 Thread Isaac Oram
Serial worker does not have this initialization function implemented. Cc: Dandan Bi Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Isaac Oram --- .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.h | 11 --- .../StatusCodeHandler/Smm/StatusCodeHandlerMm.h | 11 ---

[edk2-devel] [PATCH 2/3] MdeModulePkg/StatusCodeHandlerSmm: Clarify ASSERT source

2023-07-05 Thread Isaac Oram
Disambiguate SMM sourced asserts from other DXE asserts. Cc: Dandan Bi Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Isaac Oram --- .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/

[edk2-devel] [PATCH 3/3] MdePkg/ReportStatusCodeLib: Add macros to identify status codes

2023-07-05 Thread Isaac Oram
Add macros that make it easier to determine if a status code is an error, progress, or debug code. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Isaac Oram --- .../Include/Guid/MemoryStatusCodeRecord.h | 2 +- MdePkg/Include/Library/ReportStatusCodeLib.h | 61 +

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib

2023-07-05 Thread Isaac Oram
Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, July 5, 2023 6:40 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric Subject: [edk2-devel] [edk2-platforms][

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add Mem Type Info variable validity checks

2023-07-05 Thread Isaac Oram
Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, July 5, 2023 6:57 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric ; Lautner, Kenneth Subject: [edk2-deve

[edk2-devel] [PATCH v3] SecurityPkg/SecureBoot: Support RSA 512 and RSA 384

2023-07-05 Thread Sheng Wei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413 Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Cc: Zeyi Chen Cc: Fiona Wang Signed-off-by: Sheng Wei --- CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 3 +- MdePkg/Include/Guid/ImageAuthentication.h | 26 +++ MdePkg/MdePkg.dec