Re: [edk2-devel] [PATCH v1 7/8] SecurityPkg/RngDxe: Select safe default Rng algorithm

Hi Kun, On 30/06/2023, 00:08, "Kun Qin" mailto:kuqi...@gmail.com>> wrote: Hi Sami, Your suggestion in https://edk2.groups.io/g/devel/message/106511 works properly during my test. [SAMI] Thank you for trying this out and confirming. But I t

[edk2-devel] [PATCH v2] SecurityPkg/SecureBoot: Support RSA 512 and RSA 384

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413 Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Cc: Zeyi Chen Cc: Fiona Wang Signed-off-by: Sheng Wei --- CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 3 +- MdePkg/Include/Guid/ImageAuthentication.h | 26 +++ MdePkg/MdePkg.dec

Re: [edk2-devel] [PATCH] SecurityPkg/SecureBoot: Support RSA 512 and RSA 384

Hi Jiewen, I raised the patch V2. I do the fix for 1) , 2), 3). But for 4) 5), I have below comments. 4) I am not sure why we need this PCD. Why cannot we support all of hash algo? + ## Indicates default hash algorithm in Secure Boot + # 0 - Use SHA256 + # 1 - Use SHA384 + # 2 - Use SHA

Re: [edk2-devel] [PATCH] RedfishPkg: Fix SortLib library class name typo.

Sorry, I created a PR for the change to edk2-redfish-client but that depends on this change to edk2. I created a new PR to edk2 for this patch: https://github.com/tianocore/edk2/pull/4592 Thanks, Mike On Fri, Jun 30, 2023 at 5:13 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > >

Re: [edk2-devel] [PATCH] SecurityPkg/SecureBoot: Support RSA 512 and RSA 384

For 4, I think we can enroll all supported algorithms, or the active algorithm. I don’t think the PCD is needed. For 5, I suggest to change the data structure to include the algorithm ID. Thank you Yao, Jiewen > -Original Message- > From: Sheng, W > Sent: Friday, June 30, 2023 3:52 PM

Re: [edk2-devel] [PATCH v1 1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation

Hello Kun, The reason was that: - KvmTool uses the SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf module - the RngDxe.inf modules requires an ArmTrng implementation - GetArmTrngVersion() is called to check whether there is a Trng backend - GetArmTrngVersion() asserts as it is a NULL implement

Re: [edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg

Hello Kun, On 6/29/23 22:36, Kun Qin wrote: This patch seems to have some discrepancy between the title and content :) I'm not sure I see the discrepancy between the title/content, should I have mentioned the SecurityPkg ? Can you please break this patch into 2, so that MdePkg change and Se

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

Hi Mike, Thanks for your comments. I haven't seen specific error message when using the same include guard name: __PROCESSOR_BIND_H__ . For short-term, I think RISC-V also could use same guard name with AArch64/Arm/Ebc/Ia32/X64 CPU architecture, which also keep code alignment. How about your com

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Add support for driver binding

> -Original Message- > From: Ni, Ray > Sent: Thursday, June 29, 2023 9:59 PM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Hao A > Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Add support for driver > binding > > External email: Use caution open

Re: [edk2-devel] [PATCH] RedfishPkg: Fix SortLib library class name typo.

[AMD Official Use Only - General] Thanks Mike. CI is running now, I will push it once it passes CI. Abner > -Original Message- > From: Mike Maslenkin > Sent: Friday, June 30, 2023 5:05 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com > Subject: Re: [P

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

Using the same include guard define name is preferred. Why was anything other than that considered? Mike > -Original Message- > From: Xue, Gavin > Sent: Friday, June 30, 2023 2:29 AM > To: Kinney, Michael D ; > devel@edk2.groups.io; Pedro Falcato > Cc: suni...@ventanamicro.com; Warkent

Re: [edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg

Hi Pierre, Thanks for the example. If we are to keep this in one commit, I think we should mention SecurityPkg in the title? To follow the example, can we rename it to `SecurityPkg/SecurityPkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg`? At least this makes it more obvious that it is tou

[edk2-devel] [PATCH v2 0/2] dp command without ACPI

Systems that do not boot with ACPI (system that use device tree for example) can not use the shell dp command. This patch adds this to the configuration table so that dp command can get this without the FPDT table. I am open to other ways for this to be passed if desired (Installed protocol, handl

[edk2-devel] [PATCH v2 1/2] MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table

Install the performance table into the UEFI configuration table. This will allow the shell application to get this if the system is not using ACPI. Signed-off-by: Jeff Brasen --- .../Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[edk2-devel] [PATCH v2 2/2] ShellPkg/Dp: Allow dp command to work without ACPI

If the system does not have ACPI setup use the configuration table to get the performance info. Signed-off-by: Jeff Brasen --- ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf| 1 + .../DpDynamicCommand/DpDynamicCommand.inf | 1 + ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c

[edk2-devel] [PATCH v3 0/1] Add support for running shell test application in an immutable volume

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4467 This is a rebase of a previously submitted patch series based on top of master branch: https://edk2.groups.io/g/devel/message/105827. The main changes between v2 and v3 patch are: - Rebased to top of master. No other changes. The updated

[edk2-devel] [PATCH v3 1/1] UnitTestFrameworkPkg: UnitTestPersistenceLib: Save Unit Test Cache Option

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4467 Current implementation of UnitTestFrameworkPkg for shell-based unit test will save the unit test cache to the same volume as the test application itself. This works as long as the test application is on a writable volume, such as USB or EFI

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

Reviewed-by: Ashraf Ali S -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Friday, June 30, 2023 8:03 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] In

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

Reviewed-by: Isaac Oram Mixing DEBUG_WARN | DEBUG_ERROR confuses me a bit. I would prefer simpler definitions were errors are "something is wrong" and warnings are "something might be wrong". But it is a pretty minor nit and cleanup is good, so don't worry about changing it. Regards, Isaac

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

Pushed as 1befeabcc8..dd09609ec9 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Friday, June 30, 2023 1:22 PM To: S, Ashraf Ali ; devel@edk2.groups.io; mikub...@linux.microsoft.com Cc: Ni, Ray ; Chaganty, Rangasai V Subject: Re: [edk2-devel] [edk2-platforms

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add gEndOfSiInitPpiGuid definition in DEC file

Reviewed-by: Isaac Oram -Original Message- From: Chang, Hunter Sent: Tuesday, June 13, 2023 5:40 AM To: devel@edk2.groups.io Cc: Chang, Hunter ; Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali ; Chen, Tina ; Chen, Arthur G Subject: [PATCH v1] IntelSiliconPkg: Add gEnd

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add gEndOfSiInitPpiGuid definition in DEC file

Pushed as dd09609ec9..bc10b26189 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Friday, June 30, 2023 1:51 PM To: Chang, Hunter ; devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali ; Chen, Tina ; Chen, Arthur G Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH] RedfishPkg: Fix SortLib library class name typo.

[AMD Official Use Only - General] Hi Mike, The changes for both RedfishPkg and RedfishClinetPkg were merged. Thanks to your contribution. Abner > -Original Message- > From: Chang, Abner > Sent: Tuesday, June 27, 2023 8:05 AM > To: Mike Maslenkin ; devel@edk2.groups.io > Cc: nick...@nvidi

[edk2-devel] edk2 NULL instance library

[AMD Official Use Only - General] Hi all, NULL instance library is commonly used as a dummy library that statically linked with a module, usually that is a no implementation to the module framework. However, do we have an document or edk2 spec that describes what is a NULL library instance and