Re: [edk2-devel] [PATCH 01/22] CryptoPkg/openssl: update submodule to openssl-3.0.8

2023-06-19 Thread Gerd Hoffmann
On Fri, Jun 02, 2023 at 02:29:11PM +, Yao, Jiewen wrote: > Thanks Ard. That is good news. > We may try the patch to see if that will break X86. > > Current blocking issue seems IA32 intrinsic and OVMF size. I am not sure if > Gerd has any idea on that. Size is NOOPT only I guess? Problem is

Re: [edk2-devel] [PATCH 01/22] CryptoPkg/openssl: update submodule to openssl-3.0.8

2023-06-19 Thread Li, Yi
Right. We already skipped this build with VS2019, I tend to skip the GCC NOOPT build also. https://edk2.groups.io/g/devel/topic/99477984#106001 Regards, Yi -Original Message- From: kra...@redhat.com Sent: Monday, June 19, 2023 4:12 PM To: Yao, Jiewen Cc: Ard Biesheuvel ; devel@edk2.g

Re: [edk2-devel] [PATCH v14 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-06-19 Thread Gerd Hoffmann
On Fri, Jun 16, 2023 at 01:34:54AM +, Ni, Ray wrote: > Gerd, > Can you kindly provide "Reviewed-by" for the patch series? Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply On

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/Bhyve: include TPM driver

2023-06-19 Thread Gerd Hoffmann
On Wed, Jun 07, 2023 at 03:17:19PM +0200, Corvin Köhne wrote: > From: Corvin Köhne > > Bhyve will gain support for TPM emulation in the near future. Therefore, > prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the > bhyve OVMF DSC. > > Signed-off-by: Corvin Köhne > Cc: Ard B

Re: [edk2-devel] [Patch V5 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry

2023-06-19 Thread Gerd Hoffmann
On Thu, Jun 08, 2023 at 10:27:29AM +0800, duntan wrote: > Remove code that apply AddressEncMask to non-leaf entry when split > smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it > calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask > bit in page table for a specific range.

Re: [edk2-devel] [PATCH 2/3] UefiCpuPkg/ResetVector: Add guidance of how to guarantee 16B align

2023-06-19 Thread Zhiguang Liu
Hi Ray, I don't think we need the 16 bytes align for reset vector. Because the size of reset vector is 16 bytes align, and it will be put in the end of FD, this mean the beginning address of the reset vector is (4G - size of reset vector), which is 16 bytes align. Thanks Zhiguang > -Origin

Re: [edk2-devel] [PATCH 1/5] OvmfPkg: avoid including AcpiPlatformLib twice

2023-06-19 Thread Gerd Hoffmann
On Wed, Jun 14, 2023 at 09:55:43AM +0200, Corvin Köhne wrote: > Signed-off-by: Corvin Köhne > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Peter Grehan > Cc: Rebecca Cran > Cc: Sami Mujawar Series breaks OvmfPkg/OvmfPkgIa32.dsc buil

Re: [edk2-devel] [PATCH 1/3] UefiCpuPkg: Include ResetVector in DSC

2023-06-19 Thread Gerd Hoffmann
On Thu, Jun 15, 2023 at 06:50:55PM +0800, Ray Ni wrote: > Since ResetVector source module shares the same GUID as the binary > module, the binary INF file is just removed from DSC. Series: Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messa

Re: [edk2-devel] [PATCH] OvmfPkg/README: Document Secure Boot

2023-06-19 Thread Gerd Hoffmann
On Fri, Jun 16, 2023 at 12:51:55AM +0400, Joursoir wrote: > +cc to maintainers > > On Sat, 3 Jun 2023 01:44:40 +0400 > "Joursoir" wrote: > > > Add the new section for Secure Boot. > > > > Signed-off-by: Alexander Goncharov > > --- > > OvmfPkg/README | 36 >

Re: [edk2-devel] [PATCH 1/5] OvmfPkg: avoid including AcpiPlatformLib twice

2023-06-19 Thread Corvin Köhne
On Mon, 2023-06-19 at 12:41 +0200, Gerd Hoffmann wrote: > On Wed, Jun 14, 2023 at 09:55:43AM +0200, Corvin Köhne wrote: > > Signed-off-by: Corvin Köhne > > Cc: Ard Biesheuvel > > Cc: Gerd Hoffmann > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Leif Lindholm > > Cc: Peter Grehan > > Cc: Reb

[edk2-devel] [PATCH v3 1/1] OvmfPkg/Bhyve: include TPM driver

2023-06-19 Thread Corvin Köhne
Bhyve will gain support for TPM emulation in the near future. Therefore, prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the bhyve OVMF DSC. Signed-off-by: Corvin Köhne Reviewed-by: Rebecca Cran Acked-by: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen C

[edk2-devel] [PATCH v3 0/1] OvmfPkg/Bhyve: add support for TPM

2023-06-19 Thread Corvin Köhne
CI: https://github.com/tianocore/edk2/pull/4531 Corvin Köhne (1): OvmfPkg/Bhyve: include TPM driver OvmfPkg/Bhyve/BhyveX64.dsc | 17 +++-- OvmfPkg/Bhyve/BhyveX64.fdf | 7 +++ 2 files changed, 22 insertions(+), 2 deletions(-) -- 2.41.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Lin

Re: [edk2-devel] [PATCH 1/5] OvmfPkg: avoid including AcpiPlatformLib twice

2023-06-19 Thread Gerd Hoffmann
On Mon, Jun 19, 2023 at 01:52:19PM +0200, Corvin Köhne wrote: > On Mon, 2023-06-19 at 12:41 +0200, Gerd Hoffmann wrote: > > On Wed, Jun 14, 2023 at 09:55:43AM +0200, Corvin Köhne wrote: > > > Signed-off-by: Corvin Köhne > > > Cc: Ard Biesheuvel > > > Cc: Gerd Hoffmann > > > Cc: Jiewen Yao > > >

Re: [edk2-devel] [PATCH 1/5] OvmfPkg: avoid including AcpiPlatformLib twice

2023-06-19 Thread Corvin Köhne
On Mon, 2023-06-19 at 15:04 +0200, Gerd Hoffmann wrote: > On Mon, Jun 19, 2023 at 01:52:19PM +0200, Corvin Köhne wrote: > > On Mon, 2023-06-19 at 12:41 +0200, Gerd Hoffmann wrote: > > > On Wed, Jun 14, 2023 at 09:55:43AM +0200, Corvin Köhne wrote: > > > > Signed-off-by: Corvin Köhne > > > > Cc: Ar

[edk2-devel] [PATCH v2 0/6] OvmfPkg/Bhyve: install ACPI tables by FwCfg

2023-06-19 Thread Corvin Köhne
CI: https://github.com/tianocore/edk2/pull/4545 Corvin Köhne (6): OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory OvmfPkg: avoid including AcpiPlatformLib twice OvmfPkg: move PciEncoding into AcpiPlatformLib OvmfPkg: move BootScript into AcpiPlatformLib OvmfPkg: move QemuFwCfgAc

[edk2-devel] [PATCH v2 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory

2023-06-19 Thread Corvin Köhne
The definition and declaration of GetAcpiRsdpFromMemory doesn't match. We don't get a compile error yet because UINTN is the same as UINT64 on 64bit machines. As the function works on memory addresses, UINTN is the correct type of the input parameters. Signed-off-by: Corvin Köhne Cc: Ard Biesheuv

[edk2-devel] [PATCH v2 2/6] OvmfPkg: avoid including AcpiPlatformLib twice

2023-06-19 Thread Corvin Köhne
Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 + 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/Include/Lib

[edk2-devel] [PATCH v2 3/6] OvmfPkg: move PciEncoding into AcpiPlatformLib

2023-06-19 Thread Corvin Köhne
Bhyve supports providing ACPI tables by FwCfg. Therefore, InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the code. As first step, move PciEncoding into AcpiPlatformLib. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Le

[edk2-devel] [PATCH v2 4/6] OvmfPkg: move BootScript into AcpiPlatformLib

2023-06-19 Thread Corvin Köhne
This is required to move InstallQemuFwCfgTables into AcpiPlatformLib. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf |

[edk2-devel] [PATCH v2 5/6] OvmfPkg: move QemuFwCfgAcpi into AcpiPlatformLib

2023-06-19 Thread Corvin Köhne
This makes the InstallQemuFwcfgTables function reusable by bhyve. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf

[edk2-devel] [PATCH v2 6/6] OvmfPkg/Bhyve: install Acpi tables provided by FwCfg

2023-06-19 Thread Corvin Köhne
Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 + 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/Bhyve/Ac

[edk2-devel] Need help to add me to the edk-ii-reviewers team

2023-06-19 Thread Ashraf Ali S
HI All I signed up to work as Reviewer for InteFsp2Pkg and IntelFsp2WrapperPkg Maintainer file has been already updated : https://github.com/tianocore/edk2/blob/master/Maintainers.txt Need help to add me to the edk-ii-reviewers team. Ashraf Ali S ashraf.al...@intel.com

[edk2-devel] [PATCH 1/1] ArmPkg: Add Pcd to disable EFI_MEMORY_ATTRIBUTE_PROTOCOL

2023-06-19 Thread Oliver Steffen
Recent versions of shim (15.6 and 15.7) crash when the newly added EFI_MEMORY_ATTRIBUTE_PROTOCOL is provided by the firmware. To allow existing installations to boot, provide a workaround in form of a Pcd that allows tuning it off at build time (defaults to 'enabled'). Additionally, check the ret

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, June 19, 2023 #cal-reminder

2023-06-19 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, June 19, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f9

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, June 19, 2023 #cal-notice

2023-06-19 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, June 19, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, June 20, 2023 #cal-reminder

2023-06-19 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, June 20, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed

[edk2-devel] [PATCH V2] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-19 Thread Li, Yi
FIX: https://bugzilla.tianocore.org/show_bug.cgi?id=4477 Tls connection fail over WiFi in AMT OCR flow due to invalid identity. This was due to missing conversion between unicode and ascii string which resulted in invalid strlen. Cc: Maciej Rabeda Cc: Siyuan Fu Cc: Zachary Clark-Williams Sign

Re: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-19 Thread Li, Yi
Hi Zachary, Thanks for review. > > The protocol has changes since ADL from PlatSapmle to an advanced feature > and the Protocol has shifted into EDK2, so the protocol name needs to be > updated: > + Status = gBS->LocateProtocol (& gWiFiProfileSyncProtocolGuid , NULL, > (VOID **) &WiFiProfileSync