[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix wrong parameter type in VtdLog.c

2023-06-12 Thread Sheng Wei
Add (VOID **) for gBS->AllocatePool. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski Signed-off-by: Sheng Wei --- .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSi

[edk2-devel][edk2-platforms][PATCH V2-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-06-12 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This A

[edk2-devel][edk2-platforms][PATCH V2-2] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

2023-06-12 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This A

[edk2-devel] [PATCH v1 0/3] OvmfPkg/Bhyve: enable bus enumeration

2023-06-12 Thread Corvin Köhne
CI: https://github.com/tianocore/edk2/pull/4543 Corvin Köhne (3): Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan" Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver" OvmfPkg/BhyvePkg: enable bus enumeration OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++-- OvmfPkg/Bhyve/BhyveX64

[edk2-devel] [PATCH v1 2/3] Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"

2023-06-12 Thread Corvin Köhne
We like to enable bus enumeration for bhyve. Therefore, this patch needs to be reverted. This reverts commit 8c8f886f27556f2fb6e8b502d32aa9ccee930acc. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan --- Ov

[edk2-devel] [PATCH v1 1/3] Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"

2023-06-12 Thread Corvin Köhne
We like to enable bus enumartion for bhyve. Therefore, this patch needs to be reverted. This reverts commit c2f24ba3218ae91a8d5a1a31c31dad3417850d0c. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan --- Ovm

[edk2-devel] [PATCH v1 3/3] OvmfPkg/BhyvePkg: enable bus enumeration

2023-06-12 Thread Corvin Köhne
bhyve supports adding a ROM to PCI devices. It was added to support GPU passthrough of dedicated AMD GPUs. At the moment, this ROM file is mostly useless as it's not shadowed and executed by firmware. Change that by enabling bus enumeration. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Jie

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add CAPSULE_SUPPORT in UPL and set it as FALSE in default

2023-06-12 Thread Lu, James
Reviewed-by : James Lu Thanks, James -Original Message- From: Lin, MarsX Sent: Monday, June 12, 2023 3:10 PM To: devel@edk2.groups.io Cc: Lin, MarsX ; Ni, Ray ; Rhodes, Sean ; Guo, Gua ; Lu, James ; Dong, Guo Subject: [PATCH] UefiPayloadPkg: Add CAPSULE_SUPPORT in UPL and set it as

[edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-06-12 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This API us

[edk2-devel][edk2-platforms][PATCH V3-2] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

2023-06-12 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This API us

[edk2-devel] [PATCH 0/5] Eliminate the second INIT-SIPI-SIPI sequence

2023-06-12 Thread Yuanhao Xie
To speed up MP initialization, this set of patches replaces the time-consuming init-sipi-sipi process in the DXE phase. Instead, a start-up signal is used to wake up the APs and switch context from the PEI phase to the DXE phase. This optimization is effective when both PEI and DXE operate in

[edk2-devel] [PATCH 1/5] UefiCpuPkg: Create MpHandOff to transfer info from PEI to DXE.

2023-06-12 Thread Yuanhao Xie
The purpose of the Hob characterized by mCpuInitMpLibHobGuid was twofold: To transfer information from PEI to DXE and acted as a global variable for PEI. However, during the DXE phase,only a few fields from the CPU_MP_DATA which collected in PEI phase were needed. To enhance this process, a new H

[edk2-devel] [PATCH 2/5] UefiCpuPkg: Refactor the logic for placing APs in HltLoop.

2023-06-12 Thread Yuanhao Xie
Refactor the logic for placing APs in HltLoop into a separate function. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/UefiCp

[edk2-devel] [PATCH 3/5] UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop.

2023-06-12 Thread Yuanhao Xie
Refactor the logic for placing APs in Mwait/Runloop into a separate function. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 83 ++- 1 file changed,

[edk2-devel] [PATCH 4/5] UefiCpuPkg: ApWakeupFunction directly use CpuMpData.

2023-06-12 Thread Yuanhao Xie
CpuMpData can be passed directly to the ApWakeUpFunction instead of through MP_CPU_EXCHANGE_INFO. This modification is made in preparation for eliminating the requirement of a second INIT-SIPI-SIPI sequence in the DXE phase. Cc: Gerd Hoffmann Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Tom Le

[edk2-devel] [PATCH 5/5] UefiCpuPkg: Eliminate the second INIT-SIPI-SIPI sequence.

2023-06-12 Thread Yuanhao Xie
When both the PEI and DXE phases operate in the same execution mode(32-bit/64-bit), the BSP send a special start-up signal during the DXE phase to awaken the Application APs. To eliminate the need for the INIT-SIPI-SIPI sequence at the beginning of the DXE phase, the BSP call the SwitchApContext f

[edk2-devel] [PATCH] UefiPayloadPkg: Add CAPSULE_SUPPORT in UPL and set it as FALSE in default

2023-06-12 Thread marsx . lin
From: MarsX Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4479 Add CAPSULE_SUPPORT to optionally select CapsuleLib instance, default value is FALSE. Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Cc: James Lu Cc: Guo Dong Signed-off-by: MarsX Lin --- UefiPayloadPkg/UefiPayloadPkg.dsc

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Get HobListPtr before calling the Multiphase FSPS

2023-06-12 Thread kurugodx
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480 In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will be able to get the correct FspHobListPtr value Signed-off-by: kurugodx Cc: Chasel C

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

2023-06-12 Thread Nickle Wang via groups.io
- Run /BaseTools/Scripts/PatchCheck.py to check changes on pull request. - Create main.yml to handle push check on main branch. And show the status of RedfishClientPkg on README.md Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/workflows/build.yml | 3 -- .g

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Get HobListPtr before calling the Multiphase FSPS

2023-06-12 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Aishwarya, KurugoduMelmatamX > > Sent: Sunday, June 11, 2023 10:24 PM > To: devel@edk2.groups.io > Cc: Aishwarya, KurugoduMelmatamX > ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Chen, Gang C ;

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

2023-06-12 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, June 12, 2023 11:15 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch > ch

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

2023-06-12 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, June 12, 2023 11:15 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check **CAUTION: The e-mail below i

[edk2-devel] uefi VM and IO window overlap issue

2023-06-12 Thread Kallol Biswas [C]
Hi, We have been observing an issue that IO BARs can't be claimed due to resource conflict. [0.457693] pci :00:1d.0: can't claim BAR 4 [io 0x92a0-0x92bf]: address conflict with PCI Bus :01 [io 0x9000-0x9fff] [0.457705] pci :00:1d.1: can't claim BAR 4 [io 0x9280-0x929f]

[edk2-devel] [PATCH v2] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-06-12 Thread Abhimanyu Singh
From: Abhi Singh REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4410 REPO: https://github.com/tianocore/edk2/commit/7c9e1303fce5d49f8b597b4afd99ed855faaffaa Inside TcgMorLockSmm.c, the SetVariableCheckHandlerMorLock() function contains a scenario to prevent a possible dictionary attack

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, June 12, 2023 #cal-reminder

2023-06-12 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, June 12, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f9

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, June 12, 2023 #cal-notice

2023-06-12 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, June 12, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-

Re: [edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-06-12 Thread Isaac Oram
Comments inline, prefaced with "[Isaac]". Mostly style things that you could probably fix with uncrustify also. The main concern is the controls seem confused with #defines and PCD. Simplifying to just use the PCD directly seems clear to me and eliminating the #if logic in favor of regular C

Re: [edk2-devel][edk2-platforms][PATCH V3-2] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

2023-06-12 Thread Isaac Oram
Similar issues with four space indents, lack of spaces before { and (, #if logic. Regards, Isaac -Original Message- From: Arun K Sent: Monday, June 12, 2023 5:53 AM To: devel@edk2.groups.io; Arun K Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Ramkumar Krishnamoorthi ; Gao, Liming Su

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, June 13, 2023 #cal-reminder

2023-06-12 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, June 13, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed

[edk2-devel] [PATCH] Maintainers.txt: Stop to be reviewer of several modules

2023-06-12 Thread Ni, Ray
Remove my name from reviewer list of following modules: * MdeModulePkg: Console and Graphics modules * MdeModulePkg: Disk modules * MdeModulePkg: Reset modules * MdeModulePkg: Serial modules * MdeModulePkg: Universal Payload definitions Signed-off-by: Ray Ni Cc: Zhichao Gao Cc: Hao A Wu Cc: Zhi

Re: [edk2-devel] [PATCH] Maintainers.txt: Stop to be reviewer of several modules

2023-06-12 Thread Guo, Gua
Reviewed-by: Gua Guo for MdeModulePkg: Universal Payload definitions -Original Message- From: Ni, Ray Sent: Tuesday, June 13, 2023 10:07 AM To: devel@edk2.groups.io Cc: Gao, Zhichao ; Wu, Hao A ; Liu, Zhiguang ; Guo, Gua Subject: [PATCH] Maintainers.txt: Stop to be reviewer of sever

Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix wrong parameter type in VtdLog.c

2023-06-12 Thread Ni, Ray
Reviewed-by: Ray Ni From: devel@edk2.groups.io on behalf of Sheng Wei Sent: Monday, June 12, 2023 16:17 To: devel@edk2.groups.io Cc: Ni, Ray; Chaganty, Rangasai V; Huang, Jenny; Kowalewski, Robert Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix w

Re: [edk2-devel] [PATCH] Maintainers.txt: Stop to be reviewer of several modules

2023-06-12 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 10:07 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Wu, Hao A > ; Liu, Zhiguang ; Guo, Gua > > Subject: [PATCH] Maintainers.txt: Stop to be reviewer of several modules > > Remove my name from reviewer list of follow

Re: [edk2-devel] [PATCH] Maintainers.txt: Stop to be reviewer of several modules

2023-06-12 Thread Ni, Ray
Sure. I will update the patch to keep my name for disk modules. Thanks, Ray > -Original Message- > From: Wu, Hao A > Sent: Tuesday, June 13, 2023 11:05 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Gao, Zhichao ; Liu, Zhiguang > ; Guo, Gua > Subject: RE: [PATCH] Maintainers.txt: Stop to

Re: [edk2-devel] [PATCH] Maintainers.txt: Stop to be reviewer of several modules

2023-06-12 Thread Wu, Hao A
Thank you. Best Regards, Hao Wu > -Original Message- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 11:40 AM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Gao, Zhichao ; Liu, Zhiguang > ; Guo, Gua > Subject: RE: [PATCH] Maintainers.txt: Stop to be reviewer of several modules > > Sure.

Re: [edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-06-12 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Isaac, I had replied to AMI and had them to work on the ManageabilityPkg directly (I think it was few months ago) as we migrated all IPMI stuff from Intel IpmiFeaturePkg to ManageabilityPkg. Do you think we still have to spend effort on IpmiFeaturePkg? AMD al

[edk2-devel] [PATCH v3] StandaloneMmPkg: Add StandaloneMmIplPei driver.

2023-06-12 Thread Zhang, Hongbin1
Add StandaloneMmIplPei IA32/X64 driver at PEI stage. FSP will use this driver to load Standalone MM code to dispatch other Standalone MM drivers. And this is the 1st patch to implement the entrypoint to find the correct SMRAM range and dump it Signed-off-by: Hongbin1 Zhang Cc: Jiewen Yao Cc: Ray

[edk2-devel] [PATCH V3 0/8] Enable SMM perf-logging

2023-06-12 Thread Ni, Ray
To avoid impacting runtime performance, the perf-logging is disabled upon ExitBootServices. Ray Ni (8): UefiCpuPkg/CpuSmm: Add perf-logging for time-consuming BSP procedures UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures MdeModulePkg/SmmCore: Add perf-logging for time-consuming proced

[edk2-devel] [PATCH V3 1/8] UefiCpuPkg/CpuSmm: Add perf-logging for time-consuming BSP procedures

2023-06-12 Thread Ni, Ray
The patch adds perf-logging for the following potential time-consuming BSP procedures: * PiCpuSmmEntry - SmmRelocateBases - ExecuteFirstSmiInit * BSPHandler - SmmWaitForApArrival - PerformRemainingTasks * InitPaging * SetMemMapAttributes * SetUefiMemMapAttributes * SetPageT

[edk2-devel] [PATCH V3 2/8] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures

2023-06-12 Thread Ni, Ray
MP procedures are those procedures that run in every CPU thread. The EDKII perf infra is not MP safe so it doesn't support to be called from those MP procedures. The patch adds SMM MP perf-logging support in SmmMpPerf.c. The following procedures are perf-logged: * SmmInitHandler * SmmCpuFeaturesRe

[edk2-devel] [PATCH V3 3/8] MdeModulePkg/SmmCore: Add perf-logging for time-consuming procedures

2023-06-12 Thread Ni, Ray
Following procedures are perf-logged: * SmmReadyToBootHandler * SmmReadyToLockHandler * SmmEndOfDxeHandler * SmmEntryPoint (It's the main routine run in BSP when SMI happens.) * SmiManage Cc: Jian J Wang Cc: Liming Gao Cc: Jiaxin Wu Reviewed-by: Jiaxin Wu Reviewed-by: Eric Dong --- MdeModu

[edk2-devel] [PATCH V3 4/8] MdeModulePkg/SmmCore: Add perf-logging for SmmDriverDispatchHandler

2023-06-12 Thread Ni, Ray
SmmDriverDispatchHandler is the routine that dispatches SMM drivers from FV. It's a time-consuming routine. Add perf-logging for this routine. Signed-off-by: Ray Ni Cc: Jian J Wang Cc: Liming Gao Cc: Jiaxin Wu Reviewed-by: Jiaxin Wu Reviewed-by: Eric Dong --- MdeModulePkg/Core/PiSmmCore/Dis

[edk2-devel] [PATCH V3 5/8] MdeModulePkg/SmmPerformanceLib: Disable perf-logging after ExitBS

2023-06-12 Thread Ni, Ray
Because SMM perf-logging is migrated to non-SMRAM at ReadyToBoot by DxeCorePerformanceLib, the perf-logging after ExitBS is useless and impact the SMI latency at runtime. Hence the SmmPerformanceLib is updated to disable perf-logging after ExitBS. Cc: Jiaxin Wu Cc: Dandan Bi Cc: Liming Gao Cc:

[edk2-devel] [PATCH V3 6/8] MdeModulePkg/SmmCorePerformanceLib: Disable perf-logging at runtime

2023-06-12 Thread Ni, Ray
Because SMM perf-logging is migrated to non-SMRAM at ReadyToBoot by DxeCorePerformanceLib, the perf-logging after ExitBS is useless and impact the SMI latency at runtime. Hence the SmmCorePerformanceLib is updated to disable perf-logging after ExitBS. Cc: Jiaxin Wu Cc: Dandan Bi Cc: Liming Gao

[edk2-devel] [PATCH V3 7/8] UefiCpuPkg/SmmCpu: Add PcdSmmApPerfLogEnable control AP perf-logging

2023-06-12 Thread Ni, Ray
When a platform has lots of CPU cores/threads, perf-logging on every AP produces lots of records. When this multiplies with number of SMIs during post, the records are even more. So, this patch adds a new PCD PcdSmmApPerfLogEnable (default TRUE) to allow platform to turn off perf-logging on APs.

[edk2-devel] [PATCH V3 8/8] MdeModulePkg/SmmCore: Perf-log PlatformHookBefore/AfterSmmDispatch

2023-06-12 Thread Ni, Ray
Signed-off-by: Ray Ni Cc: Jian J Wang Cc: Liming Gao Cc: Jiaxin Wu --- MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 4 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c index 68af9ab81b..a8537829e3 100644 --- a/Md

[edk2-devel] [PATCH V2] Maintainers.txt: Stop to be reviewer of several modules

2023-06-12 Thread Ni, Ray
Remove my name from reviewer list of following modules: * MdeModulePkg: Console and Graphics modules * MdeModulePkg: Reset modules * MdeModulePkg: Serial modules * MdeModulePkg: Universal Payload definitions Signed-off-by: Ray Ni Cc: Zhichao Gao Cc: Hao A Wu Cc: Zhiguang Liu Cc: Gua Guo ---