On Fri, 2 Jun 2023 at 21:42, Ranbir Singh wrote:
>
> From: Ranbir Singh
>
> Line number 1348 does contain a typecast with UINT32, but it is after
> all the operations (16-bit left shift followed by OR'ing) are over.
> To avoid any SIGN_EXTENSION, typecast the intermediate result after
> 16-bit le
On Sat, 3 Jun 2023 at 18:04, Pedro Falcato wrote:
>
> On Fri, Jun 2, 2023 at 8:42 PM Ranbir Singh wrote:
> >
> > From: Ranbir Singh
> >
> > The return value stored in Status after call to SetDriveParameters
> > is not made of any use thereafter and hence it remains as UNUSED.
> > Assuming, this
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, June 5, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1890537 )
*Description:*
TianoCor
> +/**
> + Allocate Buffer Or Clear Buffer For Global Data.
> +**/
> +VOID
> +AllocateBufferOrClearBufferForGlobalData (
> + VOID
> + )
> +{
> + ZeroMem (&mPrivateData, sizeof (mPrivateData));
> + if (!PSInitDone) {
1. "PSInitDone" doesn't follow edk2 coding style.
> +mHobBuffer = Alloc
Thanks all,
Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/4478,
but failed 3 times (all due to some canceled CI tests).
Will re-try tomorrow.
Best Regards,
Hao Wu
From: Hsueh, Hong-Chih (Neo)
Sent: Saturday, June 3, 2023 2:12 AM
To: Chang, Abner ; Wu, Hao A ; He,
Ji
FIX: https://bugzilla.tianocore.org/show_bug.cgi?id=4477
Tls connection fail over WiFi in AMT OCR flow due to invalid identity.
This was due to missing conversion between unicode and ascii
string which resulted in invalid strlen.
Cc: Maciej Rabeda
Cc: Siyuan Fu
Signed-off-by: Yi Li
---
.../W
First nibbles of DFR0/ISAR1/ISAR2/MMRF2/PFR0 system registers were read
in wrong way -- second one was used instead.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ArmPkg/Application/
This changeset was supposed to add SVE/SME information but got some
updates to improve output of ArmCpuInfo application a bit too.
Probably would need to definition of system registers for older
toolchains.
Changes since v1:
- show stage 2 granule support on Neoverse-N1
Marcin Juszkiewicz (8):
It is hard to fit in 80 columns so let drop extra spaces and ID_AA64
prefix from system register names.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 36 +++---
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/ArmPkg/Application
ID_AA64ZFR0_EL1 and ID_AA64SMFR0_EL1 system registers are needed for
ArmCpuInfo application to show state of SVE/SME support.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Library/ArmLib/ArmBaseLib.inf | 5 +
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 12
ArmPkg/
If system register is empty (value == 0) then do not display information
from it.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 35 +++---
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo
Having two places with same formatting is error-prone.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
ind
If cpu supports SVE or SME then display information of supported
features.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 344 +
1 file changed, 344 insertions(+)
diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
b/ArmPkg/Applicatio
They are useful for those platforms where SMC SiP calls exist.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
N1 uses '' values which mean:
Support for 4KB granule at stage 2 is identified in the
ID_AA64MMFR0_EL1.TGran{4,16,64} field.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/ArmPkg/App
There is no point of having double spaces.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 24 +++---
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
b/ArmPkg/Application/ArmCpuInfo/Arm
16 matches
Mail list logo