Thanks Liming!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming
> via groups.io
> Sent: Thursday, May 11, 2023 7:45 PM
> To: Chiu, Chasel ; devel@edk2.groups.io; Guo, Gua
>
> Cc: 'Andrew Fish' ; 'Leif Lindholm'
> ; Kinney, Michael D
> Subject: 回复: [edk2-devel] [
Hi Liming,
PR has been updated with all RB:
https://github.com/tianocore/edk2/pull/4389/commits
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Friday, May 12, 2023 12:11 AM
> To: devel@edk2.groups.io; Gao, Liming ; Guo,
> Gua
> Cc:
Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish feature driver.
Feature driver uses this protocol to query OEM resource from platform in
order to support Redfish OEM property. This protocol is also used to get
addendum data that is required by BMC to manage Redfish BIOS service.
Sign
Introduce Redfish Resource Addendum Protocol to Redfish feature driver.
Feature driver uses this protocol to query OEM resource from platform in
order to support Redfish OEM property. This protocol is also used to get
addendum data that is required by BMC to manage Redfish BIOS service.
Signed-off
Implement RedfishAddendumLib to support Redfish Resource Addendum Protocol.
Feature driver calls this library to get addendum data before providing
data to Redfish service
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/RedfishClientLibs.dsc.inc| 4 +-
Bios feature driver utilizes RedfishAddendumLib and get additional data
before sending BIOS attributes to Redfish service.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 2 +
.../Include/RedfishResourceCommon.h |
From: Abner Chang
IpmiSolStatus is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/SolStatus in order to consolidate
edk2 system manageability support in one place.
Uncustify is applied to C files and no functionalities
are changed in this patch.
We will still keep
From: Abner Chang
Add IpmiSolStatus to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 1 +
Features/ManageabilityPkg/Include/Manageability.dsc | 4
Features/ManageabilityPkg/Ma
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, May 12, 2023 12:07 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang ; Tinh Nguyen
>
> Subject: [edk2-platforms][PATCH 1/2] ManageabilityPkg/IpmiO
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, May 12, 2023 12:07 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang
> Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiOsWdt: Add to
>
Reviewed-by: Tinh Nguyen
Thanks,
- Tinh
On 12/05/2023 10:26, abner.ch...@amd.com wrote:
From: Abner Chang
IpmiFru is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/IpmiFru in order to consolidate
edk2 system manageability support in one place.
Uncustify is app
Hi Liming,
If there are no concerns, can you assist in merging them?
Thanks
- Tinh
On 08/05/2023 08:07, gaoliming wrote:
Reviewed-by: Liming Gao
-邮件原件-
发件人: Tinh Nguyen
发送时间: 2023年5月7日 17:29
收件人: devel@edk2.groups.io
抄送: patc...@amperecomputing.com; michael.d.kin...@intel.com;
gao
[AMD Official Use Only - General]
Hi Tinh, It is already merged.
Abner
> -Original Message-
> From: Tinh Nguyen
> Sent: Friday, May 12, 2023 4:50 PM
> To: gaoliming ; 'Tinh Nguyen'
> ; devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com;
> zhiguang@in
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of VincentX Ke
> Sent: Thursday, May 11, 2023 6:00 PM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric ;
> Sinha, Ankit
> Subject: [edk2-deve
oh, sorry, I have some personal issues and not follow up recently,
Abner, thanks for letting me know
- Tinh
On 12/05/2023 16:16, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Tinh, It is already merged.
Abner
-Original Message-
From: Tinh Nguyen
Sent: Friday, May 12, 202
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394
Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit
pointer
Cc: Hao A Wu
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Cc: Andrew Fish
Signed-off-by: Giri Mudusuru
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcP
From: Abner Chang
IpmiBmcElog is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/BmcElog in order to consolidate
edk2 system manageability support in one place.
Uncustify is applied to C files and no functionalities
are changed in this patch.
We will still keep the
From: Abner Chang
Add IpmiBmcElog to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 1 +
Features/ManageabilityPkg/Include/Manageability.dsc | 4
Features/ManageabilityPkg/Mana
addres->address
orignal->original
Propery->Property
StartAdress->StartAddress
sucessfully->successfully
uinstance->instance
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Andrew Fish
Signed-off-by: Giri Mudusuru
---
MdePkg/Library/BaseDebugLibNull/DebugLib.c| 28 +--
compatability->compatibility
EFI_MEDIA_CHNAGED->EFI_MEDIA_CHANGED
Funtion->Function
exhausive->exhaustive
Propery->Property
StartAdress->StartAddress
sucessful->successful
writting->writing
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Andrew Fish
Signed-off-by: Giri Mudusuru
---
Backward-compatibility changes:
This patch series removes the SmmCpuFeaturesReadSaveStateRegister
and SmmCpuFeaturesWriteSaveStateRegister interface/function.
SmmReadSaveState() and SmmWriteSaveState() now directly invokes MmSaveStateLib
routines to save/restore registers.
PR: https://gith
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds an SMM SMRAM save-state map for AMD processors.
SMRAM save state maps for the AMD processor family are now supported.
Save state map structure is added based on
AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2.
The AMD le
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds MmSaveStateLib Library class in UefiCpuPkg.dec.
Adds function declaration header file.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Abn
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib Library class for
AMD cpu family.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Abner Ch
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
moves Intel-specific code to the arch-dependent file.
Other processor families might have different
implementation of these functions.
Hence, moving out of the common file.
Cc: Abner Chang
Cc: Paul Grimes
Cc: Eri
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib library interfaces
to read and write save state
registers for Intel processor family.
Moves Intel and AMD common functionality to common area.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements interfaces to read and write save state
registers of AMD's processor family.
Initializes processor SMMADDR and MASK depends
on PcdSmrrEnable flag.
Program or corrects the IP once control returns from SMM.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Removes SmmCpuFeaturesReadSaveStateRegister and
SmmCpuFeaturesWirteSaveStateRegister
function from SmmCpuFeaturesLib library.
MmSaveStateLib library replaces the functionality of the above
functions.
Platform old/new need to use MmSaveState
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Uses new MmSaveStateLib library instance.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Signed-off-by: Abdul
On Tue, May 09, 2023 at 05:32:11PM +0100, Pedro Falcato wrote:
> Replace the OVMF-specific SataControllerDxe (to be later removed) with
> the generic, MdeModulePkg one, for the OvmfXen platform.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Cc: Anthony Perar
Signed-off-by: Gerd Hoffmann
---
ArmVirtPkg/ArmVirtQemu.dsc | 1 +
ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 +
3 files changed, 3 insertions(+)
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index 449e73b9e132..d998f816b
IsVirtioRng() becomes just a thin wrapper for IsVirtio().
This allows to add similar thin wrappers for other virtio
devices in the future.
Signed-off-by: Gerd Hoffmann
---
.../PlatformBootManagerLib/PlatformBm.c | 26 +++
1 file changed, 21 insertions(+), 5 deletions(-)
di
IsVirtioPciRng() becomes just a thin wrapper for IsVirtioPci().
This allows to add similar thin wrappers for other virtio
devices in the future.
Signed-off-by: Gerd Hoffmann
---
.../PlatformBootManagerLib/PlatformBm.c | 30 ++-
1 file changed, 23 insertions(+), 7 deletions(
Apparently TPL_CALLBACK is too low, code runs into an ASSERT
complaining the new TPL is lower than the old TPL.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial
Gerd Hoffmann (5):
ArmVirt: add VirtioSerialDxe to ArmVirtQemu builds
ArmVirt/PlatformBootManagerLib: factor out IsVirtio()
ArmVirt/PlatformBootManagerLib: factor out IsVirtioPci()
ArmVirt/PlatformBootManagerLib: set up virtio serial as console
OvmfPkg/VirtioSerialDxe: use TPL_NOTIFY
In case a virtio serial device is found in the system register the first
console port as EFI console, by updating ConIn, ConOut and ErrOut.
Signed-off-by: Gerd Hoffmann
---
.../PlatformBootManagerLib/PlatformBm.c | 163 ++
1 file changed, 163 insertions(+)
diff --git a/Arm
[AMD Official Use Only - General]
Hi Ray,
Looks like some issue with my mailbox, I saw your mail after submitting
patch V12.
I'll rework and send V13 patch series.
Thanks
AbduL
-Original Message-
From: Ni, Ray
Sent: 12 May 2023 09:11
To: devel@edk2.groups.io; Ni, Ray ; Attar, A
Currently, the GIC and redistributors base addresses are defined using
FixedPcds.
In order to enable the QEMU platform to evolve to provide ITS frames,
as well as newer versions of the GIC, convert these accesses to Dynamic.
Firtsly, this requires fixing the bug of the addresses being read as 32-
gArmTokenSpaceGuid.PcdGicDistributorBase and
gArmTokenSpaceGuid.PcdGicRedistributorsBase are both defined as UINT64 in
ArmPkg.dec, but SbsaQemuAcpiDxe and its exported header file use
PcdGet32. While this currently works, it will break once these Pcds are
made dynamic - so fix.
Signed-off-by: Leif
The GIC addresses as currently declared as FixedPcd for SbsaQemu.
Change them to dynamic, to enable future patches to support these
being determined at runtime.
Signed-off-by: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Graeme Gregory
Cc: Radoslaw Biernacki
Cc: Marcin Juszkiewicz
---
Platform/Qemu/
(+CC maintainers)
On Thu, May 11, 2023 at 5:47 PM wrote:
>
> The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit
> machines.
>
> Signed-off-by: Neil Jones
> ---
> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
Hi Mike,
Thanks to share the details. I think you are right the "buffer" need be freed
using ReadSection().
I don't really want to read the shell file, so I would update this patch to use
ReadFile() which supports NULL for the file buffer.
Thanks,
Guo
-Original Message-
From: Mike Masle
From: Guo Dong
After moving BDS driver to a new FV for universal UEFI payload,
the shell boot option path is not correct since it used the BDS
FV instead of DXE FV in its device path.
This patch would find the correct FV by reading shell file.
It also removed PcdShellFile by using gUefiShellFileG
Hi Liming,
I know EDK2 is code freeze now. This patch fixes the UEFI payload boot to shell
bug and it got reviewed and should have no impact to other packages.
Do you think we could merge it for this stable release?
https://github.com/tianocore/edk2/pull/4377
Thanks,
Guo
-Original Message-
44 matches
Mail list logo
