This patchset contains modifications required in UPL boot flow to
enable RiscV64 support. Squashing earlier series of patches
related to arch specific removal from UPL boot path to this release such
that all chnages can be viewed in the entirety.
1. Add required infra to support RiscV64
2. New UPL
According to UPL spec BL should initialize FP init meaning UPL
does not need to initialize it. Besides this is arch specific init
and needs to be moved out of UPL common flow. In order to not break
current BL implementations, for now just moving the init to later
point of time but for both x32 and
This patchset contains modifications required in UPL boot flow to
enable RiscV64 support. Squashing earlier series of patches
related to arch specific removal from UPL boot path to this release such
that all chnages can be viewed in the entirety.
1. Add required infra to support RiscV64
2. New UPL
According to UPL spec BL should initialize FP init meaning UPL
does not need to initialize it. Besides this is arch specific init
and needs to be moved out of UPL common flow. In order to not break
current BL implementations, for now just moving the init to later
point of time but for both x32 and
8259 is very arch specific programming. It needs to be moved out to
the respective arch flow. Added in both x64 and x32 paths
Test: Able to boot UEFI shell with Coreboot Tianocore payload on
x86 qemu
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Dhaval Shar
According to UPL spec for various archs ABIs we have different
input passing arguments. We provide Arch specific hooks to
ensure FDT is populated from the correct argument following the
spec. TODO: Will have to create one parser per arch.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc
Add support for RiscV64 Arch for UPL. The Patch primarily
allows one to compile UPL with RV64 GCC tools.
It builds on top of earlier patches submitted for UPL
boot flow modifications where arch specific initialization
was removed. Follow up patches will be added to further the
boot flow.
Test: Tes
Provide an arch specific hook which will consume IN params
to UPL and populate FDT variable properly. Each Arch has its
own ABI and accordingly input param changes. First part, This
hook will ensure correct input param is used to populate FDT
value. Second part, after finding proper FDT, it uses FD
RV CPU driver requires access to HartID and FDT passed by BL.
Set it through FirmwareContext. In future this should be passed
as part of FDT itself to avoid any custome structures.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc: Sunil V
Signed-off-by: Dhaval Sharma
---
UPL expects to have Dxe info from gUniversalPayloadExtraDataGuid HOB.
With new FDT proposal this requirement should go away. But for now
satisfying this requirement through RV hook.
Test: Able to enter DxeMain function after finding correct DxeFv.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: Ja
Added required Dxe and Arch Proto drivers to ensure we
are able to boot to Shell.
Test: Able to boot to UEFI Shell
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc: Sunil V
Signed-off-by: Dhaval Sharma
---
UefiPayloadPkg/UefiPayloadPkgRV64.dsc | 33 +++--
UefiPa
Jiaxin,
Let's keep using 48 or 57.
We can use separate patch to clean all existing code to use 47 and 56.
Thanks,
Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, May 11, 2023 1:08 PM
> To: devel@edk2.groups.io; kra...@redhat.com; Ni, Ray
> Cc: Dong, Eric ; Zeng, Star ;
> K
On 2023-05-10 19:57, Michael D Kinney wrote:
Hi Leif,
The original patch series was sent by Victor in January and has Signed-off-by
from Victor.
https://edk2.groups.io/g/devel/message/99333
Subsequent updates to the patch series based on feedback were sent by Gua.
Ah, understood.
@Dhaval Sharma I give some feedbacks on the PR.
URL: https://github.com/tianocore/edk2/pull/4367
I think we can discuss it on the PR. And currently Edk2 code freeze so the
change need to hold on until UPL spec 1.0 publish and Edk2 code freeze unlock
(2023/05/26).
Thanks,
Gua
-Original Messa
From: VincentX Ke
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
Calculating CRC based on each ACPI table.
Update HWSignature filed in FACS based on CRC while ACPI table changed.
Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c
Signed-off-by: VincentX Ke
Cc: Chasel Chiu
Cc: Nate
Hi, Ray
Thanks for the correction and those suggestion in previous patches.
As your suggestion, the best way is keep following the logic of ACPI spec
definition.
[Patch V7] updated with https://edk2.groups.io/g/devel/message/104685
I apologize for those flaws in previous patches.
Sincerely,
Vinc
Backward-compatibility changes:
This patch series removes the SmmCpuFeaturesReadSaveStateRegister
and SmmCpuFeaturesWriteSaveStateRegister interface/function.
SmmReadSaveState() and SmmWriteSaveState() now directly invokes MmSaveStateLib
routines to save/restore registers.
PR: https://gith
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds an SMM SMRAM save-state map for AMD processors.
SMRAM save state maps for the AMD processor family are now supported.
Save state map structure is added based on
AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2.
The AMD le
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib Library class for
AMD cpu family.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Abner Ch
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds MmSaveStateLib Library class in UefiCpuPkg.dec.
Adds function declaration header file.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Abn
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
moves Intel-specific code to the arch-dependent file.
Other processor families might have different
implementation of these functions.
Hence, moving out of the common file.
Cc: Abner Chang
Cc: Paul Grimes
Cc: Eri
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib library interfaces
to read and write save state
registers for Intel processor family.
Moves Intel and AMD common functionality to common area.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements interfaces to read and write save state
registers of AMD's processor family.
Initializes processor SMMADDR and MASK depends
on PcdSmrrEnable flag.
Program or corrects the IP once control returns from SMM.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Removes SmmCpuFeaturesReadSaveStateRegister and
SmmCpuFeaturesWirteSaveStateRegister
function from SmmCpuFeaturesLib library.
MmSaveStateLib library replaces the functionality of the above
functions.
Platform old/new need to use MmSaveState
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Uses new MmSaveStateLib library instance.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Signed-off-by: Abdul
On 5/9/23 18:32, Pedro Falcato wrote:
> > Replace the OVMF-specific SataControllerDxe (to be later removed)
> > with
> > the generic, MdeModulePkg one, for the Bhyve platform.
> >
> > Cc: Ard Biesheuvel
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Gerd Hoffmann
> > Cc: Rebecca Cran
> > Cc
This makes the function reuseable by bhyve.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Anthony Perard
Cc: Julien Grall
---
.../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 -
OvmfPkg/Include/Library/AcpiPlatformLib.h |
It's much easier to create configuration dependend ACPI tables for bhyve
than for OVMF. For this reason, don't use the statically created ACPI
tables provided by OVMF. Instead prefer the dynamically created ACPI
tables of bhyve. If bhyve provides no ACPI tables or we are unable to
detect those, fal
Xen and bhyve are placing ACPI tables into system memory. So, they can
share the same code. Therefore, create a new library which searches and
installs ACPI tables from system memory.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: A
Could you cc me on _all_ of the patches in a series please?
I seem to have been missed on this one, and only cc'd on 3/3.
--
Rebecca Cran
On 5/11/23 06:02, Corvin Köhne wrote:
This makes the function reuseable by bhyve.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuv
On Thu, 2023-05-11 at 07:04 -0600, Rebecca Cran wrote:
> Could you cc me on _all_ of the patches in a series please?
>
> I seem to have been missed on this one, and only cc'd on 3/3.
>
>
Sry, I've updated my cc list. So, you'll be included in my next update.
--
Kind regards,
Corvin
On 5/11
On Thu, 11 May 2023 at 15:16, Corvin Köhne wrote:
>
> On Thu, 2023-05-11 at 07:04 -0600, Rebecca Cran wrote:
> > Could you cc me on _all_ of the patches in a series please?
> >
> > I seem to have been missed on this one, and only cc'd on 3/3.
> >
> >
>
> Sry, I've updated my cc list. So, you'll be
On Thu, May 11, 2023 at 02:02:37PM +0200, Corvin Köhne wrote:
> diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c
> b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c
> new file mode 100644
> index ..ce52ad31cf25
> --- /dev/null
> +++ b/OvmfPkg/Library/AcpiPlatformL
On Thu, May 11, 2023 at 02:02:38PM +0200, Corvin Köhne wrote:
> This makes the function reuseable by bhyve.
>
> Signed-off-by: Corvin Köhne
> Acked-by: Gerd Hoffmann
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sen
Liming’s email appeared to say that patch reviews could continue even if they
aren’t for the upcoming release?
“ We enter into Soft Feature Freeze phase on 2023-05-08. In this phase,
the feature under review will not be allowed to be pushed. The feature passed
review can still be merged.
The
Qemu has versioning for sbsa-ref platform. TF-A reads data from provided
DeviceTree and provides as SMC.
This change adds reading GIC base addresses into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 24 +++
.../SbsaQemuPlatformDxe.i
This changeset adds support to platform versioning for SbsaQemu
platform.
changes since v4:
- SMC variables renamed to Arg0, Arg1 as they are used for misc calls
- GIC base handling added
Patch 2/2 (GIC) does not build. No idea why.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messa
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 +++
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c
[AMD Official Use Only - General]
Hi Michael,
Thanks for providing the inputs, I will make the necessary changes.
Please see inline for my reply.
-Original Message-
From: Michael Kubacki
Sent: 10 May 2023 00:42
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc: Gr
These patches help to improve PCIe core for Link training sequence and
add logic to check PCIe card is present or not. One patch also removes
unnecessary checks for PCIe Devmap mode.
Minh Nguyen (2):
AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap
mode
AmpereAltraPkg
In order to detect the NVMe after OS boots successfully but
that NVMe's not present previously. Hot Plug Slot Capable
will help PCI Linux driver to initialize its slot iomem resource
which is used for detecting the disk when it's inserted.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltr
Because PCIe Auto bifurcation feature doesn't depend on the default
Devmap mode so that "DevMapModeAuto" is unnecessary in retrieving
the PCIe Devmap default mode.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c | 2 +-
1 file changed, 1 inse
Currently, the implementation starts link training and put device
out-of-reset right away. This make LinkStat and BlockEventStat registers
indicate that link is not up yet (LinkStat: 0x300 and BlockEventStat: 0x0).
This fix will start link training after putting device out-of-reset.
The values of L
From: Vu Nguyen
This adds necessary changes of ACPI tables and defines the memory
region between OS and Trusted Firmware-A for supporting Hot Plug
of Ampere Altra.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/AcpiTables/Dsdt.asl | 499 -
Platform/Ampere/JadePkg/AcpiTables/
As AMBA_LINK_TIMEOUT_OFF spec, it impacts OS Hot Plug removal delay.
The greater value the longer delay it is. Per experiments, set it 2
from beginning of Root Port initialization for stable operation.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c |
These patches support NVMe Hot Plug feature for Ampere Altra and Ampere Altra
Max.
Minh Nguyen (2):
AmpereAltraPkg: Add Hot Plug Slot Capable during PCIe port
initialization
AmpereAltraPkg: Change PCIe Amba Link Timeout value
Vu Nguyen (4):
AmpereAltraPkg: Add PCIe Hot Plug library
J
From: Vu Nguyen
This enables NVMe Hot Plug feature after finishing
PCIe set up. This helps to detect NVMe disk when
it's removed or inserted into its slot.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/PcieInitPei.inf | 3 ++-
Silicon/Ampere/AmpereAltraPkg/Dr
The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit
machines.
Signed-off-by: Neil Jones
---
ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
b/ArmPkg/Drivers/ArmGic/GicV2/ArmG
From: Vu Nguyen
This adds necessary changes of ACPI tables and defines the memory
region between OS and Trusted Firmware-A for supporting Hot Plug
of Ampere Altra Max.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi | 24 +
Platform/Ampere/JadePkg/Ac02
From: Tinh Nguyen
Add PCIe link retry logic. If the card is detected to be present,
allow a retry for 3 times.
When the link is down, check if the LTSSMEN bit is cleared.
Based on Altra PCIe IP, the LTSSMEN bit is cleared from 1 to 0
if there is a surprising link down.
This indicates that a card
From: Vu Nguyen
This adds PCIe Hot Plug library to support Hot Plug
feature and specific procedures for setting different
Portmap tables (GPIO pins used for PCIe reset).
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dec| 8
+-
Silicon/Am
Hi Mike,
Thanks for your comments.
The "Buffer" is initialized to NULL for ReadSection call, we don't need free
"Buffer" since there is no data really read to Buffer.
With "Buffer" set to NULL, it just test if the file exists in the FV. If it
exists, it will return success with file size.
Thank
Hi Guo,
thanks for your explanation.
I may be wrong, but there is a different logic used.
Passing pointer to NULL means request for callee allocation.
I assume EFI_FIRMWARE_VOLUME2_PROTOCOL implemented in
MdeModulePkg/Core/Dxe/FwVol.
So, Fv->ReadSection() actually is FvReadFileSection() call [1].
Hi Michael,
When can you or one of the MdePkg maintainers merge the SBI SerialLib patch set?
A
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Andrei
> Warkentin
> Sent: Tuesday, April 25, 2023 2:27 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Sunil V L
> Subj
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro
> Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming ; Wu, Hao A ; Ni,
> Ray ; Mik
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Pedro Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming ; Wu, Hao A ; Ni,
> Ray
> Subject: [PATCH v2 02/12] MdeModulePkg
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro
> Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming ; Wu, Hao A ; Ni,
> Ray
> Su
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Pedro Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming ; Wu, Hao A ; Ni,
> Ray ; Mike Maslenkin
> Subject: [PATCH v2 04
Ard:
This change is good to me. Reviewed-by: Liming Gao
Will it be merged for this stable tag?
Thanks
Liming
> -邮件原件-
> 发件人: Ard Biesheuvel
> 发送时间: 2023年5月11日 15:00
> 收件人: devel@edk2.groups.io
> 抄送: Ard Biesheuvel ; Rebecca Cran
> ; Liming Gao
> 主题: [PATCH] BaseTools/tools_def:
Reviewed-by: Rebecca Cran
Thanks!
On 5/11/23 12:59 AM, Ard Biesheuvel wrote:
When using CLANGDWARF to build for the ARM architecture, objcopy is
references via the wrong environment variable, resulting in the wrong
llvm-objcopy to be used (if one exists), or the build to fail (if
CLANGDWARF_
Yes. Patch review and update are still as normal. But, the patch will be merged
after the stable tag is created if this patch is not target for this stable
tag.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Rebecca Cran
> 发送时间: 2023年5月11日 21:48
> 收件人: devel@edk2.groups.io; a...
From: Gua Guo
V1
PR: https://github.com/tianocore/edk2/pull/4389
Maintainer: Benny Lin
Reviewer: Gua Guo
Reviewer: Chasel Chiu
Reviewer: James Lu
Gua Guo (1):
Maintainers.txt: Update reviewers and maintainers for FdtLib. Update
reviewers and maintainers for FdtLib.
Maintain
From: Gua Guo
Cc: Michael D Kinney
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Signed-off-by: Guo Gua
---
Maintainers.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 30e2d2686d..97886accd
Series Reviewed-by : Benny Lin
-Original Message-
From: Guo, Gua
Sent: Friday, May 12, 2023 10:11 AM
To: devel@edk2.groups.io
Cc: Guo, Gua ; Kinney, Michael D
; Andrew Fish ; Leif Lindholm
; Lin, Benny ; Chiu, Chasel
; Lu, James
Subject: [PATCH v1 1/1] Maintainers.txt: Update review
Agree, thanks comments.
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, May 11, 2023 3:48 PM
> To: Wu, Jiaxin ; devel@edk2.groups.io;
> kra...@redhat.com
> Cc: Dong, Eric ; Zeng, Star ;
> Kumar, Rahul R
> Subject: RE: [edk2-devel] [PATCH v1 1/3] UefiCpuPkg/SecCore: Migrate page
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
> Sent: Thursday, May 11, 2023 7:11 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua
> Subject: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers and
> maintainer for FdtLib
>
>
Hi Liming,
Do you know whether for code freeze also include Maintainers.txt update ?
Or maybe we can submit it once the change approve.
Thanks,
Gua
-Original Message-
From: Guo, Gua
Sent: Friday, May 12, 2023 10:11 AM
To: devel@edk2.groups.io
Cc: Guo, Gua
Subject: [PATCH v1 0/1] Mainta
Hi Liming,
We are considering this is a missing when merging FdtLib support earlier.
Do we need to wait for Stewards approval for adding maintainers?
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
> Sent: Thursday, May 11, 2023 7:31 PM
> To: de
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Guo, Gua
> Sent: Thursday, May 11, 2023 7:11 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua ; Kinney, Michael D
> ; Andrew Fish ; Leif Lindholm
> ; Lin, Benny ; Chiu, Chasel
> ; Lu, James
> Subject: [PATCH v1 1/1] Ma
The loongarch qemu tcg code section is 16K aligned by default.
When UEFI keep 4K alignment, the code section and data section
of UEFI are loaded into the same page by qemu, and when the data
is written to the page containing the code section, it will cause
qemu to refresh TB, resulting in qemu runn
Chasel:
I agree to merge this change together with code change for this stable
tag.
Thanks
Liming
> -邮件原件-
> 发件人: Chiu, Chasel
> 发送时间: 2023年5月12日 10:35
> 收件人: devel@edk2.groups.io; Guo, Gua ; Gao, Liming
>
> 抄送: Andrew Fish ; Leif Lindholm
> ; Kinney, Michael D
>
> 主题: RE: [edk2-deve
Hi Minh,
Thanks for this patchset. It looks good to me.
Reviewed-by: Nhi Pham
Hi Leif, Ard - Could you please help merge this series?
Thanks,
Nhi
On 5/11/2023 2:51 PM, Minh Nguyen wrote:
These patches help to improve PCIe core for Link training sequence and
add logic to check PCIe card is
From: Abner Chang
IpmiFru is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/IpmiFru in order to consolidate
edk2 system manageability support in one place.
Uncustify is applied to C files and no functionalities
are changed in this patch.
We will still keep the one
From: Abner Chang
Add IpmiFru to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 1 +
Features/ManageabilityPkg/Include/Manageability.dsc | 4
Features/ManageabilityPkg/Manageab
Abdul,
I checked your V12 patch. It seems none of comments I have for your V11 are not
addressed. (check my inline reply below)
Can we get aligned firstly then you send out next version patches?
This could also save my time on downloading your changes and reviewing them one
by one.
Thanks,
Ray
Fix below GCC build error:
1) "Head" dereference issue.
2) "BooleanArrayBuffer" uninitialized variable issue.
3) Multiple definition of mRedfishVariableGuid.
4) Multiple definition of medfishResourceConfigProtocolHandle.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
Redfi
BIOS feature driver cannot recognize "@Redfish.Settings",
decode it and get pending setting URI. So BIOS feature
driver can consume pending setting from correct place.
Signed-off-by: Simon Wang
Cc: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c
When system configuration is updated from RESTful interface, we need a
system reboot so that the changes can be applied. Introduce PCD
"PcdSystemRebootRequired" to RedfishClientPkg. RedfishFeatureUtility
library will enable this flag when system config is updated.
RedfishFeatureCore driver will che
Move REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG and
REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST from
RedfishFeatureUtilityLib.h to
EdkIIRedfishInterchangeData.h. Also, remove
unnecessary jansson.h in RedfishDataTypeDef.h.
Signed-off-by: Simon Wang
Cc: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytsky
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, May 12, 2023 11:27 AM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang ; Tinh Nguyen
>
> Subject: [edk2-platforms][PATCH 1/2] ManageabilityPkg/IpmiF
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, May 12, 2023 11:27 AM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang
> Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiFru: Add to
> Man
From: Abner Chang
IpmiOsWdt is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/OsWdt in order to consolidate
edk2 system manageability support in one place.
Uncustify is applied to C files and no functionalities
are changed in this patch.
We will still keep the one
From: Abner Chang
Add IpmiOsWdt to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 1 +
Features/ManageabilityPkg/Include/Manageability.dsc | 4
Features/ManageabilityPkg/Manage
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Friday, May 12, 2023 11:47 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: Fix GCC build
> err
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Friday, May 12, 2023 11:47 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: Add
> Redfish.Setti
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Friday, May 12, 2023 11:47 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: Add mechanism
> to
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Friday, May 12, 2023 11:47 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: Reduce the
> header
For arch X64, system will enable the page table in SPI to cover 0-512G
range via CR4.PAE & MSR.LME & CR0.PG & CR3 setting. Existing code doesn't
cover the higher address access above 512G before memory-discovered
callback. This series patches provide the solution to enable paging from
temporary RAM
Background:
For arch X64, system will enable the page table in SPI to cover 0-512G range
via CR4.PAE & MSR.LME & CR0.PG & CR3 setting (see ResetVector code). Existing
code doesn't cover the higher address access above 512G before memory-discovered
callback. That will be potential problem if system
Some security features depends on the page table enabling. So, This patch
is to enable the page table if page table has not been enabled during the
transition from Temporary RAM to Permanent RAM.
Note: If page table is not enabled before this point, which means the system
IA-32e Mode is not activa
System paging 5 level enabled or not can be checked via CR4.LA57, system
preferred Page table Level (PcdUse5LevelPageTable) must align with previous
level for 64bit long mode.
This patch is to do the wise check:
If cpu has already runned in 64bit long mode PEI, Page table Level in DXE
must align w
Add CpuPageTableLib required by SecCore & CpuMpPei in OvmfPkg.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Ray Ni
Cc: Zeng Star
Signed-off-by: Jiaxin Wu
---
OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +-
OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +-
OvmfPkg/IntelTdx/Inte
Add CpuPageTableLib required by SecCore & CpuMpPei in UefiPayloadPkg.
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Cc: Ray Ni
Cc: Zeng Star
Signed-off-by: Jiaxin Wu
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiPayloa
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, May 12, 2023 12:16 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Gerd Hoffmann ; Kumar, Rahul R
>
> Subject: [PATCH v2 1/5] UefiCpuPkg/SecCore: Migrate page table to permanent
> memory
>
> Background:
allocateDuplicateStr() will not copy input string when input
string is empty string. It returns NULL pointer and creates
assertion in application driver.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 2 +-
1 file chang
1. can you please change the commit title as "UefiCpuPkg/CpuMpPei:
Conditionally enable PAE paging in 32bit mode"?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin
> Sent: Friday, May 12, 2023 12:16 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Zeng,
Liming:
I'd like to merge this one for the stable tag - any objections?
On Thu, 11 May 2023 at 06:55, Gerd Hoffmann wrote:
>
> On Wed, May 10, 2023 at 04:50:08PM +0200, Ard Biesheuvel wrote:
> > The warnings Clang emits when enabling -Wunneeded-internal-declaration
> > (which is part of -Wall)
> + //
> + // Check cpu runs in 64bit long mode or 32bit protected mode.
1. this comment seems to be redundant.
> + //
> + if (sizeof (UINTN) == sizeof (UINT64)) {
> +//
> +// If cpu has already runned in 64bit long mode PEI, Page table Level in
> DXE
> must align with previous level.
On Fri, 12 May 2023 at 03:43, gaoliming via groups.io
wrote:
>
> Ard:
> This change is good to me. Reviewed-by: Liming Gao
>
>
> Will it be merged for this stable tag?
>
Yes I will merge it today.
Thanks,
> > -邮件原件-
> > 发件人: Ard Biesheuvel
> > 发送时间: 2023年5月11日 15:00
> > 收件人: deve
99 matches
Mail list logo
